linted, somewhat

Makefile

@@ -61,28 +61,28 @@ metalinter_test: tools
 		--enable=aligncheck \
 		--enable=deadcode \
 		--enable=gas \
+		--enable=goconst \
 		--enable=goimports \
 		--enable=gosimple \
 		--enable=gotype \
 	 	--enable=ineffassign \
+		--enable=megacheck \
 	 	--enable=misspell \
+	   	--enable=staticcheck \
 		--enable=safesql \
 	   	--enable=structcheck \
+	   	--enable=unconvert \
+		--enable=unused \
 	   	--enable=varcheck \
+		--enable=vetshadow \
 		./...
 
 		#--enable=dupl \
 		#--enable=errcheck \
-		#--enable=goconst \
 		#--enable=gocyclo \
 		#--enable=golint \ <== comments on anything exported
 	   	#--enable=interfacer \
-	   	#--enable=megacheck \
-	   	#--enable=staticcheck \
-	   	#--enable=unconvert \
 	   	#--enable=unparam \
-		#--enable=unused \
 		#--enable=vet \
-		#--enable=vetshadow \
 
 .PHONY: all build test fmt lint get_deps tools

circle.yml

@@ -18,4 +18,5 @@ checkout:
 test:
   override:
     - "go version"
+    - "cd $REPO && make metalinter_test"
     - "cd $REPO && make test_integrations"

tests/test_app/app.go

@@ -59,7 +59,7 @@ func commit(client abcicli.Client, hashExp []byte) {
 	res := client.CommitSync()
 	_, data, log := res.Code, res.Data, res.Log
 	if res.IsErr() {
-		panic(fmt.Sprintf("committing %v\nlog: %v", log))
+		panic(fmt.Sprintf("committing %v\nlog: %v", log, res.Log))
 	}
 	if !bytes.Equal(res.Data, hashExp) {
 		panic(fmt.Sprintf("Commit hash was unexpected. Got %X expected %X",