mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-07-29 19:42:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

mempool: return duplicate tx errors more consistently (#7714)

Browse Source
This commit is contained in:
Sam Kleinman
2022-01-27 16:44:07 -05:00
committed by GitHub
parent 9b32346ebd
commit 6822378334
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/mempool/mempool.go
+5 -12
View File
@@ -255,19 +255,12 @@ func (txmp *TxMempool) CheckTx(
txHash := tx.Key()
// We add the transaction to the mempool's cache and if the transaction already
// exists, i.e. false is returned, then we check if we've seen this transaction
// from the same sender and error if we have. Otherwise, we return nil.
// We add the transaction to the mempool's cache and if the
// transaction is already present in the cache, i.e. false is returned, then we
// check if we've seen this transaction and error if we have.
if !txmp.cache.Push(tx) {
wtx, ok := txmp.txStore.GetOrSetPeerByTxHash(txHash, txInfo.SenderID)
if wtx != nil && ok {
// We already have the transaction stored and the we've already seen this
// transaction from txInfo.SenderID.
return types.ErrTxInCache
}
txmp.logger.Debug("tx exists already in cache", "tx_hash", tx.Hash())
return nil
txmp.txStore.GetOrSetPeerByTxHash(txHash, txInfo.SenderID)
return types.ErrTxInCache
}
reqRes, err := txmp.proxyAppConn.CheckTxAsync(ctx, abci.RequestCheckTx{Tx: tx})