mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-02-09 21:40:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use parseVoteExtension instead of custom parsing in PrepareProposal

Browse Source 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
This commit is contained in:
Thane Thomson
2022-03-30 08:26:06 -04:00
parent 7d1f9288f8
commit 685487a605
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/e2e/app/app.go
View File

@@ -320,10 +320,10 @@ func (app *Application) PrepareProposal(req abci.RequestPrepareProposal) abci.Re
if !vote.SignedLastBlock || len(vote.VoteExtension) == 0 {
continue
}
extValue, errVal := binary.Varint(vote.VoteExtension)
extValue, err := parseVoteExtension(vote.VoteExtension)
// This should have been verified in VerifyVoteExtension
if errVal <= 0 {
panic(fmt.Sprintf("Failed to parse vote extension. Got return value %d", errVal))
if err != nil {
panic(fmt.Errorf("failed to parse vote extension in PrepareProposal: %w", err))
}
valAddr := crypto.Address(vote.Validator.Address)
app.logger.Info("got vote extension value in PrepareProposal", "valAddr", valAddr, "value", extValue)