Merge pull request #53 from roylee17/makefile

Makefile: add fmt and lint targets

Makefile

@@ -1,24 +1,36 @@
-.PHONY: all test get_deps
+.PHONY: all build test fmt lint get_deps
 
 all: protoc install test
 
 NOVENDOR = go list github.com/tendermint/abci/... | grep -v /vendor/
 
 protoc:
-	protoc --go_out=plugins=grpc:. types/*.proto
+	@ protoc --go_out=plugins=grpc:. types/*.proto
 
 install:
-	go install github.com/tendermint/abci/cmd/...
+	@ go install github.com/tendermint/abci/cmd/...
+
+build:
+	@ go build -i github.com/tendermint/abci/cmd/...
 
 test:
-	go test `${NOVENDOR}`
-	bash tests/test.sh
+	@ go test `${NOVENDOR}`
+	@ bash tests/test.sh
+
+fmt:
+	@ go fmt ./...
+
+lint:
+	@ go get -u github.com/golang/lint/golint
+	@ for file in $$(find "." -name '*.go' | grep -v '/vendor/' | grep -v '\.pb\.go'); do \
+		golint -set_exit_status $${file}; \
+	done;
 
 test_integrations: get_vendor_deps install test
 
 get_deps:
-	go get -d `${NOVENDOR}`
+	@ go get -d `${NOVENDOR}`
 
 get_vendor_deps:
-	go get github.com/Masterminds/glide
-	glide install
+	@ go get github.com/Masterminds/glide
+	@ glide install

client/client.go

@@ -4,8 +4,8 @@ import (
 	"fmt"
 	"sync"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 type Client interface {

client/grpc_client.go

@@ -8,8 +8,8 @@ import (
 	context "golang.org/x/net/context"
 	grpc "google.golang.org/grpc"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 // A stripped copy of the remoteClient that makes

client/local_client.go

@@ -3,8 +3,8 @@ package abcicli
 import (
 	"sync"
 
-	. "github.com/tendermint/go-common"
 	types "github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 type localClient struct {

client/socket_client.go

@@ -10,8 +10,8 @@ import (
 	"sync"
 	"time"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 const (

cmd/counter/main.go

@@ -3,9 +3,9 @@ package main
 import (
 	"flag"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/example/counter"
 	"github.com/tendermint/abci/server"
+	. "github.com/tendermint/go-common"
 )
 
 func main() {

cmd/dummy/main.go

@@ -3,10 +3,10 @@ package main
 import (
 	"flag"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/example/dummy"
 	"github.com/tendermint/abci/server"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 func main() {

example/chain_aware/chain_aware_app.go

@@ -3,9 +3,9 @@ package main
 import (
 	"flag"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/server"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 func main() {

example/chain_aware/chain_aware_test.go

@@ -5,10 +5,10 @@ import (
 	"strings"
 	"testing"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/client"
 	"github.com/tendermint/abci/server"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 func TestChainAware(t *testing.T) {

example/counter/counter.go

@@ -3,8 +3,8 @@ package counter
 import (
 	"encoding/binary"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 type CounterApplication struct {

example/dummy/dummy_test.go

@@ -6,10 +6,10 @@ import (
 	"sort"
 	"testing"
 
+	"github.com/tendermint/abci/types"
 	. "github.com/tendermint/go-common"
 	"github.com/tendermint/go-crypto"
 	"github.com/tendermint/go-wire"
-	"github.com/tendermint/abci/types"
 )
 
 func testDummy(t *testing.T, dummy types.Application, tx []byte, key, value string) {

example/dummy/persistent_dummy.go

@@ -6,11 +6,11 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/tendermint/abci/types"
 	. "github.com/tendermint/go-common"
 	dbm "github.com/tendermint/go-db"
 	"github.com/tendermint/go-merkle"
 	"github.com/tendermint/go-wire"
-	"github.com/tendermint/abci/types"
 )
 
 const (

example/example_test.go

@@ -10,12 +10,12 @@ import (
 	"golang.org/x/net/context"
 	"google.golang.org/grpc"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/client"
 	"github.com/tendermint/abci/example/dummy"
 	nilapp "github.com/tendermint/abci/example/nil"
 	"github.com/tendermint/abci/server"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 func TestDummy(t *testing.T) {

server/grpc_server.go

@@ -6,8 +6,8 @@ import (
 
 	"google.golang.org/grpc"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 // var maxNumberConnections = 2

server/server.go

@@ -3,8 +3,8 @@ package server
 import (
 	"fmt"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 func NewServer(protoAddr, transport string, app types.Application) (Service, error) {

server/socket_server.go

@@ -8,8 +8,8 @@ import (
 	"strings"
 	"sync"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 // var maxNumberConnections = 2

tests/benchmarks/parallel/parallel.go

@@ -5,8 +5,8 @@ import (
 	"fmt"
 	//"encoding/hex"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 func main() {

tests/benchmarks/simple/simple.go

@@ -8,8 +8,8 @@ import (
 	"reflect"
 	//"encoding/hex"
 
-	. "github.com/tendermint/go-common"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
 )
 
 func main() {

tests/test_app/app.go

@@ -5,10 +5,10 @@ import (
 	"os"
 	"time"
 
-	. "github.com/tendermint/go-common"
-	"github.com/tendermint/go-process"
 	"github.com/tendermint/abci/client"
 	"github.com/tendermint/abci/types"
+	. "github.com/tendermint/go-common"
+	"github.com/tendermint/go-process"
 )
 
 //----------------------------------------

testutil/messages.go

@@ -1,8 +1,8 @@
 package testutil
 
 import (
-	"github.com/tendermint/go-crypto"
 	"github.com/tendermint/abci/types"
+	"github.com/tendermint/go-crypto"
 )
 
 //----------------------------------------