mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-09 14:43:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

types: fix path handling in node key tests (#7493) (#7502)

Browse Source 
These tests use a deterministic and unseeded random source to generate
non-colliding filenames for testing. When testing locally, this means tests are
not hermetic from one run to the next.

Use proper temp directories, and clean up after they're done.

(cherry picked from commit 5f85c8f536)

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
This commit is contained in:
mergify[bot]
2022-01-03 11:30:29 -08:00
committed by GitHub
parent 410aad8465
commit 7770ab0efd
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
types/node_key_test.go
View File

@@ -7,12 +7,11 @@ import (
"github.com/stretchr/testify/require"
tmrand "github.com/tendermint/tendermint/libs/rand"
"github.com/tendermint/tendermint/types"
)
func TestLoadOrGenNodeKey(t *testing.T) {
filePath := filepath.Join(os.TempDir(), tmrand.Str(12)+"_peer_id.json")
filePath := filepath.Join(t.TempDir(), "peer_id.json")
nodeKey, err := types.LoadOrGenNodeKey(filePath)
require.Nil(t, err)
@@ -23,7 +22,7 @@ func TestLoadOrGenNodeKey(t *testing.T) {
}
func TestLoadNodeKey(t *testing.T) {
filePath := filepath.Join(os.TempDir(), tmrand.Str(12)+"_peer_id.json")
filePath := filepath.Join(t.TempDir(), "peer_id.json")
_, err := types.LoadNodeKey(filePath)
require.True(t, os.IsNotExist(err))
@@ -37,7 +36,7 @@ func TestLoadNodeKey(t *testing.T) {
}
func TestNodeKeySaveAs(t *testing.T) {
filePath := filepath.Join(os.TempDir(), tmrand.Str(12)+"_peer_id.json")
filePath := filepath.Join(t.TempDir(), "peer_id.json")
require.NoFileExists(t, filePath)
nodeKey := types.GenNodeKey()