Apply suggestions from code review

Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com>
This commit is contained in:
Sam Kleinman
2022-06-15 11:36:11 -04:00
committed by GitHub
co-authored by M. J. Fromberger
parent 053ecd9b8c
commit 796688e7d7
3 changed files with 5 additions and 11 deletions
-1
View File
@@ -28,7 +28,6 @@ var (
type Metrics struct {
// Number of peers connected.
PeersConnected metrics.Gauge
// Nomber of peers in the peer store database.
PeersStored metrics.Gauge
// Number of inactive peers stored.
+3 -8
View File
@@ -115,14 +115,9 @@ func makeMockPeerStore(t *testing.T, peers ...peerInfo) *peerStore {
func TestPeerRanking(t *testing.T) {
t.Run("InactiveSecond", func(t *testing.T) {
store := makeMockPeerStore(t,
peerInfo{
ID: "second",
Inactive: true,
},
peerInfo{
ID: "first",
Inactive: false,
})
peerInfo{ID: "second", Inactive: true},
peerInfo{ID: "first", Inactive: false},
)
ranked := store.Ranked()
if len(ranked) != 2 {
+2 -2
View File
@@ -444,8 +444,8 @@ func (r *Router) filterPeersID(ctx context.Context, id types.NodeID) error {
func (r *Router) dialSleep(ctx context.Context) {
if r.options.DialSleep == nil {
const (
maxDialerInterval = 500
minDialerInterval = 100
maxDialerInterval = 500 // ms
minDialerInterval = 100 // ms
)
// nolint:gosec // G404: Use of weak random number generator