Merge pull request #1679 from tendermint/flush-wal-on-stop

Flush cs.wal on stop

Gopkg.lock

@@ -281,10 +281,10 @@
     "flowrate",
     "log",
     "merkle",
+    "merkle/tmhash",
     "test"
   ]
-  revision = "cc5f287c4798ffe88c04d02df219ecb6932080fd"
-  version = "v0.8.3-rc0"
+  revision = "0803cd354816952a8d8bcba88c592b3eb54ac427"
 
 [[projects]]
   branch = "master"
@@ -382,6 +382,6 @@
 [solve-meta]
   analyzer-name = "dep"
   analyzer-version = 1
-  inputs-digest = "d85c98dcac32cc1fe05d006aa75e8985f6447a150a041b972a673a65e7681da9"
+  inputs-digest = "aa8421ead26741e4ff7a59edb48dd7f12c8f29e3d6c0a893f95ea3fa3023a095"
   solver-name = "gps-cdcl"
   solver-version = 1

Gopkg.toml

@@ -83,7 +83,7 @@
 
 [[override]]
   name = "github.com/tendermint/tmlibs"
-  version = "~0.8.3-rc0"
+  revision = "0803cd354816952a8d8bcba88c592b3eb54ac427"
 
 [[constraint]]
   name = "google.golang.org/grpc"

consensus/wal.go

@@ -106,8 +106,8 @@ func (wal *baseWAL) OnStart() error {
 }
 
 func (wal *baseWAL) OnStop() {
-	wal.BaseService.OnStop()
 	wal.group.Stop()
+	wal.group.Close()
 }
 
 // Write is called in newStep and for each receive on the

p2p/pex/pex_reactor_test.go

@@ -54,6 +54,7 @@ func TestPEXReactorAddRemovePeer(t *testing.T) {
 	outboundPeer := p2p.CreateRandomPeer(true)
 
 	r.AddPeer(outboundPeer)
+	assert.Equal(t, size+1, book.Size(), "outbound peers should not be added to the address book")
 
 	r.RemovePeer(outboundPeer, "peer not available")
 }