mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-08-21 06:36:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

statesync: do not recover panic on peer updates (#5869)

Browse Source
This commit is contained in:
Aleksandr Bezobchuk
2021-01-06 10:07:10 -05:00
committed by GitHub
parent 1ccd23ca1d
commit 8bf77d9b1a
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
statesync/reactor.go
+2 -11
View File
@@ -392,14 +392,7 @@ func (r *Reactor) processChunkCh() {
// processPeerUpdate processes a PeerUpdate, returning an error upon failing to
// handle the PeerUpdate or if a panic is recovered.
func (r *Reactor) processPeerUpdate(peerUpdate p2p.PeerUpdate) (err error) {
defer func() {
if e := recover(); e != nil {
err = fmt.Errorf("panic in processing peer update: %v", e)
r.Logger.Error("recovering from processing peer update panic", "err", err)
}
}()
func (r *Reactor) processPeerUpdate(peerUpdate p2p.PeerUpdate) {
r.Logger.Debug("received peer update", "peer", peerUpdate.PeerID, "status", peerUpdate.Status)
r.mtx.RLock()
@@ -414,8 +407,6 @@ func (r *Reactor) processPeerUpdate(peerUpdate p2p.PeerUpdate) (err error) {
r.syncer.RemovePeer(peerUpdate.PeerID)
}
}
return err
}
// processPeerUpdates initiates a blocking process where we listen for and handle
@@ -427,7 +418,7 @@ func (r *Reactor) processPeerUpdates() {
for {
select {
case peerUpdate := <-r.peerUpdates.Updates():
_ = r.processPeerUpdate(peerUpdate)
r.processPeerUpdate(peerUpdate)
case <-r.closeCh:
r.Logger.Debug("stopped listening on peer updates channel; closing...")