e2e: fix initialization of light client (#8682)

test/e2e/node/main.go

@@ -68,35 +68,37 @@ func run(ctx context.Context, configFile string) error {
 		return err
 	}
 
-	// Start remote signer (must start before node if running builtin).
-	if cfg.PrivValServer != "" {
-		if err = startSigner(ctx, logger, cfg); err != nil {
-			logger.Error("starting signer",
-				"server", cfg.PrivValServer,
-				"err", err)
-			return err
+	if cfg.Mode == string(e2e.ModeLight) {
+		err = startLightNode(ctx, logger, cfg)
+	} else {
+		// Start remote signer (must start before node if running builtin).
+		if cfg.PrivValServer != "" {
+			if err = startSigner(ctx, logger, cfg); err != nil {
+				logger.Error("starting signer",
+					"server", cfg.PrivValServer,
+					"err", err)
+				return err
+			}
+			if cfg.Protocol == "builtin" {
+				time.Sleep(1 * time.Second)
+			}
 		}
-		if cfg.Protocol == "builtin" {
-			time.Sleep(1 * time.Second)
+
+		// Start app server.
+		switch cfg.Protocol {
+		case "socket", "grpc":
+			err = startApp(ctx, logger, cfg)
+		case "builtin":
+			if cfg.Mode == string(e2e.ModeSeed) {
+				err = startSeedNode(ctx)
+			} else {
+				err = startNode(ctx, cfg)
+			}
+		default:
+			err = fmt.Errorf("invalid protocol %q", cfg.Protocol)
 		}
 	}
 
-	// Start app server.
-	switch cfg.Protocol {
-	case "socket", "grpc":
-		err = startApp(ctx, logger, cfg)
-	case "builtin":
-		switch cfg.Mode {
-		case string(e2e.ModeLight):
-			err = startLightNode(ctx, logger, cfg)
-		case string(e2e.ModeSeed):
-			err = startSeedNode(ctx)
-		default:
-			err = startNode(ctx, cfg)
-		}
-	default:
-		err = fmt.Errorf("invalid protocol %q", cfg.Protocol)
-	}
 	if err != nil {
 		logger.Error("starting node",
 			"protocol", cfg.Protocol,

test/e2e/pkg/testnet.go

@@ -310,6 +310,12 @@ func (t Testnet) Validate() error {
 	default:
 		return errors.New("unsupported KeyType")
 	}
+	switch t.ABCIProtocol {
+	case ProtocolBuiltin, ProtocolUNIX, ProtocolTCP, ProtocolGRPC:
+	default:
+		return fmt.Errorf("invalid ABCI protocol setting %q", t.ABCIProtocol)
+	}
+
 	for _, node := range t.Nodes {
 		if err := node.Validate(t); err != nil {
 			return fmt.Errorf("invalid node %q: %w", node.Name, err)

test/e2e/runner/setup.go

@@ -354,6 +354,7 @@ func MakeAppConfig(node *e2e.Node) ([]byte, error) {
 		"vote_extension_delay_ms":   node.Testnet.VoteExtensionDelayMS,
 		"finalize_block_delay_ms":   node.Testnet.FinalizeBlockDelayMS,
 	}
+
 	switch node.Testnet.ABCIProtocol {
 	case e2e.ProtocolUNIX:
 		cfg["listen"] = AppAddressUNIX