Revert "p2p: self-add node should not error (tendermint#8753)" (#8757)

internal/p2p/peermanager.go

@@ -15,7 +15,6 @@ import (
 	dbm "github.com/tendermint/tm-db"
 
 	tmsync "github.com/tendermint/tendermint/internal/libs/sync"
-	"github.com/tendermint/tendermint/libs/log"
 	p2pproto "github.com/tendermint/tendermint/proto/tendermint/p2p"
 	"github.com/tendermint/tendermint/types"
 )
@@ -146,8 +145,6 @@ type PeerManagerOptions struct {
 	// persistentPeers provides fast PersistentPeers lookups. It is built
 	// by optimize().
 	persistentPeers map[types.NodeID]bool
-
-	Logger log.Logger
 }
 
 // Validate validates the options.
@@ -267,7 +264,6 @@ type PeerManager struct {
 	rand       *rand.Rand
 	dialWaker  *tmsync.Waker // wakes up DialNext() on relevant peer changes
 	evictWaker *tmsync.Waker // wakes up EvictNext() on relevant peer changes
-	logger     log.Logger
 
 	mtx           sync.Mutex
 	store         *peerStore
@@ -302,7 +298,6 @@ func NewPeerManager(selfID types.NodeID, peerDB dbm.DB, options PeerManagerOptio
 		rand:       rand.New(rand.NewSource(time.Now().UnixNano())), // nolint:gosec
 		dialWaker:  tmsync.NewWaker(),
 		evictWaker: tmsync.NewWaker(),
-		logger:     log.NewNopLogger(),
 
 		store:         store,
 		dialing:       map[types.NodeID]bool{},
@@ -313,11 +308,6 @@ func NewPeerManager(selfID types.NodeID, peerDB dbm.DB, options PeerManagerOptio
 		evicting:      map[types.NodeID]bool{},
 		subscriptions: map[*PeerUpdates]*PeerUpdates{},
 	}
-
-	if options.Logger != nil {
-		peerManager.logger = options.Logger
-	}
-
 	if err = peerManager.configurePeers(); err != nil {
 		return nil, err
 	}
@@ -400,7 +390,7 @@ func (m *PeerManager) Add(address NodeAddress) (bool, error) {
 		return false, err
 	}
 	if address.NodeID == m.selfID {
-		return false, nil
+		return false, fmt.Errorf("can't add self (%v) to peer store", m.selfID)
 	}
 
 	m.mtx.Lock()

internal/p2p/peermanager_test.go

@@ -265,9 +265,8 @@ func TestPeerManager_Add(t *testing.T) {
 	require.Error(t, err)
 
 	// Adding self should error
-	ok, err := peerManager.Add(p2p.NodeAddress{Protocol: "memory", NodeID: selfID})
-	require.False(t, ok)
-	require.NoError(t, err)
+	_, err = peerManager.Add(p2p.NodeAddress{Protocol: "memory", NodeID: selfID})
+	require.Error(t, err)
 }
 
 func TestPeerManager_DialNext(t *testing.T) {
@@ -842,14 +841,13 @@ func TestPeerManager_Dialed_Connected(t *testing.T) {
 	require.Error(t, peerManager.Dialed(b))
 }
 
-func TestPeerManager_Adding_Self(t *testing.T) {
+func TestPeerManager_Dialed_Self(t *testing.T) {
 	peerManager, err := p2p.NewPeerManager(selfID, dbm.NewMemDB(), p2p.PeerManagerOptions{})
 	require.NoError(t, err)
 
-	// Ingesting self should not error.
-	ok, err := peerManager.Add(p2p.NodeAddress{Protocol: "memory", NodeID: selfID})
-	require.False(t, ok)
-	require.NoError(t, err)
+	// Dialing self should error.
+	_, err = peerManager.Add(p2p.NodeAddress{Protocol: "memory", NodeID: selfID})
+	require.Error(t, err)
 }
 
 func TestPeerManager_Dialed_MaxConnected(t *testing.T) {

node/node.go

@@ -203,7 +203,7 @@ func makeNode(
 		}
 	}
 
-	peerManager, peerCloser, err := createPeerManager(logger, cfg, dbProvider, nodeKey.ID)
+	peerManager, peerCloser, err := createPeerManager(cfg, dbProvider, nodeKey.ID)
 	closers = append(closers, peerCloser)
 	if err != nil {
 		return nil, combineCloseError(

node/seed.go

@@ -67,7 +67,7 @@ func makeSeedNode(
 	// Setup Transport and Switch.
 	p2pMetrics := p2p.PrometheusMetrics(cfg.Instrumentation.Namespace, "chain_id", genDoc.ChainID)
 
-	peerManager, closer, err := createPeerManager(logger, cfg, dbProvider, nodeKey.ID)
+	peerManager, closer, err := createPeerManager(cfg, dbProvider, nodeKey.ID)
 	if err != nil {
 		return nil, combineCloseError(
 			fmt.Errorf("failed to create peer manager: %w", err),

node/setup.go

@@ -199,7 +199,6 @@ func createEvidenceReactor(
 }
 
 func createPeerManager(
-	logger log.Logger,
 	cfg *config.Config,
 	dbProvider config.DBProvider,
 	nodeID types.NodeID,
@@ -227,7 +226,6 @@ func createPeerManager(
 	maxUpgradeConns := uint16(4)
 
 	options := p2p.PeerManagerOptions{
-		Logger:                 logger.With("module", "peermanager"),
 		SelfAddress:            selfAddr,
 		MaxConnected:           maxConns,
 		MaxConnectedUpgrade:    maxUpgradeConns,