mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-10 23:10:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: use logger in TrySend and Send

Browse Source
This commit is contained in:
William Banfield
2022-10-24 16:01:14 -04:00
parent 0b0d921e92
commit d4fcfa127b
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
p2p/peer.go
View File

@@ -271,7 +271,8 @@ func (p *peer) Send(e Envelope) bool {
}
msgBytes, err := proto.Marshal(msg)
if err != nil {
panic(err) // Q: should this panic or error?
p.Logger.Error("marshaling message to send", "error", err)
return false
}
res := p.mconn.Send(e.ChannelID, msgBytes)
if res {
@@ -300,7 +301,8 @@ func (p *peer) TrySend(e Envelope) bool {
}
msgBytes, err := proto.Marshal(msg)
if err != nil {
panic(err)
p.Logger.Error("marshaling message to send", "error", err)
return false
}
res := p.mconn.TrySend(e.ChannelID, msgBytes)
if res {
@@ -437,8 +439,7 @@ func createMConnection(
if w, ok := msg.(Unwrapper); ok {
msg, err = w.Unwrap()
if err != nil {
// TODO(williambanfield) add error log line.
return
panic(fmt.Errorf("unwrapping message: %s", err))
}
}
p.metrics.PeerReceiveBytesTotal.With(labels...).Add(float64(len(msgBytes)))