review fixes

This commit is contained in:
Juan Leni
2019-04-03 16:22:14 +02:00
parent 944d76d76e
commit dc1d24afb1
+14 -16
View File
@@ -44,13 +44,11 @@ func getSignerTestCases(t *testing.T) []signerTestCase {
func TestSignerClose(t *testing.T) {
for _, tc := range getSignerTestCases(t) {
func() {
err := tc.signer.Close()
assert.NoError(t, err)
err := tc.signer.Close()
assert.NoError(t, err)
err = tc.signerService.Stop()
assert.NoError(t, err)
}()
err = tc.signerService.Stop()
assert.NoError(t, err)
}
}
@@ -171,16 +169,16 @@ func TestSignerSignProposalErrors(t *testing.T) {
defer tc.signerService.OnStop()
defer tc.signer.Close()
//ts := time.Now()
//proposal := &types.Proposal{Timestamp: ts}
//err := tc.signer.SignProposal(tc.chainID, proposal)
//require.Equal(t, err.(*RemoteSignerError).Description, types.ErroringMockPVErr.Error())
//
//err = tc.mockPV.SignProposal(tc.chainID, proposal)
//require.Error(t, err)
//
//err = tc.signer.SignProposal(tc.chainID, proposal)
//require.Error(t, err)
ts := time.Now()
proposal := &types.Proposal{Timestamp: ts}
err := tc.signer.SignProposal(tc.chainID, proposal)
require.Equal(t, err.(*RemoteSignerError).Description, types.ErroringMockPVErr.Error())
err = tc.mockPV.SignProposal(tc.chainID, proposal)
require.Error(t, err)
err = tc.signer.SignProposal(tc.chainID, proposal)
require.Error(t, err)
}()
}
}