a few uncaught asserts replaced with require

This commit is contained in:
Ismail Khoffi
2018-12-03 12:08:20 +01:00
parent f17c04c892
commit df20323cd2
4 changed files with 8 additions and 6 deletions
+3 -3
View File
@@ -26,10 +26,10 @@ func TestSocketPVAddress(t *testing.T) {
defer rs.Stop()
serverAddr, err := rs.privVal.GetAddress()
assert.NoError(t, err)
require.NoError(t, err)
clientAddr, err := sc.GetAddress()
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, serverAddr, clientAddr)
}
@@ -46,7 +46,7 @@ func TestSocketPVPubKey(t *testing.T) {
require.NoError(t, err)
privKey, err := rs.privVal.GetPubKey()
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, privKey, clientKey)
}
+1 -1
View File
@@ -69,7 +69,7 @@ func TestEvidence(t *testing.T) {
}
pubKey, err := val.GetPubKey()
assert.NoError(t, err)
require.NoError(t, err)
for _, c := range cases {
ev := &DuplicateVoteEvidence{
VoteA: c.vote1,
+1 -1
View File
@@ -46,7 +46,7 @@ func TestProposalString(t *testing.T) {
func TestProposalVerifySignature(t *testing.T) {
privVal := NewMockPV()
pubKey, err := privVal.GetPubKey()
assert.NoError(t, err)
require.NoError(t, err)
prop := NewProposal(
4, 2, 2,
+3 -1
View File
@@ -4,6 +4,8 @@ import (
"testing"
"time"
"github.com/stretchr/testify/require"
"github.com/golang/protobuf/proto"
"github.com/stretchr/testify/assert"
@@ -143,7 +145,7 @@ func TestABCIEvidence(t *testing.T) {
blockID2 := makeBlockID([]byte("blockhash2"), 1000, []byte("partshash"))
const chainID = "mychain"
pubKey, err := val.GetPubKey()
assert.NoError(t, err)
require.NoError(t, err)
ev := &DuplicateVoteEvidence{
PubKey: pubKey,
VoteA: makeVote(val, chainID, 0, 10, 2, 1, blockID),