cleanup requested from review by @melekes

cmd/abci-cli/abci-cli.go

@@ -387,15 +387,9 @@ func cmdConsole(cmd *cobra.Command, args []string) error {
 	return nil
 }
 
-var (
-	errBadPersistentArgs = errors.New("expecting persistent args of the form: abci-cli [command] <...>")
-
-	errUnimplemented = errors.New("unimplemented")
-)
-
 func muxOnCommands(cmd *cobra.Command, pArgs []string) error {
 	if len(pArgs) < 2 {
-		return errBadPersistentArgs
+		return errors.New("expecting persistent args of the form: abci-cli [command] <...>")
 	}
 	subCommand, actualArgs := pArgs[1], pArgs[2:]
 

tests/server/client.go

@@ -21,7 +21,7 @@ func InitChain(client abcicli.Client) error {
 	}
 	_, err := client.InitChainSync(types.RequestInitChain{Validators: vals})
 	if err != nil {
-		fmt.Println("Failed test: InitChain - %v", err)
+		fmt.Printf("Failed test: InitChain - %v\n", err)
 		return err
 	}
 	fmt.Println("Passed test: InitChain")
@@ -46,7 +46,7 @@ func Commit(client abcicli.Client, hashExp []byte) error {
 	_, data := res.Code, res.Data
 	if err != nil {
 		fmt.Println("Failed test: Commit")
-		fmt.Printf("committing %v\nlog: %v", res.GetLog())
+		fmt.Printf("committing %v\nlog: %v\n", res.GetLog(), err)
 		return err
 	}
 	if !bytes.Equal(data, hashExp) {