mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-03 11:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

types: validatebasic on from proto (#5152)

Browse Source 
## Description

Validatebasic on FromProto for validator set not ToProto

Closes: #XXX
This commit is contained in:
Marko
2020-07-27 13:36:03 +02:00
committed by GitHub
parent fb4e00f7f9
commit ee7bbb6cb2
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
types/validator_set.go
View File

@@ -910,9 +910,7 @@ func (vals *ValidatorSet) ToProto() (*tmproto.ValidatorSet, error) {
if vals == nil {
return nil, errors.New("nil validator set") // validator set should never be nil
}
if err := vals.ValidateBasic(); err != nil {
return nil, fmt.Errorf("validator set failed basic: %w", err)
}
vp := new(tmproto.ValidatorSet)
valsProto := make([]*tmproto.Validator, len(vals.Validators))
for i := 0; i < len(vals.Validators); i++ {
@@ -963,7 +961,7 @@ func ValidatorSetFromProto(vp *tmproto.ValidatorSet) (*ValidatorSet, error) {
vals.totalVotingPower = vp.GetTotalVotingPower()
return vals, nil
return vals, vals.ValidateBasic()
}
//----------------------------------------