fix scoring test

(cherry picked from commit 9abc55f3a0)

internal/p2p/peermanager.go

@@ -1376,22 +1376,19 @@ func (p *peerInfo) LastDialed() (time.Time, bool) {
 			if addr.LastDialFailure.IsZero() {
 				continue
 			}
-			if last.Before(addr.LastDialSuccess) {
-				last = addr.LastDialSuccess
-				success = true
+			if last.After(addr.LastDialSuccess) {
+				continue
 			}
+			success = true
+			last = addr.LastDialSuccess
 		}
-		if addr.LastDialSuccess.After(addr.LastDialFailure) {
-			if last.Before(addr.LastDialSuccess) {
-				last = addr.LastDialSuccess
-				success = true
-			}
+		if addr.LastDialFailure.After(last) {
+			success = false
+			last = addr.LastDialFailure
 		}
-		if addr.LastDialFailure.After(addr.LastDialSuccess) {
-			if last.Before(addr.LastDialFailure) {
-				last = addr.LastDialFailure
-				success = false
-			}
+		if addr.LastDialSuccess.After(last) || last.Equal(addr.LastDialSuccess) {
+			success = true
+			last = addr.LastDialSuccess
 		}
 	}
 

internal/p2p/peermanager_scoring_test.go

@@ -200,6 +200,9 @@ func TestLastDialed(t *testing.T) {
 			FailTime        time.Time
 			ExpectedSuccess bool
 		}{
+			{
+				Name: "Zero",
+			},
 			{
 				Name:            "Success",
 				SuccessTime:     base.Add(time.Hour),