mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-02-08 04:50:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add strong correctness guarantees when constructing extended commit info for ABCI++

Browse Source 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
This commit is contained in:
Thane Thomson
2022-03-28 11:41:24 -04:00
parent 01b6a4f2d5
commit fab3cd0932
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/state/execution.go
View File

@@ -1,6 +1,7 @@
package state
import (
"bytes"
"context"
"fmt"
"time"
@@ -436,12 +437,23 @@ func buildLastCommitInfo(block *types.Block, store Store, initialHeight int64) a
}
}
// extendedCommitInfo assumes that votes from the given commit correspond
// precisely to those provided in the list of votes, such that vote extensions
// can be correlated with the votes in the commit.
func extendedCommitInfo(c abci.CommitInfo, votes []*types.Vote) abci.ExtendedCommitInfo {
vs := make([]abci.ExtendedVoteInfo, len(c.Votes))
for i := range vs {
var ext []byte
// votes[i] will be nil if c.Votes[i].SignedLastBlock is false
if c.Votes[i].SignedLastBlock {
// We would panic anyways, but at least this will provide more information.
if votes[i] == nil {
panic(fmt.Sprintf("extendedCommitInfo: expected vote in position %d (%v), but got nil", i, c.Votes[i]))
}
// Strong guarantee that the vote corresponds to the relevant validator
if !bytes.Equal(c.Votes[i].Validator.Address, votes[i].ValidatorAddress) {
panic(fmt.Sprintf("extendedCommitInfo: expected votes in position %d to have the same validator address (%v != %v)", i, c.Votes[i].Validator.Address, votes[i].ValidatorAddress))
}
ext = votes[i].Extension
}
vs[i] = abci.ExtendedVoteInfo{