mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-02-06 03:50:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

verifyAndSave now internally checks if the commit is validate before proceeding.

Browse Source 
Fix a comment for clarity
This commit is contained in:
Zaki Manian
2019-07-06 19:05:10 -07:00
parent b97a8b69ed
commit fb3663cfb1
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lite/verifying/provider.go
View File

@@ -335,6 +335,11 @@ func (vp *Provider) fillValsetAndSaveFC(signedHeader types.SignedHeader, valset,
// Panics if trustedFC.Height() >= newFC.Height().
func (vp *Provider) verifyAndSave(trustedFC, newFC lite.FullCommit) error {
//Locally validate the full commit before we can trust it.
if err := newFC.ValidateFull(vp.chainID); err != nil {
return err
}
// Shouldn't have trusted commits before the new commit height
if trustedFC.Height() >= newFC.Height() {
panic("should not happen")
@@ -345,7 +350,7 @@ func (vp *Provider) verifyAndSave(trustedFC, newFC lite.FullCommit) error {
return lerr.ErrCommitExpired()
}
// If the new full commit is the next block, verify it. Otherwise use the verify future commit function
// Validate the new commit in terms of validator set of last trusted commit.
if err := trustedFC.NextValidators.VerifyCommit(vp.chainID, newFC.SignedHeader.Commit.BlockID, newFC.SignedHeader.Height, newFC.SignedHeader.Commit); err != nil {
return err
}