William Banfield
2b7f46206e
change output and related tests
2022-05-11 13:37:02 -04:00
William Banfield
ad577e93d4
sort data and merge
2022-05-11 13:27:50 -04:00
William Banfield
5b5dc2ea95
use strings.Builder
2022-05-11 10:12:54 -04:00
William Banfield
81cac78702
field renames
2022-05-11 10:10:23 -04:00
William Banfield
4eb6bdaee7
use fmt.Print
2022-05-11 10:04:29 -04:00
William Banfield
0048bfe5a9
use flag.Arg
2022-05-11 10:03:05 -04:00
William Banfield
8ebbc52b97
close files
2022-05-11 10:00:47 -04:00
William Banfield
ace89bf523
simplify open error
2022-05-11 09:59:51 -04:00
William Banfield
4257b0762e
non allocating decl
2022-05-11 09:58:19 -04:00
William Banfield
e0badc0b2f
rename diff function
2022-05-11 09:57:26 -04:00
William Banfield
7947e9ea5f
change struct name
2022-05-11 09:56:28 -04:00
William Banfield
f3550cea47
use want as name in test
2022-05-11 09:54:50 -04:00
William Banfield
dc1d9d48e0
use NArg
2022-05-11 09:52:49 -04:00
William Banfield
f834edea56
Update scripts/metricsgen/metricsdiff/metricsdiff.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-11 09:50:53 -04:00
William Banfield
8c5f42949f
Update scripts/metricsgen/metricsdiff/metricsdiff.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-11 09:49:15 -04:00
William Banfield
035356df64
Update scripts/metricsgen/metricsdiff/metricsdiff.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-11 09:48:19 -04:00
William Banfield
672a26a3cf
Update scripts/metricsgen/metricsdiff/metricsdiff.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-11 09:47:51 -04:00
William Banfield
118b48fba0
scripts/metricsgen: add metricsdiff tool
2022-05-11 00:06:04 -04:00
Sergio Mena
735a1a537b
Fixed math notation in ABCI++ app requirements ( #8499 )
...
* Fixed math notation in ABCI++ app requirements
* Update spec/abci++/abci++_app_requirements_002_draft.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
* Update spec/abci++/abci++_app_requirements_002_draft.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
* Update spec/abci++/abci++_app_requirements_002_draft.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
* Update spec/abci++/abci++_app_requirements_002_draft.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
Co-authored-by: Daniel <daniel.cason@usi.ch >
2022-05-10 21:50:28 +02:00
William Banfield
c052181e32
consensus: add additional metrics for abci++ data ( #8480 )
...
This pull request adds an additional set of metrics targeted at providing more visibility into `abci++`.
The following set of metrics are added and exposed through the `metrics` endpoint:
```
tendermint_consensus_proposal_receive_count{chain_id="test-chain-IrF74Y",status="accepted"} 34
tendermint_consensus_proposal_create_count{chain_id="test-chain-IrF74Y"} 34
tendermint_consensus_vote_extension_receive_count{chain_id="test-chain-IrF74Y",status="accepted"} 34
tendermint_consensus_round_voting_power_percent{chain_id="test-chain-IrF74Y",vote_type="precommit"} 1
tendermint_consensus_round_voting_power_percent{chain_id="test-chain-IrF74Y",vote_type="prevote"} 1
tendermint_state_consensus_param_updates{chain_id="test-chain-IrF74Y"} 0
tendermint_state_validator_set_updates{chain_id="test-chain-IrF74Y"} 0
tendermint_consensus_late_votes{chain_id="test-chain-IrF74Y",vote_type="precommit"} 16
```
This pull request also updates the `metrics.md` file to include some metrics that were previously missed. My hope is to generate the `metrics.md` file with a future version of the tool being architected in #8479
2022-05-10 16:48:13 +00:00
Callum Waters
a4c3b5cab4
validate block before we persist it ( #8493 )
2022-05-10 17:34:53 +02:00
Callum Waters
9dae97d845
RFC 016: Node Architecture ( #8285 )
2022-05-10 15:42:22 +02:00
dependabot[bot]
412a77915d
build(deps): Bump github.com/golangci/golangci-lint ( #8490 )
2022-05-10 08:25:15 -04:00
William Banfield
4b36feaa2b
scripts/metricsgen: add the initial version of metricsgen ( #8479 )
...
This pull requests adds a new tool, metricsgen, for generating Tendermint metrics constructors from `Metrics` struct definitions. This tool aims to reduce the amount of boilerplate required to add additional metrics to Tendermint.
Its working is fairly simple, it parses the go ast, extracts field information, and uses this field information to execute a go template.
This pull request also adds a proof-of-concept of the tool's output and working by using it to generate the [indexer metrics](https://github.com/tendermint/tendermint/pull/8479/files#diff-4b0c597b6fa05332a2f9a8e0ce079e360602942fae99dc5485f1edfe71c0a29e ) using `//go:generate` directives and a simple `make` target.
The next steps for this tool are documented in https://github.com/tendermint/tendermint/issues/8485 and https://github.com/tendermint/tendermint/issues/8486 , which detail using the tool to generate the `metrics.md` documentation file and using the tool to migrate away from `go-kit`.
2022-05-09 22:52:10 +00:00
dependabot[bot]
b52b8f2740
build(deps): Bump docker/login-action from 1.14.1 to 2.0.0 ( #8481 )
...
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1.14.1 to 2.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/login-action/releases ">docker/login-action's releases</a>.</em></p>
<blockquote>
<h2>v2.0.0</h2>
<ul>
<li>Node 16 as default runtime by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/161 ">#161</a>)
<ul>
<li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0 ">Actions Runner</a> version of v2.285.0, which is by default available in GHES 3.4 or later.</li>
</ul>
</li>
<li>chore: update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/170 ">#170</a>)</li>
<li>Bump <code>@actions/exec</code> from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/167 ">#167</a>)</li>
<li>Bump <code>@actions/io</code> from 1.1.1 to 1.1.2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/168 ">#168</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/176 ">#176</a>)</li>
<li>Bump https-proxy-agent from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/182 ">#182</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/login-action/compare/v1.14.1...v2.0.0 ">https://github.com/docker/login-action/compare/v1.14.1...v2.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/docker/login-action/commit/49ed152c8eca782a232dede0303416e8f356c37b "><code>49ed152</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/login-action/issues/161 ">#161</a> from crazy-max/node16-runtime</li>
<li><a href="https://github.com/docker/login-action/commit/b61a9ce7bd93239c435d3a7e3d6fe56020bf38c3 "><code>b61a9ce</code></a> Node 16 as default runtime</li>
<li><a href="https://github.com/docker/login-action/commit/3a136a8631bbc4ca05cc2f33d3a19059e9255bae "><code>3a136a8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/login-action/issues/182 ">#182</a> from docker/dependabot/npm_and_yarn/https-proxy-agent...</li>
<li><a href="https://github.com/docker/login-action/commit/b312880b6957654c92704d65c445d4db3157237f "><code>b312880</code></a> Update generated content</li>
<li><a href="https://github.com/docker/login-action/commit/795794e081a18060d5db5537d3e874e675d8d7c9 "><code>795794e</code></a> Bump https-proxy-agent from 5.0.0 to 5.0.1</li>
<li><a href="https://github.com/docker/login-action/commit/1edf6180e07d2ffb423fc48a1a552855c0a1f508 "><code>1edf618</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/login-action/issues/179 ">#179</a> from docker/dependabot/github_actions/codecov/codecov...</li>
<li><a href="https://github.com/docker/login-action/commit/8e66ad4089051ec73ac8b193deca830bd52edb83 "><code>8e66ad4</code></a> Bump codecov/codecov-action from 2 to 3</li>
<li><a href="https://github.com/docker/login-action/commit/7c79b598eaa33458e78e8d0d71e0a9c217dd92af "><code>7c79b59</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/login-action/issues/176 ">#176</a> from docker/dependabot/npm_and_yarn/minimist-1.2.6</li>
<li><a href="https://github.com/docker/login-action/commit/24a38e0d6d99bc9b277904a244b17b7e511d994f "><code>24a38e0</code></a> Bump minimist from 1.2.5 to 1.2.6</li>
<li><a href="https://github.com/docker/login-action/commit/70e1ff84cbd75a9e03941a79f21f05f1b03a71bb "><code>70e1ff8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/login-action/issues/170 ">#170</a> from crazy-max/eslint</li>
<li>Additional commits viewable in <a href="https://github.com/docker/login-action/compare/v1.14.1...v2.0.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-09 14:35:43 +00:00
dependabot[bot]
083716b22a
build(deps): Bump docker/build-push-action from 2.10.0 to 3.0.0 ( #8482 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2.10.0 to 3.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases ">docker/build-push-action's releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<ul>
<li>Node 16 as default runtime by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/564 ">#564</a>)
<ul>
<li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0 ">Actions Runner</a> version of v2.285.0, which is by default available in GHES 3.4 or later.</li>
</ul>
</li>
<li>Standalone mode support by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/601 ">#601</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/609 ">#609</a>)</li>
<li>chore: update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/571 ">#571</a>)</li>
<li>Bump <code>@actions/exec</code> from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/573 ">#573</a>)</li>
<li>Bump <code>@actions/github</code> from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/582 ">#582</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/584 ">#584</a>)</li>
<li>Bump semver from 7.3.5 to 7.3.7 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/595 ">#595</a>)</li>
<li>Bump csv-parse from 4.16.3 to 5.0.4 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/533 ">#533</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v2.10.0...v3.0.0 ">https://github.com/docker/build-push-action/compare/v2.10.0...v3.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/docker/build-push-action/commit/e551b19e49efd4e98792db7592c17c09b89db8d8 "><code>e551b19</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/564 ">#564</a> from crazy-max/node-16</li>
<li><a href="https://github.com/docker/build-push-action/commit/3554377aa377509838f2e53d71f7c4127b2bece4 "><code>3554377</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/609 ">#609</a> from crazy-max/ci-fix-test</li>
<li><a href="https://github.com/docker/build-push-action/commit/a62bc1b22b6b959fa4fb8cffc6c46650e2388ee4 "><code>a62bc1b</code></a> ci: fix standalone test</li>
<li><a href="https://github.com/docker/build-push-action/commit/c2085839e18b24c219aef4366ca2337979d7f194 "><code>c208583</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/601 ">#601</a> from crazy-max/standalone-mode</li>
<li><a href="https://github.com/docker/build-push-action/commit/fcd91249e5fa3d8dd25f0a6d707cd1aa263e59d3 "><code>fcd9124</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/607 ">#607</a> from docker/dependabot/github_actions/docker/metadata...</li>
<li><a href="https://github.com/docker/build-push-action/commit/0ebe720aed7e7e5bedf4d280fc1cca0a463b9a4e "><code>0ebe720</code></a> Bump docker/metadata-action from 3 to 4</li>
<li><a href="https://github.com/docker/build-push-action/commit/38b45804b51da93918ce9015ddf0398c77cb8cef "><code>38b4580</code></a> Standalone mode support</li>
<li><a href="https://github.com/docker/build-push-action/commit/ba317382dcde9f7deb318467fc6cd7230d8b1714 "><code>ba31738</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/533 ">#533</a> from docker/dependabot/npm_and_yarn/csv-parse-5.0.4</li>
<li><a href="https://github.com/docker/build-push-action/commit/43721d2346db18770b3b3a3e3450dc7c44d6db16 "><code>43721d2</code></a> Update generated content</li>
<li><a href="https://github.com/docker/build-push-action/commit/5ea21bf2ba7bc46e8b4f6182a0bbb064eecab476 "><code>5ea21bf</code></a> Fix csv-parse implementation since major update</li>
<li>Additional commits viewable in <a href="https://github.com/docker/build-push-action/compare/v2.10.0...v3.0.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-09 14:33:45 +00:00
dependabot[bot]
494c5cddbe
build(deps): Bump docker/setup-buildx-action from 1.7.0 to 2.0.0 ( #8483 )
...
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action ) from 1.7.0 to 2.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/setup-buildx-action/releases ">docker/setup-buildx-action's releases</a>.</em></p>
<blockquote>
<h2>v2.0.0</h2>
<ul>
<li>Node 16 as default runtime by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/131 ">#131</a>)
<ul>
<li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0 ">Actions Runner</a> version of v2.285.0, which is by default available in GHES 3.4 or later.</li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/setup-buildx-action/compare/v1.7.0...v2.0.0 ">https://github.com/docker/setup-buildx-action/compare/v1.7.0...v2.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/docker/setup-buildx-action/commit/dc7b9719a96d48369863986a06765841d7ea23f6 "><code>dc7b971</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/131 ">#131</a> from crazy-max/node16</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/f55bc08278651b656ee62b6ac783a728845412a8 "><code>f55bc08</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/141 ">#141</a> from crazy-max/fix-test</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/aa877a9d36ddbed778ffbf41ea213fe5a457520b "><code>aa877a9</code></a> ci: fix standalone test</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/130c56f342d03a8e22596cda4ff8eeaff804eb7a "><code>130c56f</code></a> Node 16 as default runtime</li>
<li>See full diff in <a href="https://github.com/docker/setup-buildx-action/compare/v1.7.0...v2.0.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-09 14:31:59 +00:00
Sergio Mena
cec0a97987
RFC017: ABCI++ Vote Extension Propagation ( #8317 )
...
* 1st version
* Addressed (some of) @williambanfield's comments
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Sam Kleinman <garen@tychoish.com >
* Update docs/rfc/README.md
Co-authored-by: Sam Kleinman <garen@tychoish.com >
* Addressed some comments
* Addressed more comments. Improved description of Solution 3
* Work on 'definitions' section
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Callum Waters <cmwaters19@gmail.com >
* bottom
* Addressed Josef's valset-change comment. Other minor edits
* Improved wording of 'disjoint valsets' case
* Addressed TODOs: major revamp of various sections. First complete version.
* Fixed minor wording problem
* removed blank line
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Thane Thomson <connect@thanethomson.com >
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Thane Thomson <connect@thanethomson.com >
* Addressed some of Thane's comments
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Thane Thomson <connect@thanethomson.com >
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Thane Thomson <connect@thanethomson.com >
* Addressed outstanding comments
* Addressed @williambanfield's 'catch-up message' comment
* Removed TODO after confirming statesync is only run on nodes starting from scratch
* Removed TODO (after checking with Jasmina)
* Removed addressed TODO
* Addressed Josef's feedback on case (h)
* Typo
* Update docs/rfc/rfc-017-abci++-vote-extension-propag.md
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
* Added log line
Co-authored-by: Daniel <daniel.cason@usi.ch >
Co-authored-by: Sam Kleinman <garen@tychoish.com >
Co-authored-by: Callum Waters <cmwaters19@gmail.com >
Co-authored-by: Thane Thomson <connect@thanethomson.com >
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
2022-05-09 02:15:08 +02:00
elias-orijtech
694ab2c6d1
test/fuzz: replace outdated reference to go-fuzz in README ( #8477 )
2022-05-06 11:02:19 -07:00
M. J. Fromberger
97f2944db0
Reintegrate docs deployment into the main TM repo ( #8468 )
...
Per https://github.com/tendermint/docs/issues/20 , it is no longer necessary to
build the static documentation out of a separate repository.
This change:
- Adds an actions workflow to build and deploy the docs to GitHub Pages.
- Updates some build settings in a compatible manner.
This change does not affect the existing site deployment. To complete this
change, we will need to update the custom domain pointer and disable the
corresponding workflow in the tendermint/docs repository. Those changes can and
must be done after this is merged.
In the future should probably also move the build rule out of the Makefile and
into the workflow directly. That will also make it easier to manage caching of
build artifacts. For now, however, I've left it as-is, so that we do not break
the active workflow on tendermint/docs, which depends on it.
2022-05-06 07:35:35 -07:00
M. J. Fromberger
ef44460c41
Convert explicit zero comparison to a method. ( #8475 )
...
Fixes #8472 .
I didn't see any other obvious cases of us doing this (although we do return zeroes in other places alongside errors, which is fine).
2022-05-06 13:44:09 +00:00
dependabot[bot]
ce40697ea6
build(deps): Bump github.com/vektra/mockery/v2 from 2.12.1 to 2.12.2 ( #8474 )
...
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery ) from 2.12.1 to 2.12.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vektra/mockery/releases ">github.com/vektra/mockery/v2's releases</a>.</em></p>
<blockquote>
<h2>v2.12.2</h2>
<h2>Changelog</h2>
<ul>
<li>ea4c438 Add deprecation notice to logs</li>
<li>735bc0c Add go-get deprecation note</li>
<li>bea853e Add missing mock</li>
<li>989253d Fix *unsafe.Pointer</li>
<li>9228ad4 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/457 ">#457</a> from LandonTClipp/readme_deprecation</li>
<li>1d92e73 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/460 ">#460</a> from grongor/fix-unsafe-pointer</li>
<li>2fcd83d Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/462 ">#462</a> from LandonTClipp/deprecation</li>
<li>9f67b8a More explicit deprecation for go-get</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/vektra/mockery/commit/1d92e7320b158ed06b285e8717f15504f9374e29 "><code>1d92e73</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/460 ">#460</a> from grongor/fix-unsafe-pointer</li>
<li><a href="https://github.com/vektra/mockery/commit/2fcd83d746b7b9bf5e58f842995ecc33faa8b657 "><code>2fcd83d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/462 ">#462</a> from LandonTClipp/deprecation</li>
<li><a href="https://github.com/vektra/mockery/commit/ea4c438a5358e48a3c4c13506882e77829005b88 "><code>ea4c438</code></a> Add deprecation notice to logs</li>
<li><a href="https://github.com/vektra/mockery/commit/989253d1a4672c73dd000c3bee8b9bed91fcb067 "><code>989253d</code></a> Fix *unsafe.Pointer</li>
<li><a href="https://github.com/vektra/mockery/commit/bea853e93dfb166e3749c00f2816f63f6d563028 "><code>bea853e</code></a> Add missing mock</li>
<li><a href="https://github.com/vektra/mockery/commit/9f67b8afdc0b24f2894b7002743d094c5751a6e8 "><code>9f67b8a</code></a> More explicit deprecation for go-get</li>
<li><a href="https://github.com/vektra/mockery/commit/9228ad4b4a7a0a2a8a1c4f515851380ebc987b70 "><code>9228ad4</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/457 ">#457</a> from LandonTClipp/readme_deprecation</li>
<li><a href="https://github.com/vektra/mockery/commit/735bc0c9f85aed76b132210e7b1ff0442041998f "><code>735bc0c</code></a> Add go-get deprecation note</li>
<li>See full diff in <a href="https://github.com/vektra/mockery/compare/v2.12.1...v2.12.2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-06 10:25:34 +00:00
William Banfield
e980e1468d
RFC-018: initial research of BLS signature aggregation ( #8358 )
...
This provides an initial document for understanding the landscape of implementing a BLS signature aggregation scheme into Tendermint.
2022-05-05 12:08:22 -04:00
M. J. Fromberger
dd4fee88ef
keymigrate: improve filtering for legacy transaction hashes ( #8466 )
...
This is a follow-up to #8352 . The check for legacy evidence keys is only based
on the prefix of the key. Hashes, which are unprefixed, could easily have this
form and be misdiagnosed.
Because the conversion for evidence checks the key structure, this should not
cause corruption. The probability that a hash is a syntactically valid evidence
key is negligible. The tool will report an error rather than storing bad data.
But this does mean that such transaction hashes could cause the migration to
stop and report an error before it is complete.
To ensure we convert all the data, refine the legacy key check to filter these
keys more precisely. Update the test cases to exercise this condition.
* Update upgrading instructions.
2022-05-04 11:08:26 -07:00
William Banfield
c8e336f2e9
docs: minor fixups to pbts overview ( #8454 )
2022-05-04 13:21:32 +00:00
dependabot[bot]
9a028b7d8a
build(deps): Bump github.com/creachadair/atomicfile from 0.2.5 to 0.2.6 ( #8460 )
...
Bumps [github.com/creachadair/atomicfile](https://github.com/creachadair/atomicfile ) from 0.2.5 to 0.2.6.
- [Release notes](https://github.com/creachadair/atomicfile/releases )
- [Commits](https://github.com/creachadair/atomicfile/compare/v0.2.5...v0.2.6 )
---
updated-dependencies:
- dependency-name: github.com/creachadair/atomicfile
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 07:51:33 -04:00
Sam Kleinman
37287ead94
p2p: remove message type from channel implementation ( #8452 )
2022-05-02 10:52:57 -04:00
dependabot[bot]
6c40ad39b2
build(deps): Bump docker/setup-buildx-action from 1.6.0 to 1.7.0 ( #8451 )
...
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action ) from 1.6.0 to 1.7.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/setup-buildx-action/releases ">docker/setup-buildx-action's releases</a>.</em></p>
<blockquote>
<h2>v1.7.0</h2>
<ul>
<li>Standalone mode by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> in (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/119 ">#119</a>)</li>
<li>Update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/114 ">#114</a> <a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/130 ">#130</a>)</li>
<li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/108 ">#108</a>)</li>
<li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/109 ">#109</a>)</li>
<li>Bump <code>@actions/core</code> from 1.5.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/110 ">#110</a>)</li>
<li>Bump actions/checkout from 2 to 3 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/126 ">#126</a>)</li>
<li>Bump <code>@actions/tool-cache</code> from 1.7.1 to 1.7.2 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/128 ">#128</a>)</li>
<li>Bump <code>@actions/exec</code> from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/129 ">#129</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/132 ">#132</a>)</li>
<li>Bump codecov/codecov-action from 2 to 3 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/133 ">#133</a>)</li>
<li>Bump semver from 7.3.5 to 7.3.7 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/136 ">#136</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/docker/setup-buildx-action/commit/f211e3e9ded2d9377c8cadc4489a4e38014bc4c9 "><code>f211e3e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/136 ">#136</a> from docker/dependabot/npm_and_yarn/semver-7.3.7</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/b23216e5049dc1ca5be0b759aac2be71f816e561 "><code>b23216e</code></a> Update generated content</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/be7e600e20936d2401e98773b757cbfc60c4596d "><code>be7e600</code></a> Bump semver from 7.3.5 to 7.3.7</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/7117987c01eac307fd6e677d4c5fe538c6fde28e "><code>7117987</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/119 ">#119</a> from crazy-max/standalone</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/17ebdd4d657fd1734938d25bc7ebb09e17f38430 "><code>17ebdd4</code></a> ci: add jobs to check standalone behavior</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/3472856dd98651ba887346cd57a440713d7af7f7 "><code>3472856</code></a> support standalone mode and display version</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/74283caced5fd781db4de393d8e45f49f031fead "><code>74283ca</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/133 ">#133</a> from docker/dependabot/github_actions/codecov/codecov...</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/5b77ad49e85ddf74fb2f5d6ca358ab84fdac9ecb "><code>5b77ad4</code></a> Bump codecov/codecov-action from 2 to 3</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/2a6fbda6d8bd6fe40f8b36c71fca20ffc286129e "><code>2a6fbda</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/132 ">#132</a> from docker/dependabot/npm_and_yarn/minimist-1.2.6</li>
<li><a href="https://github.com/docker/setup-buildx-action/commit/03815bdb0601e885859cc2bb53b9b1755fa0b881 "><code>03815bd</code></a> Bump minimist from 1.2.5 to 1.2.6</li>
<li>Additional commits viewable in <a href="https://github.com/docker/setup-buildx-action/compare/v1.6.0...v1.7.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-02 11:52:11 +00:00
Daniel
a49325e4e0
PBTS: system model made more precise ( #8096 )
...
* PBTS model: precision, accuracy, and delay defs
* PBTS model: consensus properties reviewed
* PBTS model: reinforcing alignment with UTC
* PBTS model: precision parameter embodies accuracy
* PBTS model: discussion about accuracy shortened
* PBTS model: proposal time monotonocity rephrased
* PBTS model: precision, accuracy, and delay defs
* PBTS model: consensus properties reviewed
* PBTS model: reinforcing alignment with UTC
* PBTS model: precision parameter embodies accuracy
* PBTS model: discussion about accuracy shortened
* PBTS model: proposal time monotonocity rephrased
* PBTS model: Safety Invariants subsection
* PBTS model: MSGDELAY description shortened
* PBTS model: timely proposals definition refined
* PBTS model: some formatting changes
* PBTS model: timely predicate definition
* PBTS model: timely proof-of-lock re-defined
* PBTS model: derived proof-of-lock requirements
* The property needs to be properly demonstrated.
* Apply suggestions from William
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
* PBTS model: reference to arXiv algorithm on timely
* PBTS model: typos fixed
* PBTS model: derived POL "demonstration"
* PBTS model: fix formatting, r' renamed to vr
* PBTS model: minor fixes
* PBTS model: derived POL proof ammended
* PBTS safety: consensus validity with time inequalty
* PBTS: renamed receiveTime to proposalReceptionTime
* PBTS safety: short intro, some links
* PBTS model: safety refactored again
* PBTS model: liveness condition stated
* PBTS liveness: minor change
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
* PBTS sysmodel: formmatting typo fixed
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
2022-05-02 10:22:03 +02:00
Thane Thomson
e7451a43e7
blocksync: Honor contexts supplied to BlockPool ( #8447 )
...
* Lift condition into for loop
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Honor contexts in BlockPool
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only stop timers when necessary
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Optimize timers
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Simplify request interval definition
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove extraneous timer stop
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Convert switch into if
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Eliminate timers
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-30 14:34:59 -04:00
Sam Kleinman
cf2a00b398
p2p: avoid using p2p.Channel internals ( #8444 )
2022-04-29 17:21:36 -04:00
Sam Kleinman
89196596f7
privval/grpc: normalize signature ( #8441 )
2022-04-29 10:56:10 -04:00
Sam Kleinman
eee19e42db
consensus: reduce size of validator set changes test ( #8442 )
2022-04-29 10:29:26 -04:00
dependabot[bot]
97b39770e0
build(deps): Bump github.com/btcsuite/btcd from 0.22.0-beta to 0.22.1 ( #8439 )
...
Bumps [github.com/btcsuite/btcd](https://github.com/btcsuite/btcd ) from 0.22.0-beta to 0.22.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/btcsuite/btcd/blob/v0.22.1/CHANGES ">github.com/btcsuite/btcd's changelog</a>.</em></p>
<blockquote>
<h1>============================================================================
User visible changes for btcd
A full-node bitcoin implementation written in Go</h1>
<p>Changes in 0.22.1 (Wed Apr 27 2022)</p>
<ul>
<li>Notable developer-related package changes:
<ul>
<li>Update to use chaincfg/chainhash module and remove conflicting
package</li>
</ul>
</li>
<li>Contributors (alphabetical order):
<ul>
<li>Dave Collins</li>
</ul>
</li>
</ul>
<p>Changes in 0.22.0 (Tue Jun 01 2021)</p>
<ul>
<li>Protocol and network-related changes:
<ul>
<li>Add support for witness tx and block in notfound msg (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1625 ">#1625</a>)</li>
<li>Add support for receiving sendaddrv2 messages from a peer (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1670 ">#1670</a>)</li>
<li>Fix bug in peer package causing last block height to go backwards
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1606 ">#1606</a>)</li>
<li>Add chain parameters for connecting to the public Signet network
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1692 ">#1692</a>, <a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1718 ">#1718</a>)</li>
</ul>
</li>
<li>Crypto changes:
<ul>
<li>Fix bug causing panic due to bad R and S signature components in
btcec.RecoverCompact (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1691 ">#1691</a>)</li>
<li>Set the name (secp256k1) in the CurveParams of the S256 curve
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1565 ">#1565</a>)</li>
</ul>
</li>
<li>Notable developer-related package changes:
<ul>
<li>Remove unknown block version warning in the blockchain package,
due to false positives triggered by AsicBoost (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1463 ">#1463</a>)</li>
<li>Add chaincfg.RegisterHDKeyID function to populate HD key ID pairs
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1617 ">#1617</a>)</li>
<li>Add new method mining.AddWitnessCommitment to add the witness
commitment as an OP_RETURN output within the coinbase transaction.
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1716 ">#1716</a>)</li>
</ul>
</li>
<li>RPC changes:
<ul>
<li>Support Batch JSON-RPC in rpcclient and server (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1583 ">#1583</a>)</li>
<li>Add rpcclient method to invoke getdescriptorinfo JSON-RPC command
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1578 ">#1578</a>)</li>
<li>Update the rpcserver handler for validateaddress JSON-RPC command to
have parity with the bitcoind 0.20.0 interface (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1613 ">#1613</a>)</li>
<li>Add rpcclient method to invoke getblockfilter JSON-RPC command
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1579 ">#1579</a>)</li>
<li>Add signmessagewithprivkey JSON-RPC command in rpcserver (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1585 ">#1585</a>)</li>
<li>Add rpcclient method to invoke importmulti JSON-RPC command (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1579 ">#1579</a>)</li>
<li>Add watchOnly argument in rpcclient method to invoke
listtransactions JSON-RPC command (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1628 ">#1628</a>)</li>
<li>Update btcjson.ListTransactionsResult for compatibility with Bitcoin
Core 0.20.0 (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1626 ">#1626</a>)</li>
<li>Support nullable optional JSON-RPC parameters (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1594 ">#1594</a>)</li>
<li>Add rpcclient and server method to invoke getnodeaddresses JSON-RPC</li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/btcsuite/btcd/commit/2f508b3f86ed9ef87bcf3426b87b6c0dc0d3632c "><code>2f508b3</code></a> Update CHANGES file for 0.22.1 release.</li>
<li><a href="https://github.com/btcsuite/btcd/commit/ff92d88504eb4fb0e09d4c09664c5162e9e51a1c "><code>ff92d88</code></a> btcd: bump version to v0.22.1.</li>
<li><a href="https://github.com/btcsuite/btcd/commit/cf5c461d91bcad304eae5d106d79d1a6138dc8a0 "><code>cf5c461</code></a> main: Switch to chaincfg/chainhash module.</li>
<li>See full diff in <a href="https://github.com/btcsuite/btcd/compare/v0.22.0-beta...v0.22.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-29 11:21:56 +00:00
dependabot[bot]
297fcc0a7c
build(deps): Bump github.com/creachadair/tomledit from 0.0.18 to 0.0.19 ( #8440 )
...
Bumps [github.com/creachadair/tomledit](https://github.com/creachadair/tomledit ) from 0.0.18 to 0.0.19.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/creachadair/tomledit/commit/0692e4157ab4d6f462f193a34c64fd36ed046e64 "><code>0692e41</code></a> Release v0.0.19</li>
<li><a href="https://github.com/creachadair/tomledit/commit/d1160a474bfb13f6e1bc11e87b6f41ea53448775 "><code>d1160a4</code></a> Update default permissions.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/56f28f4ea0d3e46cfb700d32a1a987978d4c15ef "><code>56f28f4</code></a> Move transform tests to that package.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/3b8b380274179214af105fb08fc80eaf733f39ab "><code>3b8b380</code></a> Add permissions to CI workflow.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/409951b699618a43a8fe4ec9abab55e686c69df2 "><code>409951b</code></a> Add a quotation test case.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/f35c8bec5cd9461158496d0227f5427cb06c00d4 "><code>f35c8be</code></a> parser: include line numbers in headings, mappings, and values</li>
<li><a href="https://github.com/creachadair/tomledit/commit/26acca1df827b8f8eaf980b5444b3694f3026965 "><code>26acca1</code></a> Regularize location formatting in diagnostics.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/3394f599e4005db38e64b7ad1e23e503f34d9fe0 "><code>3394f59</code></a> Add more parser test cases.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/5ce10cc05ab2003c6a47b7d33493c1116ab7a97c "><code>5ce10cc</code></a> Rename test file.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/29f3eb34c894b3b6f3f00633ee624b7d8a8201ca "><code>29f3eb3</code></a> Allow compliance tests to be skipped with -short.</li>
<li>See full diff in <a href="https://github.com/creachadair/tomledit/compare/v0.0.18...v0.0.19 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-29 10:59:15 +00:00
Sam Kleinman
3d448e1ef8
crypto: cleanup tmhash package ( #8434 )
2022-04-28 22:21:43 -04:00
M. J. Fromberger
6faf506540
rpc: fix byte string decoding for URL parameters ( #8431 )
...
In #8397 I tried to remove all the cases where we needed to keep track of the
target type of parameters for JSON encoding, but there is one case still left:
When decoding parameters from URL query terms, there is no way to tell whether
or not we need base64 encoding without knowing whether the underlying type of
the target is string or []byte.
To fix this, keep track of parameters that are []byte valued when RPCFunc is
compiling its argument map, and use that when parsing URL query terms. Update
the tests accordingly.
2022-04-28 15:18:11 -07:00
Thane Thomson
d69bd64702
abci++: Vote extension cleanup ( #8402 )
...
* Split vote verification/validation based on vote extensions
Some parts of the code need vote extensions to be verified and
validated (mostly in consensus), and other parts of the code don't
because its possible that, in some cases (as per RFC 017), we won't have
vote extensions.
This explicitly facilitates that split.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only sign extensions in precommits, not prevotes
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Update privval/file.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Apply suggestions from code review
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Temporarily disable extension requirement again for E2E testing
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Reorganize comment for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Leave vote validation and pre-call nil check up to caller of VoteToProto
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Split complex vote validation test into multiple tests
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Universally enforce no vote extensions on any vote type but precommits
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Make error messages more generic
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Verify with vote extensions when constructing a VoteSet
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Expand comment for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add extension check for prevotes prior to signing votes
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix supporting test code to only inject extensions into precommits
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Separate vote malleation from signing in vote tests for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add extension signature length check and corresponding test
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Perform basic vote validation in CommitToVoteSet
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-04-28 13:53:44 -04:00
M. J. Fromberger
47d52fc78d
Use patched link-checker for periodic checks. ( #8430 )
...
In #8339 we pointed the markdown link checker action to a patched version that
has the up-to-date version of the underlying check tool. In doing so, I missed
the periodic cron job that runs the same workflow. Update it to use the patched
version also.
2022-04-28 06:44:56 -07:00
Sam Kleinman
2a58ea3ab2
p2p: use nodeinfo less often ( #8427 )
2022-04-27 21:13:38 +00:00