William Banfield
2e1f5bdbcd
fix hvs test
2022-05-17 15:29:43 -04:00
William Banfield
5d84aaf7d4
fix tests to store and load state
2022-05-17 15:06:35 -04:00
William Banfield
5dc8a1fac0
hack to not generate protos yet
2022-05-17 15:06:17 -04:00
William Banfield
351b3bf6b0
tentative change for preventing blocksync early bail out
2022-05-17 12:24:43 -04:00
William Banfield
42b9c99c93
add check for blockid flag is commit
2022-05-17 10:40:36 -04:00
William Banfield
ff7955470a
update proposal tests to ensure off-by-one is correctly handled
2022-05-17 10:28:35 -04:00
William Banfield
ae6b910427
log if extension data present
2022-05-17 10:17:20 -04:00
William Banfield
603381ca2b
update vote reconstruction logic to force extended commit if extension enabled
2022-05-17 10:12:56 -04:00
William Banfield
93ea3d0b7d
strip extensions in blocksync
2022-05-16 19:20:08 -04:00
William Banfield
44f1f045e2
update the VoteSet methods to only validate extensions when enabled
2022-05-16 19:08:34 -04:00
William Banfield
78c0c9c6ce
strip vote extensions in the reactor
2022-05-16 18:25:07 -04:00
William Banfield
b51b83a250
change prepare proposal to use enable extension logic
2022-05-16 18:00:25 -04:00
William Banfield
397f0840f6
do not call extension methods when not enabled
2022-05-16 17:13:14 -04:00
William Banfield
32790dedfc
do not verify extension if not enabled
2022-05-16 17:02:43 -04:00
William Banfield
589d4030ce
rename vote extension param
2022-05-16 16:46:17 -04:00
William Banfield
17d5e71489
Update internal/consensus/state.go
...
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-05-16 15:29:49 -04:00
William Banfield
ed9df4d1f1
Update types/block.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-16 12:13:57 -04:00
William Banfield
62ecdf5b60
correct NewStrictVoteSet constructor to not call itself
2022-05-16 11:40:08 -04:00
William Banfield
f5cd75c090
shorter timeout in SwitchToConsensus test
2022-05-16 11:39:01 -04:00
William Banfield
19cc03f6fd
addr -> myAddr
2022-05-16 11:38:23 -04:00
William Banfield
cb2f3624da
Update internal/consensus/state.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-16 11:36:01 -04:00
William Banfield
d3c9ab64b5
Update internal/consensus/state.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-16 11:35:49 -04:00
William Banfield
331a7ceea1
Update types/block.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-16 11:33:41 -04:00
William Banfield
c2f543bebb
update heightvoteset constructor for strict vs non strict
2022-05-16 11:27:45 -04:00
William Banfield
bd26649455
change voteset constructor to strict vs non strict
2022-05-16 11:24:43 -04:00
William Banfield
f0b03adfca
Merge branch 'master' into wb/add-consensus-param-internal
2022-05-16 10:27:17 -04:00
Sam Kleinman
7f79661c2e
rfc: onboarding projects ( #8413 )
...
This is meant as a supporting recruiting document. The idea is to
describe a bunch of projects scoped and selected as teaching projects
for new engineers joining the team.
This isn't meant to replace "neweng" or "good-first-ticket" tags on
issues, but provide a higher level set of examples of the kinds of
things that someone joining the team could tackle.
2022-05-16 14:15:06 +00:00
William Banfield
6cb415028e
Merge branch 'master' into wb/add-consensus-param-internal
2022-05-16 10:14:59 -04:00
dependabot[bot]
fb7229135a
build(deps): Bump google.golang.org/grpc from 1.46.0 to 1.46.2 ( #8559 )
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.46.0 to 1.46.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases ">google.golang.org/grpc's releases</a>.</em></p>
<blockquote>
<h2>Release v1.46.2</h2>
<h1>Bug Fixes</h1>
<ul>
<li>client: fix potential panic during RPC retries (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5323 ">#5323</a>)</li>
<li>xds: fix leak of deleted CDS resources from CSDS view (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5339 ">#5339</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="46da11bc8b10b610c0behttps://github-redirect.dependabot.com/grpc/grpc-go/issues/5339 ">#5339</a>)</li>
<li><a href="1303098b85https://github-redirect.dependabot.com/grpc/grpc-go/issues/5323 ">#5323</a>)</li>
<li><a href="beb2eafa90https://github-redirect.dependabot.com/grpc/grpc-go/issues/5297 ">#5297</a>)</li>
<li>See full diff in <a href="https://github.com/grpc/grpc-go/compare/v1.46.0...v1.46.2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-16 14:04:08 +00:00
dependabot[bot]
d004638b0b
build(deps): Bump github.com/prometheus/common from 0.32.1 to 0.34.0 ( #8557 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.32.1 to 0.34.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/prometheus/common/releases ">github.com/prometheus/common's releases</a>.</em></p>
<blockquote>
<h2>v0.34.0</h2>
<ul>
<li>[ENHANCEMENT] Enable selecting minimum TLS version. <a href="https://github-redirect.dependabot.com/prometheus/common/issues/375 ">#375</a></li>
</ul>
<h2>v0.33.0</h2>
<ul>
<li>[ENHANCEMENT] Make HTTP2 User Visible <a href="https://github-redirect.dependabot.com/prometheus/common/issues/360 ">#360</a></li>
<li>[FEATURE] Add proxy_url support for oauth2 <a href="https://github-redirect.dependabot.com/prometheus/common/issues/358 ">#358</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3763a1ded1https://github-redirect.dependabot.com/prometheus/common/issues/375 ">#375</a>)</li>
<li><a href="0c7319ad92840c039c5fffd0efb12a902cb39e6chttps://github-redirect.dependabot.com/prometheus/common/issues/365 ">#365</a> from prometheus/superq/bump_sigv4</li>
<li><a href="910a9dfdc72c242773f1https://github-redirect.dependabot.com/prometheus/common/issues/362 ">#362</a> from prometheus/repo_sync</li>
<li><a href="f6b09127ffhttps://github-redirect.dependabot.com/prometheus/common/issues/353 ">#353</a> from prometheus/superq/bump_go</li>
<li><a href="e457c0a6f30e1254b764https://github-redirect.dependabot.com/prometheus/common/issues/359 ">#359</a> from prometheus/repo_sync</li>
<li>Additional commits viewable in <a href="https://github.com/prometheus/common/compare/v0.32.1...v0.34.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-16 13:20:31 +00:00
William Banfield
e80d2bd494
Merge branch 'master' into wb/add-consensus-param-internal
2022-05-15 23:27:32 -04:00
William Banfield
9d6e0235e9
comment fixup
2022-05-15 23:26:55 -04:00
William Banfield
f1db90affe
abci++: add consensus parameter to control vote extension require height
2022-05-15 23:22:34 -04:00
Ivo Elenchev
c780619db5
Fix typo ( #8550 )
2022-05-14 15:50:36 -07:00
Sam Kleinman
42e5924662
mempool: do not continue checking transactions if context was cacneled ( #8549 )
2022-05-14 08:27:53 -04:00
dependabot[bot]
bdca727014
build(deps): Bump github.com/prometheus/client_golang ( #8540 )
...
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang ) from 1.12.1 to 1.12.2.
- [Release notes](https://github.com/prometheus/client_golang/releases )
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.12.2/CHANGELOG.md )
- [Commits](https://github.com/prometheus/client_golang/compare/v1.12.1...v1.12.2 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-13 13:08:55 -07:00
M. J. Fromberger
2d9a379b63
build: add CI check that generated files are up-to-date ( #8521 )
...
Add an actions workflow that verifies that generated files are up-to-date
during a pull request. If not, give the reader instructions about what to do to
update the PR.
Checks are included for protobuf and mockery.
2022-05-13 12:41:24 -07:00
M. J. Fromberger
9c9a4140d9
chore: update generated mocks ( #8546 )
2022-05-13 12:27:10 -07:00
M. J. Fromberger
7da9746a57
Fix protobuf generated code. ( #8545 )
...
* Revert "update protos (#8515 )"
This reverts commit f094fd204a#8515 may have been generated with an out-of-date version of
either buf or the gogo plugin. using the latest versions (buf 1.4.0 and gogo
1.3.2) reverts those changes.
* Add a script to re-generate protos with the latest tools.
This script is just a wrapper for the Make rule, but it runs the build inside a
container with the latest versions of buf and gogo installed. This reduces the
chance that an out-of-date ambient installation on a developer machine will get
us outdated output.
2022-05-13 12:08:21 -07:00
dependabot[bot]
c29d1b34fd
build(deps): Bump golangci/golangci-lint-action from 3.1.0 to 3.2.0 ( #8525 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 3.1.0 to 3.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint-action/releases ">golangci/golangci-lint-action's releases</a>.</em></p>
<blockquote>
<h2>v3.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Expire cache periodically to avoid unbounded size by <a href="https://github.com/ezimanyi "><code>@ezimanyi</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/466 ">golangci/golangci-lint-action#466</a></li>
</ul>
<h3>misc</h3>
<ul>
<li>docs: update version to v3 by <a href="https://github.com/zaunist "><code>@zaunist</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/450 ">golangci/golangci-lint-action#450</a></li>
<li>modify examples using setup-go by <a href="https://github.com/3100 "><code>@3100</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/451 ">golangci/golangci-lint-action#451</a></li>
</ul>
<h3>dependencies</h3>
<ul>
<li>build(deps): bump actions/checkout from 2 to 3 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/409 ">golangci/golangci-lint-action#409</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.12.1 to 5.13.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/410 ">golangci/golangci-lint-action#410</a></li>
<li>build(deps-dev): bump eslint-config-prettier from 8.4.0 to 8.5.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/412 ">golangci/golangci-lint-action#412</a></li>
<li>build(deps-dev): bump typescript from 4.5.5 to 4.6.2 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/413 ">golangci/golangci-lint-action#413</a></li>
<li>build(deps-dev): bump eslint from 8.10.0 to 8.11.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/418 ">golangci/golangci-lint-action#418</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.14.0 to 5.15.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/421 ">golangci/golangci-lint-action#421</a></li>
<li>build(deps-dev): bump prettier from 2.5.1 to 2.6.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/422 ">golangci/golangci-lint-action#422</a></li>
<li>build(deps): bump <code>@actions/cache</code> from 1.0.9 to 1.0.10 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/423 ">golangci/golangci-lint-action#423</a></li>
<li>build(deps): bump <code>@actions/tool-cache</code> from 1.7.1 to 1.7.2 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/426 ">golangci/golangci-lint-action#426</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.14.0 to 5.15.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/425 ">golangci/golangci-lint-action#425</a></li>
<li>build(deps): bump <code>@actions/exec</code> from 1.1.0 to 1.1.1 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/424 ">golangci/golangci-lint-action#424</a></li>
<li>build(deps): bump minimist from 1.2.5 to 1.2.6 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/427 ">golangci/golangci-lint-action#427</a></li>
<li>build(deps-dev): bump prettier from 2.6.0 to 2.6.1 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/428 ">golangci/golangci-lint-action#428</a></li>
<li>build(deps-dev): bump typescript from 4.6.2 to 4.6.3 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/429 ">golangci/golangci-lint-action#429</a></li>
<li>build(deps): bump <code>@actions/cache</code> from 1.0.10 to 2.0.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/432 ">golangci/golangci-lint-action#432</a></li>
<li>build(deps-dev): bump prettier from 2.6.1 to 2.6.2 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/436 ">golangci/golangci-lint-action#436</a></li>
<li>build(deps): bump <code>@actions/github</code> from 5.0.0 to 5.0.1 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/437 ">golangci/golangci-lint-action#437</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.16.0 to 5.17.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/438 ">golangci/golangci-lint-action#438</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.16.0 to 5.18.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/441 ">golangci/golangci-lint-action#441</a></li>
<li>build(deps-dev): bump eslint-plugin-import from 2.25.4 to 2.26.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/444 ">golangci/golangci-lint-action#444</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.17.0 to 5.18.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/445 ">golangci/golangci-lint-action#445</a></li>
<li>build(deps-dev): bump eslint from 8.12.0 to 8.13.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/446 ">golangci/golangci-lint-action#446</a></li>
<li>build(deps): bump actions/setup-go from 2 to 3 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/443 ">golangci/golangci-lint-action#443</a></li>
<li>build(deps-dev): bump <code>@vercel/ncc</code> from 0.33.3 to 0.33.4 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/452 ">golangci/golangci-lint-action#452</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.18.0 to 5.19.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/453 ">golangci/golangci-lint-action#453</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.18.0 to 5.19.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/454 ">golangci/golangci-lint-action#454</a></li>
<li>build(deps): bump <code>@actions/cache</code> from 2.0.0 to 2.0.2 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/447 ">golangci/golangci-lint-action#447</a></li>
<li>build(deps-dev): bump eslint from 8.13.0 to 8.14.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/456 ">golangci/golangci-lint-action#456</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.19.0 to 5.20.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/455 ">golangci/golangci-lint-action#455</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.19.0 to 5.20.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/457 ">golangci/golangci-lint-action#457</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.20.0 to 5.21.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/460 ">golangci/golangci-lint-action#460</a></li>
<li>build(deps-dev): bump typescript from 4.6.3 to 4.6.4 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/461 ">golangci/golangci-lint-action#461</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.20.0 to 5.22.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/464 ">golangci/golangci-lint-action#464</a></li>
<li>build(deps): bump github/codeql-action from 1 to 2 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/459 ">golangci/golangci-lint-action#459</a></li>
<li>build(deps-dev): bump eslint from 8.14.0 to 8.15.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/467 ">golangci/golangci-lint-action#467</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.21.0 to 5.22.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/469 ">golangci/golangci-lint-action#469</a></li>
<li>build(deps): bump <code>@actions/core</code> from 1.6.0 to 1.8.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/468 ">golangci/golangci-lint-action#468</a></li>
</ul>
<h2>New Contributors</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="537aa1903ehttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/466 ">#466</a>)</li>
<li><a href="f70e52dcc9https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/468 ">#468</a>)</li>
<li><a href="a304692ecbhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/469 ">#469</a>)</li>
<li><a href="eeca7c5026https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/467 ">#467</a>)</li>
<li><a href="dfbcd2aee1https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/459 ">#459</a>)</li>
<li><a href="4421331437https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/464 ">#464</a>)</li>
<li><a href="5e6c1bb9e2https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/461 ">#461</a>)</li>
<li><a href="44eba43baehttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/460 ">#460</a>)</li>
<li><a href="358a5e374fhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/457 ">#457</a>)</li>
<li><a href="b9c65a53a1https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/455 ">#455</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint-action/compare/v3.1.0...v3.2.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-13 15:32:25 +00:00
M. J. Fromberger
81e5bf8417
Consolidate Dependabot checks for GitHub Actions deps. ( #8518 )
...
We currently have Dependabot check for updates to GitHub actions once a week on
master, but daily on the backport branches. This is unnecessarily noisy.
As a first step to reducing this noise, consolidate all the settings onto the
default branch (master).
2022-05-13 08:09:09 -07:00
Callum Waters
f094fd204a
update protos ( #8515 )
2022-05-13 16:18:24 +02:00
M. J. Fromberger
f9fa0a3228
docs: update event subscription documentation for new API ( #8509 )
...
Update the static documentation about event subscription to include the new
/events API, and to add more details about how queries work. Mention that the
streaming API is deprecated.
2022-05-12 11:54:49 -07:00
William Banfield
92811b9153
metrics: transition all metrics to using metricsgen generated constructors. ( #8488 )
...
## What does this change do?
This pull request completes the change to the `metricsgen` metrics. It adds `go generate` directives to all of the files containing the `Metrics` structs.
Using the outputs of `metricsdiff` between these generated metrics and `master`, we can see that there is not a diff between the two sets of metrics when run locally.
```
[william@sidewinder] tendermint[wb/metrics-gen-transition]:. ◆ ./scripts/metricsgen/metricsdiff/metricsdiff metrics_master metrics_generated
[william@sidewinder] tendermint[wb/metrics-gen-transition]:. ◆
```
This change also adds parsing for a `metrics:` key in a field comment. If a comment line begins with `//metrics:` the rest of the line is interpreted to be the metric help text. Additionally, a bug where lists of labels were not properly quoted in the `metricsgen` rendered output was fixed.
2022-05-12 18:39:12 +00:00
M. J. Fromberger
b5550b0d1b
rpc: make block.height visible to event subscription ( #8508 )
...
Although we index block.height for blocks in the KV indexer, this reserved
attribute was not previously exposed to the event subscription API. Despite
being advertised in the OpenAPI spec, neither the old (websocket) nor new
(events) query interface could see it. This change exposes block.height to the
/events API.
In addition: Remove a non-public constant from types (finalize_block). This
value is used only as an internal tag by the indexer, and should not be exposed
to users of the public interface. (We could probably drop it entirely, as it
was previously a disambiguator for BeginBlock vs. EndBlock events, but keeping
a tag here simplifies the cleanup).
2022-05-12 06:43:05 -07:00
William Banfield
0130a8cf97
scripts/metricsgen: add metricsdiff tool ( #8501 )
...
Adds the `metricsdiff` tool. The metricsdiff tool parses two files containing prometheus metrics and calculates the sets of metrics that were added or removed between the two files or have changed labels. This tool is added to ensure that the metrics been generated for `metricsgen` match the bespoke metrics.
The following metrics were found to be different between master and the the tool was built with. The output makes sense given that the metrics branch does _not_ contain https://github.com/tendermint/tendermint/pull/8480 .
```
./metricsdiff metrics_master metrics_generated
Removes:
--- tendermint_consensus_proposal_create_count
--- tendermint_consensus_vote_extension_receive_count
--- tendermint_consensus_round_voting_power_percent
--- tendermint_consensus_proposal_receive_count
```
2022-05-11 22:06:15 +00:00
dependabot[bot]
b0fe38c245
build(deps): Bump github.com/creachadair/tomledit from 0.0.19 to 0.0.22 ( #8504 )
...
Bumps [github.com/creachadair/tomledit](https://github.com/creachadair/tomledit ) from 0.0.19 to 0.0.22.
<details>
<summary>Commits</summary>
<ul>
<li><a href="f7ad71d86c2cb36fdb81f56c9925a30271385b7a6e4454ec9dd59f49c18b9f9039fa9bhttps://github.com/creachadair/tomledit/compare/v0.0.19...v0.0.22 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-11 13:23:47 +00:00
Thane Thomson
06b1812094
abci++: Propagate vote extensions (RFC 017) ( #8433 )
...
* Add protos for ExtendedCommit
Cherry-pick from e73f0178b72a16ee81f8e856aadf651f2c62ec6e just the
changes to the .proto files, since we have deleted the .intermediate
files.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* make proto-gen
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* BlockStore holds extended commit
Cherry-pick 8d504d4b50ec6afbdffe2df7ababbef30e15053d and fix conflicts.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Reshuffle ExtendedCommit and ExtendedCommitSig
Separate the data structures and functions from their Commit-oriented
counterparts to adhere to the current coding style.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix exit condition in blocksync
* Add note to remove TxResult proto
As Sergio pointed out in 3e31aa6f583cdc71e208ed03a82f1d804ec0de49, this
proto message can probably be removed. We should do this in a separate
PR.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Lift termination condition into for loop
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Enforce vote extension signature requirement
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Expand on comment for PeekTwoBlocks for posterity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Isolate TODO more clearly
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* make mockery
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix comment
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Make panic output from BlockStore.SaveBlock more readable
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add helper methods to ExtendedCommitSig and ExtendedCommit
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix most tests except TestHandshake*
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix store prefix collision
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix TestBlockFetchAtHeight
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove global state from store tests
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Apply suggestions from code review
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
Co-authored-by: Sergio Mena <sergio@informal.systems >
* blocksync: Just return error
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* make format
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Remove unused/commented-out code
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* blocksync: Change pool AddBlock function signature to return errors
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Improve legibility of switch statements
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* blocksync: Expand on extended commit requirement in AddBlock description
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* blocksync: Return error without also logging it
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* consensus: Rename short-lived local variable
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* consensus: Allocate TODO to Sergio
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* evidence/pool_test: Inline slice construction
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* state: Rename LoadBlockExtCommit to LoadBlockExtendedCommit
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* proto: Remove TODO on TxResult
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Minor format
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Reformat ExtendedCommitSig.BlockID
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Remove NewExtendedCommit constructor
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Remove NewCommit constructor
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Shorten receiver names for ExtendedCommit
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Convert ExtendedCommit.Copy to a deep clone
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Assign TODO to Sergio
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Fix legibility nits
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Improve legibility
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* store/state: Add TODO to move prefixes to common package
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Propagate validator info to PrepareProposal
In order to propagate validator voting power through to PrepareProposal,
we need to load the validator set info from the height corresponding to
the extended commit that we're passing through to PrepareProposal as the
"LocalLastCommit".
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Rename local var for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix TestMaxProposalBlockSize
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Rename local var for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove debug log
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove CommigSig.ForBlock helper
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove CommigSig.Absent helper
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove ExtendedCommitSig.ForBlock helper
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove ExtendedCommitSig.Absent helper
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* There are no extended commits below the initial height
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix comment grammar
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove JSON encoding from ExtendedCommit
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Embed CommitSig into ExtendedCommitSig instead of duplicating fields
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Rename ExtendedCommit vote_extension field to extension for consistency with domain types
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* blocksync: Panic if we peek a block without an extended commit
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Apply suggestions from code review
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Remove Sergio from TODO
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Increase hard-coded vote extension max size to 1MB
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* state: Remove unnecessary comment
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* state: Ensure no of commit sigs equals validator set length
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* make format
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Minor legibility improvements
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Improve legibility
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Remove unused GetVotes function on VoteSet
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Refactor TestMaxProposalBlockSize to construct more realistic extended commit
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Refactor buildExtendedCommitInfo to resemble buildLastCommitInfo
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Apply suggestions from code review
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* abci++: Disable VerifyVoteExtension call on nil precommits (#8491 )
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: Require vote extensions on non-nil precommits and not otherwise
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Disable lint
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Increase timeout for TestReactorVotingPowerChange to counter flakiness
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only sign and verify vote extensions in non-nil precommits
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Revert "Disable lint"
This reverts commit 6fffbf9402connect@thanethomson.com >
* Add missing non-nil check uncovered non-deterministically in TestHandshakeReplayAll
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Expand error message for accuracy
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only call ExtendVote when we make non-nil precommits
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Revert "Increase timeout for TestReactorVotingPowerChange to counter flakiness"
This reverts commit af514939dbconnect@thanethomson.com >
* Refactor ValidateBasic for ExtendedCommitSig for legibility
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Co-authored-by: Sergio Mena <sergio@informal.systems >
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-11 07:10:32 -04:00
Sergio Mena
735a1a537b
Fixed math notation in ABCI++ app requirements ( #8499 )
...
* Fixed math notation in ABCI++ app requirements
* Update spec/abci++/abci++_app_requirements_002_draft.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
* Update spec/abci++/abci++_app_requirements_002_draft.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
* Update spec/abci++/abci++_app_requirements_002_draft.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
* Update spec/abci++/abci++_app_requirements_002_draft.md
Co-authored-by: Daniel <daniel.cason@usi.ch >
Co-authored-by: Daniel <daniel.cason@usi.ch >
2022-05-10 21:50:28 +02:00
William Banfield
c052181e32
consensus: add additional metrics for abci++ data ( #8480 )
...
This pull request adds an additional set of metrics targeted at providing more visibility into `abci++`.
The following set of metrics are added and exposed through the `metrics` endpoint:
```
tendermint_consensus_proposal_receive_count{chain_id="test-chain-IrF74Y",status="accepted"} 34
tendermint_consensus_proposal_create_count{chain_id="test-chain-IrF74Y"} 34
tendermint_consensus_vote_extension_receive_count{chain_id="test-chain-IrF74Y",status="accepted"} 34
tendermint_consensus_round_voting_power_percent{chain_id="test-chain-IrF74Y",vote_type="precommit"} 1
tendermint_consensus_round_voting_power_percent{chain_id="test-chain-IrF74Y",vote_type="prevote"} 1
tendermint_state_consensus_param_updates{chain_id="test-chain-IrF74Y"} 0
tendermint_state_validator_set_updates{chain_id="test-chain-IrF74Y"} 0
tendermint_consensus_late_votes{chain_id="test-chain-IrF74Y",vote_type="precommit"} 16
```
This pull request also updates the `metrics.md` file to include some metrics that were previously missed. My hope is to generate the `metrics.md` file with a future version of the tool being architected in #8479
2022-05-10 16:48:13 +00:00
