William Banfield
5e210ce5d8
remove assertion that finalize block being generated for psql indexer
2022-03-01 14:46:13 -05:00
William Banfield
1eac8534a0
change out event type for psql indexer
2022-03-01 14:46:13 -05:00
William Banfield
8a9f722caa
remove most references to endblock
2022-03-01 14:46:13 -05:00
William Banfield
8d79f3bf7c
remove most remaining references to BeginBlock
2022-03-01 14:46:13 -05:00
William Banfield
e7c0a18212
renmae deterministicDeliverTx
2022-03-01 14:46:13 -05:00
William Banfield
1b4daf7c5f
name begin/end_events
2022-03-01 14:46:13 -05:00
William Banfield
1fb789e7b7
remove needless nil variable
2022-03-01 14:46:13 -05:00
William Banfield
eca41af266
update comment
2022-03-01 14:46:13 -05:00
William Banfield
42a01cc966
reorder block fields for aesthetics
2022-03-01 14:46:13 -05:00
William Banfield
a97c1819c3
remove unhelpful comment
2022-03-01 14:46:13 -05:00
William Banfield
520ce222ab
light.go comment change
2022-03-01 14:46:13 -05:00
William Banfield
ecb13bb4fd
remove useless panic test
2022-03-01 14:46:13 -05:00
William Banfield
83fc8c4601
variable renames for finalize
2022-03-01 14:46:13 -05:00
William Banfield
21df89b60f
consensus: rename deliver tx helper
2022-03-01 14:46:13 -05:00
William Banfield
0cd4c3f2c8
abci: rename abci-cli command 'add_tx' from 'deliver_tx'
2022-03-01 14:46:13 -05:00
William Banfield
077b1d5617
remove no longer relevant begin block test
2022-03-01 14:46:13 -05:00
William Banfield
b44b7e468c
fix abci protobuf to contain vote
2022-03-01 14:46:13 -05:00
William Banfield
afbaa86a63
cleanup remaining struct problems
2022-03-01 14:46:13 -05:00
William Banfield
855cb51189
more delivertx changes
2022-03-01 14:46:13 -05:00
William Banfield
9474faf879
fix abci protobuf to contain ExecTxResult
2022-03-01 14:46:13 -05:00
William Banfield
a341046b28
update sites of DeliverTx
2022-03-01 14:46:11 -05:00
William Banfield
1aa5dda364
block events and tx fixups
2022-03-01 14:42:44 -05:00
William Banfield
e3ff082f21
rename Txs -> TxResults
2022-03-01 14:42:41 -05:00
William Banfield
984f52ff9d
build latest abci protos
2022-03-01 14:34:50 -05:00
Callum Waters
ea46a4e9d1
github: add Informal code owners ( #8042 )
2022-03-01 15:58:23 +01:00
Sam Kleinman
21087563eb
consensus: validator set changes test cleanup ( #8035 )
...
This is mostly an extremely small change where I double a somewhat
arbitrarly set timeout from 1m to 2m for an entire test. When I put
these timeouts in the test, they were arbitrary based on my local
performance (which is quite fact,) and I expected that they'd need to
be tweaked in the future.
A big chunk of this PR is reworking a collection of helper functions
that produce somewhat intractable messages when a test fails, so that
the error messages take up less vertical space, hopefully without
losing any debugability.
2022-03-01 13:42:00 +00:00
Sam Kleinman
a965f03c15
statesync: avoid compounding retry logic for fetching consensus parameters ( #8032 )
...
We're waiting between trying witnesses (which shouldn't be neccessary
because the witnesses shouldn't depend on each other,) and also
between *attempts*, and really the outer sleep should be enough.
2022-03-01 13:01:57 +00:00
Manuel Bravo
82a2ca4ba5
abci++ spec: remove new_hashes and discuss transaction traceability ( #8002 )
...
* remove new_hashes, discuss traceability
* Update spec/abci++/abci++_methods_002_draft.md
Co-authored-by: Sergio Mena <sergio@informal.systems >
* Update spec/abci++/abci++_methods_002_draft.md
Co-authored-by: Sergio Mena <sergio@informal.systems >
* Update spec/abci++/abci++_methods_002_draft.md
Co-authored-by: Sergio Mena <sergio@informal.systems >
* quote example traceability
* remove new_hashes from protobuf
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-03-01 12:41:09 +01:00
Sam Kleinman
58dc172611
p2p: plumb rudamentary service discovery to rectors and update statesync ( #8030 )
...
This is a little coarse, but the idea is that we'll send information
about the channels a peer has upon the peer-up event that we send to
reactors that we can then use to reject peers (if neeeded) from reactors.
This solves the problem where statesync would hang in test networks
(and presumably real) where we would attempt to statesync from seed
nodes, thereby hanging silently forever.
2022-02-28 20:02:54 +00:00
Sam Kleinman
9cb01168a6
Revert "build(deps): Bump golangci/golangci-lint-action from 2.5.2 to 3.1.0 ( #8026 )" ( #8034 )
...
This reverts commit e4dced2437
2022-02-28 14:45:53 -05:00
dependabot[bot]
e4dced2437
build(deps): Bump golangci/golangci-lint-action from 2.5.2 to 3.1.0 ( #8026 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 2.5.2 to 3.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint-action/releases ">golangci/golangci-lint-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.0</h2>
<h2>What's Changed</h2>
<h3>New features</h3>
<ul>
<li>Allow to disable caching completely by <a href="https://github.com/tdabasinskas "><code>@tdabasinskas</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/351 ">golangci/golangci-lint-action#351</a></li>
</ul>
<h3>CI</h3>
<ul>
<li>ci(dep): Add step to commit changes if PR has dependencies label by <a href="https://github.com/sayboras "><code>@sayboras</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/108 ">golangci/golangci-lint-action#108</a></li>
</ul>
<h3>Dependabot</h3>
<ul>
<li>build(deps-dev): bump eslint from 8.9.0 to 8.10.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/405 ">golangci/golangci-lint-action#405</a></li>
</ul>
<h3>Misc</h3>
<ul>
<li>Update version to 3.1.0 in package.json by <a href="https://github.com/SVilgelm "><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/406 ">golangci/golangci-lint-action#406</a></li>
<li>fix version in package-lock.json by <a href="https://github.com/SVilgelm "><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/407 ">golangci/golangci-lint-action#407</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/tdabasinskas "><code>@tdabasinskas</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/351 ">golangci/golangci-lint-action#351</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v3...v3.1.0 ">https://github.com/golangci/golangci-lint-action/compare/v3...v3.1.0 </a></p>
<h2>v3.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix grammar in action.yml by <a href="https://github.com/abennett "><code>@abennett</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/356 ">golangci/golangci-lint-action#356</a></li>
<li>Add description for permissions settings by <a href="https://github.com/sg0hsmt "><code>@sg0hsmt</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/298 ">golangci/golangci-lint-action#298</a></li>
<li>Remove Setup-Go by <a href="https://github.com/StevenACoffman "><code>@StevenACoffman</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/403 ">golangci/golangci-lint-action#403</a></li>
<li>Update all direct dependencies by <a href="https://github.com/SVilgelm "><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/404 ">golangci/golangci-lint-action#404</a></li>
<li>139 Dependabot updates</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/abennett "><code>@abennett</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/356 ">golangci/golangci-lint-action#356</a></li>
<li><a href="https://github.com/sg0hsmt "><code>@sg0hsmt</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/298 ">golangci/golangci-lint-action#298</a></li>
<li><a href="https://github.com/StevenACoffman "><code>@StevenACoffman</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/403 ">golangci/golangci-lint-action#403</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v2...v3.0.0 ">https://github.com/golangci/golangci-lint-action/compare/v2...v3.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b517f99ae2https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/407 ">#407</a>)</li>
<li><a href="9636c5bc97https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/406 ">#406</a>)</li>
<li><a href="03e4befc7ahttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/108 ">#108</a>)</li>
<li><a href="cdfc708aebhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/351 ">#351</a>)</li>
<li><a href="7d5614c3ebhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/405 ">#405</a>)</li>
<li><a href="c675eb70dbhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/404 ">#404</a>)</li>
<li><a href="423fbafafchttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/403 ">#403</a>)</li>
<li><a href="bcfc6f96bbhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/402 ">#402</a>)</li>
<li><a href="d34ac2aef3https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/401 ">#401</a>)</li>
<li><a href="e4b538ed37https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/400 ">#400</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint-action/compare/v2.5.2...v3.1.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-02-28 12:57:21 +00:00
M. J. Fromberger
8175b2b26d
docs: fix some broken markdown links ( #8021 )
...
Found by the link checker.
There are still some links that aren't fixed, because it's not clear where they _should_ point. I just hit the obvious ones.
2022-02-27 13:27:29 +00:00
dependabot[bot]
0fcfaa4568
build(deps): Bump url-parse from 1.5.7 to 1.5.10 in /docs ( #8023 )
...
Bumps [url-parse](https://github.com/unshiftio/url-parse ) from 1.5.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases )
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10 )
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-25 19:48:51 -08:00
dependabot[bot]
b488198d47
build(deps): Bump prismjs from 1.26.0 to 1.27.0 in /docs ( #8022 )
...
Bumps [prismjs](https://github.com/PrismJS/prism ) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/PrismJS/prism/releases )
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md )
- [Commits](https://github.com/PrismJS/prism/compare/v1.26.0...v1.27.0 )
---
updated-dependencies:
- dependency-name: prismjs
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-25 19:38:41 -08:00
M. J. Fromberger
b848c79971
Revert "Migration of TLA+ files from the spec repo ( #8004 )" ( #8016 )
...
This reverts commit e762dbb603
2022-02-25 16:37:31 -08:00
Sam Kleinman
f25b7ceeb2
consensus: make orchestration more reliable for invalid precommit test ( #8013 )
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-02-26 00:21:59 +00:00
Kukovec
e762dbb603
Migration of TLA+ files from the spec repo ( #8004 )
2022-02-25 16:09:27 -08:00
M. J. Fromberger
cd0472014a
Add command-line tool to manually subscribe to an event stream. ( #8015 )
...
This tool is an aid to debugging, and demonstrates the API of the eventstream
helper package. It subscribes to the event stream of a running node with the
ADR 075 event log enabled, and writes matching events to stdout as JSON.
2022-02-25 13:23:39 -08:00
M. J. Fromberger
ab32f5a9b6
rpc/client: add eventstream helper ( #7987 )
...
This allows the caller to stream events. It handles the bookkeeping for cursors
and pagination, and delivers items to a callback.
Handle missed items by reporting a structured error. The caller can use the
Reset method to "catch up" to head after this happens.
Add a manual test CLI to probe a running node. Requires the node to be
configured with the event log settings.
Add a unit test that scripts input to the stream to exercise it.
2022-02-25 12:37:01 -08:00
Sam Kleinman
a153f82433
p2p: ignore transport close error during cleanup ( #8011 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-02-25 14:48:41 -05:00
William Banfield
c80734e5af
state: synchronize the ProcessProposal implementation with the latest version of the spec ( #7961 )
...
This change implements the spec for `ProcessProposal`. It first calls the Tendermint block validation logic to check that all of the proposed block fields are well formed and do not violate any of the rules for Tendermint to consider the block valid and then passes the validated block the `ProcessProposal`.
This change also adds additional fixtures to test the change. It adds the `baseMock` types that holds a mock as well as a reference to `BaseApplication`. If the function was not setup by the test on the contained mock Application, the type delegates to the `BaseApplication` and returns what `BaseApplication` returns.
The change also switches the `makeState` helper to take an arg struct so that an ABCI application can be plumbed through when needed.
closes : #7656
2022-02-25 18:56:34 +00:00
Sam Kleinman
89dbebd1c5
p2p: retry failed connections slightly more aggressively ( #8010 )
...
* p2p: retry failed connections slightly more aggressively
* fix dial interval test
2022-02-25 18:05:29 +00:00
M. J. Fromberger
af60a9c385
Forward port v0.34.16 changelog to master. ( #8008 )
2022-02-25 17:04:37 +00:00
Sam Kleinman
c8ae5db50e
p2p: relax pong timeout ( #8007 )
2022-02-25 10:58:29 -05:00
JayT106
49e3688b79
fix syncAny test ( #8001 )
...
Co-authored-by: Sam Kleinman <garen@tychoish.com >
2022-02-25 10:33:28 -05:00
Sam Kleinman
c85e3e4ba8
p2p: mconn track last message for pongs ( #7995 )
...
* p2p: mconn track last message for pongs
* fix spell
* cr feedback
* test fix part one
* cleanup tests
* fix comment
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-02-25 15:15:13 +00:00
M. J. Fromberger
8c5e36159e
abci: use no-op loggers in the examples ( #7996 )
...
This averts a rare but annoying log-after-test race condition.
2022-02-25 14:41:49 +00:00
Sam Kleinman
858d57a984
abci/kvstore: test cleanup improvements ( #7991 )
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-02-25 03:12:27 +00:00
M. J. Fromberger
0875074ea2
Add upgrading notes for the new Events RPC interface. ( #7993 )
...
Add deprecation logs when websocket is enabled
As promised in ADR 075, this causes the node to log (without error) when
websocket transport is enabled, and also when subscribers connect.
2022-02-24 15:04:55 -08:00
Sam Kleinman
3e2d5db289
abci: remove lock protecting calls to the application interface ( #7984 )
...
Closes #7073
As part of the 0.36 cycle we've discussed and decided to remove the mutex in tendermint that protects the ABCI application. First, applications should be able to be responsible for their own concurrency control, and can make more fine-grained decisions about concurrent use than tendermint ever could. Second, I've observed in recent weeks as we've been making this change that the mutex wasn't applied particularly consistently in many cases (e.g. multiple "local" connections to the application had multiple locks, etc.) so this will give more consistent experiences across ABCI execution environments, and simplifies the tendermint ABCI handling code.
2022-02-24 19:53:04 +00:00
