6389f2ff0c
Embed CommitSig into ExtendedCommitSig instead of duplicating fields
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 12:30:42 -04:00
fe5220bca6
Remove JSON encoding from ExtendedCommit
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 11:19:16 -04:00
739e60e309
Fix comment grammar
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 10:40:07 -04:00
521734934d
There are no extended commits below the initial height
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 10:35:14 -04:00
e7e7da35a5
Remove ExtendedCommitSig.Absent helper
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 10:19:55 -04:00
a27365b09a
Remove ExtendedCommitSig.ForBlock helper
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 10:15:59 -04:00
08bf156462
Remove CommigSig.Absent helper
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 10:13:57 -04:00
accba4774d
Remove CommigSig.ForBlock helper
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 10:11:01 -04:00
630ec2591d
Remove debug log
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 09:59:45 -04:00
0dd7ce3aa4
Rename local var for clarity
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 09:44:06 -04:00
e43e72c70a
Fix TestMaxProposalBlockSize
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 09:44:06 -04:00
408cc4c5b5
Rename local var for clarity
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 09:44:05 -04:00
a20a485dbe
Propagate validator info to PrepareProposal
...
In order to propagate validator voting power through to PrepareProposal,
we need to load the validator set info from the height corresponding to
the extended commit that we're passing through to PrepareProposal as the
"LocalLastCommit".
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-07 09:44:05 -04:00
bce2c7c220
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-05-07 09:43:53 -04:00
694ab2c6d1
test/fuzz: replace outdated reference to go-fuzz in README ( #8477 )
2022-05-06 11:02:19 -07:00
97f2944db0
Reintegrate docs deployment into the main TM repo ( #8468 )
...
Per https://github.com/tendermint/docs/issues/20 , it is no longer necessary to
build the static documentation out of a separate repository.
This change:
- Adds an actions workflow to build and deploy the docs to GitHub Pages.
- Updates some build settings in a compatible manner.
This change does not affect the existing site deployment. To complete this
change, we will need to update the custom domain pointer and disable the
corresponding workflow in the tendermint/docs repository. Those changes can and
must be done after this is merged.
In the future should probably also move the build rule out of the Makefile and
into the workflow directly. That will also make it easier to manage caching of
build artifacts. For now, however, I've left it as-is, so that we do not break
the active workflow on tendermint/docs, which depends on it.
2022-05-06 07:35:35 -07:00
ef44460c41
Convert explicit zero comparison to a method. ( #8475 )
...
Fixes #8472 .
I didn't see any other obvious cases of us doing this (although we do return zeroes in other places alongside errors, which is fine).
2022-05-06 13:44:09 +00:00
ce40697ea6
build(deps): Bump github.com/vektra/mockery/v2 from 2.12.1 to 2.12.2 ( #8474 )
...
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery ) from 2.12.1 to 2.12.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vektra/mockery/releases ">github.com/vektra/mockery/v2's releases</a>.</em></p>
<blockquote>
<h2>v2.12.2</h2>
<h2>Changelog</h2>
<ul>
<li>ea4c438 Add deprecation notice to logs</li>
<li>735bc0c Add go-get deprecation note</li>
<li>bea853e Add missing mock</li>
<li>989253d Fix *unsafe.Pointer</li>
<li>9228ad4 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/457 ">#457</a> from LandonTClipp/readme_deprecation</li>
<li>1d92e73 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/460 ">#460</a> from grongor/fix-unsafe-pointer</li>
<li>2fcd83d Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/462 ">#462</a> from LandonTClipp/deprecation</li>
<li>9f67b8a More explicit deprecation for go-get</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/vektra/mockery/commit/1d92e7320b158ed06b285e8717f15504f9374e29 "><code>1d92e73</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/460 ">#460</a> from grongor/fix-unsafe-pointer</li>
<li><a href="https://github.com/vektra/mockery/commit/2fcd83d746b7b9bf5e58f842995ecc33faa8b657 "><code>2fcd83d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/462 ">#462</a> from LandonTClipp/deprecation</li>
<li><a href="https://github.com/vektra/mockery/commit/ea4c438a5358e48a3c4c13506882e77829005b88 "><code>ea4c438</code></a> Add deprecation notice to logs</li>
<li><a href="https://github.com/vektra/mockery/commit/989253d1a4672c73dd000c3bee8b9bed91fcb067 "><code>989253d</code></a> Fix *unsafe.Pointer</li>
<li><a href="https://github.com/vektra/mockery/commit/bea853e93dfb166e3749c00f2816f63f6d563028 "><code>bea853e</code></a> Add missing mock</li>
<li><a href="https://github.com/vektra/mockery/commit/9f67b8afdc0b24f2894b7002743d094c5751a6e8 "><code>9f67b8a</code></a> More explicit deprecation for go-get</li>
<li><a href="https://github.com/vektra/mockery/commit/9228ad4b4a7a0a2a8a1c4f515851380ebc987b70 "><code>9228ad4</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/457 ">#457</a> from LandonTClipp/readme_deprecation</li>
<li><a href="https://github.com/vektra/mockery/commit/735bc0c9f85aed76b132210e7b1ff0442041998f "><code>735bc0c</code></a> Add go-get deprecation note</li>
<li>See full diff in <a href="https://github.com/vektra/mockery/compare/v2.12.1...v2.12.2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-06 10:25:34 +00:00
e980e1468d
RFC-018: initial research of BLS signature aggregation ( #8358 )
...
This provides an initial document for understanding the landscape of implementing a BLS signature aggregation scheme into Tendermint.
2022-05-05 12:08:22 -04:00
6a69e88b48
store/state: Add TODO to move prefixes to common package
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-05 08:34:01 -04:00
c9deedf0eb
types: Improve legibility
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 18:14:54 -04:00
3377d6160b
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-05-04 17:59:20 -04:00
2ef2733723
types: Fix legibility nits
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 17:58:22 -04:00
d0102e6b7e
types: Assign TODO to Sergio
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 17:46:28 -04:00
0a31afe4c6
types: Convert ExtendedCommit.Copy to a deep clone
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 17:38:34 -04:00
386cdeff98
types: Shorten receiver names for ExtendedCommit
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 17:36:37 -04:00
59434d8513
types: Remove NewCommit constructor
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 17:33:31 -04:00
b5a94bba16
types: Remove NewExtendedCommit constructor
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 17:18:41 -04:00
a3b3415a3a
types: Reformat ExtendedCommitSig.BlockID
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 14:12:15 -04:00
dd4fee88ef
keymigrate: improve filtering for legacy transaction hashes ( #8466 )
...
This is a follow-up to #8352 . The check for legacy evidence keys is only based
on the prefix of the key. Hashes, which are unprefixed, could easily have this
form and be misdiagnosed.
Because the conversion for evidence checks the key structure, this should not
cause corruption. The probability that a hash is a syntactically valid evidence
key is negligible. The tool will report an error rather than storing bad data.
But this does mean that such transaction hashes could cause the migration to
stop and report an error before it is complete.
To ensure we convert all the data, refine the legacy key check to filter these
keys more precisely. Update the test cases to exercise this condition.
* Update upgrading instructions.
2022-05-04 11:08:26 -07:00
24d1e6da01
types: Minor format
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 14:07:39 -04:00
b9fe2d73d6
proto: Remove TODO on TxResult
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 14:05:50 -04:00
9fcab6000a
state: Rename LoadBlockExtCommit to LoadBlockExtendedCommit
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 14:05:01 -04:00
0e8fc8e0b0
evidence/pool_test: Inline slice construction
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 13:59:25 -04:00
1667ed25ea
consensus: Allocate TODO to Sergio
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 13:58:20 -04:00
fce052d710
consensus: Rename short-lived local variable
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 13:50:07 -04:00
86f942ac0f
blocksync: Return error without also logging it
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 13:46:22 -04:00
a8adf63287
blocksync: Expand on extended commit requirement in AddBlock description
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 13:45:08 -04:00
2febbb24d9
types: Improve legibility of switch statements
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 12:37:59 -04:00
dd5c23de7d
blocksync: Change pool AddBlock function signature to return errors
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 11:36:03 -04:00
4aed18a11e
types: Remove unused/commented-out code
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 11:34:49 -04:00
421a12bfce
make format
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 10:30:05 -04:00
1378900e86
blocksync: Just return error
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 10:29:54 -04:00
e3bfd4363d
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-05-04 09:35:04 -04:00
c8e336f2e9
docs: minor fixups to pbts overview ( #8454 )
2022-05-04 13:21:32 +00:00
a3277368c4
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-05-04 08:32:09 -04:00
51f87b6074
Apply suggestions from code review
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-05-04 08:31:27 -04:00
9a028b7d8a
build(deps): Bump github.com/creachadair/atomicfile from 0.2.5 to 0.2.6 ( #8460 )
...
Bumps [github.com/creachadair/atomicfile](https://github.com/creachadair/atomicfile ) from 0.2.5 to 0.2.6.
- [Release notes](https://github.com/creachadair/atomicfile/releases )
- [Commits](https://github.com/creachadair/atomicfile/compare/v0.2.5...v0.2.6 )
---
updated-dependencies:
- dependency-name: github.com/creachadair/atomicfile
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 07:51:33 -04:00
6396abd49f
Remove global state from store tests
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 17:26:18 -04:00
e503d746a8
Fix TestBlockFetchAtHeight
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 16:54:08 -04:00
Thane Thomson
elias-orijtech
M. J. Fromberger
dependabot[bot]
William Banfield