Sam Kleinman
691cb52528
statesync: avoid leaking a thread during tests ( #8085 )
...
* statesync: avoid leaking a thread during tests
* fix
2022-03-07 22:12:39 +00:00
Sam Kleinman
01266881b8
evidence: manage and initialize state objects more clearly in the pool ( #8080 )
2022-03-07 14:26:58 -05:00
M. J. Fromberger
2df5c85a8d
Fix govet errors for %w use in test errors. ( #8083 )
...
The %w syntax is a fmt.Errorf thing, not supported by the testing package.
2022-03-07 18:17:37 +00:00
dependabot[bot]
1f03287f52
build(deps): Bump golangci/golangci-lint-action from 2.5.2 to 3.1.0 ( #8074 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 2.5.2 to 3.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint-action/releases ">golangci/golangci-lint-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.0</h2>
<h2>What's Changed</h2>
<h3>New features</h3>
<ul>
<li>Allow to disable caching completely by <a href="https://github.com/tdabasinskas "><code>@tdabasinskas</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/351 ">golangci/golangci-lint-action#351</a></li>
</ul>
<h3>CI</h3>
<ul>
<li>ci(dep): Add step to commit changes if PR has dependencies label by <a href="https://github.com/sayboras "><code>@sayboras</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/108 ">golangci/golangci-lint-action#108</a></li>
</ul>
<h3>Dependabot</h3>
<ul>
<li>build(deps-dev): bump eslint from 8.9.0 to 8.10.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/405 ">golangci/golangci-lint-action#405</a></li>
</ul>
<h3>Misc</h3>
<ul>
<li>Update version to 3.1.0 in package.json by <a href="https://github.com/SVilgelm "><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/406 ">golangci/golangci-lint-action#406</a></li>
<li>fix version in package-lock.json by <a href="https://github.com/SVilgelm "><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/407 ">golangci/golangci-lint-action#407</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/tdabasinskas "><code>@tdabasinskas</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/351 ">golangci/golangci-lint-action#351</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v3...v3.1.0 ">https://github.com/golangci/golangci-lint-action/compare/v3...v3.1.0 </a></p>
<h2>v3.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix grammar in action.yml by <a href="https://github.com/abennett "><code>@abennett</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/356 ">golangci/golangci-lint-action#356</a></li>
<li>Add description for permissions settings by <a href="https://github.com/sg0hsmt "><code>@sg0hsmt</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/298 ">golangci/golangci-lint-action#298</a></li>
<li>Remove Setup-Go by <a href="https://github.com/StevenACoffman "><code>@StevenACoffman</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/403 ">golangci/golangci-lint-action#403</a></li>
<li>Update all direct dependencies by <a href="https://github.com/SVilgelm "><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/404 ">golangci/golangci-lint-action#404</a></li>
<li>139 Dependabot updates</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/abennett "><code>@abennett</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/356 ">golangci/golangci-lint-action#356</a></li>
<li><a href="https://github.com/sg0hsmt "><code>@sg0hsmt</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/298 ">golangci/golangci-lint-action#298</a></li>
<li><a href="https://github.com/StevenACoffman "><code>@StevenACoffman</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/403 ">golangci/golangci-lint-action#403</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v2...v3.0.0 ">https://github.com/golangci/golangci-lint-action/compare/v2...v3.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b517f99ae2https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/407 ">#407</a>)</li>
<li><a href="9636c5bc97https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/406 ">#406</a>)</li>
<li><a href="03e4befc7ahttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/108 ">#108</a>)</li>
<li><a href="cdfc708aebhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/351 ">#351</a>)</li>
<li><a href="7d5614c3ebhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/405 ">#405</a>)</li>
<li><a href="c675eb70dbhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/404 ">#404</a>)</li>
<li><a href="423fbafafchttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/403 ">#403</a>)</li>
<li><a href="bcfc6f96bbhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/402 ">#402</a>)</li>
<li><a href="d34ac2aef3https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/401 ">#401</a>)</li>
<li><a href="e4b538ed37https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/400 ">#400</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint-action/compare/v2.5.2...v3.1.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-03-07 16:24:18 +00:00
dependabot[bot]
e7955185b4
build(deps): Bump docker/login-action from 1.13.0 to 1.14.1 ( #8075 )
...
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1.13.0 to 1.14.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/login-action/releases ">docker/login-action's releases</a>.</em></p>
<blockquote>
<h2>v1.14.1</h2>
<ul>
<li>Revert to Node 12 as default runtime to fix issue for GHE users (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/160 ">#160</a>)</li>
</ul>
<h2>v1.14.0</h2>
<ul>
<li>Update to node 16 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/158 ">#158</a>)</li>
<li>Bump <code>@aws-sdk/client-ecr</code> from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/157 ">#157</a>)</li>
<li>Bump <code>@aws-sdk/client-ecr-public</code> from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/156 ">#156</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="dd4fa0671bhttps://github-redirect.dependabot.com/docker/login-action/issues/160 ">#160</a> from crazy-max/node12</li>
<li><a href="4e3538592ebb984efc56https://github-redirect.dependabot.com/docker/login-action/issues/156 ">#156</a> from docker/dependabot/npm_and_yarn/aws-sdk/client-ec...</li>
<li><a href="722888132b17780b56b739857b3b45https://github-redirect.dependabot.com/docker/login-action/issues/157 ">#157</a> from docker/dependabot/npm_and_yarn/aws-sdk/client-ec...</li>
<li><a href="5fcc7284229fb8721eb94e3c9375bbhttps://github-redirect.dependabot.com/docker/login-action/issues/158 ">#158</a> from crazy-max/node-16</li>
<li><a href="4b59a429dbhttps://github.com/docker/login-action/compare/v1.13.0...v1.14.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-03-07 14:27:08 +00:00
dependabot[bot]
854add04b0
build(deps): Bump actions/checkout from 2.4.0 to 3 ( #8076 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 2.4.0 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<ul>
<li>Update default runtime to node16</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md ">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v2.3.1</h2>
<ul>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/284 ">Fix default branch resolution for .wiki and when using SSH</a></li>
</ul>
<h2>v2.3.0</h2>
<ul>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/278 ">Fallback to the default branch</a></li>
</ul>
<h2>v2.2.0</h2>
<ul>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/258 ">Fetch all history for all tags and branches when fetch-depth=0</a></li>
</ul>
<h2>v2.1.1</h2>
<ul>
<li>Changes to support GHES (<a href="https://github-redirect.dependabot.com/actions/checkout/pull/236 ">here</a> and <a href="https://github-redirect.dependabot.com/actions/checkout/pull/248 ">here</a>)</li>
</ul>
<h2>v2.1.0</h2>
<ul>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/191 ">Group output</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/199 ">Changes to support GHES alpha release</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/184 ">Persist core.sshCommand for submodules</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/163 ">Add support ssh</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/179 ">Convert submodule SSH URL to HTTPS, when not using SSH</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/157 ">Add submodule support</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/144 ">Follow proxy settings</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/141 ">Fix ref for pr closed event when a pr is merged</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/128 ">Fix issue checking detached when git less than 2.22</a></li>
</ul>
<h2>v2.0.0</h2>
<ul>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/108 ">Do not pass cred on command line</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/107 ">Add input persist-credentials</a></li>
<li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/104 ">Fallback to REST API to download repo</a></li>
</ul>
<h2>v2 (beta)</h2>
<ul>
<li>Improved fetch performance
<ul>
<li>The default behavior now fetches only the SHA being checked-out</li>
</ul>
</li>
<li>Script authenticated git commands
<ul>
<li>Persists <code>with.token</code> in the local git config</li>
<li>Enables your scripts to run authenticated git commands</li>
<li>Post-job cleanup removes the token</li>
<li>Coming soon: Opt out by setting <code>with.persist-credentials</code> to <code>false</code></li>
</ul>
</li>
<li>Creates a local branch
<ul>
<li>No longer detached HEAD when checking out a branch</li>
<li>A local branch is created with the corresponding upstream branch set</li>
</ul>
</li>
<li>Improved layout</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="a12a3943b4https://github-redirect.dependabot.com/actions/checkout/issues/708 ">#708</a>)</li>
<li><a href="8f9e05e482https://github-redirect.dependabot.com/actions/checkout/issues/689 ">#689</a>)</li>
<li><a href="230611dbd0https://github-redirect.dependabot.com/actions/checkout/issues/623 ">#623</a>)</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/v2.4.0...v3 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-03-07 14:25:08 +00:00
Sam Kleinman
8df7b6103f
proxy: collapse triforcated abci.Client ( #8067 )
2022-03-06 18:25:50 -05:00
Sam Kleinman
f1659ce329
consensus: fix TestInvalidState race and reporting ( #8071 )
2022-03-06 12:29:05 -05:00
William Banfield
8d0bd1c0ff
update abci cli test output ( #8070 )
2022-03-04 17:54:21 -05:00
William Banfield
0b8a62c87b
abci: Synchronize FinalizeBlock with the updated specification ( #7983 )
...
This change set implements the most recent version of `FinalizeBlock`.
# What does this change actually contain?
* This change set is rather large but fear not! The majority of the files touched and changes are renaming `ResponseDeliverTx` to `ExecTxResult`. This should be a pretty inoffensive change since they're effectively the same type but with a different name.
* The `execBlockOnProxyApp` was totally removed since it served as just a wrapper around the logic that is now mostly encapsulated within `FinalizeBlock`
* The `updateState` helper function has been made a public method on `State`. It was being exposed as a shim through the testing infrastructure, so this seemed innocuous.
* Tests already existed to ensure that the application received the `ByzantineValidators` and the `ValidatorUpdates`, but one was fixed up to ensure that `LastCommitInfo` was being sent across.
* Tests were removed from the `psql` indexer that seemed to search for an event in the indexer that was not being created.
# Questions for reviewers
* We store this [ABCIResponses](5721a13ab1/proto/tendermint/state/types.pb.go (L37)5721a13ab1/rpc/coretypes/responses.go (L69)closes : #7658
2022-03-04 22:32:37 +00:00
William Banfield
9accc1a531
abci++ tooling: proto synchronization ( #8065 )
...
This PR implements a hack. It does effectively 2 things:
1. It checks in a set of protos, suffixed with `.intermediate` that allow the abci proto generation to proceed.
2. Adds a script / makefile to enable the generation.
The script is pretty simple. It copies over the 'intermediate' files over to be the `.proto` files for the `abci/types.proto` file and the `types/types.proto` files, generates all the protos, and then reverts all of the changes made to the `*.proto` files and the `*.pb.go` files, except for the single abci file.
If this is too ugly, I'm happy to tweak it, but my goal here is to have some working version of the protos that currently build the abci code so that we can coordinate changes to the code and not have them all sit in different branches that make breaking changes across each other.
The end goal is to have the `.intermediate` files disappear completely, since they should be moving towards containing everything that the `.proto` files contain.
2022-03-04 20:09:49 +00:00
Sam Kleinman
0167f0d527
node: nodes should fetch state on startup ( #8062 )
2022-03-04 12:23:57 -05:00
William Banfield
c8c248d733
docs: add an overview of the proposer-based timestamps algorithm ( #8058 )
...
This change adds an overview of the proposer-based timestamps algorithm. The goal of this documentation is to give a plain enough explanation of the algorithm so that application developers and validators can understand both the utility of the algorithm and understand how the new constrains may affect their network and topology.
I'm blanking on the scheme we decided on for docs linking, so if anyone could remind me what link format we decided on, I'll go clean that up ASAP.
Once this is merged, I intend to create a runbook for chains that see slower block-times or higher nil prevotes and link that runbook to this document to provide a higher-level overview.
closes : #8046
2022-03-03 22:25:06 +00:00
Sam Kleinman
9d98484845
node: excise node handle within rpc env ( #8063 )
2022-03-03 15:17:45 -05:00
M. J. Fromberger
63ff2f052d
Remove now-unused and deprecated Subscribe methods. ( #8064 )
...
Both pubsub and eventbus are internal packages now, and all the existing use
has been updated to use the SubscribeWithArgs methods instead.
2022-03-03 10:03:38 -08:00
Sergio Mena
7c4fe5b108
Vote extensions: new design ( #8031 )
...
* Changed the spec text to agreed VoteExtension solution
* Revert "Removed protobufs related to vote extensions"
This reverts commit 4566f1e302fromberger@interchain.io >
* Update spec/core/data_structures.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Fix dangling link in ABCI++ readme
* Addressed comments
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-03-02 22:12:01 +01:00
Sam Kleinman
a3881f0fb1
consensus: improve wal test cleanup ( #8059 )
...
I believe that this gets rid of our temp-file related test errors.
2022-03-02 18:35:39 +00:00
M. J. Fromberger
59eaa4dba0
Revert "Remove master from versions and copy it from the latest. ( #7980 )" ( #8053 )
...
This reverts commit f939f962b1
2022-03-02 08:50:35 -08:00
M. J. Fromberger
33e6f7af11
Forward-port changelog updates for v0.35.2 to master. ( #8054 )
2022-03-02 16:43:11 +00:00
M. J. Fromberger
af96ef2fe4
rpc: set a minimum long-polling interval for Events ( #8050 )
...
Since the goal of reading events at the head of the event log is to satisfy a
subscription style interface, there is no point in allowing head polling with
no wait interval. The pagination case already bypasses long polling, so the
extra option is unneessary.
Set a minimum default long-polling interval for the head case.
Add a test for minimum delay.
2022-03-02 08:12:18 -08:00
Thane Thomson
65065e6054
docs: update ADR template ( #7789 )
...
* Update ADR template
The reason for this proposed update to the ADR template is twofold:
1. There's currently no easy way to cross-reference between ADRs and
issues/PRs on GitHub. This may be easy to manage for those with
context while they're working on implementing an ADR, but after time
passes and for complex ADRs it gets more difficult for newcomers to
the codebase to track both the implementation status of the ADR or
its historical context and discussions.
2. We should not allow for "proposed" ADRs. An ADR is a **decision
record**, which implies acceptance, and not a proposal. RFCs provide
a mechanism to make proposals.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add example of one ADR superseding another
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Move "Proposed" ToC entries to "Accepted".
It's possible some of these should actually be "Implemented", but I did not try
to go through each one to distinguish.
* Revert "Move "Proposed" ToC entries to "Accepted"."
This reverts commit d8d2907e98connect@thanethomson.com >
* Fix Markdown formatting
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add "Deprecated" section to ADR TOC
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Expand ADR template to explicitly cater for rejected ADRs
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-03-02 10:25:30 -05:00
M. J. Fromberger
c42c6d06d2
Migration of TLA+ files from the spec repo ( #8004 ) ( #8018 )
...
Co-authored-by: Kukovec <jure.kukovec@gmail.com >
2022-03-02 09:08:39 -05:00
M. J. Fromberger
a22942504c
p2p: re-enable tests previously disabled ( #8049 )
2022-03-01 12:25:11 -08:00
Callum Waters
ea46a4e9d1
github: add Informal code owners ( #8042 )
2022-03-01 15:58:23 +01:00
Sam Kleinman
21087563eb
consensus: validator set changes test cleanup ( #8035 )
...
This is mostly an extremely small change where I double a somewhat
arbitrarly set timeout from 1m to 2m for an entire test. When I put
these timeouts in the test, they were arbitrary based on my local
performance (which is quite fact,) and I expected that they'd need to
be tweaked in the future.
A big chunk of this PR is reworking a collection of helper functions
that produce somewhat intractable messages when a test fails, so that
the error messages take up less vertical space, hopefully without
losing any debugability.
2022-03-01 13:42:00 +00:00
Sam Kleinman
a965f03c15
statesync: avoid compounding retry logic for fetching consensus parameters ( #8032 )
...
We're waiting between trying witnesses (which shouldn't be neccessary
because the witnesses shouldn't depend on each other,) and also
between *attempts*, and really the outer sleep should be enough.
2022-03-01 13:01:57 +00:00
Manuel Bravo
82a2ca4ba5
abci++ spec: remove new_hashes and discuss transaction traceability ( #8002 )
...
* remove new_hashes, discuss traceability
* Update spec/abci++/abci++_methods_002_draft.md
Co-authored-by: Sergio Mena <sergio@informal.systems >
* Update spec/abci++/abci++_methods_002_draft.md
Co-authored-by: Sergio Mena <sergio@informal.systems >
* Update spec/abci++/abci++_methods_002_draft.md
Co-authored-by: Sergio Mena <sergio@informal.systems >
* quote example traceability
* remove new_hashes from protobuf
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-03-01 12:41:09 +01:00
Sam Kleinman
58dc172611
p2p: plumb rudamentary service discovery to rectors and update statesync ( #8030 )
...
This is a little coarse, but the idea is that we'll send information
about the channels a peer has upon the peer-up event that we send to
reactors that we can then use to reject peers (if neeeded) from reactors.
This solves the problem where statesync would hang in test networks
(and presumably real) where we would attempt to statesync from seed
nodes, thereby hanging silently forever.
2022-02-28 20:02:54 +00:00
Sam Kleinman
9cb01168a6
Revert "build(deps): Bump golangci/golangci-lint-action from 2.5.2 to 3.1.0 ( #8026 )" ( #8034 )
...
This reverts commit e4dced2437
2022-02-28 14:45:53 -05:00
dependabot[bot]
e4dced2437
build(deps): Bump golangci/golangci-lint-action from 2.5.2 to 3.1.0 ( #8026 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 2.5.2 to 3.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint-action/releases ">golangci/golangci-lint-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.0</h2>
<h2>What's Changed</h2>
<h3>New features</h3>
<ul>
<li>Allow to disable caching completely by <a href="https://github.com/tdabasinskas "><code>@tdabasinskas</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/351 ">golangci/golangci-lint-action#351</a></li>
</ul>
<h3>CI</h3>
<ul>
<li>ci(dep): Add step to commit changes if PR has dependencies label by <a href="https://github.com/sayboras "><code>@sayboras</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/108 ">golangci/golangci-lint-action#108</a></li>
</ul>
<h3>Dependabot</h3>
<ul>
<li>build(deps-dev): bump eslint from 8.9.0 to 8.10.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/405 ">golangci/golangci-lint-action#405</a></li>
</ul>
<h3>Misc</h3>
<ul>
<li>Update version to 3.1.0 in package.json by <a href="https://github.com/SVilgelm "><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/406 ">golangci/golangci-lint-action#406</a></li>
<li>fix version in package-lock.json by <a href="https://github.com/SVilgelm "><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/407 ">golangci/golangci-lint-action#407</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/tdabasinskas "><code>@tdabasinskas</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/351 ">golangci/golangci-lint-action#351</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v3...v3.1.0 ">https://github.com/golangci/golangci-lint-action/compare/v3...v3.1.0 </a></p>
<h2>v3.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix grammar in action.yml by <a href="https://github.com/abennett "><code>@abennett</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/356 ">golangci/golangci-lint-action#356</a></li>
<li>Add description for permissions settings by <a href="https://github.com/sg0hsmt "><code>@sg0hsmt</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/298 ">golangci/golangci-lint-action#298</a></li>
<li>Remove Setup-Go by <a href="https://github.com/StevenACoffman "><code>@StevenACoffman</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/403 ">golangci/golangci-lint-action#403</a></li>
<li>Update all direct dependencies by <a href="https://github.com/SVilgelm "><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/404 ">golangci/golangci-lint-action#404</a></li>
<li>139 Dependabot updates</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/abennett "><code>@abennett</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/356 ">golangci/golangci-lint-action#356</a></li>
<li><a href="https://github.com/sg0hsmt "><code>@sg0hsmt</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/298 ">golangci/golangci-lint-action#298</a></li>
<li><a href="https://github.com/StevenACoffman "><code>@StevenACoffman</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/403 ">golangci/golangci-lint-action#403</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v2...v3.0.0 ">https://github.com/golangci/golangci-lint-action/compare/v2...v3.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b517f99ae2https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/407 ">#407</a>)</li>
<li><a href="9636c5bc97https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/406 ">#406</a>)</li>
<li><a href="03e4befc7ahttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/108 ">#108</a>)</li>
<li><a href="cdfc708aebhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/351 ">#351</a>)</li>
<li><a href="7d5614c3ebhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/405 ">#405</a>)</li>
<li><a href="c675eb70dbhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/404 ">#404</a>)</li>
<li><a href="423fbafafchttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/403 ">#403</a>)</li>
<li><a href="bcfc6f96bbhttps://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/402 ">#402</a>)</li>
<li><a href="d34ac2aef3https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/401 ">#401</a>)</li>
<li><a href="e4b538ed37https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/400 ">#400</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint-action/compare/v2.5.2...v3.1.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-02-28 12:57:21 +00:00
M. J. Fromberger
8175b2b26d
docs: fix some broken markdown links ( #8021 )
...
Found by the link checker.
There are still some links that aren't fixed, because it's not clear where they _should_ point. I just hit the obvious ones.
2022-02-27 13:27:29 +00:00
dependabot[bot]
0fcfaa4568
build(deps): Bump url-parse from 1.5.7 to 1.5.10 in /docs ( #8023 )
...
Bumps [url-parse](https://github.com/unshiftio/url-parse ) from 1.5.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases )
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10 )
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-25 19:48:51 -08:00
dependabot[bot]
b488198d47
build(deps): Bump prismjs from 1.26.0 to 1.27.0 in /docs ( #8022 )
...
Bumps [prismjs](https://github.com/PrismJS/prism ) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/PrismJS/prism/releases )
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md )
- [Commits](https://github.com/PrismJS/prism/compare/v1.26.0...v1.27.0 )
---
updated-dependencies:
- dependency-name: prismjs
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-25 19:38:41 -08:00
M. J. Fromberger
b848c79971
Revert "Migration of TLA+ files from the spec repo ( #8004 )" ( #8016 )
...
This reverts commit e762dbb603
2022-02-25 16:37:31 -08:00
Sam Kleinman
f25b7ceeb2
consensus: make orchestration more reliable for invalid precommit test ( #8013 )
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-02-26 00:21:59 +00:00
Kukovec
e762dbb603
Migration of TLA+ files from the spec repo ( #8004 )
2022-02-25 16:09:27 -08:00
M. J. Fromberger
cd0472014a
Add command-line tool to manually subscribe to an event stream. ( #8015 )
...
This tool is an aid to debugging, and demonstrates the API of the eventstream
helper package. It subscribes to the event stream of a running node with the
ADR 075 event log enabled, and writes matching events to stdout as JSON.
2022-02-25 13:23:39 -08:00
M. J. Fromberger
ab32f5a9b6
rpc/client: add eventstream helper ( #7987 )
...
This allows the caller to stream events. It handles the bookkeeping for cursors
and pagination, and delivers items to a callback.
Handle missed items by reporting a structured error. The caller can use the
Reset method to "catch up" to head after this happens.
Add a manual test CLI to probe a running node. Requires the node to be
configured with the event log settings.
Add a unit test that scripts input to the stream to exercise it.
2022-02-25 12:37:01 -08:00
Sam Kleinman
a153f82433
p2p: ignore transport close error during cleanup ( #8011 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-02-25 14:48:41 -05:00
William Banfield
c80734e5af
state: synchronize the ProcessProposal implementation with the latest version of the spec ( #7961 )
...
This change implements the spec for `ProcessProposal`. It first calls the Tendermint block validation logic to check that all of the proposed block fields are well formed and do not violate any of the rules for Tendermint to consider the block valid and then passes the validated block the `ProcessProposal`.
This change also adds additional fixtures to test the change. It adds the `baseMock` types that holds a mock as well as a reference to `BaseApplication`. If the function was not setup by the test on the contained mock Application, the type delegates to the `BaseApplication` and returns what `BaseApplication` returns.
The change also switches the `makeState` helper to take an arg struct so that an ABCI application can be plumbed through when needed.
closes : #7656
2022-02-25 18:56:34 +00:00
Sam Kleinman
89dbebd1c5
p2p: retry failed connections slightly more aggressively ( #8010 )
...
* p2p: retry failed connections slightly more aggressively
* fix dial interval test
2022-02-25 18:05:29 +00:00
M. J. Fromberger
af60a9c385
Forward port v0.34.16 changelog to master. ( #8008 )
2022-02-25 17:04:37 +00:00
Sam Kleinman
c8ae5db50e
p2p: relax pong timeout ( #8007 )
2022-02-25 10:58:29 -05:00
JayT106
49e3688b79
fix syncAny test ( #8001 )
...
Co-authored-by: Sam Kleinman <garen@tychoish.com >
2022-02-25 10:33:28 -05:00
Sam Kleinman
c85e3e4ba8
p2p: mconn track last message for pongs ( #7995 )
...
* p2p: mconn track last message for pongs
* fix spell
* cr feedback
* test fix part one
* cleanup tests
* fix comment
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-02-25 15:15:13 +00:00
M. J. Fromberger
8c5e36159e
abci: use no-op loggers in the examples ( #7996 )
...
This averts a rare but annoying log-after-test race condition.
2022-02-25 14:41:49 +00:00
Sam Kleinman
858d57a984
abci/kvstore: test cleanup improvements ( #7991 )
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-02-25 03:12:27 +00:00
M. J. Fromberger
0875074ea2
Add upgrading notes for the new Events RPC interface. ( #7993 )
...
Add deprecation logs when websocket is enabled
As promised in ADR 075, this causes the node to log (without error) when
websocket transport is enabled, and also when subscribers connect.
2022-02-24 15:04:55 -08:00
Sam Kleinman
3e2d5db289
abci: remove lock protecting calls to the application interface ( #7984 )
...
Closes #7073
As part of the 0.36 cycle we've discussed and decided to remove the mutex in tendermint that protects the ABCI application. First, applications should be able to be responsible for their own concurrency control, and can make more fine-grained decisions about concurrent use than tendermint ever could. Second, I've observed in recent weeks as we've been making this change that the mutex wasn't applied particularly consistently in many cases (e.g. multiple "local" connections to the application had multiple locks, etc.) so this will give more consistent experiences across ABCI execution environments, and simplifies the tendermint ABCI handling code.
2022-02-24 19:53:04 +00:00
M. J. Fromberger
f795d3f360
rpc/client: rewrite the WaitForOneEvent helper ( #7986 )
...
Update usage in tests.
2022-02-24 11:21:40 -08:00
