M. J. Fromberger
75dafaeacc
docs: remove unnecessary os.Exit calls at the end of main ( #7861 )
...
The main function defers some things that do not run in the "normal" exit case
because we call os.Exit(0) explicitly. Since falling off the end of main does
the same thing, and also permits defers to run, let's do that.
2022-02-18 06:11:30 -08:00
Sam Kleinman
6280f45460
clist: remove unused waitgroup from clist implementation ( #7843 )
2022-02-18 13:53:33 +00:00
Sam Kleinman
be83ec6664
p2p: pass start time to flowrate and cleanup constructors ( #7838 )
...
After poking around #7828 , I saw the oppertunity for this cleanup,
which I think is both reasonable on its own, and quite low impact, and
removes the math around process start time.
2022-02-18 13:30:19 +00:00
dependabot[bot]
cb26c5238a
build(deps): Bump github.com/golangci/golangci-lint from 1.44.0 to 1.44.2 ( #7854 )
...
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint ) from 1.44.0 to 1.44.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/releases ">github.com/golangci/golangci-lint's releases</a>.</em></p>
<blockquote>
<h2>v1.44.2</h2>
<h2>Changelog</h2>
<ul>
<li>cad735b2 build(deps): bump github.com/ultraware/whitespace from 0.0.4 to 0.0.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2580 ">#2580</a>)</li>
<li>eeda375f bump github.com/daixiang0/gci to HEAD (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2593 ">#2593</a>)</li>
<li>4f20929c gci: restore defaults for sections (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2589 ">#2589</a>)</li>
</ul>
<h2>v1.44.1</h2>
<h2>Changelog</h2>
<ul>
<li>bf442005 Revert "build(deps): bump github.com/sylvia7788/contextcheck from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2534 ">#2534</a>)" (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2538 ">#2538</a>)</li>
<li>39a76b86 build(deps): bump ajv from 6.12.2 to 6.12.6 in /.github/peril (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2564 ">#2564</a>)</li>
<li>9d047929 build(deps): bump github.com/breml/bidichk from 0.2.1 to 0.2.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2572 ">#2572</a>)</li>
<li>18c25f79 build(deps): bump github.com/breml/errchkjson from 0.2.1 to 0.2.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2559 ">#2559</a>)</li>
<li>af6159c8 build(deps): bump github.com/breml/errchkjson from 0.2.2 to 0.2.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2570 ">#2570</a>)</li>
<li>b221c97b build(deps): bump github.com/kulti/thelper from 0.5.0 to 0.5.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2535 ">#2535</a>)</li>
<li>015c8e5b build(deps): bump github.com/ldez/tagliatelle from 0.3.0 to 0.3.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2557 ">#2557</a>)</li>
<li>331073af build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2556 ">#2556</a>)</li>
<li>19e87134 build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2571 ">#2571</a>)</li>
<li>717b99c0 build(deps): bump github.com/shirou/gopsutil/v3 from 3.21.12 to 3.22.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2558 ">#2558</a>)</li>
<li>181c61f8 build(deps): bump github.com/sylvia7788/contextcheck from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2534 ">#2534</a>)</li>
<li>f7d2406d bump github.com/daixiang0/gci from 0.2.9 to 0.3.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2532 ">#2532</a>)</li>
<li>05e7d32e bump github.com/mgechev/revive from v1.1.3 to v1.1.4 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2576 ">#2576</a>)</li>
<li>8d3c6e12 bump varnamelen from v0.5.0 to v0.6.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2551 ">#2551</a>)</li>
<li>07f9b12e docs(decorder): fix <code>disable-init-func-first-check: false</code> elaboration (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2560 ">#2560</a>)</li>
<li>3d733a2a fix debug output (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2531 ">#2531</a>)</li>
<li>9a70e9a4 gci: fix configuration naming (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2578 ">#2578</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md ">github.com/golangci/golangci-lint's changelog</a>.</em></p>
<blockquote>
<h3>v1.44.2</h3>
<ol>
<li>updated linters:
<ul>
<li><code>gci</code>: bump to HEAD</li>
<li><code>gci</code>: restore defaults for sections</li>
<li><code>whitespace</code>: from 0.0.4 to 0.0.5</li>
</ul>
</li>
<li>documentation:
<ul>
<li>add link to configuration in the linters list</li>
</ul>
</li>
</ol>
<h3>v1.44.1</h3>
<ol>
<li>updated linters:
<ul>
<li><code>bidichk</code>: from 0.2.1 to 0.2.2</li>
<li><code>errchkjson</code>: from 0.2.1 to 0.2.3</li>
<li><code>thelper</code>: from 0.5.0 to 0.5.1</li>
<li><code>tagliatelle</code>: from 0.3.0 to 0.3.1</li>
<li><code>gopsutil</code>: from 3.21.12 to 3.22.1</li>
<li><code>gci</code>: from 0.2.9 to 0.3.0</li>
<li><code>revive</code>: from v1.1.3 to v1.1.4</li>
<li><code>varnamelen</code>: from v0.5.0 to v0.6.0</li>
</ul>
</li>
<li>documentation:
<ul>
<li>linters: improve configuration pages</li>
<li><code>decorder</code>: fix <code>disable-init-func-first-check: false</code> elaboration</li>
</ul>
</li>
<li>misc:
<ul>
<li>fix debug output</li>
</ul>
</li>
</ol>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d58dbde584 "><code>d58dbde</code></a> build(deps): bump url-parse from 1.5.1 to 1.5.7 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2590 ">#2590</a>)</li>
<li><a href="6cecd4fd39 "><code>6cecd4f</code></a> build(deps): bump gatsby-plugin-manifest from 4.6.0 to 4.7.0 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2586 ">#2586</a>)</li>
<li><a href="4274864670 "><code>4274864</code></a> build(deps): bump gatsby-remark-images from 6.6.0 to 6.7.0 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2582 ">#2582</a>)</li>
<li><a href="58b188980b "><code>58b1889</code></a> build(deps): bump gatsby-transformer-yaml from 4.6.0 to 4.7.0 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2583 ">#2583</a>)</li>
<li><a href="eeda375f8e "><code>eeda375</code></a> bump github.com/daixiang0/gci to HEAD (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2593 ">#2593</a>)</li>
<li><a href="4f20929c4b "><code>4f20929</code></a> gci: restore defaults for sections (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2589 ">#2589</a>)</li>
<li><a href="cad735b2ab "><code>cad735b</code></a> build(deps): bump github.com/ultraware/whitespace from 0.0.4 to 0.0.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2580 ">#2580</a>)</li>
<li><a href="d7e110ebbd "><code>d7e110e</code></a> docs: add link to configuration in the linters list (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2587 ">#2587</a>)</li>
<li><a href="949b059028 "><code>949b059</code></a> build(deps): bump gatsby-source-filesystem from 4.6.0 to 4.7.0 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2581 ">#2581</a>)</li>
<li><a href="ed93066d16 "><code>ed93066</code></a> docs: Update documentation and assets (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2579 ">#2579</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint/compare/v1.44.0...v1.44.2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-02-18 13:09:16 +00:00
dependabot[bot]
e439cf3ba2
build(deps): Bump url-parse from 1.5.4 to 1.5.7 in /docs ( #7855 )
2022-02-18 13:54:05 +01:00
M. J. Fromberger
f9e0f77af3
docs: Update spec links to point to tendermint/tendermint ( #7851 )
2022-02-18 04:40:32 -08:00
M. J. Fromberger
2183d90d05
docs: fix broken markdown links ( #7847 )
...
For most cases I was able to find a new target. In one case the branch was
deleted, so I removed the link.
2022-02-17 14:59:12 -08:00
Sam Kleinman
d187962ec0
blocksync: shutdown cleanup ( #7840 )
...
Now that shutdown is handled by contexts in most cases, I think it's
fair to cleanup the way this reactor shuts down. Additionaly there
were a few cases where the `blockSyncOutBridgeCh` was misshandled and
could have lead to a deadlock which I observed in some tests
2022-02-17 20:42:11 +00:00
M. J. Fromberger
9e69615451
consensus: start the timeout ticker before replay ( #7844 )
2022-02-17 12:18:19 -08:00
Sam Kleinman
f6569b5dcd
abci/client: remove waitgroup for requests ( #7842 )
...
* abci/client: remove awkward waitgroup
* elide done
2022-02-17 18:56:11 +00:00
M. J. Fromberger
f92289d5e8
RFC 012: Event Indexing Revisited ( #7784 )
...
The original Tendermint implementation provided a fixed, built-in event
indexer, but users would like to plug in different indexing backends. Although
ADR-065 was a good first step toward customization of indexing, its
implementation model does not satisfy all the user requirements. Moreover,
this approach leaves some existing technical issues with indexing unsolved.
This RFC documents these concerns, and discusses some potential approaches to
solving them. It does _not_ propose a specific technical decision. It is meant
to unify and focus some of the disparate discussions of the topic.
2022-02-17 09:30:02 -08:00
Sam Kleinman
28d34d635c
service: change stop interface ( #7816 )
2022-02-17 11:23:32 -05:00
M. J. Fromberger
38e29590ff
docs: rename RFC 008 ( #7841 )
...
While the name including an apostrophe is perfectly legal, it turns out to
confuse some tools that don't escape things properly. Rename to remove the
apostrophe rather than fight the world.
Fixes #7836 .
2022-02-17 16:07:14 +00:00
Sam Kleinman
c928818db9
abci/client: remove vestigially captured context ( #7839 )
2022-02-17 10:40:35 -05:00
Sam Kleinman
e0d44a650e
node: clarify unneccessary logic in seed constructor ( #7818 )
2022-02-17 08:56:55 -05:00
Sam Kleinman
d72939fe36
statesync: relax timing ( #7819 )
2022-02-17 08:23:27 -05:00
Sam Kleinman
cbb2c1d3bd
node: allow orderly shutdown if context is canceled and gensis is in the future ( #7817 )
2022-02-17 08:07:44 -05:00
Callum Waters
94b409e407
spec: merge spec repo into tendermint repo ( #7804 )
2022-02-17 13:51:18 +01:00
Callum Waters
c763f8ef59
Merge branch 'master' into callum/merge-spec
2022-02-17 13:05:13 +01:00
Callum Waters
e81b0e290e
spec: merge spec repo into tendermint repo ( #7804 )
2022-02-17 13:02:48 +01:00
M. J. Fromberger
cdc4c31e88
Fix broken links in ADR 071. ( #7834 )
2022-02-17 09:43:06 +01:00
dependabot[bot]
6638db2473
build(deps): Bump github.com/gorilla/websocket from 1.4.2 to 1.5.0 ( #7829 )
...
Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket ) from 1.4.2 to 1.5.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gorilla/websocket/releases ">github.com/gorilla/websocket's releases</a>.</em></p>
<blockquote>
<p>Minor new features and maintenance update</p>
<h2>CHANGELOG</h2>
<ul>
<li>Dialer: add optional method NetDialTLSContext (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/746 ">#746</a>) <a href="https://github.com/lluiscampos "><code>@lluiscampos</code></a></li>
<li>Update README (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/757 ">#757</a>) <a href="https://github.com/garyburd "><code>@garyburd</code></a></li>
<li>Remove support for Go 1.8 (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/755 ">#755</a>) <a href="https://github.com/garyburd "><code>@garyburd</code></a></li>
<li>Improve protocol error messages (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/754 ">#754</a>) <a href="https://github.com/garyburd "><code>@garyburd</code></a></li>
<li>Update autobahn example (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/753 ">#753</a>) <a href="https://github.com/garyburd "><code>@garyburd</code></a></li>
<li>Fix broadcast benchmarks (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/542 ">#542</a>) <a href="https://github.com/FZambia "><code>@FZambia</code></a></li>
<li>Use context.Context in TLS handshake (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/751 ">#751</a>) <a href="https://github.com/garyburd "><code>@garyburd</code></a></li>
<li>Modify http Method String Literal to Variable (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/728 ">#728</a>) <a href="https://github.com/thak1411 "><code>@thak1411</code></a></li>
<li>Update to match gofmt 1.17 (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/750 ">#750</a>) <a href="https://github.com/garyburd "><code>@garyburd</code></a></li>
<li>Document the allowed concurrency on Upgrader and Dialer (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/636 ">#636</a>) <a href="https://github.com/ghost "><code>@ghost</code></a></li>
<li>improve echo example (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/671 ">#671</a>) <a href="https://github.com/hellflame "><code>@hellflame</code></a></li>
<li>build: use build matrix; drop Go <= 1.10 (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/629 ">#629</a>) <a href="https://github.com/elithrar "><code>@elithrar</code></a></li>
<li>Fix Docs w.r.t. setting subprotocols (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/627 ">#627</a>) <a href="https://github.com/elithrar "><code>@elithrar</code></a></li>
<li>Fix how the client checks for presence of Upgrade: websocket, Connection: upgrade (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/604 ">#604</a>) <a href="https://github.com/bluetech "><code>@bluetech</code></a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="9111bb834a "><code>9111bb8</code></a> Dialer: add optional method NetDialTLSContext (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/746 ">#746</a>)</li>
<li><a href="2f25f7843d "><code>2f25f78</code></a> Update README (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/757 ">#757</a>)</li>
<li><a href="4fad403619 "><code>4fad403</code></a> Remove support for Go 1.8</li>
<li><a href="f0643a3a18 "><code>f0643a3</code></a> Improve protocol error messages</li>
<li><a href="2d6ee4c55c "><code>2d6ee4c</code></a> Update autobahn example</li>
<li><a href="beca1d3940 "><code>beca1d3</code></a> Fix broadcast benchmarks (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/542 ">#542</a>)</li>
<li><a href="bcef8431c9 "><code>bcef843</code></a> Use context.Context in TLS handshake (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/751 ">#751</a>)</li>
<li><a href="2c89656910 "><code>2c89656</code></a> Modify http Method String Literal to Variable (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/728 ">#728</a>)</li>
<li><a href="1905f7e442 "><code>1905f7e</code></a> Update source to match output from gofmt 1.17</li>
<li><a href="b4b5d887ad "><code>b4b5d88</code></a> Document the allowed concurrency on Upgrader and Dialer (<a href="https://github-redirect.dependabot.com/gorilla/websocket/issues/636 ">#636</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/gorilla/websocket/compare/v1.4.2...v1.5.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-02-16 18:40:44 +00:00
Marko
56ee72424f
remove libsecp256k1 build tag ( #7823 )
...
We no longer use cgo for anything in this package.
Consolidate the non-cgo code with the rest of the library.
2022-02-15 11:06:18 -08:00
Sergio Mena
60f09840dd
abci: PrepareProposal-VoteExtension integration [2nd try] ( #7821 )
...
* PrepareProposal-VoteExtension integration (#6915 )
* make proto-gen
* Fix protobuf crash in e2e nightly tests
* Update types/vote.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Addressed @creachadair's comments
Co-authored-by: mconcat <monoidconcat@gmail.com >
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-02-15 18:16:11 +01:00
M. J. Fromberger
44d9e9917c
pubsub: check for termination in UnsubscribeAll ( #7820 )
...
This check was correctly handled in Unsubscribe, but not UnsubscribeAll.
2022-02-14 15:34:35 -08:00
Sergio Mena
d3548eb706
Completed the existing FinalizeBlock PR and rebased to master ( #7798 )
...
* Rebased and git-squashed the commits in PR #6546
migrate abci to finalizeBlock
work on abci, proxy and mempool
abciresponse, blok events, indexer, some tests
fix some tests
fix errors
fix errors in abci
fix tests amd errors
* Fixes after rebasing PR#6546
* Restored height to RequestFinalizeBlock & other
* Fixed more UTs
* Fixed kvstore
* More UT fixes
* last TC fixed
* make format
* Update internal/consensus/mempool_test.go
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
* Addressed @williambanfield's comments
* Fixed UTs
* Addressed last comments from @williambanfield
* make format
Co-authored-by: marbar3778 <marbar3778@yahoo.com >
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
2022-02-14 23:41:28 +01:00
M. J. Fromberger
7e09c2ef43
Clean up temp files more thoroughly after testing. ( #7815 )
...
Our test cases spew a lot of files and directories around $TMPDIR. Make more
thorough use of the testing package's TempDir methods to ensure these are
cleaned up.
In a few cases, this required plumbing test contexts through existing helper
code. In a couple places an explicit path was required, to work around cases
where we do global setup during a TestMain function. Those cases probably
deserve more thorough cleansing (preferably with fire), but for now I have just
worked around it to keep focused on the cleanup.
2022-02-14 06:32:07 -08:00
Sam Kleinman
824960c565
libs/service: regularize Stop semantics and concurrency primitives ( #7809 )
2022-02-14 08:28:29 -05:00
M. J. Fromberger
73f605af3f
indexer: skip Docker tests when Docker is not available ( #7814 )
...
To simplify local testing, do not report failures for tests that require Docker
when Docker is not avaliable. Instead, log a warning and skip the tests.
This has no effect in CI, where Docker is installed.
2022-02-14 01:46:16 -08:00
Callum Waters
9b724f7a6c
github: update e2e workflows ( #7803 )
2022-02-14 10:03:04 +01:00
M. J. Fromberger
2f9355c579
docs: fix ToC file extension for RFC 004. ( #7813 )
2022-02-13 17:59:33 +00:00
JayT106
58d8bad99a
mempool: fix benchmark CheckTx for hitting the GetEvictableTxs call ( #7796 )
...
Based on the discussion in #7723 , make the CheckTx benchmark exercise
GetEvictableTxs which is one of the critical paths in CheckTx.
After profiling the test, the sorting will occupy 90% of the CPU time in CheckTx.
In the test it doesn't count the influence of the preCheck, postCheck, and
CheckTxAsync when the mempool is full.
2022-02-11 21:43:38 -08:00
M. J. Fromberger
ca6163a3ec
Silence a staticcheck warning. ( #7811 )
...
There was a nolint directive on this deprecated import, which golangci-lint
complains about being unnecessary. However, removing it angers staticcheck,
which enforces deprecation warnings.
Use the right syntax to make both equally unhappy.
2022-02-11 21:48:40 +00:00
M. J. Fromberger
01262b8ca9
rpc: remove unused latency metric ( #7810 )
...
We have this one solitary metric from the go-metrics package. In principle
this statistic could be useful, but the way we have it hooked up, nothing can
observe the value: We don't export it, we don't log it, and it does not auto
publish anywhere.
Given that this state of affairs has not changed since the metric was first
added in 2017 (c08618f ), I think we can safely discard it. No one is now or has
ever gotten any data out of this metric.
2022-02-11 13:19:56 -08:00
William Banfield
0dbd38d4d9
RFC: add delete gas rfc ( #7777 )
...
This RFC attempts to explore the requirements for deleting the notion of Gas from Tendermint while allowing applications that need such functionality to build it.
2022-02-11 20:24:08 +00:00
Sam Kleinman
dbb7d6ecdd
sync+p2p: remove closer ( #7805 )
2022-02-11 15:12:25 -05:00
Sam Kleinman
9e59fc6924
libs/cli: clean up package ( #7806 )
2022-02-11 11:30:16 -05:00
Sam Kleinman
662c0aac9e
libs/strings: cleanup string helper function package ( #7808 )
2022-02-11 10:59:55 -05:00
Sam Kleinman
1fe1b6c032
libs/events: remove unused event cache ( #7807 )
2022-02-11 09:48:37 -05:00
Callum Waters
7fb4e04b02
Merge branch 'master' of github.com:tendermint/spec into callum/merge-spec
2022-02-11 14:10:50 +01:00
M. J. Fromberger
4ba5a053de
rpc: allow GET parameters that support encoding.TextUnmarshaler ( #7800 )
...
Extend the decoding rules for URL query parameters so that if the target type
implements encoding.TextUnmarshaler, the decoder will use it.
This is a non-breaking change.
2022-02-10 18:32:18 -08:00
M. J. Fromberger
ef1cc5b516
docs: fix RPC output examples for GET queries ( #7799 )
...
Remove JSON-RPC wrappers from GET output, since they are no longer printed.
Also format examples with jq so they look a little neater.
Fixes #7779 .
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
2022-02-10 15:49:32 -08:00
Sam Kleinman
7885839b75
mempool: remove duplicate tx message from reactor logs ( #7795 )
2022-02-10 12:02:26 -05:00
Sam Kleinman
81dcc8d1b4
mempool+evidence: simplify cleanup ( #7794 )
2022-02-10 07:29:54 -05:00
Sam Kleinman
eed617c2d9
consensus: refactor operations in consensus queryMaj23Routine ( #7791 )
2022-02-09 14:47:50 -05:00
Sam Kleinman
c555226d2b
consensus: tie peer threads to peer lifecylce context ( #7792 )
2022-02-09 12:01:12 -05:00
William Banfield
860f78f000
add proposer address to the message delay metrics ( #7790 )
2022-02-09 10:52:14 -05:00
M. J. Fromberger
205bfca66f
types: add string format to 64-bit integer JSON fields ( #7787 )
...
This picks up a few remaining cases that I missed during my previous round of
adding these tags.
2022-02-09 13:34:23 +00:00
Anca Zamfir
27ccf3b590
Don't allow duplicates for light client providers ( #7781 )
...
* Allow for zero witness providers
* Verify provider duplicates, fix tests
* Add duplicate provider ID to the error
* Return error on attempt to remove last witness
* Verify duplicates when restoring from store
2022-02-08 22:09:10 +01:00
Sam Kleinman
fd50d90b70
light: remove legacy timeout scheme ( #7776 )
2022-02-08 12:26:24 -05:00