Marko and GitHub
85acd11097
upgrading.md additions ( #5049 )
...
## Description
- expand `upgrading.md`
- alphabetize the changelog
- update swagger with changes
Closes: #XXX
2020-06-26 08:40:41 +00:00
Alexander Bezobchuk and GitHub
e59378b45d
p2p: Remove data race bug in netaddr stringer ( #5048 )
...
## Description
Remove concurrent write access bug by removing the memoized string representation of a `NetAddress`.
Closes : #5047
2020-06-25 14:03:59 +00:00
Anton Kaliaev and GitHub
7a1ee66763
rpc: move docs from doc.go to swagger.yaml ( #5044 )
...
also,
- add an example for WS
- mention that a subscription could be terminated in /subscribe
Closes #5014
2020-06-25 05:53:18 +00:00
dependabot-preview[bot]
8830176567
build(deps): Bump github.com/prometheus/client_golang
...
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang ) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/prometheus/client_golang/releases )
- [Changelog](https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md )
- [Commits](https://github.com/prometheus/client_golang/compare/v1.7.0...v1.7.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-06-24 11:29:31 +00:00
Callum Waters and GitHub
3ecc0ffe7e
evidence: replace mock evidence with mocked duplicate vote evidence ( #5036 )
v0.34.0-dev1
2020-06-24 07:24:30 +02:00
dependabot-preview[bot]
a2284b8533
build(deps): Bump google.golang.org/grpc from 1.29.1 to 1.30.0
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.29.1 to 1.30.0.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.29.1...v1.30.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-06-23 16:44:54 +00:00
5412426ae8
indexer: remove index filtering ( #5006 )
...
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com >
2020-06-23 17:42:10 +02:00
65d7ce9c9c
evidence: improve amnesia evidence handling ( #5003 )
...
fix bug so that PotentialAmnesiaEvidence is being gossiped
handle inbound amnesia evidence correctly
add method to check if potential amnesia evidence is on trial
fix a bug with the height when we upgrade to amnesia evidence
change evidence to using just pointers.
More logging in the evidence module
Co-authored-by: Marko <marbar3778@yahoo.com >
2020-06-23 17:09:14 +02:00
Anton Kaliaev and GitHub
44b306b38e
types: reject blocks w/ ConflictingHeadersEvidence ( #5041 )
...
* types: reject blocks w/ ConflictingHeadersEvidence
Closes #5037
* types: reject blocks w/ PotentialAmnesiaEvidence
as well
PotentialAmnesiaEvidence does not contribute anything on its own,
therefore should not be committed on chain.
* fix lint issue
2020-06-23 16:55:16 +04:00
Anton Kaliaev and GitHub
ceac02b891
types: add AppVersion to ConsensusParams ( #5031 )
...
Co-authored-by: JamesRay <66258875@qq.com >
making it possible to change app version via EndBlock
2020-06-23 12:14:16 +04:00
Anton Kaliaev and GitHub
0b13059216
types: fix evidence timestamp calculation ( #5032 )
...
depending on the votes order in DuplicateVoteEvidence is arbitrary.
we should always choose the latest timestamp.
Closes #5030
2020-06-23 07:10:57 +00:00
Marko and GitHub
73e22a3c5a
abci: proto files follow same path ( #5039 )
...
## Description
have the defined abci proto types follow the same directory structure as in abci folder.
Closes: #XXX
2020-06-23 05:38:50 +00:00
Anton Kaliaev and GitHub
3c79251ffc
Update UPGRADING.md and bump p2p/block protocol versions ( #5038 )
...
Closes #4411
2020-06-22 12:27:43 +00:00
Marko and GitHub
dedf0d2350
proto: folder structure adhere to buf ( #5025 )
2020-06-22 10:00:51 +02:00
51da4fe356
types: rename partsheader to partsetheader ( #5029 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-22 09:38:03 +02:00
Marko and GitHub
dc87c09d93
cov: ignore autogen file ( #5033 )
...
## Description
ignore autogen file codecov
Closes: #XXX
2020-06-19 12:53:29 +00:00
Anton Kaliaev and GitHub
8b4a30fada
types: more test cases for TestValidatorSet_VerifyCommit ( #5018 )
...
Refs #4926
2020-06-19 10:09:41 +00:00
dependabot-preview[bot] and GitHub
65d4506fea
build(deps): Bump github.com/prometheus/client_golang from 1.6.0 to 1.7.0 ( #5027 )
...
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang ) from 1.6.0 to 1.7.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/prometheus/client_golang/releases ">github.com/prometheus/client_golang's releases</a>.</em></p>
<blockquote>
<h2>1.7.0 / 2020-06-17</h2>
<ul>
<li>[CHANGE] API client: Add start/end parameters to <code>LabelNames</code> and <code>LabelValues</code>. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/767 ">#767</a></li>
<li>[FEATURE] testutil: Add <code>GatherAndCount</code> and enable filtering in <code>CollectAndCount</code> <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/753 ">#753</a></li>
<li>[FEATURE] API client: Add support for <code>status</code> and <code>runtimeinfo</code> endpoints. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/755 ">#755</a></li>
<li>[ENHANCEMENT] Wrapping <code>nil</code> with a <code>WrapRegistererWith...</code> function creates a no-op <code>Registerer</code>. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/764 ">#764</a></li>
<li>[ENHANCEMENT] promlint: Allow Kelvin as a base unit for cases like color temperature. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/761 ">#761</a></li>
<li>[BUGFIX] push: Properly handle empty job and label values. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/752 ">#752</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md ">github.com/prometheus/client_golang's changelog</a>.</em></p>
<blockquote>
<h2>1.7.0 / 2020-06-17</h2>
<ul>
<li>[CHANGE] API client: Add start/end parameters to <code>LabelNames</code> and <code>LabelValues</code>. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/767 ">#767</a></li>
<li>[FEATURE] testutil: Add <code>GatherAndCount</code> and enable filtering in <code>CollectAndCount</code> <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/753 ">#753</a></li>
<li>[FEATURE] API client: Add support for <code>status</code> and <code>runtimeinfo</code> endpoints. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/755 ">#755</a></li>
<li>[ENHANCEMENT] Wrapping <code>nil</code> with a <code>WrapRegistererWith...</code> function creates a no-op <code>Registerer</code>. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/764 ">#764</a></li>
<li>[ENHANCEMENT] promlint: Allow Kelvin as a base unit for cases like color temperature. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/761 ">#761</a></li>
<li>[BUGFIX] push: Properly handle empty job and label values. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/752 ">#752</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/prometheus/client_golang/commit/b05e50c9298cbadd2b4be3f1527f5c1b178acb55 "><code>b05e50c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/769 ">#769</a> from prometheus/beorn7/release</li>
<li><a href="https://github.com/prometheus/client_golang/commit/cc5731c16cbea6ec23e3398f27ba14dc0ff7b709 "><code>cc5731c</code></a> Cut v1.7.0</li>
<li><a href="https://github.com/prometheus/client_golang/commit/3c8b15fa0d84373bf5e35c6a0f0626650c513b32 "><code>3c8b15f</code></a> Update dependencies</li>
<li><a href="https://github.com/prometheus/client_golang/commit/c304bb07a67e362c70d622b31bde26f57624916b "><code>c304bb0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/767 ">#767</a> from Nexucis/feature/labelNames-parameter</li>
<li><a href="https://github.com/prometheus/client_golang/commit/3defbd9c7c086d0b0d24b0e0f3db541cea084964 "><code>3defbd9</code></a> add start/end parameter for LabelValues</li>
<li><a href="https://github.com/prometheus/client_golang/commit/6ce5f2ca8ad23ffb3ed2389acc285bc04bdb0089 "><code>6ce5f2c</code></a> add start/end parameter for LabelNames</li>
<li><a href="https://github.com/prometheus/client_golang/commit/03575cad4e55adb37a5396afa7cc0eec43526740 "><code>03575ca</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/764 ">#764</a> from prometheus/wrap-nil</li>
<li><a href="https://github.com/prometheus/client_golang/commit/9c8ba1f9451a222e7918818ecff91bac5626dd48 "><code>9c8ba1f</code></a> Review feedback: add comment and tests for WrapRegistererWith.</li>
<li><a href="https://github.com/prometheus/client_golang/commit/614377c5501cb1666a3b057dd23c094d6d13ab24 "><code>614377c</code></a> Review feedback: use one line.</li>
<li><a href="https://github.com/prometheus/client_golang/commit/8961609f911516b04f81ac75fc4b0e0b8e455c2e "><code>8961609</code></a> Ensure that nil registers are treat as a no-op, even when wrapping.</li>
<li>Additional commits viewable in <a href="https://github.com/prometheus/client_golang/compare/v1.6.0...v1.7.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://dependabot.com/compatibility-score/?dependency-name=github.com/prometheus/client_golang&package-manager=go_modules&previous-version=1.6.0&new-version=1.7.0 )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
Dependabot will merge this PR once CI passes on it, as requested by @marbar3778.
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com ):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
</details>
2020-06-19 08:16:26 +00:00
Anton Kaliaev and GitHub
257a374b78
rpc: add /check_tx endpoint ( #5017 )
...
Closes #4549
2020-06-19 09:25:52 +04:00
Marko and GitHub
95d2d136cd
types: remove pubkey options ( #5016 )
...
## Description
This PR removes options in picking different pubkey types. We don't support anything other than ed25519 so this was redundant.
We only ever supported ed25519 keys so not sure why we exposed different options.
Not sure if this needs a changelog entry ?
Closes: #XXX
2020-06-17 09:35:00 +00:00
Marko and GitHub
8149bf517f
types: add tests for blockmeta ( #5013 )
...
## Description
add tests for to/from proto for blockmeta and add validate basic test case.
Closes: #XXX
2020-06-16 17:45:15 +00:00
Marko and GitHub
a12bfca93d
proto: move all proto dirs to /proto ( #5012 )
...
## Description
This PR moves all proto files under one dir (`/proto`). The script to generate adding functionality to copy the files that still need to be in the same place. (abci & rpc)
renames every proto package from `tendermint.proto.<pkg_name>` to `tendermint.<pkg_name>`
Removes unneeded types in privval proto directory
Closes: #XXX
2020-06-16 14:41:36 +00:00
Marko and GitHub
812dddc5ce
ci: fix spacing of if statement ( #5015 )
...
## Description
This pr fixes the spacing of the if statement. It was working but throwing warnings. this aims to resolve that
Closes: #XXX
2020-06-16 14:35:16 +00:00
062764ae72
ci: migrate test_cover ( #4869 )
...
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com >
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com >
2020-06-16 11:36:40 +02:00
4774a8ec61
non breaking signbytes ( #5008 )
...
* test-vectors for backwards compatibility:
- copy & paste test-vectors from v0.33.5 to ensure
backwards compatibility for vote's SignBytes
* WIP: everything besides time seems to match :-/
* almost
* Found the culprit: field nums weren't consecutive ints ...
* fix order of partset header too
* this last votes-related test can easily be fixed
* some minor changes and fix last failing test
* move proto types back to stdtime, fix various linting
* use libs/protoio
* remvoe commented code
* add comments
* fix tests
* uncomment testscases
* dont ignore error panic
* fix signable test
* fix happy path testing
* fix comment
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com >
2020-06-15 21:54:58 +02:00
Marko and GitHub
b8b50733f0
encoding: remove codecs ( #4996 )
...
## Description
This pr removes amino from tendermint.
Closes : #4278
2020-06-15 11:17:12 +00:00
Marko and GitHub
74cae49c3b
proto: leftover amino ( #4986 )
2020-06-15 11:14:36 +02:00
Marko and GitHub
a37480c396
tools: update gogoproto get cmd ( #5007 )
...
## Description
Update gogoproto tools cmd to download the correct version. I still need to update the docker container and test that they generate the same
Closes: #XXX
2020-06-14 19:41:25 +00:00
Anton Kaliaev and GitHub
206c814a8e
UPGRADING.md: write about the LastResultsHash change ( #5000 )
...
Refs #1007
2020-06-12 20:07:44 +04:00
Anton Kaliaev and GitHub
a8d8600308
[block#LastResultsHash] add Events + GasWanted/Used ( #4845 )
...
Closes #1007
2020-06-12 12:49:14 +04:00
Marko and GitHub
a39d4bc9b4
bring back binary:fixed64 ( #4997 )
...
## Description
Binary: fixed64 is used for ledger support in signing for validators. This can be useful for other hsms as well
Closes: #XXX
2020-06-11 17:44:57 +00:00
Marko and GitHub
bdac0818ac
p2p: proto leftover ( #4995 )
...
## Description
removing codec.go from p2p pkg and some leftover amino encoding
Closes: #XXX
2020-06-11 14:37:29 +00:00
Marko and GitHub
f6243d8b9e
privval: migrate to protobuf ( #4985 )
2020-06-11 11:54:02 +02:00
Marko and GitHub
31a361d119
proto: move keys to oneof ( #4983 )
2020-06-11 11:10:37 +02:00
Callum Waters and GitHub
18d333c392
docs: update amnesia adr ( #4994 )
2020-06-10 20:17:32 +02:00
Marko and GitHub
a057da6ab5
toml: make sections standout ( #4993 )
...
## Description
make sections in the toml standout.
Making this PR as I found it hard to find different sections on the `config.toml` when it was generated. This makes it somewhat simpler
Closes: #XXX
2020-06-10 17:49:27 +00:00
Callum Waters and GitHub
b1dba352b0
light: added more tests for pruning, initialization and bisection ( #4978 )
2020-06-10 18:56:24 +02:00
Marko and GitHub
46f6d17601
crypto/merkle: remove simple prefix ( #4989 )
...
## Description
This PR removes simple prefix from all types in the crypto/merkle directory.
The two proto types `Proof` & `ProofOp` have been moved to the `proto/crypto/merkle` directory.
proto messge `Proof` was renamed to `ProofOps` and `SimpleProof` message to `Proof`.
Closes : #2755
2020-06-10 14:57:38 +00:00
Marko and GitHub
d54de61bf6
consensus: proto migration ( #4984 )
...
## Description
migrate consensus to protobuf
Closes: #XXX
2020-06-10 12:08:47 +00:00
Callum Waters and GitHub
5697e144a7
evidence: adr56 form amnesia evidence ( #4821 )
...
Creates Amnesia Evidence which is formed from Potential Amnesia Evidence with either a matching proof or after a period of time denoted as the Amnesia Trial Period. This also adds the code necessary so that Amnesia Evidence can be validated and committed on a block
2020-06-10 13:53:55 +02:00
65909a13d5
consensus: stricter on LastCommitRound check ( #4970 )
...
LastCommitRound should always be >= 0 for heights > 1.
In State.updateToState, last precommit is computed only when round
greater than -1 and has votes. But "LastCommit" is always updated
regardless of the condition. If there's no last precommit, "LastCommit"
is set to (*types.VoteSet)(nil). That's why "LastCommit" can be -1 for
heights > 1.
To fix it, only update State.RoundState.LastCommit when there is last
precommit.
Fixes #2737
Co-authored-by: Cuong Manh Le <cuong.manhle.vn@gmail.com >
2020-06-10 11:13:38 +04:00
Erik Grinaker and GitHub
660e72a12f
p2p/conn: migrate to Protobuf ( #4990 )
...
Migrates the p2p connections to Protobuf. Supersedes #4800 .
gogoproto's `NewDelimitedReader()` uses an internal buffer, which makes it unsuitable for reading individual messages from a shared reader (since any remaining data in the buffer will be discarded). We therefore add a new `protoio` package with an unbuffered `NewDelimitedReader()`. Additionally, the `NewDelimitedWriter()` returns the number of bytes written, and we've added `MarshalDelimited()` and `UnmarshalDelimited()`, to ease migration of existing code.
2020-06-09 16:09:51 +00:00
Stevan Ognjanovic and GitHub
89665e7d67
types: Remove duplicated validation in VerifyCommit ( #4991 )
2020-06-09 17:15:32 +02:00
Marko and GitHub
6961c7e5d1
crypto: removal of multisig ( #4988 )
...
## Description
deprecation & removal of multisig. This key was only used in the sdk and now it has been added there
Closes : #4715
Closes : #2163
2020-06-09 08:13:49 +00:00
Marko and GitHub
99985278d4
evidence: migrate reactor to proto ( #4949 )
...
## Description
migration of evidence reactor to proto
Closes: #XXX
2020-06-09 07:54:47 +00:00
Anton Kaliaev and GitHub
6ec58f1560
rpc: support EXISTS operator in /tx_search query ( #4979 )
...
Closes #4763
* check for Error after for loop ends
so we don't silently ignore errors, which would lead to clients getting
incomplete results
Refs https://github.com/tendermint/tendermint/pull/4979/files#r436511572
2020-06-09 09:30:05 +04:00
Marko and GitHub
a89f2581fc
blockchain: proto migration ( #4969 )
...
## Description
migration of blockchain reactors to protobuf
Closes: #XXX
2020-06-08 12:45:03 +00:00
Erik Grinaker and GitHub
db8f1b3df3
migrate all JSON to new JSON encoder ( #4975 )
...
Uses new JSON encoder in #4955 for all JSON. Branched off of #4968 .
2020-06-08 12:22:59 +00:00
Erik Grinaker and GitHub
ba3a2dde37
rpc: replace Amino with new JSON encoder ( #4968 )
...
Migrates the `rpc` package to use new JSON encoder in #4955 . Branched off of that PR.
Tests pass, but I haven't done any manual testing beyond that. This should be handled as part of broader 0.34 testing.
2020-06-08 12:04:05 +00:00
Erik Grinaker and GitHub
ccc990498d
json: add Amino-compatible encoder/decoder ( #4955 )
...
Amino-compatible JSON encoder/decoder, including bug compatibility. Interface types must be registered via `json.RegisterType()`. Unlike Amino, this allows floats to be encoded/decoded.
Partial fix for #4828 , needs code migration.
2020-06-08 11:42:35 +00:00