Thane Thomson
86f942ac0f
blocksync: Return error without also logging it
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 13:46:22 -04:00
Thane Thomson
a8adf63287
blocksync: Expand on extended commit requirement in AddBlock description
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 13:45:08 -04:00
Thane Thomson
2febbb24d9
types: Improve legibility of switch statements
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 12:37:59 -04:00
Thane Thomson
dd5c23de7d
blocksync: Change pool AddBlock function signature to return errors
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 11:36:03 -04:00
Thane Thomson
4aed18a11e
types: Remove unused/commented-out code
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 11:34:49 -04:00
Thane Thomson
421a12bfce
make format
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 10:30:05 -04:00
Thane Thomson
1378900e86
blocksync: Just return error
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-04 10:29:54 -04:00
Thane Thomson
e3bfd4363d
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-05-04 09:35:04 -04:00
William Banfield
c8e336f2e9
docs: minor fixups to pbts overview ( #8454 )
2022-05-04 13:21:32 +00:00
Thane Thomson
a3277368c4
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-05-04 08:32:09 -04:00
Thane Thomson
51f87b6074
Apply suggestions from code review
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-05-04 08:31:27 -04:00
dependabot[bot]
9a028b7d8a
build(deps): Bump github.com/creachadair/atomicfile from 0.2.5 to 0.2.6 ( #8460 )
...
Bumps [github.com/creachadair/atomicfile](https://github.com/creachadair/atomicfile ) from 0.2.5 to 0.2.6.
- [Release notes](https://github.com/creachadair/atomicfile/releases )
- [Commits](https://github.com/creachadair/atomicfile/compare/v0.2.5...v0.2.6 )
---
updated-dependencies:
- dependency-name: github.com/creachadair/atomicfile
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 07:51:33 -04:00
Thane Thomson
6396abd49f
Remove global state from store tests
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 17:26:18 -04:00
Thane Thomson
e503d746a8
Fix TestBlockFetchAtHeight
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 16:54:08 -04:00
Thane Thomson
ce70167add
Fix store prefix collision
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 11:52:48 -04:00
Thane Thomson
656d2d01be
Fix most tests except TestHandshake*
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 10:59:37 -04:00
Thane Thomson
056aa98570
Add helper methods to ExtendedCommitSig and ExtendedCommit
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 10:51:20 -04:00
Thane Thomson
5c81f7a568
Make panic output from BlockStore.SaveBlock more readable
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 10:50:39 -04:00
Thane Thomson
b3f3c32381
Fix comment
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 07:39:15 -04:00
Thane Thomson
583d5fc3ce
make mockery
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-05-03 07:39:15 -04:00
Thane Thomson
61d5837ba2
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-05-03 07:38:53 -04:00
Sam Kleinman
37287ead94
p2p: remove message type from channel implementation ( #8452 )
2022-05-02 10:52:57 -04:00
Thane Thomson
4037fcd19a
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-05-02 07:59:57 -04:00
dependabot[bot]
6c40ad39b2
build(deps): Bump docker/setup-buildx-action from 1.6.0 to 1.7.0 ( #8451 )
...
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action ) from 1.6.0 to 1.7.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/setup-buildx-action/releases ">docker/setup-buildx-action's releases</a>.</em></p>
<blockquote>
<h2>v1.7.0</h2>
<ul>
<li>Standalone mode by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> in (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/119 ">#119</a>)</li>
<li>Update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/114 ">#114</a> <a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/130 ">#130</a>)</li>
<li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/108 ">#108</a>)</li>
<li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/109 ">#109</a>)</li>
<li>Bump <code>@actions/core</code> from 1.5.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/110 ">#110</a>)</li>
<li>Bump actions/checkout from 2 to 3 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/126 ">#126</a>)</li>
<li>Bump <code>@actions/tool-cache</code> from 1.7.1 to 1.7.2 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/128 ">#128</a>)</li>
<li>Bump <code>@actions/exec</code> from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/129 ">#129</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/132 ">#132</a>)</li>
<li>Bump codecov/codecov-action from 2 to 3 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/133 ">#133</a>)</li>
<li>Bump semver from 7.3.5 to 7.3.7 (<a href="https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/136 ">#136</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="f211e3e9dehttps://github-redirect.dependabot.com/docker/setup-buildx-action/issues/136 ">#136</a> from docker/dependabot/npm_and_yarn/semver-7.3.7</li>
<li><a href="b23216e504be7e600e207117987c01https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/119 ">#119</a> from crazy-max/standalone</li>
<li><a href="17ebdd4d653472856dd974283cacedhttps://github-redirect.dependabot.com/docker/setup-buildx-action/issues/133 ">#133</a> from docker/dependabot/github_actions/codecov/codecov...</li>
<li><a href="5b77ad49e82a6fbda6d8https://github-redirect.dependabot.com/docker/setup-buildx-action/issues/132 ">#132</a> from docker/dependabot/npm_and_yarn/minimist-1.2.6</li>
<li><a href="03815bdb06https://github.com/docker/setup-buildx-action/compare/v1.6.0...v1.7.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-02 11:52:11 +00:00
Daniel
a49325e4e0
PBTS: system model made more precise ( #8096 )
...
* PBTS model: precision, accuracy, and delay defs
* PBTS model: consensus properties reviewed
* PBTS model: reinforcing alignment with UTC
* PBTS model: precision parameter embodies accuracy
* PBTS model: discussion about accuracy shortened
* PBTS model: proposal time monotonocity rephrased
* PBTS model: precision, accuracy, and delay defs
* PBTS model: consensus properties reviewed
* PBTS model: reinforcing alignment with UTC
* PBTS model: precision parameter embodies accuracy
* PBTS model: discussion about accuracy shortened
* PBTS model: proposal time monotonocity rephrased
* PBTS model: Safety Invariants subsection
* PBTS model: MSGDELAY description shortened
* PBTS model: timely proposals definition refined
* PBTS model: some formatting changes
* PBTS model: timely predicate definition
* PBTS model: timely proof-of-lock re-defined
* PBTS model: derived proof-of-lock requirements
* The property needs to be properly demonstrated.
* Apply suggestions from William
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
* PBTS model: reference to arXiv algorithm on timely
* PBTS model: typos fixed
* PBTS model: derived POL "demonstration"
* PBTS model: fix formatting, r' renamed to vr
* PBTS model: minor fixes
* PBTS model: derived POL proof ammended
* PBTS safety: consensus validity with time inequalty
* PBTS: renamed receiveTime to proposalReceptionTime
* PBTS safety: short intro, some links
* PBTS model: safety refactored again
* PBTS model: liveness condition stated
* PBTS liveness: minor change
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_002_draft.md
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
* PBTS sysmodel: formmatting typo fixed
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com >
2022-05-02 10:22:03 +02:00
Thane Thomson
91d076a6cc
Merge changes from master and resolve conflicts
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-30 14:37:13 -04:00
Thane Thomson
e7451a43e7
blocksync: Honor contexts supplied to BlockPool ( #8447 )
...
* Lift condition into for loop
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Honor contexts in BlockPool
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only stop timers when necessary
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Optimize timers
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Simplify request interval definition
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove extraneous timer stop
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Convert switch into if
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Eliminate timers
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-30 14:34:59 -04:00
Thane Thomson
fba6848f6c
Isolate TODO more clearly
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-29 17:51:01 -04:00
Thane Thomson
dc6a208f1d
Expand on comment for PeekTwoBlocks for posterity
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-29 17:49:35 -04:00
Sam Kleinman
cf2a00b398
p2p: avoid using p2p.Channel internals ( #8444 )
2022-04-29 17:21:36 -04:00
Thane Thomson
c5db2e9bc4
Enforce vote extension signature requirement
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-29 14:43:49 -04:00
Thane Thomson
82dd779e93
Lift termination condition into for loop
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-29 14:43:49 -04:00
Thane Thomson
adfdfca227
Add note to remove TxResult proto
...
As Sergio pointed out in 3e31aa6f583cdc71e208ed03a82f1d804ec0de49, this
proto message can probably be removed. We should do this in a separate
PR.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-29 14:43:48 -04:00
Thane Thomson
bb4a1c7645
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-04-29 14:43:42 -04:00
Sam Kleinman
89196596f7
privval/grpc: normalize signature ( #8441 )
2022-04-29 10:56:10 -04:00
Sam Kleinman
eee19e42db
consensus: reduce size of validator set changes test ( #8442 )
2022-04-29 10:29:26 -04:00
Thane Thomson
49a6b2f88f
Merge branch 'master' into thane/8272-propagate-vote-extensions
2022-04-29 08:08:14 -04:00
dependabot[bot]
97b39770e0
build(deps): Bump github.com/btcsuite/btcd from 0.22.0-beta to 0.22.1 ( #8439 )
...
Bumps [github.com/btcsuite/btcd](https://github.com/btcsuite/btcd ) from 0.22.0-beta to 0.22.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/btcsuite/btcd/blob/v0.22.1/CHANGES ">github.com/btcsuite/btcd's changelog</a>.</em></p>
<blockquote>
<h1>============================================================================
User visible changes for btcd
A full-node bitcoin implementation written in Go</h1>
<p>Changes in 0.22.1 (Wed Apr 27 2022)</p>
<ul>
<li>Notable developer-related package changes:
<ul>
<li>Update to use chaincfg/chainhash module and remove conflicting
package</li>
</ul>
</li>
<li>Contributors (alphabetical order):
<ul>
<li>Dave Collins</li>
</ul>
</li>
</ul>
<p>Changes in 0.22.0 (Tue Jun 01 2021)</p>
<ul>
<li>Protocol and network-related changes:
<ul>
<li>Add support for witness tx and block in notfound msg (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1625 ">#1625</a>)</li>
<li>Add support for receiving sendaddrv2 messages from a peer (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1670 ">#1670</a>)</li>
<li>Fix bug in peer package causing last block height to go backwards
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1606 ">#1606</a>)</li>
<li>Add chain parameters for connecting to the public Signet network
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1692 ">#1692</a>, <a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1718 ">#1718</a>)</li>
</ul>
</li>
<li>Crypto changes:
<ul>
<li>Fix bug causing panic due to bad R and S signature components in
btcec.RecoverCompact (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1691 ">#1691</a>)</li>
<li>Set the name (secp256k1) in the CurveParams of the S256 curve
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1565 ">#1565</a>)</li>
</ul>
</li>
<li>Notable developer-related package changes:
<ul>
<li>Remove unknown block version warning in the blockchain package,
due to false positives triggered by AsicBoost (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1463 ">#1463</a>)</li>
<li>Add chaincfg.RegisterHDKeyID function to populate HD key ID pairs
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1617 ">#1617</a>)</li>
<li>Add new method mining.AddWitnessCommitment to add the witness
commitment as an OP_RETURN output within the coinbase transaction.
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1716 ">#1716</a>)</li>
</ul>
</li>
<li>RPC changes:
<ul>
<li>Support Batch JSON-RPC in rpcclient and server (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1583 ">#1583</a>)</li>
<li>Add rpcclient method to invoke getdescriptorinfo JSON-RPC command
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1578 ">#1578</a>)</li>
<li>Update the rpcserver handler for validateaddress JSON-RPC command to
have parity with the bitcoind 0.20.0 interface (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1613 ">#1613</a>)</li>
<li>Add rpcclient method to invoke getblockfilter JSON-RPC command
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1579 ">#1579</a>)</li>
<li>Add signmessagewithprivkey JSON-RPC command in rpcserver (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1585 ">#1585</a>)</li>
<li>Add rpcclient method to invoke importmulti JSON-RPC command (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1579 ">#1579</a>)</li>
<li>Add watchOnly argument in rpcclient method to invoke
listtransactions JSON-RPC command (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1628 ">#1628</a>)</li>
<li>Update btcjson.ListTransactionsResult for compatibility with Bitcoin
Core 0.20.0 (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1626 ">#1626</a>)</li>
<li>Support nullable optional JSON-RPC parameters (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1594 ">#1594</a>)</li>
<li>Add rpcclient and server method to invoke getnodeaddresses JSON-RPC</li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="2f508b3f86ff92d88504cf5c461d91https://github.com/btcsuite/btcd/compare/v0.22.0-beta...v0.22.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-29 11:21:56 +00:00
dependabot[bot]
297fcc0a7c
build(deps): Bump github.com/creachadair/tomledit from 0.0.18 to 0.0.19 ( #8440 )
...
Bumps [github.com/creachadair/tomledit](https://github.com/creachadair/tomledit ) from 0.0.18 to 0.0.19.
<details>
<summary>Commits</summary>
<ul>
<li><a href="0692e4157ad1160a474b56f28f4ea03b8b380274409951b699f35c8bec5c26acca1df83394f599e45ce10cc05a29f3eb34c8https://github.com/creachadair/tomledit/compare/v0.0.18...v0.0.19 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-29 10:59:15 +00:00
Sam Kleinman
3d448e1ef8
crypto: cleanup tmhash package ( #8434 )
2022-04-28 22:21:43 -04:00
M. J. Fromberger
6faf506540
rpc: fix byte string decoding for URL parameters ( #8431 )
...
In #8397 I tried to remove all the cases where we needed to keep track of the
target type of parameters for JSON encoding, but there is one case still left:
When decoding parameters from URL query terms, there is no way to tell whether
or not we need base64 encoding without knowing whether the underlying type of
the target is string or []byte.
To fix this, keep track of parameters that are []byte valued when RPCFunc is
compiling its argument map, and use that when parsing URL query terms. Update
the tests accordingly.
2022-04-28 15:18:11 -07:00
Sergio Mena
9cd356db8d
Fix exit condition in blocksync
2022-04-28 17:54:52 -04:00
Thane Thomson
23d4d6f914
Reshuffle ExtendedCommit and ExtendedCommitSig
...
Separate the data structures and functions from their Commit-oriented
counterparts to adhere to the current coding style.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-28 17:45:01 -04:00
Sergio Mena
f18f1cb3db
BlockStore holds extended commit
...
Cherry-pick 8d504d4b50ec6afbdffe2df7ababbef30e15053d and fix conflicts.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-28 17:12:20 -04:00
Thane Thomson
98ea839470
make proto-gen
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-28 17:02:35 -04:00
Sergio Mena
d651cd535b
Add protos for ExtendedCommit
...
Cherry-pick from e73f0178b72a16ee81f8e856aadf651f2c62ec6e just the
changes to the .proto files, since we have deleted the .intermediate
files.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-28 17:01:33 -04:00
Thane Thomson
d69bd64702
abci++: Vote extension cleanup ( #8402 )
...
* Split vote verification/validation based on vote extensions
Some parts of the code need vote extensions to be verified and
validated (mostly in consensus), and other parts of the code don't
because its possible that, in some cases (as per RFC 017), we won't have
vote extensions.
This explicitly facilitates that split.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only sign extensions in precommits, not prevotes
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Update privval/file.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Apply suggestions from code review
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Temporarily disable extension requirement again for E2E testing
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Reorganize comment for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Leave vote validation and pre-call nil check up to caller of VoteToProto
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Split complex vote validation test into multiple tests
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Universally enforce no vote extensions on any vote type but precommits
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Make error messages more generic
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Verify with vote extensions when constructing a VoteSet
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Expand comment for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add extension check for prevotes prior to signing votes
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix supporting test code to only inject extensions into precommits
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Separate vote malleation from signing in vote tests for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add extension signature length check and corresponding test
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Perform basic vote validation in CommitToVoteSet
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-04-28 13:53:44 -04:00
M. J. Fromberger
47d52fc78d
Use patched link-checker for periodic checks. ( #8430 )
...
In #8339 we pointed the markdown link checker action to a patched version that
has the up-to-date version of the underlying check tool. In doing so, I missed
the periodic cron job that runs the same workflow. Update it to use the patched
version also.
2022-04-28 06:44:56 -07:00
Sam Kleinman
2a58ea3ab2
p2p: use nodeinfo less often ( #8427 )
2022-04-27 21:13:38 +00:00
Sam Kleinman
1121698757
node: start rpc service after reactors ( #8426 )
2022-04-27 15:55:27 -04:00
