M. J. Fromberger
9177206750
Prepare changelog for Release v0.35.8 ( #8988 )
2022-07-14 14:49:37 -07:00
mergify[bot]
0c6efd8c51
config: update config to reflect simple-priority queue ( #9007 ) ( #9008 )
...
Update the queue documentation to reflect the types of queues and current default queue.
(cherry picked from commit c1c501ecd44561443+williambanfield@users.noreply.github.com >
2022-07-14 17:13:41 -04:00
Sam Kleinman
f8d15fc682
blocksync: drop support for enabled=false ( #8912 )
2022-07-14 13:19:12 -04:00
William Banfield
7971514b55
p2p: configure max accepted for non-legacy as well ( #8999 )
...
* p2p: configure max connected for non-legacy as well
* remove explicit 0
2022-07-14 10:11:34 -04:00
M. J. Fromberger
b94470a6a4
mempool: ensure evicted transactions are removed from the cache ( #9000 )
...
In the original implementation transactions evicted for priority were also
removed from the cache. In addition, remove expired transactions from
the cache.
Related:
- Add Has method to cache implementations.
- Update tests to exercise this condition.
2022-07-14 06:51:54 -07:00
mergify[bot]
a1c8f8df0b
doc: fix typos in quick-start.md. ( #8990 ) ( #8997 )
2022-07-14 11:44:08 +02:00
M. J. Fromberger
3790968156
mempool: release lock during app connection flush ( #8984 )
...
This case is symmetric to what we did for CheckTx calls, where we release the
mempool mutex to ensure callbacks can fire during call setup. We also need
this behaviour for application flush, for the same reason: The caller holds the
lock by contract from the Mempool interface.
2022-07-12 10:28:51 -07:00
M. J. Fromberger
9e64c95e56
mempool: reduce lock contention during CheckTx (cleanup) ( #8983 )
...
The way this was originally structured, we reacquired the lock after issuing
the initial ABCI CheckTx call, only to immediately release it. Restructure the
code so that this redundant acquire is no longer necessary.
2022-07-12 08:00:29 -07:00
M. J. Fromberger
cb93d3b587
mempool: don't log message type mismatch in the default callback ( #8969 )
2022-07-11 18:06:49 -07:00
M. J. Fromberger
f98de20f7e
p2p: ensure closed channels stop receiving service ( #8979 )
...
Once these channels are closed, we should not continue to service them, as they
will never again deliver nonzero values.
2022-07-11 16:34:05 -07:00
M. J. Fromberger
451e697331
Update generated mocks after upgrade of Mockery v2. ( #8973 )
2022-07-11 09:18:36 -04:00
mergify[bot]
e3292a48e3
p2p: simpler priority queue (backport #8929 ) ( #8956 )
2022-07-08 13:29:42 -04:00
M. J. Fromberger
6a354a1e8d
Update pending changelog. ( #8965 )
2022-07-08 09:54:50 -07:00
mergify[bot]
1daf7b939d
p2p: make peer gossiping coinflip safer ( #8949 ) ( #8963 )
...
Closes #8948
(cherry picked from commit 61ce384d75garen@tychoish.com >
2022-07-08 12:32:12 -04:00
mergify[bot]
156c305b08
p2p: delete cruft ( #8958 ) ( #8959 )
...
I think the decision in #8806 is that we shouldn't do this yet, so I think it's best to just drop this.
(cherry picked from commit 636320f901garen@tychoish.com >
2022-07-08 09:59:57 -04:00
M. J. Fromberger
bc49f66c35
Add more unit tests for the priority mempool. ( #8961 )
...
- Add a test for time-based (TTL) expiration.
- Add tests for eviction based on size and priority.
2022-07-07 14:56:34 -07:00
M. J. Fromberger
9b02094827
Fix unbounded heap growth in the priority mempool. ( #8944 )
...
The primary effect of this change is to simplify the implementation of the
priority mempool to eliminate an unbounded heap growth observed by Vega team
when it was enabled in their testnet. It updates and fixes #8775 .
The main body of this change is to remove the auxiliary indexing structures,
and use only the concurrent list structure (the same as the legacy mempool) to
maintain both gossip order and priority.
This means that operations that require priority information, such as block
updates and insert-time evictions, require a linear scan over the mempool.
This tradeoff greatly simplifies the code and eliminates the long-term heap
load, at the cost of some extra CPU and short-lived working memory during
CheckTx and Update calls.
Rough benchmark results:
- This PR:
BenchmarkTxMempool_CheckTx-10 486373 2271 ns/op
- Original priority mempool implementation:
BenchmarkTxMempool_CheckTx-10 500302 2113 ns/op
- Legacy (v0) mempool:
BenchmarkCheckTx-10 364591 3571 ns/op
These benchmarks are not a good proxy for production load, but at least suggest
that the overhead of the implementation changes are not cause for concern.
In addition:
- Rework synchronization so that access to shared data structures is safe.
Previously shared locks were used to exclude block updates during calls that
update mempool state. Now access is properly exclusive where necessary.
- Fix a bug in the recheck flow, where priority updates from the application
were not correctly reflected in the index structures.
- Eliminate the need for separate recheck cursors during block update. This
avoids the need to explicitly invalidate elements of the concurrent list,
which averts the dependency cycle that led to objects being pinned.
- Clean up, clarify, and fix inaccuracies in documentation comments throughout
the package.
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
2022-07-07 07:15:08 -07:00
William Banfield
da83edc588
p2p: return from conn send on stopped mconn ( #8904 )
...
Co-authored-by: Sam Kleinman <garen@tychoish.com >
2022-07-06 10:41:55 -04:00
mergify[bot]
047d7c927b
p2p: fix flakey test due to disconnect cooldown ( #8917 ) ( #8918 )
...
This test was made flakey by #8839 . The cooldown period means that the node in the test will not try to reconnect as quickly as the test expects. This change makes the cooldown shorter in the test so that the node quickly reconnects.
(cherry picked from commit 5274f80de44561443+williambanfield@users.noreply.github.com >
Co-authored-by: Sam Kleinman <garen@tychoish.com >
2022-07-05 19:11:38 -04:00
mergify[bot]
49788adde5
p2p: use correct context error ( #8916 ) ( #8920 )
...
handshakeCtx is the internal context carrying the timeout. Its error should be used for the error return.
(cherry picked from commit 921530c3524561443+williambanfield@users.noreply.github.com >
Co-authored-by: Sam Kleinman <garen@tychoish.com >
Co-authored-by: Callum Waters <cmwaters19@gmail.com >
2022-07-05 13:36:26 -04:00
dependabot[bot]
e414d0a878
build(deps): Bump github.com/libp2p/go-buffer-pool from 0.0.2 to 0.1.0 ( #8931 )
2022-07-05 12:19:03 +02:00
dependabot[bot]
6a646f366e
build(deps): Bump github.com/vektra/mockery/v2 from 2.13.1 to 2.14.0 ( #8925 )
...
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery ) from 2.13.1 to 2.14.0.
- [Release notes](https://github.com/vektra/mockery/releases )
- [Changelog](https://github.com/vektra/mockery/blob/master/.goreleaser.yml )
- [Commits](https://github.com/vektra/mockery/compare/v2.13.1...v2.14.0 )
---
updated-dependencies:
- dependency-name: github.com/vektra/mockery/v2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-01 12:15:22 -04:00
mergify[bot]
01984cb3b2
p2p: set outgoing connections to around 20% of total connections ( #8913 ) ( #8914 )
...
(cherry picked from commit 47cb30fc1d4561443+williambanfield@users.noreply.github.com >
2022-06-30 17:15:32 -04:00
dependabot[bot]
e2d2c04aac
build(deps): Bump github.com/stretchr/testify from 1.7.2 to 1.8.0 ( #8908 )
...
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify ) from 1.7.2 to 1.8.0.
- [Release notes](https://github.com/stretchr/testify/releases )
- [Commits](https://github.com/stretchr/testify/compare/v1.7.2...v1.8.0 )
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-30 08:33:13 -07:00
Sam Kleinman
204281fa66
node: always start blocksync and avoid misconfiguration ( #8902 )
2022-06-29 22:12:36 -04:00
mergify[bot]
486370ac68
log: do not pre-process log results (backport #8895 ) ( #8896 )
...
(cherry picked from commit 37f9d59969garen@tychoish.com >
2022-06-29 11:26:28 -04:00
William Banfield
978f754ad3
p2p: set empty timeouts to configed values. (manual backport of #8847 ) ( #8869 )
...
* regenerate mocks using newer style
* p2p: set empty timeouts to small values. (#8847 )
These timeouts default to 'do not time out' if they are not set. This times up resources, potentially indefinitely. If node on the other side of the the handshake is up but unresponsive, the[ handshake call](edec79448a/internal/p2p/router.go (L720)
2022-06-28 16:07:15 -04:00
mergify[bot]
c4ef566071
p2p: remove dial sleep and provide disconnect cooldown (backport #8839 ) ( #8875 )
...
(cherry picked from commit 52b6dc19ba
2022-06-27 10:49:51 -04:00
dependabot[bot]
f19e52e6f2
build(deps): Bump styfle/cancel-workflow-action from 0.9.1 to 0.10.0 ( #8882 )
...
Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action ) from 0.9.1 to 0.10.0.
- [Release notes](https://github.com/styfle/cancel-workflow-action/releases )
- [Commits](https://github.com/styfle/cancel-workflow-action/compare/0.9.1...0.10.0 )
---
updated-dependencies:
- dependency-name: styfle/cancel-workflow-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-27 09:13:46 -04:00
mergify[bot]
19b98c7005
e2e: disable another network test ( #8862 ) ( #8873 )
...
Follow up on: https://github.com/tendermint/tendermint/pull/8849
(cherry picked from commit c4d24eed7dcmwaters19@gmail.com >
2022-06-24 13:22:26 -04:00
mergify[bot]
826f224c2d
p2p: add eviction metrics and cleanup dialing error handling (backport #8819 ) ( #8820 )
2022-06-24 10:42:58 -04:00
mergify[bot]
2df4c2b19d
e2e: add tolerance to peer discovery test ( #8849 ) ( #8857 )
...
(cherry picked from commit fb209136f8cmwaters19@gmail.com >
Co-authored-by: Sam Kleinman <garen@tychoish.com >
2022-06-23 14:46:10 -04:00
mergify[bot]
6f4ef72964
p2p: track peers by address ( #8841 ) ( #8855 )
...
(cherry picked from commit 436a38f876garen@tychoish.com >
2022-06-23 13:21:46 -04:00
mergify[bot]
3398f37979
cmd: add tool for compaction of goleveldb (backport #8564 ) ( #8675 )
2022-06-23 18:25:19 +02:00
mergify[bot]
8ef63fe3d9
e2e: report peer heights in error message ( #8843 ) ( #8853 )
...
(cherry picked from commit 52b2efb827garen@tychoish.com >
2022-06-23 10:46:51 -04:00
M. J. Fromberger
9daea43375
Update default version marker. ( #8844 )
2022-06-22 18:16:58 -04:00
M. J. Fromberger
df9363c67c
Prepare changelog for Release v0.35.7 ( #8772 )
2022-06-22 11:54:03 -07:00
mergify[bot]
24701cd587
p2p: more dial routines ( #8827 ) ( #8828 )
2022-06-21 21:27:28 -04:00
William Banfield
e9c87a3c49
remove dial wake change ( #8824 )
2022-06-21 20:20:04 -04:00
dependabot[bot]
034a9f8422
build(deps): Bump github.com/spf13/cobra from 1.4.0 to 1.5.0 ( #8811 )
...
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra ) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/spf13/cobra/releases )
- [Commits](https://github.com/spf13/cobra/compare/v1.4.0...v1.5.0 )
---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com >
2022-06-21 17:16:31 -04:00
Callum Waters
4322f7d0b9
mempool: make error throwing for CheckTx consistent ( #8817 )
2022-06-21 18:51:50 +02:00
Sam Kleinman
83526cacbc
p2p: peer store and dialing changes (0.35.x backport) ( #8740 )
...
* p2p: peer store and dialing changes
(cherry picked from commit 9dbb135152b213a2766fcc28ce298f56a91642dc86db59f53b000aa054854e2bc8f51ee3068b50b231bd396c88eddb23b5af4c8651026amichael.j.fromberger@gmail.com >
(cherry picked from commit f23f6e1089michael.j.fromberger@gmail.com >
(cherry picked from commit 1c02758eaf9f604fd2ef930fd7f2be9abc55f3a0720600ef628195c97590053ecd9b8cmichael.j.fromberger@gmail.com >
* comments
* fix lint
* cr feedback
* fixup cherrypick
* make wb happy
* more comments
* fixup
* fix lint
* iota fix
* add skip
* cleanup
* remove comment
* fix rand
* fix rand
* use numaddresses correctly
* advertise fixes
* remove some things
* cleanup comment
* more fixes
* toml
* fix comment
* fix spell
* dec limit
* fixes
* up the attmept max
* cr feedback
* probablistic test
* fix spell
* add metrics for peers stored on startup
* p2p: peer score should not wrap around (#8790 )
(cherry picked from commit 4d820ff4f5michael.j.fromberger@gmail.com >
2022-06-20 13:13:21 -04:00
mergify[bot]
25d724b920
e2e: reactivate network test (backport #8635 ) ( #8777 )
2022-06-20 17:10:20 +02:00
dependabot[bot]
3945cec115
build(deps): Bump github.com/adlio/schema from 1.3.0 to 1.3.3 ( #8797 )
...
Bumps [github.com/adlio/schema](https://github.com/adlio/schema ) from 1.3.0 to 1.3.3.
- [Release notes](https://github.com/adlio/schema/releases )
- [Commits](https://github.com/adlio/schema/compare/v1.3.0...v1.3.3 )
---
updated-dependencies:
- dependency-name: github.com/adlio/schema
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-20 09:19:34 -04:00
mergify[bot]
74c6d8100d
p2p: fix typo ( #8793 ) ( #8794 )
2022-06-19 11:52:43 -07:00
M. J. Fromberger
e2d01cdcff
Make priority mempool fuzz test actually test the priority mempool. ( #8785 )
...
Fixes #8783 .
2022-06-17 09:29:13 -07:00
dependabot[bot]
bee6597b28
build(deps): Bump github.com/vektra/mockery/v2 from 2.13.0 to 2.13.1 ( #8765 )
...
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery ) from 2.13.0 to 2.13.1.
- [Release notes](https://github.com/vektra/mockery/releases )
- [Changelog](https://github.com/vektra/mockery/blob/master/.goreleaser.yml )
- [Commits](https://github.com/vektra/mockery/compare/v2.13.0...v2.13.1 )
---
updated-dependencies:
- dependency-name: github.com/vektra/mockery/v2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sam Kleinman <garen@tychoish.com >
2022-06-15 10:12:21 -04:00
mergify[bot]
ce8284c027
p2p: accept should not abort on first error (backport #8759 ) ( #8760 )
2022-06-15 07:56:15 -04:00
dependabot[bot]
d02f58e191
build(deps): Bump github.com/vektra/mockery/v2 from 2.12.3 to 2.13.0 ( #8747 )
...
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery ) from 2.12.3 to 2.13.0.
- [Release notes](https://github.com/vektra/mockery/releases )
- [Changelog](https://github.com/vektra/mockery/blob/master/.goreleaser.yml )
- [Commits](https://github.com/vektra/mockery/compare/v2.12.3...v2.13.0 )
---
updated-dependencies:
- dependency-name: github.com/vektra/mockery/v2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-14 10:00:05 -07:00
Callum Waters
28c38522e0
do not log an error for duplicate txs ( #8732 )
2022-06-10 11:56:00 +02:00
