Sam Kleinman
94e1eb8cfe
rfc: fix link style ( #6870 )
...
This is super minor, but chaning this to fix a broken link and to
match the existing style of the ADRs.
2021-08-27 16:21:12 +00:00
Sam Kleinman
23abb0de8b
rfc: p2p next steps ( #6866 )
2021-08-27 12:14:59 -04:00
Aleksandr Bezobchuk
58a6cfff9a
internal/consensus: update error log ( #6863 )
...
Issues reported in Osmosis, where the message is extremely long. Also, there is absolutely no reason to log the message IMO. If we must, we can make the message log DEBUG.
2021-08-25 22:43:21 +00:00
Sam Kleinman
6e921f6644
p2p: change default to use new stack ( #6862 )
...
This is just a configuration change to default to using the new stack
unless explicitly disabled (e.g. `UseLegacy`) this renames the
configuration value and makes the configuration logic more clear.
The legacy option is good to retain as a fallback if the new stack has
issues operationally, but we should make sure that most of the time
we're using the new stack.
2021-08-25 17:33:38 +00:00
Sam Kleinman
a0a5d45cb1
lint: change deprecated linter ( #6861 )
...
This is a super minor change that silences a warning when running the linter locally.
2021-08-25 12:26:11 +00:00
Sam Kleinman
9c8379ef30
e2e: more consistent node selection during tests ( #6857 )
...
In the transaction load generator, the e2e test harness previously distributed load randomly to hosts, which was a source of test non-determinism. This change distributes the load generation to the different nodes in the set in a round robin fashion, to produce more reliable results, but does not otherwise change the behavior of the test harness.
2021-08-25 12:24:01 +00:00
dependabot[bot]
e053643b95
build(deps): Bump codecov/codecov-action from 2.0.2 to 2.0.3 ( #6860 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 2.0.2 to 2.0.3.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v2.0.2...v2.0.3 )
---
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-25 08:12:04 -04:00
M. J. Fromberger
41a361ed8d
psql: add documentation and simplify constructor API ( #6856 )
...
Add documentation comments to the psql event sink package, and simplify the
constructor function so that it does not return the SQL database handle. The
handle is needed for testing, so expose that via a separate method on the
concrete type.
Update the tests and existing usage for the change. This change does not affect
the behaviour of the sink, so there are no functional changes, only syntactic
updates.
2021-08-24 17:18:27 -04:00
William Banfield
bc2b529b95
inspect: add inspect mode for debugging crashed tendermint node ( #6785 )
...
EDIT: Updated, see [comment below]( https://github.com/tendermint/tendermint/pull/6785#issuecomment-897793175 )
This change adds a sketch of the `Debug` mode.
This change adds a `Debug` struct to the node package. This `Debug` struct is intended to be created and started by a command in the `cmd` directory. The `Debug` struct runs the RPC server on the data directories: both the state store and the block store.
This change required a good deal of refactoring. Namely, a new `rpc.go` file was added to the `node` package. This file encapsulates functions for starting RPC servers used by nodes. A potential additional change is to further factor this code into shared code _in_ the `rpc` package.
Minor API tweaks were also made that seemed appropriate such as the mechanism for fetching routes from the `rpc/core` package.
Additional work is required to register the `Debug` service as a command in the `cmd` directory but I am looking for feedback on if this direction seems appropriate before diving much further.
closes : #5908
2021-08-24 18:12:06 +00:00
Tess Rinearson
6d5ff590c3
contributing: remove release_notes.md reference ( #6846 )
2021-08-24 19:07:53 +02:00
Sam Kleinman
d8642a941e
cmd: remove deprecated snakes ( #6854 )
...
just following up on a deprecation.
2021-08-24 16:06:27 +00:00
Sam Kleinman
d7c3a8f682
time: make median time library type private ( #6853 )
...
This is a very minor change, but I was looking through the code, and
this seems like it shouldn't be exported or used more broadly, so I've
moved it out.
2021-08-24 15:43:13 +00:00
M. J. Fromberger
ce3c059a0d
ADR 072: Re-instate a request-for-comments archive. ( #6851 )
...
This ADR restores a variation of the old Request for Comments documentation
that we previously used. The proposal differs from the original formulation,
and does not replace ADRs.
2021-08-23 18:06:01 -04:00
Sam Kleinman
39dee8abc5
pubsub: improve handling of closed blocking subsciptions. ( #6852 )
2021-08-23 16:41:45 -04:00
Hlib Kanunnikov
d0e33b4292
blocksync: complete transition from Blockchain to BlockSync ( #6847 )
2021-08-23 16:45:08 +02:00
William Banfield
8700ca9d1a
ADR 071: Proposer-based Timestamps ( #6799 )
...
Architectural decision record for Proposer-based timestamps.
2021-08-20 16:07:20 -04:00
Sam Kleinman
a374f74f7c
e2e: cleanup node start function ( #6842 )
...
I realized after my last commit that my change made a following line of code a bit redundant.
(alternatively my last change was redunadnt to the existing code.)
I took this oppertunity to make some minor cleanups and logging changes to the node changes which I hope will make tests a bit more clear.
2021-08-20 17:26:04 +00:00
dependabot[bot]
3a234e1144
build(deps): Bump docker/build-push-action from 2.6.1 to 2.7.0 ( #6845 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2.6.1 to 2.7.0.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](https://github.com/docker/build-push-action/compare/v2.6.1...v2.7.0 )
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-20 13:32:11 +02:00
Aleksandr Bezobchuk
cce0a3c171
docs: add package godoc for indexer ( #6839 )
...
* docs: add indexer godoc
* docs++
* docs++
* docs++
* docs++
* docs++
* Update state/indexer/doc.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Update state/indexer/doc.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Update state/indexer/doc.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Update state/indexer/doc.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Update state/indexer/doc.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Update state/indexer/doc.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* docs++
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2021-08-19 20:25:17 +00:00
Sam Kleinman
a4cc8317da
e2e: avoid starting nodes from the future ( #6835 )
2021-08-18 14:33:28 -04:00
Tess Rinearson
69f6eee2e4
changelog: linkify the 0.34.11 release notes ( #6836 )
...
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com >
2021-08-18 12:06:13 +00:00
dependabot[bot]
afb6af8bc3
build(deps): Bump github.com/golangci/golangci-lint ( #6837 )
...
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint ) from 1.41.1 to 1.42.0.
- [Release notes](https://github.com/golangci/golangci-lint/releases )
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md )
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.41.1...v1.42.0 )
---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-18 08:02:16 -04:00
Tess Rinearson
0ed3ba6279
changelog: update to reflect 0.34.12 release ( #6833 )
2021-08-18 11:55:57 +02:00
Tess Rinearson
267aac2e90
changelog_pending: add missing item ( #6829 )
2021-08-17 15:45:14 +02:00
Tess Rinearson
471f83d557
contributing: update release instructions to use backport branches ( #6827 )
2021-08-17 15:28:20 +02:00
Aleksandr Bezobchuk
393a02a729
rpc: log update ( #6825 )
...
We INFO log every `ABCIQuery`. This can output a tremendous amount of noise in the logs, can cause cosmovisor to completely crash and slows down the node due to I/O. This log is completely unnecessary.
Let's get this backported into v0.43 and get that into v0.43 and v0.42 releases of the SDK
/cc @marbar3778
2021-08-14 01:40:14 +00:00
Sam Kleinman
bf77c0c544
rpc: support new p2p infrastructure ( #6820 )
2021-08-13 15:39:07 -04:00
Carlos Rodriguez
511e52c2fc
doc: fix typos in /tx_search and /tx. ( #6823 )
...
Just a few small typos in the descriptions of the /tx_search and /tx endpoints.
2021-08-13 15:02:30 +00:00
dependabot[bot]
1f76cb1546
build(deps): Bump google.golang.org/grpc from 1.39.1 to 1.40.0 ( #6819 )
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.39.1 to 1.40.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases ">google.golang.org/grpc's releases</a>.</em></p>
<blockquote>
<h2>Release 1.40.0</h2>
<h1>Behavior Changes</h1>
<ul>
<li>balancer: client channel no longer connects to idle subchannels that are returned by the pickers; LB policy should call SubConn.Connect instead. (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4579 ">#4579</a>)
<ul>
<li>This change is in line with existing documentation stating the balancer must call Connect on idle SubConns in order for them to connect, and is preparation for an upcoming change that transitions SubConns to the idle state when connections are lost. See <a href="https://pkg.go.dev/google.golang.org/grpc/balancer#SubConn ">https://pkg.go.dev/google.golang.org/grpc/balancer#SubConn </a> for more details.</li>
</ul>
</li>
</ul>
<h1>Bug Fixes</h1>
<ul>
<li>transport: fail RPCs without HTTP status 200 (OK), according to the gRPC spec (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4474 ">#4474</a>)
<ul>
<li>Special Thanks: <a href="https://github.com/JNProtzman "><code>@JNProtzman</code></a></li>
</ul>
</li>
<li>binarylog: fail the <code>Write()</code> method if proto marshaling fails (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4582 ">#4582</a>)
<ul>
<li>Special Thanks: <a href="https://github.com/Jille "><code>@Jille</code></a></li>
</ul>
</li>
<li>binarylog: exit the flusher goroutine upon closing the <code>bufferedSink</code> (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4583 ">#4583</a>)
<ul>
<li>Special Thanks: <a href="https://github.com/Jille "><code>@Jille</code></a></li>
</ul>
</li>
</ul>
<h1>New Features</h1>
<ul>
<li>metadata: add Delete method to MD to encapsulate lowercasing (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4549 ">#4549</a>)
<ul>
<li>Special Thanks: <a href="https://github.com/konradreiche "><code>@konradreiche</code></a></li>
</ul>
</li>
<li>xds/cds: support logical DNS cluster and aggregated cluster (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4594 ">#4594</a>)</li>
<li>stats: add stats.Begin.IsClientStream and IsServerStream to indicate the type of RPC invoked (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4533 ">#4533</a>)
<ul>
<li>Special Thanks: <a href="https://github.com/leviska "><code>@leviska</code></a></li>
</ul>
</li>
</ul>
<h1>Performance Improvements</h1>
<ul>
<li>server: improve performance when multiple interceptors are used (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4524 ">#4524</a>)
<ul>
<li>Special Thanks: <a href="https://github.com/amenzhinsky "><code>@amenzhinsky</code></a></li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="41e044e1c8https://github-redirect.dependabot.com/grpc/grpc-go/issues/4644 ">#4644</a>) (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4670 ">#4670</a>)</li>
<li><a href="1634fd3fc3https://github-redirect.dependabot.com/grpc/grpc-go/issues/4623 ">#4623</a>)</li>
<li><a href="b1a15ac370https://github-redirect.dependabot.com/grpc/grpc-go/issues/4644 ">#4644</a>)</li>
<li><a href="00edd8c13ahttps://github-redirect.dependabot.com/grpc/grpc-go/issues/4614 ">#4614</a>)</li>
<li><a href="1ddab33869https://github-redirect.dependabot.com/grpc/grpc-go/issues/4611 ">#4611</a>)</li>
<li><a href="582ef458c6c513103beehttps://github-redirect.dependabot.com/grpc/grpc-go/issues/4576 ">#4576</a>)</li>
<li><a href="a0bed723f1https://github-redirect.dependabot.com/grpc/grpc-go/issues/4595 ">#4595</a>)</li>
<li><a href="0a8c63739a8332d5b997https://github-redirect.dependabot.com/grpc/grpc-go/issues/4570 ">#4570</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/grpc/grpc-go/compare/v1.39.1...v1.40.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2021-08-12 15:23:37 +00:00
Sam Kleinman
d56a44b884
node: minimize hardcoded service initialization ( #6798 )
...
* node: minimize hardcoded service initialization
* hacking
* nil safety
* reduce space
* remove genesis state store
* fix lint
* fix pex
* unwind some odering effects
* fix tests
* remove unused experiment
2021-08-12 13:38:17 +00:00
Sam Kleinman
cbfc04df6d
rpc: avoid panics in unsafe rpc calls with new p2p stack ( #6817 )
2021-08-11 13:20:01 -04:00
Sam Kleinman
a6d20a6660
pubsub: unsubscribe locking handling ( #6816 )
2021-08-11 11:37:05 -04:00
Sam Kleinman
97435139ad
adr: node initialization ( #6562 )
2021-08-11 10:34:45 -04:00
Sam Kleinman
66084a01dc
commands: add key migration cli ( #6790 )
2021-08-10 14:58:21 -04:00
M. J. Fromberger
53d53e6205
bytes: clean up and simplify encoding of HexBytes ( #6810 )
...
As written, the encoding step unnecessarily made and moved multiple copies of
the encoded representation. Reduce this to a single allocation and encode the
data in-place so that a shift is no longer required.
Also: Add a test to ensure letter digits are capitalized, which was previously not
verified but was expected downstream.
No functional changes.
2021-08-10 09:58:18 -04:00
M. J. Fromberger
a7ecf49c10
Add new team member to CODEOWNERS. ( #6811 )
2021-08-09 23:30:58 -04:00
Sam Kleinman
31994cadc0
docs: upgrade documentation for custom mempools ( #6794 )
...
This is proposed language for the upgrade process about the new custom
reactor/mempool support.
2021-08-06 19:51:07 +00:00
dependabot[bot]
e5312942e3
build(deps): Bump google.golang.org/grpc from 1.39.0 to 1.39.1 ( #6801 )
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.39.0 to 1.39.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases ">google.golang.org/grpc's releases</a>.</em></p>
<blockquote>
<h2>Release 1.39.1</h2>
<ul>
<li>server: fix bug that net.Conn is leaked if the connection is closed (io.EOF) immediately with no traffic (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4642 ">#4642</a>)</li>
<li>transport: fix race in transport stream accessing s.recvCompress (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4627 ">#4627</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="db17d4b4adhttps://github-redirect.dependabot.com/grpc/grpc-go/issues/4651 ">#4651</a>)</li>
<li><a href="8d1369b150https://github-redirect.dependabot.com/grpc/grpc-go/issues/4642 ">#4642</a>)</li>
<li><a href="2e0b66bb0ehttps://github-redirect.dependabot.com/grpc/grpc-go/issues/4627 ">#4627</a>)</li>
<li><a href="db2d595725https://github-redirect.dependabot.com/grpc/grpc-go/issues/4542 ">#4542</a>)</li>
<li>See full diff in <a href="https://github.com/grpc/grpc-go/compare/v1.39.0...v1.39.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2021-08-06 14:28:58 +00:00
dependabot[bot]
4db71da68e
build(deps): Bump github.com/BurntSushi/toml from 0.3.1 to 0.4.1 ( #6796 )
...
Bumps [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml ) from 0.3.1 to 0.4.1.
- [Release notes](https://github.com/BurntSushi/toml/releases )
- [Commits](https://github.com/BurntSushi/toml/compare/v0.3.1...v0.4.1 )
---
updated-dependencies:
- dependency-name: github.com/BurntSushi/toml
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-05 10:08:49 -04:00
William Banfield
e801328128
clist: add simple property tests ( #6791 )
...
Adds a simple property test to the `clist` package. This test uses the [rapid](https://github.com/flyingmutant/rapid ) library and works by modeling the internal clist as a simple array.
Follow up from this mornings workshop with the Regen team.
2021-08-03 19:30:05 +00:00
M. J. Fromberger
4cbaf70d1f
docs: fix a typo in the genesis_chunked description ( #6792 )
2021-08-03 15:08:23 -04:00
rene
e5f9dd2736
docs: fix typo ( #6789 )
2021-08-02 17:25:59 -04:00
dependabot[bot]
e922016121
build(deps): Bump technote-space/get-diff-action from 4 to 5 ( #6788 )
...
Bumps [technote-space/get-diff-action](https://github.com/technote-space/get-diff-action ) from 4 to 5.
- [Release notes](https://github.com/technote-space/get-diff-action/releases )
- [Changelog](https://github.com/technote-space/get-diff-action/blob/main/.releasegarc )
- [Commits](https://github.com/technote-space/get-diff-action/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: technote-space/get-diff-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com >
2021-08-02 12:25:37 -04:00
William Banfield
dc7c212c41
mempool/v1: test reactor does not panic on broadcast ( #6772 )
...
This changes adds a failing test for issue #6660 . It achieves this by adding a transaction, starting the `broadcastTxRoutine` in a goroutine and then adding another transaction to the mempool. The `broadcastTxRoutine` can receive the second inserted transaction before `insertTx` returns. In that case, `broadcastTxRoutine` will derefence a nil pointer when referencing the `gossipEl` and panic.
2021-08-02 13:02:43 +00:00
William Banfield
4e96c6b234
tools: add mockery to tools.go and remove mockery version strings ( #6787 )
...
This change aims to keep versions of mockery consistent across developer laptops.
This change adds mockery to the `tools.go` file so that its version can be managed consistently in the `go.mod` file.
Additionally, this change temporarily disables adding mockery's version number to generated files. There is an outstanding issue against the mockery project related to the version string behavior when running from `go get`. I have created a pull request to fix this issue in the mockery project.
see: https://github.com/vektra/mockery/issues/397
2021-07-30 20:47:15 +00:00
Callum Waters
02f8e4c0bd
blockstore: fix problem with seen commit ( #6782 )
2021-07-30 17:37:04 +02:00
dependabot[bot]
3aec71cdd4
build(deps): Bump styfle/cancel-workflow-action from 0.9.0 to 0.9.1 ( #6786 )
2021-07-30 09:21:27 -04:00
M. J. Fromberger
6dd8984fef
Fix and clarify breaks from select cases. ( #6781 )
...
Update those break statements inside case clauses that are intended to reach an
enclosing for loop, so that they correctly exit the loop.
The candidate files for this change were located using:
% staticcheck -checks SA4011 ./... | cut -d: -f-2
This change is intended to preserve the intended semantics of the code, but
since the code as-written did not have its intended effect, some behaviour may
change. Specifically: Some loops may have run longer than they were supposed
to, prior to this change.
In one case I was not able to clearly determine the intended outcome. That case
has been commented but otherwise left as-written.
Fixes #6780 .
2021-07-29 22:28:32 -04:00
JayT106
9a2a7d4307
state/privval: vote timestamp fix ( #6748 )
2021-07-29 12:52:53 +02:00
M. J. Fromberger
8f06e0c9e7
cleanup: remove redundant error plumbing ( #6778 )
...
This is a mostly-automated fixup using Comby (https://comby.dev ) to remove
lexically-obvious redundant error checks. No functional changes are intended.
To reproduce the core change:
# Collapse redundant error check conditionals
% comby -in-place 'if err != nil {
return err
}
return nil' 'return err' .go
# Fold out unnecessary error temporaries
% comby -in-place ':[spc~^\s*]err :[~:?]= :[any]
return err' ':[spc]return :[any]' .go
Fixes #6479 and related cases.
2021-07-28 15:38:46 -04:00
