be9b4a7fc0
use errorf instead of sprintf in panic
2022-05-19 12:43:19 -04:00
4e05b5f108
ensure extensions on extended commit save
2022-05-19 12:31:50 -04:00
05d930f40a
Update internal/blocksync/reactor.go
...
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-05-19 10:07:46 -04:00
10078f39d6
add nil check for block load
2022-05-18 16:53:55 -04:00
4194d4da46
comment proposal extensions validation
2022-05-18 14:46:00 -04:00
f50ac0e8ea
add state check on peer response
2022-05-18 14:37:03 -04:00
4da32ea146
update and document new logic for bailing out of blocksync
2022-05-18 14:07:39 -04:00
dd98caa5f7
Update types/vote_set.go
...
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-05-18 13:29:28 -04:00
beb6c47e29
lint fix
2022-05-17 23:10:25 -04:00
cbd211a173
fix broken block store test
2022-05-17 22:37:04 -04:00
0c4a49600b
remove unused store code
2022-05-17 22:36:13 -04:00
98f614a614
use current block height as parameter in blocksync
2022-05-17 21:49:58 -04:00
6f577fa389
try commit and extcommit in blocksync response
2022-05-17 21:38:44 -04:00
4ceead171b
document new blockstore methods
2022-05-17 20:46:41 -04:00
588a310049
separate extended commit save
2022-05-17 20:37:59 -04:00
c3686fea00
Merge branch 'master' into wb/add-consensus-param-internal
2022-05-17 17:02:29 -04:00
dc253a8196
remove unnecessary assignment in proposal test
2022-05-17 16:39:46 -04:00
9e9f3a1433
strip extensions in consensus
2022-05-17 16:35:24 -04:00
d0377bade0
final case to voteset test
2022-05-17 16:23:39 -04:00
01d78e7d3d
update comment for vote set constructor
2022-05-17 15:45:20 -04:00
931e897c6a
fix node test
2022-05-17 15:40:50 -04:00
d92b63b85f
fix evidence tests
2022-05-17 15:35:21 -04:00
2e1f5bdbcd
fix hvs test
2022-05-17 15:29:43 -04:00
5d84aaf7d4
fix tests to store and load state
2022-05-17 15:06:35 -04:00
5dc8a1fac0
hack to not generate protos yet
2022-05-17 15:06:17 -04:00
c620900fdd
rpc: fix plumbing of broadcast_tx_commit timeout ( #8573 )
...
In #3435 we allowed this timeout to override the global write timeout.
But after #8570 this meant we were applying a shorter timeout by default.
Don't do the patch if the timeout is already unlimited.
This is a temporary workaround; in light of #8561 I plan to get rid of this
option entirely during the v0.37 cycle, but meanwhile we should keep existing
use more or less coherent.
2022-05-17 10:34:43 -07:00
21f140410b
rpc: enable the ADR 075 event log by default in new configs ( #8572 )
...
Since we are deprecating the stream-based event subscription in v0.36, we
should ensure that new nodes enable the replacement by default. For now, just
set a baseline 30-second window.
2022-05-17 09:49:23 -07:00
351b3bf6b0
tentative change for preventing blocksync early bail out
2022-05-17 12:24:43 -04:00
66c4c82f7a
rpc: rework timeouts to be per-method instead of global ( #8570 )
...
* rpc: rework timeouts to be per-method instead of global
Prior to this change, we set a 10-second global timeout for all RPC methods
using the net/http Server type's WriteTimeout. This meant that any request
whose handler did not return within that period would simply drop the
connection to the client.
This timeout is too short for a default, as evidenced by issues like [1] and
[2]. In addition, the mode of failure on the client side is confusing; it
shows up as a dropped connection (EOF) rather than a meaningful error from the
service. More importantly, various methods have diffent constraints: Some
should be able to return quickly, others may need to adjust based on the
application workload.
This is a first step toward supporting configurable timeouts. This change:
- Removes the server-wide default global timeout, and instead:
- Wires up a default context timeout for all RPC handlers.
- Increases the default timeout from 10s to 60s.
- Adds a hook to override this per-method as needed.
This does NOT expose the timeouts in the configuration file (yet).
[1] https://github.com/osmosis-labs/osmosis/issues/1391
[2] https://github.com/tendermint/tendermint/issues/8465
2022-05-17 08:52:39 -07:00
2897b75853
p2p: remove unused get height methods ( #8569 )
2022-05-17 10:56:26 -04:00
42b9c99c93
add check for blockid flag is commit
2022-05-17 10:40:36 -04:00
ff7955470a
update proposal tests to ensure off-by-one is correctly handled
2022-05-17 10:28:35 -04:00
ae6b910427
log if extension data present
2022-05-17 10:17:20 -04:00
603381ca2b
update vote reconstruction logic to force extended commit if extension enabled
2022-05-17 10:12:56 -04:00
5a42479d52
build(deps): Bump github.com/lib/pq from 1.10.5 to 1.10.6 ( #8567 )
...
Bumps [github.com/lib/pq](https://github.com/lib/pq ) from 1.10.5 to 1.10.6.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/lib/pq/commit/8c6de565f76fb5cd40a5c1b8ce583fbc3ba1bd0e "><code>8c6de56</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/lib/pq/issues/1081 ">#1081</a> from catj-cockroach/add-kubernetes-secret-support</li>
<li><a href="https://github.com/lib/pq/commit/d8917faf2ecafe856e2cb2df95b51a96f58b3387 "><code>d8917fa</code></a> adds support for kubernetes mounted private keys</li>
<li><a href="https://github.com/lib/pq/commit/54a3a4b3f393c97a92757204b31bfbb76473a1fb "><code>54a3a4b</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/lib/pq/issues/1082 ">#1082</a> from johanneswuerbach/connector-dialer</li>
<li><a href="https://github.com/lib/pq/commit/30d9faf71f714a01fc9d2a301915b97f226e0b52 "><code>30d9faf</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/lib/pq/issues/1080 ">#1080</a> from drakkan/sqlstate</li>
<li><a href="https://github.com/lib/pq/commit/cf6aeee4f29bfe6ca4eb95d3d577c98f271e40d7 "><code>cf6aeee</code></a> feat: change the connector dialer</li>
<li><a href="https://github.com/lib/pq/commit/ef3111ea5aefd45f868ed58012b1d0d0dd162982 "><code>ef3111e</code></a> error: add SQLState</li>
<li><a href="https://github.com/lib/pq/commit/006a3f492338e7f74b87a2c16d2c4be10cc04ae6 "><code>006a3f4</code></a> Added code that accounts for the 'Z' timezone separator in the ParseTimestamp...</li>
<li><a href="https://github.com/lib/pq/commit/da9184484ea1eaf6d07c2cd8d41b20b9ed92471c "><code>da91844</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/lib/pq/issues/1078 ">#1078</a> from otan-cockroach/copydata</li>
<li><a href="https://github.com/lib/pq/commit/326e7d02f7cd360303d51a606825189b358a3c6f "><code>326e7d0</code></a> fix CopyData comment</li>
<li><a href="https://github.com/lib/pq/commit/b3b833258663afbe55669e5b53e5d62f7e1231bd "><code>b3b8332</code></a> expose raw CopyData command (<a href="https://github-redirect.dependabot.com/lib/pq/issues/1077 ">#1077</a>)</li>
<li>See full diff in <a href="https://github.com/lib/pq/compare/v1.10.5...v1.10.6 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-05-17 11:55:04 +00:00
93ea3d0b7d
strip extensions in blocksync
2022-05-16 19:20:08 -04:00
44f1f045e2
update the VoteSet methods to only validate extensions when enabled
2022-05-16 19:08:34 -04:00
78c0c9c6ce
strip vote extensions in the reactor
2022-05-16 18:25:07 -04:00
b51b83a250
change prepare proposal to use enable extension logic
2022-05-16 18:00:25 -04:00
397f0840f6
do not call extension methods when not enabled
2022-05-16 17:13:14 -04:00
32790dedfc
do not verify extension if not enabled
2022-05-16 17:02:43 -04:00
589d4030ce
rename vote extension param
2022-05-16 16:46:17 -04:00
17d5e71489
Update internal/consensus/state.go
...
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-05-16 15:29:49 -04:00
ed9df4d1f1
Update types/block.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-16 12:13:57 -04:00
62ecdf5b60
correct NewStrictVoteSet constructor to not call itself
2022-05-16 11:40:08 -04:00
f5cd75c090
shorter timeout in SwitchToConsensus test
2022-05-16 11:39:01 -04:00
19cc03f6fd
addr -> myAddr
2022-05-16 11:38:23 -04:00
cb2f3624da
Update internal/consensus/state.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-16 11:36:01 -04:00
d3c9ab64b5
Update internal/consensus/state.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-16 11:35:49 -04:00
331a7ceea1
Update types/block.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-05-16 11:33:41 -04:00
William Banfield
William Banfield
M. J. Fromberger
Sam Kleinman
dependabot[bot]