eee19e42db
consensus: reduce size of validator set changes test ( #8442 )
2022-04-29 10:29:26 -04:00
97b39770e0
build(deps): Bump github.com/btcsuite/btcd from 0.22.0-beta to 0.22.1 ( #8439 )
...
Bumps [github.com/btcsuite/btcd](https://github.com/btcsuite/btcd ) from 0.22.0-beta to 0.22.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/btcsuite/btcd/blob/v0.22.1/CHANGES ">github.com/btcsuite/btcd's changelog</a>.</em></p>
<blockquote>
<h1>============================================================================
User visible changes for btcd
A full-node bitcoin implementation written in Go</h1>
<p>Changes in 0.22.1 (Wed Apr 27 2022)</p>
<ul>
<li>Notable developer-related package changes:
<ul>
<li>Update to use chaincfg/chainhash module and remove conflicting
package</li>
</ul>
</li>
<li>Contributors (alphabetical order):
<ul>
<li>Dave Collins</li>
</ul>
</li>
</ul>
<p>Changes in 0.22.0 (Tue Jun 01 2021)</p>
<ul>
<li>Protocol and network-related changes:
<ul>
<li>Add support for witness tx and block in notfound msg (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1625 ">#1625</a>)</li>
<li>Add support for receiving sendaddrv2 messages from a peer (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1670 ">#1670</a>)</li>
<li>Fix bug in peer package causing last block height to go backwards
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1606 ">#1606</a>)</li>
<li>Add chain parameters for connecting to the public Signet network
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1692 ">#1692</a>, <a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1718 ">#1718</a>)</li>
</ul>
</li>
<li>Crypto changes:
<ul>
<li>Fix bug causing panic due to bad R and S signature components in
btcec.RecoverCompact (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1691 ">#1691</a>)</li>
<li>Set the name (secp256k1) in the CurveParams of the S256 curve
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1565 ">#1565</a>)</li>
</ul>
</li>
<li>Notable developer-related package changes:
<ul>
<li>Remove unknown block version warning in the blockchain package,
due to false positives triggered by AsicBoost (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1463 ">#1463</a>)</li>
<li>Add chaincfg.RegisterHDKeyID function to populate HD key ID pairs
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1617 ">#1617</a>)</li>
<li>Add new method mining.AddWitnessCommitment to add the witness
commitment as an OP_RETURN output within the coinbase transaction.
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1716 ">#1716</a>)</li>
</ul>
</li>
<li>RPC changes:
<ul>
<li>Support Batch JSON-RPC in rpcclient and server (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1583 ">#1583</a>)</li>
<li>Add rpcclient method to invoke getdescriptorinfo JSON-RPC command
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1578 ">#1578</a>)</li>
<li>Update the rpcserver handler for validateaddress JSON-RPC command to
have parity with the bitcoind 0.20.0 interface (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1613 ">#1613</a>)</li>
<li>Add rpcclient method to invoke getblockfilter JSON-RPC command
(<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1579 ">#1579</a>)</li>
<li>Add signmessagewithprivkey JSON-RPC command in rpcserver (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1585 ">#1585</a>)</li>
<li>Add rpcclient method to invoke importmulti JSON-RPC command (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1579 ">#1579</a>)</li>
<li>Add watchOnly argument in rpcclient method to invoke
listtransactions JSON-RPC command (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1628 ">#1628</a>)</li>
<li>Update btcjson.ListTransactionsResult for compatibility with Bitcoin
Core 0.20.0 (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1626 ">#1626</a>)</li>
<li>Support nullable optional JSON-RPC parameters (<a href="https://github-redirect.dependabot.com/btcsuite/btcd/issues/1594 ">#1594</a>)</li>
<li>Add rpcclient and server method to invoke getnodeaddresses JSON-RPC</li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/btcsuite/btcd/commit/2f508b3f86ed9ef87bcf3426b87b6c0dc0d3632c "><code>2f508b3</code></a> Update CHANGES file for 0.22.1 release.</li>
<li><a href="https://github.com/btcsuite/btcd/commit/ff92d88504eb4fb0e09d4c09664c5162e9e51a1c "><code>ff92d88</code></a> btcd: bump version to v0.22.1.</li>
<li><a href="https://github.com/btcsuite/btcd/commit/cf5c461d91bcad304eae5d106d79d1a6138dc8a0 "><code>cf5c461</code></a> main: Switch to chaincfg/chainhash module.</li>
<li>See full diff in <a href="https://github.com/btcsuite/btcd/compare/v0.22.0-beta...v0.22.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-29 11:21:56 +00:00
297fcc0a7c
build(deps): Bump github.com/creachadair/tomledit from 0.0.18 to 0.0.19 ( #8440 )
...
Bumps [github.com/creachadair/tomledit](https://github.com/creachadair/tomledit ) from 0.0.18 to 0.0.19.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/creachadair/tomledit/commit/0692e4157ab4d6f462f193a34c64fd36ed046e64 "><code>0692e41</code></a> Release v0.0.19</li>
<li><a href="https://github.com/creachadair/tomledit/commit/d1160a474bfb13f6e1bc11e87b6f41ea53448775 "><code>d1160a4</code></a> Update default permissions.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/56f28f4ea0d3e46cfb700d32a1a987978d4c15ef "><code>56f28f4</code></a> Move transform tests to that package.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/3b8b380274179214af105fb08fc80eaf733f39ab "><code>3b8b380</code></a> Add permissions to CI workflow.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/409951b699618a43a8fe4ec9abab55e686c69df2 "><code>409951b</code></a> Add a quotation test case.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/f35c8bec5cd9461158496d0227f5427cb06c00d4 "><code>f35c8be</code></a> parser: include line numbers in headings, mappings, and values</li>
<li><a href="https://github.com/creachadair/tomledit/commit/26acca1df827b8f8eaf980b5444b3694f3026965 "><code>26acca1</code></a> Regularize location formatting in diagnostics.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/3394f599e4005db38e64b7ad1e23e503f34d9fe0 "><code>3394f59</code></a> Add more parser test cases.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/5ce10cc05ab2003c6a47b7d33493c1116ab7a97c "><code>5ce10cc</code></a> Rename test file.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/29f3eb34c894b3b6f3f00633ee624b7d8a8201ca "><code>29f3eb3</code></a> Allow compliance tests to be skipped with -short.</li>
<li>See full diff in <a href="https://github.com/creachadair/tomledit/compare/v0.0.18...v0.0.19 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-29 10:59:15 +00:00
3d448e1ef8
crypto: cleanup tmhash package ( #8434 )
2022-04-28 22:21:43 -04:00
6faf506540
rpc: fix byte string decoding for URL parameters ( #8431 )
...
In #8397 I tried to remove all the cases where we needed to keep track of the
target type of parameters for JSON encoding, but there is one case still left:
When decoding parameters from URL query terms, there is no way to tell whether
or not we need base64 encoding without knowing whether the underlying type of
the target is string or []byte.
To fix this, keep track of parameters that are []byte valued when RPCFunc is
compiling its argument map, and use that when parsing URL query terms. Update
the tests accordingly.
2022-04-28 15:18:11 -07:00
d69bd64702
abci++: Vote extension cleanup ( #8402 )
...
* Split vote verification/validation based on vote extensions
Some parts of the code need vote extensions to be verified and
validated (mostly in consensus), and other parts of the code don't
because its possible that, in some cases (as per RFC 017), we won't have
vote extensions.
This explicitly facilitates that split.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only sign extensions in precommits, not prevotes
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Update privval/file.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Apply suggestions from code review
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Temporarily disable extension requirement again for E2E testing
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Reorganize comment for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Leave vote validation and pre-call nil check up to caller of VoteToProto
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Split complex vote validation test into multiple tests
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Universally enforce no vote extensions on any vote type but precommits
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Make error messages more generic
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Verify with vote extensions when constructing a VoteSet
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Expand comment for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add extension check for prevotes prior to signing votes
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix supporting test code to only inject extensions into precommits
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Separate vote malleation from signing in vote tests for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add extension signature length check and corresponding test
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Perform basic vote validation in CommitToVoteSet
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-04-28 13:53:44 -04:00
47d52fc78d
Use patched link-checker for periodic checks. ( #8430 )
...
In #8339 we pointed the markdown link checker action to a patched version that
has the up-to-date version of the underlying check tool. In doing so, I missed
the periodic cron job that runs the same workflow. Update it to use the patched
version also.
2022-04-28 06:44:56 -07:00
2a58ea3ab2
p2p: use nodeinfo less often ( #8427 )
2022-04-27 21:13:38 +00:00
1121698757
node: start rpc service after reactors ( #8426 )
2022-04-27 15:55:27 -04:00
8670678291
p2p: remove support for multiple transports and endpoints ( #8420 )
2022-04-27 14:29:19 -04:00
da1b871808
Unify RPC method signatures and parameter decoding ( #8397 )
...
Pass all parameters from JSON-RPC requests to their corresponding handlers
using struct types instead of positional parameters. This allows us to control
encoding of arguments using only the standard library, and to eliminate the
remaining special-purpose JSON encoding hooks in the server.
To support existing use, the server still allows arguments to be encoded in
JSON as either an array or an object.
Related changes:
- Rework the RPCFunc constructor to reduce reflection during RPC call service.
- Add request parameter wrappers for each RPC service method.
- Update the RPC Environment methods to use these types.
- Update the interfaces and shims derived from Environment to the new
signatures.
- Update and extend test cases.
2022-04-27 07:53:51 -07:00
e741d01231
fuzz: don't panic on expected errors ( #8423 )
...
In the conversion to Go 1.18 fuzzing in e4991fd862
2022-04-27 07:26:21 -07:00
b626b0a719
build(deps): Bump github.com/google/go-cmp from 0.5.7 to 0.5.8 ( #8422 )
...
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp ) from 0.5.7 to 0.5.8.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/go-cmp/releases ">github.com/google/go-cmp's releases</a>.</em></p>
<blockquote>
<h2>v0.5.8</h2>
<p>Reporter changes:</p>
<ul>
<li>(<a href="https://github-redirect.dependabot.com/google/go-cmp/issues/293 ">#293</a>) Fix printing of types in reporter output for interface and pointer types</li>
<li>(<a href="https://github-redirect.dependabot.com/google/go-cmp/issues/294 ">#294</a>) Use string formatting for slice of bytes in more circumstances</li>
</ul>
<p>Dependency changes:</p>
<ul>
<li>(<a href="https://github-redirect.dependabot.com/google/go-cmp/issues/292 ">#292</a>) Update minimum supported version to go1.13 and remove <code>xerrors</code> dependency</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/google/go-cmp/commit/f144a35ed4ac538fae93fa3783175108738f71b9 "><code>f144a35</code></a> Additional cleanup with Go 1.13 as minimal version (<a href="https://github-redirect.dependabot.com/google/go-cmp/issues/295 ">#295</a>)</li>
<li><a href="https://github.com/google/go-cmp/commit/63c2960be651bb95aaf14535bd5e36e86b6b5458 "><code>63c2960</code></a> remove xerrors (<a href="https://github-redirect.dependabot.com/google/go-cmp/issues/292 ">#292</a>)</li>
<li><a href="https://github.com/google/go-cmp/commit/71220fc3ca5513eaf3583d10fd18da893bc332d8 "><code>71220fc</code></a> Use string formatting for slice of bytes (<a href="https://github-redirect.dependabot.com/google/go-cmp/issues/294 ">#294</a>)</li>
<li><a href="https://github.com/google/go-cmp/commit/4664e24d52beca933d6f5378d36e1d405099115d "><code>4664e24</code></a> Fix printing of types in reporter output (<a href="https://github-redirect.dependabot.com/google/go-cmp/issues/293 ">#293</a>)</li>
<li><a href="https://github.com/google/go-cmp/commit/79433ace284e1270988886ec120ec5aa3d1d1776 "><code>79433ac</code></a> Run tests on Go 1.18 (<a href="https://github-redirect.dependabot.com/google/go-cmp/issues/290 ">#290</a>)</li>
<li>See full diff in <a href="https://github.com/google/go-cmp/compare/v0.5.7...v0.5.8 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-27 13:21:03 +00:00
c44e6d1799
build(deps): Bump github.com/vektra/mockery/v2 from 2.12.0 to 2.12.1 ( #8417 )
...
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery ) from 2.12.0 to 2.12.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vektra/mockery/releases ">github.com/vektra/mockery/v2's releases</a>.</em></p>
<blockquote>
<h2>v2.12.1</h2>
<h2>Changelog</h2>
<ul>
<li>facf60b Add extra test cases for increasing code coverage.</li>
<li>2e1360a Collapse if statements and rename interface in the fixtures.</li>
<li>8bdc90d Fix test on go1.18.</li>
<li>fe03b57 Fix tests.</li>
<li>b8c62f7 Fix: avoid package name collision with inPackage (<a href="https://github-redirect.dependabot.com/vektra/mockery/issues/291 ">#291</a>)</li>
<li>c9dc740 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/422 ">#422</a> from i-sevostyanov/fix-package-collision</li>
<li>58a7f18 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/452 ">#452</a> from grongor/refactor-first-letter-helper</li>
<li>749b2d6 Refactor mock name generation</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/vektra/mockery/commit/c9dc740b501040ef7b74c5b604d9a563c77695a4 "><code>c9dc740</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/422 ">#422</a> from i-sevostyanov/fix-package-collision</li>
<li><a href="https://github.com/vektra/mockery/commit/facf60b02e2114614d188d1ad0f5f3246ccea56b "><code>facf60b</code></a> Add extra test cases for increasing code coverage.</li>
<li><a href="https://github.com/vektra/mockery/commit/8bdc90da7a779c013b72cbb32d39d966f89ac667 "><code>8bdc90d</code></a> Fix test on go1.18.</li>
<li><a href="https://github.com/vektra/mockery/commit/fe03b57da511161db726e027fde9e429a03209d6 "><code>fe03b57</code></a> Fix tests.</li>
<li><a href="https://github.com/vektra/mockery/commit/2e1360ae46be92f472849afe1168e28a1a9f8eec "><code>2e1360a</code></a> Collapse if statements and rename interface in the fixtures.</li>
<li><a href="https://github.com/vektra/mockery/commit/b8c62f78586a7f10e5050b46cf3f6c14eef4156f "><code>b8c62f7</code></a> Fix: avoid package name collision with inPackage (<a href="https://github-redirect.dependabot.com/vektra/mockery/issues/291 ">#291</a>)</li>
<li><a href="https://github.com/vektra/mockery/commit/58a7f185bd39d793c31be845fc9f505df3ef7066 "><code>58a7f18</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/452 ">#452</a> from grongor/refactor-first-letter-helper</li>
<li><a href="https://github.com/vektra/mockery/commit/749b2d6fa5b566faedfc763d0a7ac7a5131a04bf "><code>749b2d6</code></a> Refactor mock name generation</li>
<li>See full diff in <a href="https://github.com/vektra/mockery/compare/v2.12.0...v2.12.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-26 15:01:57 +00:00
dcfbd9bc3d
abci++: Remove intermediate protos ( #8414 )
...
* Sync protos with their intermediates
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove intermediate protos and their supporting scripts
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* make proto-gen
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-26 08:02:17 -04:00
e36052c80e
crypto: remove unused code ( #8412 )
2022-04-25 12:35:59 -04:00
02c1c8ecb4
config: minor template infrastructure ( #8411 )
2022-04-25 12:08:22 -04:00
701eff8968
build(deps): Bump google.golang.org/grpc from 1.45.0 to 1.46.0 ( #8408 )
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.45.0 to 1.46.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases ">google.golang.org/grpc's releases</a>.</em></p>
<blockquote>
<h2>Release 1.46.0</h2>
<h1>New Features</h1>
<ul>
<li>server: Support setting <code>TCP_USER_TIMEOUT</code> on <code>grpc.Server</code> connections using <code>keepalive.ServerParameters.Time</code> (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5219 ">#5219</a>)
<ul>
<li>Special Thanks: <a href="https://github.com/bonnefoa "><code>@bonnefoa</code></a></li>
</ul>
</li>
<li>client: perform graceful switching of LB policies in the <code>ClientConn</code> by default (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5285 ">#5285</a>)</li>
<li>all: improve logging by including channelz identifier in log messages (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5192 ">#5192</a>)</li>
</ul>
<h1>API Changes</h1>
<ul>
<li>grpc: delete <code>WithBalancerName()</code> API, deprecated over 4 years ago in <a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/1697 ">#1697</a> (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5232 ">#5232</a>)</li>
<li>balancer: change BuildOptions.ChannelzParentID to an opaque identifier instead of int (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5192 ">#5192</a>)
<ul>
<li>Note: the balancer package is labeled as EXPERIMENTAL, and we don't believe users were using this field.</li>
</ul>
</li>
</ul>
<h1>Behavior Changes</h1>
<ul>
<li>client: change connectivity state to <code>TransientFailure</code> in <code>pick_first</code> LB policy when all addresses are removed (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5274 ">#5274</a>)
<ul>
<li>This is a minor change that brings grpc-go's behavior in line with the intended behavior and how C and Java behave.</li>
</ul>
</li>
<li>metadata: add client-side validation of HTTP-invalid metadata before attempting to send (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4886 ">#4886</a>)
<ul>
<li>Special Thanks: <a href="https://github.com/Patrick0308 "><code>@Patrick0308</code></a></li>
</ul>
</li>
</ul>
<h1>Bug Fixes</h1>
<ul>
<li>metadata: make a copy of the value slices in FromContext() functions so that modifications won't be made to the original copy (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5267 ">#5267</a>)</li>
<li>client: handle invalid service configs by applying the default, if applicable (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5238 ">#5238</a>)</li>
<li>xds: the xds client will now apply a 1 second backoff before recreating ADS or LRS streams (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5280 ">#5280</a>)</li>
</ul>
<h1>Dependencies</h1>
<ul>
<li>Upgrade security/authorization module dependencies to <a href="https://github.com/google/cel-go ">https://github.com/google/cel-go </a> v0.10.1 and others (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5243 ">#5243</a>)
<ul>
<li>Special Thanks: <a href="https://github.com/TristonianJones "><code>@TristonianJones</code></a></li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/grpc/grpc-go/commit/e8d06c51a523ba75f052cfaa56a1b8e0583ac589 "><code>e8d06c5</code></a> Change version to 1.46.0 (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5296 ">#5296</a>)</li>
<li><a href="https://github.com/grpc/grpc-go/commit/efbd542a4f9947d6b1392f538e3b0dd3d1c94b90 "><code>efbd542</code></a> gcp/observability: correctly test this module in presubmit tests (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5300 ">#5300</a>) (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5307 ">#5307</a>)</li>
<li><a href="https://github.com/grpc/grpc-go/commit/4467a29dbb390764f9792ce61af53017d621eb7c "><code>4467a29</code></a> gcp/observability: implement logging via binarylog (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5196 ">#5196</a>)</li>
<li><a href="https://github.com/grpc/grpc-go/commit/18fdf542fab01f909e600763267ef13770a222d5 "><code>18fdf54</code></a> cmd/protoc-gen-go-grpc: allow hooks to modify client structs and service hand...</li>
<li><a href="https://github.com/grpc/grpc-go/commit/337b815c4150a12d15349cb9be5f22fb391918de "><code>337b815</code></a> interop: build client without timeout; add logs to help debug failures (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5294 ">#5294</a>)</li>
<li><a href="https://github.com/grpc/grpc-go/commit/e583b196ce4717fdc024dd9432f8e4b229cc76e7 "><code>e583b19</code></a> xds: Add RLS in xDS e2e test (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5281 ">#5281</a>)</li>
<li><a href="https://github.com/grpc/grpc-go/commit/0066bf69deb33b0e5bee4de69090c3ef8f6991aa "><code>0066bf6</code></a> grpc: perform graceful switching of LB policies in the <code>ClientConn</code> by defaul...</li>
<li><a href="https://github.com/grpc/grpc-go/commit/3cccf6a43b55b4a089e832213b0e34df859e1978 "><code>3cccf6a</code></a> xdsclient: always backoff between new streams even after successful stream (#...</li>
<li><a href="https://github.com/grpc/grpc-go/commit/4e780933f85a4d0f6903d1a5bb57bb7c882e611d "><code>4e78093</code></a> xds: ignore routes with unsupported cluster specifiers (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5269 ">#5269</a>)</li>
<li><a href="https://github.com/grpc/grpc-go/commit/99aae3442dbe8495247dda07a6b1c8cda98accca "><code>99aae34</code></a> cluster manager: Add Graceful Switch functionality to Cluster Manager (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5265 ">#5265</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/grpc/grpc-go/compare/v1.45.0...v1.46.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-25 12:04:57 +00:00
a4190208a3
build(deps): Bump codecov/codecov-action from 3.0.0 to 3.1.0 ( #8406 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.0.0 to 3.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.0</h2>
<h2>3.1.0</h2>
<h3>Features</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/699 ">#699</a> Incorporate <code>xcode</code> arguments for the Codecov uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/694 ">#694</a> build(deps-dev): bump <code>@vercel/ncc</code> from 0.33.3 to 0.33.4</li>
<li><a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/696 ">#696</a> build(deps-dev): bump <code>@types/node</code> from 17.0.23 to 17.0.25</li>
<li><a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/698 ">#698</a> build(deps-dev): bump jest-junit from 13.0.0 to 13.2.0</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md ">codecov/codecov-action's changelog</a>.</em></p>
<blockquote>
<h2>3.1.0</h2>
<h3>Features</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/699 ">#699</a> Incorporate <code>xcode</code> arguments for the Codecov uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/694 ">#694</a> build(deps-dev): bump <code>@vercel/ncc</code> from 0.33.3 to 0.33.4</li>
<li><a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/696 ">#696</a> build(deps-dev): bump <code>@types/node</code> from 17.0.23 to 17.0.25</li>
<li><a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/698 ">#698</a> build(deps-dev): bump jest-junit from 13.0.0 to 13.2.0</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/81cd2dc8148241f03f5839d295e000b8f761e378 "><code>81cd2dc</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/699 ">#699</a> from codecov/feat-xcode</li>
<li><a href="https://github.com/codecov/codecov-action/commit/a03184e530bbc4843e9db4dd9ae563daa35f25d6 "><code>a03184e</code></a> feat: add xcode support</li>
<li><a href="https://github.com/codecov/codecov-action/commit/6a6a9ae7b12211d92c625894063bb7994c6d674a "><code>6a6a9ae</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/694 ">#694</a> from codecov/dependabot/npm_and_yarn/vercel/ncc-0.33.4</li>
<li><a href="https://github.com/codecov/codecov-action/commit/92a872a5e728d9d389f8edb836abe7428a7d3033 "><code>92a872a</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/696 ">#696</a> from codecov/dependabot/npm_and_yarn/types/node-17.0.25</li>
<li><a href="https://github.com/codecov/codecov-action/commit/43a9c182dd0940dd62fc624e66d669e9ab6c15d7 "><code>43a9c18</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/698 ">#698</a> from codecov/dependabot/npm_and_yarn/jest-junit-13.2.0</li>
<li><a href="https://github.com/codecov/codecov-action/commit/13ce822ccd6d5adcd9c336418bf7a4102a33419f "><code>13ce822</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/codecov/codecov-action/issues/690 ">#690</a> from codecov/ci-v3</li>
<li><a href="https://github.com/codecov/codecov-action/commit/4d6dbaaea68115935794d4491ce749e6308e526c "><code>4d6dbaa</code></a> build(deps-dev): bump jest-junit from 13.0.0 to 13.2.0</li>
<li><a href="https://github.com/codecov/codecov-action/commit/98f0f1930096ecddbe18b424e5cae74d3af90bc4 "><code>98f0f19</code></a> build(deps-dev): bump <code>@types/node</code> from 17.0.23 to 17.0.25</li>
<li><a href="https://github.com/codecov/codecov-action/commit/d3021d99107987a6310e03989b96d9d96fa037f9 "><code>d3021d9</code></a> build(deps-dev): bump <code>@vercel/ncc</code> from 0.33.3 to 0.33.4</li>
<li><a href="https://github.com/codecov/codecov-action/commit/2c83f35c201827cc1b2a250b2546ca9378d632f9 "><code>2c83f35</code></a> Update makefile to v3</li>
<li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/v3.0.0...v3.1.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-25 11:52:01 +00:00
5b38bc17b1
build(deps): Bump bufbuild/buf-setup-action from 1.3.1 to 1.4.0 ( #8405 )
...
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action ) from 1.3.1 to 1.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/bufbuild/buf-setup-action/releases ">bufbuild/buf-setup-action's releases</a>.</em></p>
<blockquote>
<h2>v1.4.0</h2>
<ul>
<li>Set the default buf version to v1.4.0</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/bufbuild/buf-setup-action/commit/b0ab76000216fc84245744f076ab4d2ef94276e6 "><code>b0ab760</code></a> Update to v1.4.0</li>
<li><a href="https://github.com/bufbuild/buf-setup-action/commit/60debd10936c466a1449da8114dc9b3b17d10596 "><code>60debd1</code></a> Revert "Add dependabot config (<a href="https://github-redirect.dependabot.com/bufbuild/buf-setup-action/issues/21 ">#21</a>)" (<a href="https://github-redirect.dependabot.com/bufbuild/buf-setup-action/issues/33 ">#33</a>)</li>
<li><a href="https://github.com/bufbuild/buf-setup-action/commit/e789cb128b4b65cd90baa6578eb693c641b68698 "><code>e789cb1</code></a> Add dependabot config (<a href="https://github-redirect.dependabot.com/bufbuild/buf-setup-action/issues/21 ">#21</a>)</li>
<li>See full diff in <a href="https://github.com/bufbuild/buf-setup-action/compare/v1.3.1...v1.4.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-25 11:50:11 +00:00
2e5d53ea9a
abci: interface should take pointers to arguments ( #8404 )
2022-04-24 18:37:07 +00:00
674908b130
abci: remove unneccessary implementations ( #8403 )
2022-04-24 12:01:39 -04:00
001449d536
Remove obsolete build tagged patch for net.Pipe. ( #8399 )
...
The p2p/conn library was using a build patch to work around an old issue with
the net.Conn type that has not existed since Go 1.10. Remove the workaround and
update usage to use the standard net.Pipe directly.
2022-04-23 09:57:42 -07:00
a5ecd418a6
abci: remove redundant methods in client ( #8401 )
2022-04-23 08:59:18 -04:00
20f8485080
Make encoding of HexBytes values more robust. ( #8398 )
...
The HexBytes wrapper type handles decoding byte strings from JSON. In the RPC
API, hashes are encoded as hex digits rather than the standard base64.
Simplify the implementation of this wrapper using the TextMarshaler interface,
which the encoding/json package uses for values (like these) that are meant to
be wrapped in JSON strings.
In addition, allow HexBytes values to be decoded from either hex OR base64
input. This preserves all existing use, but will allow us to remove some
reflection special cases in the RPC decoder plumbing.
Update tests to correctly tolerate empty/nil.
2022-04-22 18:02:41 -07:00
b5e6cf50d1
abci: Application should return errors errors and nilable response objects ( #8396 )
2022-04-22 20:40:42 -04:00
8345dc4f7c
abci: application type should take contexts ( #8388 )
2022-04-22 10:58:01 -04:00
6970c9177b
build(deps): Bump github.com/vektra/mockery/v2 from 2.11.0 to 2.12.0 ( #8393 )
2022-04-22 05:55:33 -07:00
383f9ea180
build(deps): Bump github.com/creachadair/tomledit from 0.0.16 to 0.0.18 ( #8392 )
...
Bumps [github.com/creachadair/tomledit](https://github.com/creachadair/tomledit ) from 0.0.16 to 0.0.18.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/creachadair/tomledit/commit/5802e262c618d4bdf43e34a2b0acdb8b383c9b15 "><code>5802e26</code></a> Release v0.0.18</li>
<li><a href="https://github.com/creachadair/tomledit/commit/3c9daf1a4a5909de0f844e4442c617e32c0cdb72 "><code>3c9daf1</code></a> document that we don't validate</li>
<li><a href="https://github.com/creachadair/tomledit/commit/da8c938af4e829f08d45b5a19e605257d28c55e1 "><code>da8c938</code></a> Remove non-applicable test cases.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/ac4210b0d1ecc1e1e329bdafe7c1a4c6cb573d4d "><code>ac4210b</code></a> parser: ensure unclosed arrays are not treated as empty</li>
<li><a href="https://github.com/creachadair/tomledit/commit/f98f82fec19c6ba31f291640f1838fe4b0cef907 "><code>f98f82f</code></a> parser: ensure array separators are present</li>
<li><a href="https://github.com/creachadair/tomledit/commit/ea1671ecca600b7c0ac1b678db49a166c1dcd710 "><code>ea1671e</code></a> scanner: clean up some issues in escape and space handling</li>
<li><a href="https://github.com/creachadair/tomledit/commit/8168589a259aa852ece434f16f3724e0d38d5fc9 "><code>8168589</code></a> scanner: filter bad commas in numeric literals</li>
<li><a href="https://github.com/creachadair/tomledit/commit/83189e20b796d4ea3900543f4e45306fbfc02005 "><code>83189e2</code></a> scanner: fix some issues in multiline string recognition</li>
<li><a href="https://github.com/creachadair/tomledit/commit/bdc8e22990cc513736e476b2ecab58ae185058aa "><code>bdc8e22</code></a> scanner: allow space separators in date-time strings</li>
<li><a href="https://github.com/creachadair/tomledit/commit/1ab2c8d654dd5ec8798febf095e67cc73d4da524 "><code>1ab2c8d</code></a> Add compliance tests.</li>
<li>Additional commits viewable in <a href="https://github.com/creachadair/tomledit/compare/v0.0.16...v0.0.18 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-22 12:22:20 +00:00
ef314708e7
RFC 019: Configuration File Versioning ( #8379 )
...
This RFC discusses issues in how we migrate configuration data across
Tendermint versions, and some options for how to improve the experience for
node operators in the future.
2022-04-21 10:08:47 -07:00
f0db0ff260
abci: streamline grpc application construction ( #8383 )
...
In my mind this is "don't make grpc any weirder than it has to be."
We definitely don't need to export this type: if you're using gRPC for
ABCI you *probably* don't want to also depend on the huge swath of the
code that
The ideal case is you generate the proto yourself, standup a gRPC
service on your own (presumably because your application has other
gRPC services that you want to expose,) and then your application
doesn't need to interact with the types package at all. This is
definitely the case for anyone who uses gRPC and doesn't use Go (which
is likely the predominant use case.)
If you're using Go, and want to use tendermint's service runner for
running your gRPC service, you can, but at this point (as before,)
you're already importing the `types` package (and you were before,)
I've just eliminated an intermediate type that you shouldn't need to
think about.
Reviewers: I think the change is pretty rote, but the logic/user-story
above would definitely be better for being validated by someone other
than me. :)
2022-04-21 16:21:11 +00:00
9d49c4b9af
Add config samples from TM v26, v27, v28, v29. ( #8384 )
2022-04-21 08:54:07 -07:00
b4da12815f
test/fuzz/tests: remove debug logging statement ( #8385 )
2022-04-21 10:26:07 -04:00
cbae5f9f53
abci: avoid having untracked requests in the channel ( #8382 )
...
It seems to me that by adding requests to the clients tracker (the
`reqSent` linked list), then there's no need to actually drain the
channel, becuase we will mark all of these requests as done/errored
(which propogates to users, as users never get future objects any
more), and then the GC can reap all of the request objects and the
channel accordingly.
2022-04-20 18:06:07 +00:00
d56392cee9
Add confix testdata for Tendermint v0.30. ( #8380 )
...
Some additional testdata I grabbed while writing up the draft of RFC 019.
2022-04-20 14:38:48 +00:00
29e5fbcc64
rpc: reformat method signatures and use a context ( #8377 )
...
I was digging around over here, and thought it'd be good to
cleanup/standardize the line formating on a few of these methods. Also
found a few cases where we could use contexts better so did a little
bit of cleanup there too!
2022-04-19 19:17:07 +00:00
e4991fd862
test/fuzz: convert to Go 1.18 native fuzzing ( #8359 )
2022-04-19 11:49:51 -07:00
ad249ca178
node: cleanup setup for indexer and evidence components ( #8378 )
2022-04-19 15:35:14 +00:00
d919a42f53
node: use signals rather than ephemeral contexts ( #8376 )
2022-04-19 15:13:01 +00:00
82585e1ce6
build(deps): Bump github.com/vektra/mockery/v2 from 2.10.6 to 2.11.0 ( #8374 )
...
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery ) from 2.10.6 to 2.11.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vektra/mockery/releases ">github.com/vektra/mockery/v2's releases</a>.</em></p>
<blockquote>
<h2>v2.11.0</h2>
<h2>Changelog</h2>
<ul>
<li>a0d98e4 Add constructor to the generated mocks</li>
<li>09de88a Fix Makefile (don't call "clean" during "all")</li>
<li>eddf049 Fix import</li>
<li>b4d8eef Fix panic in tests</li>
<li>a328a65 Merge branch 'master' into add-constructor-for-mocks</li>
<li>32dd223 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/406 ">#406</a> from grongor/add-constructor-for-mocks</li>
<li>9489caf TMP-PLS-CHECK-AND-FIXUP fix rebase errors</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/vektra/mockery/commit/32dd2232929eeb9c8530e0bfa605420632a50f1e "><code>32dd223</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/406 ">#406</a> from grongor/add-constructor-for-mocks</li>
<li><a href="https://github.com/vektra/mockery/commit/eddf0493df757548872f968328af46424b4ec47a "><code>eddf049</code></a> Fix import</li>
<li><a href="https://github.com/vektra/mockery/commit/a328a65522163f57362a87bb2b1c3e2292ad446d "><code>a328a65</code></a> Merge branch 'master' into add-constructor-for-mocks</li>
<li><a href="https://github.com/vektra/mockery/commit/b4d8eef500863d393b7945371e0f00d50f51f397 "><code>b4d8eef</code></a> Fix panic in tests</li>
<li><a href="https://github.com/vektra/mockery/commit/9489caf271b971bec78f092c154736e2da14f19b "><code>9489caf</code></a> TMP-PLS-CHECK-AND-FIXUP fix rebase errors</li>
<li><a href="https://github.com/vektra/mockery/commit/09de88af6027682a13718f3bed3ef6865f9c1a84 "><code>09de88a</code></a> Fix Makefile (don't call "clean" during "all")</li>
<li><a href="https://github.com/vektra/mockery/commit/a0d98e44bd9c4a9587ac0a3fb35a4cdfe292cb4a "><code>a0d98e4</code></a> Add constructor to the generated mocks</li>
<li>See full diff in <a href="https://github.com/vektra/mockery/compare/v2.10.6...v2.11.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-19 14:02:49 +00:00
a1104b98d2
abci++: Sync implementation and spec for vote extensions ( #8141 )
...
* Refactor so building and linting works
This is the first step towards implementing vote extensions: generating
the relevant proto stubs and getting the build and linter to pass.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix typo
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Better describe method given vote extensions
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix types tests
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Move CanonicalVoteExtension to canonical types proto defs
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Regenerate protos including latest PBTS synchrony params update
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Inject vote extensions into proposal
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Thread vote extensions through code and fix tests
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove extraneous empty value initialization
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix lint
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix missing VerifyVoteExtension request data
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Explicitly ensure length > 0 to sign vote extension
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Explicitly ensure length > 0 to sign vote extension
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove extraneous comment
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Update privval/file.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Update types/vote_test.go
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
* Format
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Fix ABCI proto generation scripts for Linux
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Sync intermediate and goal protos
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Update internal/consensus/common_test.go
Co-authored-by: Sergio Mena <sergio@informal.systems >
* Use dummy value with clearer meaning
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Rewrite loop for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Panic on ABCI++ method call failure
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add strong correctness guarantees when constructing extended commit info for ABCI++
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add strong guarantee in extendedCommitInfo that the number of votes corresponds
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Make extendedCommitInfo function more robust
At first extendedCommitInfo expected votes to be in the same order as
their corresponding validators in the supplied CommitInfo struct, but
this proved to be rather difficult since when a validator set's loaded
from state it's first sorted by voting power and then by address.
Instead of sorting the votes in the same way, this approach simply maps
votes to their corresponding validator's address prior to constructing
the extended commit info. This way it's easy to look up the
corresponding vote and we don't need to care about vote order.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove extraneous validator address assignment
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Sign over canonical vote extension
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Validate vote extension signature against canonical vote extension
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Update privval tests for more meaningful dummy value
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add vote extension capability to E2E test app
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Disable lint for weak RNG usage for test app
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Use parseVoteExtension instead of custom parsing in PrepareProposal
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only include extension if we have received txs
It's unclear at this point why this is necessary to ensure that the
application's local app_hash matches that committed in the previous
block.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Require app_hash from app to match that from last block
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add contrived (possibly flaky) test to check that vote extensions code works
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove workaround for problem now solved by #8229
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* add tests for vote extension cases
* Fix spelling mistake to appease linter
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Collapse redundant if statement
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Formatting
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Always expect an extension signature, regardless of whether an extension is present
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Votes constructed from commits cannot include extensions or signatures
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Pass through vote extension in test helpers
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Temporarily disable vote extension signature requirement
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Expand on vote equality test errors for clarity
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Expand on vote matching error messages in testing
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Allow for selective subscription by vote type
This is an attempt to fix the intermittently failing
`TestPrepareProposalReceivesVoteExtensions` test in the internal
consensus package.
Occasionally we get prevote messages via the subscription channel, and
we're not interested in those. This change allows us to specify what
types of votes we're interested in (i.e. precommits) and discard the
rest.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Read lock consensus state mutex in test helper to avoid data race
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Revert BlockIDFlag parameter in node test
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Perform additional check in ProcessProposal for special txs generated by vote extensions
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* e2e: check that our added tx does not cause all txs to exceed req.MaxTxBytes
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only set vote extension signatures when signing is successful
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove channel capacity constraint in test helper to avoid missing messages
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add TODO to always require extension signatures in vote validation
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* e2e: reject vote extensions if the request height does not match what we expect
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* types: remove extraneous call to voteWithoutExtension in test
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove unnecessary address parameter from CanonicalVoteExtension
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* privval: change test vote type to precommit since we use an extension
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* privval: update signing logic to cater for vote extensions
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* proto: update field descriptions for vote message
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* proto: update field description for vote extension sig in vote message
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* proto/types: use fixed-length 64-bit integers for rounds in CanonicalVoteExtension
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* consensus: fix flaky TestPrepareProposalReceivesVoteExtensions
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* consensus: remove previously added test helper functionality
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* e2e: add error logs when we get an unexpected height in ExtendVote or VerifyVoteExtension requests
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* node_test: get validator addresses from privvals
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* privval/file_test: optimize filepv creation in tests
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* privval: add test to check that vote extensions are always signed
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Add a script to check documentation for ToC entries. (#8356 )
This script verifies that each document in the docs and architecture directory
has a corresponding table-of-contents entry in its README file. It can be run
manually from the command line.
- Hook up this script to run in CI (optional workflow).
- Update ADR ToC to include missing entries this script found.
* build(deps): Bump async from 2.6.3 to 2.6.4 in /docs (#8357 )
Bumps [async](https://github.com/caolan/async ) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases )
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md )
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4 )
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* privval/file_test: reset vote ext sig before signing
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
Co-authored-by: Sergio Mena <sergio@informal.systems >
Co-authored-by: William Banfield <wbanfield@gmail.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-19 08:05:17 -04:00
9ea0e5efa7
cleanup: pin get-diff-action uses to major version only, not minor/patch ( #8368 )
2022-04-18 22:49:26 +00:00
efd4f4a40b
cleanup: unused parameters ( #8372 )
2022-04-18 16:45:21 -04:00
c372390fea
eventbus: publish without contexts ( #8369 )
2022-04-18 16:28:31 -04:00
889341152a
p2p: fix setting in con-tracker ( #8370 )
2022-04-18 15:49:11 -04:00
7243ef71e2
Forward port changelog from v0.35.4 to master. ( #8364 )
2022-04-18 14:21:05 +00:00
bebfd8663b
build(deps): Bump github.com/creachadair/atomicfile from 0.2.4 to 0.2.5 ( #8365 )
...
Bumps [github.com/creachadair/atomicfile](https://github.com/creachadair/atomicfile ) from 0.2.4 to 0.2.5.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/creachadair/atomicfile/commit/b8ff50ef6878d7de4e8360ae09809598ecdc7bfa "><code>b8ff50e</code></a> Release v0.2.5.</li>
<li><a href="https://github.com/creachadair/atomicfile/commit/95084abf9a2952f56a164856dd4170dff5bbe4cf "><code>95084ab</code></a> Update actions/setup-go to v3.</li>
<li><a href="https://github.com/creachadair/atomicfile/commit/10d28f61c35c292e4452e03ca09b2846259f8c41 "><code>10d28f6</code></a> Update actions/checkout to v3.</li>
<li><a href="https://github.com/creachadair/atomicfile/commit/5f1989ddccaef90e5412825d871cff9c0726dfd5 "><code>5f1989d</code></a> Use a more explanatory temp file prefix.</li>
<li><a href="https://github.com/creachadair/atomicfile/commit/7819ee53ec29a78342151ff25ef3759229a38456 "><code>7819ee5</code></a> Add Go 1.18 to the CI workflow.</li>
<li><a href="https://github.com/creachadair/atomicfile/commit/c30fad6a27094dd1fdd2a76a5d49a057f7f7ba33 "><code>c30fad6</code></a> Drop old Go versions from CI.</li>
<li><a href="https://github.com/creachadair/atomicfile/commit/ebcfa6b22a611fa86a8eaae74588bb46b68efc3d "><code>ebcfa6b</code></a> acat: use WriteData to simplify the code</li>
<li>See full diff in <a href="https://github.com/creachadair/atomicfile/compare/v0.2.4...v0.2.5 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-04-18 12:48:09 +00:00
851c0dc4f3
build(deps): Bump async from 2.6.3 to 2.6.4 in /docs ( #8357 )
...
Bumps [async](https://github.com/caolan/async ) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases )
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md )
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4 )
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-15 20:48:10 -04:00
767e2ec8a2
Add a script to check documentation for ToC entries. ( #8356 )
...
This script verifies that each document in the docs and architecture directory
has a corresponding table-of-contents entry in its README file. It can be run
manually from the command line.
- Hook up this script to run in CI (optional workflow).
- Update ADR ToC to include missing entries this script found.
2022-04-15 12:15:35 -07:00
43f92806fd
Update pending changelog for #8352 . ( #8354 )
...
I forgot to add this before merging. 🙁
2022-04-14 23:07:59 +00:00
Sam Kleinman
dependabot[bot]
M. J. Fromberger
Thane Thomson
elias-orijtech