Files
tendermint/consensus
Anton Kaliaev 65909a13d5 consensus: stricter on LastCommitRound check (#4970)
LastCommitRound should always be >= 0 for heights > 1.

In State.updateToState, last precommit is computed  only when round
greater than -1 and has votes. But "LastCommit" is always updated
regardless of the condition. If there's no last precommit, "LastCommit"
is set to (*types.VoteSet)(nil). That's why "LastCommit" can be -1 for
heights > 1.

To fix it, only update State.RoundState.LastCommit when there is last
precommit.

Fixes #2737

Co-authored-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
2020-06-10 11:13:38 +04:00
..
2020-06-04 16:34:56 +02:00
2020-04-29 10:47:00 +02:00
2020-06-08 10:16:35 +00:00
2020-06-08 10:16:35 +00:00
2020-06-08 10:16:35 +00:00
2020-06-04 16:34:56 +02:00
2019-10-30 12:25:58 -07:00