Anton Kaliaev 65909a13d5 consensus: stricter on LastCommitRound check (#4970) ...

LastCommitRound should always be >= 0 for heights > 1.

In State.updateToState, last precommit is computed  only when round
greater than -1 and has votes. But "LastCommit" is always updated
regardless of the condition. If there's no last precommit, "LastCommit"
is set to (*types.VoteSet)(nil). That's why "LastCommit" can be -1 for
heights > 1.

To fix it, only update State.RoundState.LastCommit when there is last
precommit.

Fixes #2737

Co-authored-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>

2020-06-10 11:13:38 +04:00

..

codec.go

format: add format cmd & goimport repo (#4586)

2020-03-23 09:19:26 +01:00

height_vote_set_test.go

ints: stricter numbers (#4939)

2020-06-04 16:34:56 +02:00

height_vote_set.go

migrate all JSON to new JSON encoder (#4975)

2020-06-08 12:22:59 +00:00

peer_round_state.go

ints: stricter numbers (#4939)

2020-06-04 16:34:56 +02:00

round_state_test.go

format: add format cmd & goimport repo (#4586)

2020-03-23 09:19:26 +01:00

round_state.go

consensus: stricter on LastCommitRound check (#4970)

2020-06-10 11:13:38 +04:00