mirror of https://github.com/tendermint/tendermint.git synced 2026-01-05 04:55:18 +00:00

Files

Anton Kaliaev dc101f2eff mempool: disable MaxBatchBytes (#5800 )

@p4u from vocdoni.io reported that the mempool might behave incorrectly under a
high load. The consequences can range from pauses between blocks to the peers
disconnecting from this node.

My current theory is that the flowrate lib we're using to control flow
(multiplex over a single TCP connection) was not designed w/ large blobs
(1MB batch of txs) in mind.

I've tried decreasing the Mempool reactor priority, but that did not
have any visible effect. What actually worked is adding a time.Sleep
into mempool.Reactor#broadcastTxRoutine after an each successful send ==
manual control flow of sort.

As a temporary remedy (until the mempool package
is refactored), the max-batch-bytes was disabled. Transactions will be sent
one by one without batching

Closes #5796

2020-12-21 20:29:31 +04:00

1.0 KiB

Raw Blame History

Unreleased Changes

v0.34.1

Special thanks to external contributors on this release:

@p4u from vocdoni.io reported that the mempool might behave incorrectly under a high load. The consequences can range from pauses between blocks to the peers disconnecting from this node. As a temporary remedy (until the mempool package is refactored), the max-batch-bytes was disabled. Transactions will be sent one by one without batching.

Friendly reminder, we have a bug bounty program.

BREAKING CHANGES

CLI/RPC/Config
- [cli] #5786 deprecate snake_case commands for hyphen-case (@cmwaters)
Apps
P2P Protocol
Go API
Blockchain Protocol

FEATURES

IMPROVEMENTS

[mempool] #5813 Add keep-invalid-txs-in-cache config option. When set to true, mempool will keep invalid transactions in the cache (@p4u)

BUG FIXES

[crypto] #5707 Fix infinite recursion in string formatting of Secp256k1 keys (@erikgrinaker)
[mempool] #5800 Disable max-batch-bytes (@melekes)

1.0 KiB Raw Blame History