Merge pull request #889 from ffd2subroutine/minor-code-cleanup

Minor code cleanup
This commit is contained in:
Steve Kriss
2018-09-30 13:45:45 -06:00
committed by GitHub
+6 -4
View File
@@ -57,8 +57,7 @@ func (a *serviceAction) Execute(obj runtime.Unstructured, restore *api.Restore)
delete(spec, "clusterIP")
}
err = deleteNodePorts(obj, &spec)
if err != nil {
if err := deleteNodePorts(obj, &spec); err != nil {
return nil, nil, err
}
return obj, nil, nil
@@ -85,14 +84,17 @@ func getPreservedPorts(obj runtime.Unstructured) (map[string]bool, error) {
}
func deleteNodePorts(obj runtime.Unstructured, spec *map[string]interface{}) error {
if serviceType, _ := collections.GetString(*spec, "type"); serviceType == "ExternalName" {
return nil
}
preservedPorts, err := getPreservedPorts(obj)
if err != nil {
return err
}
ports, err := collections.GetSlice(obj.UnstructuredContent(), "spec.ports")
serviceType, _ := collections.GetString(*spec, "type")
if err != nil && serviceType != "ExternalName" {
if err != nil {
return err
}