mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-10-22 06:13:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

e2e: document the StorageClass flag instead of editing test data

Browse Source 
The CSI-on-kind section told readers to sed the provisioner in
test/testdata/storage-class/kind.yaml, with a warning not to commit it,
because nothing on main could point the suite at a different definition.
--storage-class-file can, so describe that instead.

The manifest is given inline rather than referencing a file in the tree,
so the instructions do not depend on which CSI test data happens to
exist, and the warning about mutating shared test data goes away with
the sed.

Signed-off-by: krishhna24 <krishhnatupedev@gmail.com>
This commit is contained in:
krishhna24
2026-10-10 05:01:56 +05:30
parent 8c59d546b0
commit 3ee33e26e4
1 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/e2e/README.md
+20 -7
View File
@@ -207,17 +207,30 @@ Every CSI label has to be named in the filter. A Ginkgo label filter matches a
bare token by exact equality and not as a substring, so `CSISnapshot` does not
select a case labelled `CSIVolumeGroupSnapshot`.
The PVCs those cases create have to land on a CSI-backed StorageClass. The suite
builds `e2e-storage-class` from the provider's file, and the kind one uses the
local-path provisioner, so until that definition is configurable the file has to
be pointed at `hostpath.csi.k8s.io` locally:
The PVCs those cases create have to land on a CSI-backed StorageClass. The kind
provider file uses the local-path provisioner, so point the suite at a CSI
definition rather than editing the shared file, which every other kind job reads:
``` yaml
# /tmp/kind-csi-sc.yaml
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: e2e-storage-class
provisioner: hostpath.csi.k8s.io
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
```
``` bash
# local change, do not commit it: every other kind job reads this file
sed -i 's|^provisioner: rancher.io/local-path$|provisioner: hostpath.csi.k8s.io|' \
test/testdata/storage-class/kind.yaml
STORAGE_CLASS_FILE=/tmp/kind-csi-sc.yaml
```
`STORAGE_CLASS_FILE` changes only the definition. The class is still named
`e2e-storage-class`, so no spec needs to know about it, and a relative path is
resolved from `test/e2e` like the default provider file.
Kibishii brings its own StorageClass for the cases that use it
(`kubernetes/yaml/kind/kibishiiKINDStorageClass.yaml` in
`vmware-tanzu-experiments/distributed-data-generator`), which is also local-path,