mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-08-21 06:36:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

assert expected errors from the test case rather than the returned error (#10312)

Browse Source 
* assert expected errors from the test case rather than the returned error

Signed-off-by: samay43 <samayrbhat43@gmail.com>

* add changelog entry

Signed-off-by: samay43 <samayrbhat43@gmail.com>

---------

Signed-off-by: samay43 <samayrbhat43@gmail.com>
This commit is contained in:
R4mbo
2026-08-18 00:25:36 -04:00
committed by GitHub
parent 83de7cab47
commit 526ea5ef00
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changelogs/unreleased/10312-samay43
+1
View File
@@ -0,0 +1 @@
Assert expected errors from the test case rather than the returned error in pkg/util/csi tests
pkg/util/csi/volume_snapshot_test.go
+3 -3
View File
@@ -202,7 +202,7 @@ func TestWaitVolumeSnapshotReady(t *testing.T) {
fakeClient := snapshotFake.NewSimpleClientset(test.clientObj...)
vs, err := WaitVolumeSnapshotReady(t.Context(), fakeClient.SnapshotV1(), test.vsName, test.namespace, time.Millisecond, velerotest.NewLogger())
if err != nil {
if test.err != "" {
require.EqualError(t, err, test.err)
} else {
require.NoError(t, err)
@@ -288,7 +288,7 @@ func TestGetVolumeSnapshotContentForVolumeSnapshot(t *testing.T) {
fakeClient := snapshotFake.NewSimpleClientset(test.clientObj...)
vs, err := GetVolumeSnapshotContentForVolumeSnapshot(context.TODO(), test.snapshotObj, fakeClient.SnapshotV1())
if err != nil {
if test.err != "" {
require.EqualError(t, err, test.err)
} else {
require.NoError(t, err)
@@ -417,7 +417,7 @@ func TestEnsureDeleteVS(t *testing.T) {
}
err := EnsureDeleteVS(t.Context(), fakeSnapshotClient.SnapshotV1(), test.vsName, test.namespace, time.Millisecond)
if err != nil {
if test.err != "" {
assert.EqualError(t, err, test.err)
} else {
assert.NoError(t, err)