Log the already deleted kopia snapshot with the repository logger

Other code in the kopia repository uses its logger without a nil check,
so drop the check and give the test a logger to cover the path.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Co-Authored-By: Claude Code (model: Claude Opus 5.5) <noreply@anthropic.com>
This commit is contained in:
Tiger KaovilaiandClaude Code committed 2026-10-24 20:35:44 -04:00
1 parent 5dde68f51b
commit 61b61769d1
2 files changed
+2 -3

No files matched your search

+1 -3
View File
@@ -748,9 +748,7 @@ func (kr *kopiaRepository) DeleteSnapshot(ctx context.Context, id udmrepo.ID) er
// The snapshot was already deleted, e.g. by a backup deletion that was
// interrupted after deleting it, so there is nothing left to do.
if errors.Is(err, snapshot.ErrSnapshotNotFound) {
if kr.logger != nil {
kr.logger.Infof("Snapshot %s is not found after repo refresh, it is already deleted", id)
}
kr.logger.Infof("Snapshot %s is not found after repo refresh, it is already deleted", id)
return nil
}
return errors.Wrap(err, "error getting snapshot after repo refresh")
@@ -1795,6 +1795,7 @@ func TestDeleteSnapshot(t *testing.T) {
kr := &kopiaRepository{
rawRepo: rawRepo,
rawWriter: rawWriter,
logger: velerotest.NewLogger(),
}
err := kr.DeleteSnapshot(t.Context(), tc.snapshotID)