mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-08-21 06:36:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid io.ReadAll in buildFinalTarball() (#10311)
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Details
e2e-test-kind.yaml / extract (push) Failing after 10s
Details
Run the E2E test on kind / get-go-version (push) Failing after 11s
Details
Run the E2E test on kind / build (push) Skipped
Details
Run the E2E test on kind / run-e2e-test (push) Skipped
Details
push.yml / extract (push) Failing after 8s
Details
Main CI / get-go-version (push) Failing after 9s
Details
Main CI / Build (push) Skipped
Details

Browse Source 
This commit updates the func buildFinalTarball so it won't use
io.ReadAll, in order to optimize memory usage.

Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
This commit is contained in:
Daniel Jiang
2026-08-18 16:41:22 +08:00
committed by GitHub
parent 9835559c60
commit 763f3a1db4
1 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/backup/backup.go
+1 -10
View File
@@ -1263,21 +1263,12 @@ func buildFinalTarball(tr *tar.Reader, tw tarWriter, updateFiles map[string]File
return errors.WithStack(err)
}
delete(updateFiles, header.Name)
// skip over file contents from old tarball
_, err := io.ReadAll(tr)
if err != nil {
return errors.WithStack(err)
}
} else {
// Add original content to new tarball, as item wasn't updated
oldContents, err := io.ReadAll(tr)
if err != nil {
return errors.WithStack(err)
}
if err := tw.WriteHeader(header); err != nil {
return errors.WithStack(err)
}
if _, err := tw.Write(oldContents); err != nil {
if _, err := io.Copy(tw, tr); err != nil {
return errors.WithStack(err)
}
}