issue 8391: check ErrCancelled from suffix

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
This commit is contained in:
Lyndon-Li
2024-11-12 18:32:38 +08:00
parent 1fbd22f353
commit 7feda11e54
3 changed files with 4 additions and 2 deletions
+1
View File
@@ -0,0 +1 @@
Fix issue #8391, check ErrCancelled from suffix of data mover pod's termination message
+2 -1
View File
@@ -20,6 +20,7 @@ import (
"context"
"encoding/json"
"os"
"strings"
"sync"
"time"
@@ -321,7 +322,7 @@ func (ms *microServiceBRWatcher) startWatch() {
if lastPod.Status.Phase == v1.PodSucceeded {
ms.callbacks.OnCompleted(ms.ctx, ms.namespace, ms.taskName, funcGetResultFromMessage(ms.taskType, terminateMessage, ms.log))
} else {
if terminateMessage == ErrCancelled {
if strings.HasSuffix(terminateMessage, ErrCancelled) {
ms.callbacks.OnCancelled(ms.ctx, ms.namespace, ms.taskName)
} else {
ms.callbacks.OnFailed(ms.ctx, ms.namespace, ms.taskName, errors.New(terminateMessage))
+1 -1
View File
@@ -360,7 +360,7 @@ func TestStartWatch(t *testing.T) {
event: &v1.Event{Reason: EventReasonStopped},
},
},
terminationMessage: ErrCancelled,
terminationMessage: fmt.Sprintf("Failed to init data path service for DataUpload %s: %v", "fake-du-name", errors.New(ErrCancelled)),
expectStartEvent: true,
expectTerminateEvent: true,
expectCancel: true,