mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-10-22 06:13:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix build: t.Context() needs Go 1.24, this branch pins Go 1.23
Run the E2E test on kind / build (push) Failing after 5m1s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Details
Run the E2E test on kind / run-e2e-test (push) Skipped
Details

Browse Source 
release-1.16's go.mod pins go 1.23.0/1.23.11. t.Context() was added in
Go 1.24, so the backported test failed to even compile (breaking both
Run CI and Run Linter Check identically, since golangci-lint's
typecheck pass hits the same compile error). Use context.TODO(),
matching every other Reconcile() call in this test file.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
This commit is contained in:
Tiger Kaovilai
2026-08-27 23:50:17 -04:00
parent dc8f065a92
commit 9c6782baa8
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/controller/backup_deletion_controller_test.go
+1 -1
View File
@@ -460,7 +460,7 @@ func TestBackupDeletionControllerReconcile(t *testing.T) {
td.backupStore.On("GetBackupContents", input.Spec.BackupName).Return(io.NopCloser(bytes.NewReader([]byte("hello world"))), nil)
td.backupStore.On("DeleteBackup", input.Spec.BackupName).Return(nil)
_, err := td.controller.Reconcile(t.Context(), td.req)
_, err := td.controller.Reconcile(context.TODO(), td.req)
require.NoError(t, err)
td.backupStore.AssertCalled(t, "DeleteBackup", input.Spec.BackupName)