Fix typo on tests fields name and add another test with gesture of errors wanted on equals

Signed-off-by: MatthieuFin <matthieu2717@gmail.com>
This commit is contained in:
MatthieuFin
2022-02-24 12:09:04 +01:00
parent f6bdfd09c5
commit a57298254f
+47 -3
View File
@@ -67,7 +67,7 @@ capabilities:
add:
- cap1
- cap2
sELinuxOptions:
seLinuxOptions:
user: userLabel
role: roleLabel
type: typeLabel
@@ -98,6 +98,46 @@ allowPrivilegeEscalation: false`},
AllowPrivilegeEscalation: boolptr.False(),
},
},
{
"valid securityContext with comments only secCtx key check seLinuxOptions is correctly parsed",
args{"", "", "", `
capabilities:
drop:
- ALL
add:
- cap1
- cap2
seLinuxOptions:
user: userLabelFail
role: roleLabel
type: typeLabel
level: levelLabel
# user www-data
runAsUser: 3333
# group www-data
runAsGroup: 3333
runAsNonRoot: true
readOnlyRootFilesystem: true
allowPrivilegeEscalation: false`},
true,
&corev1.SecurityContext{
RunAsUser: pointInt64(3333),
RunAsGroup: pointInt64(3333),
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"ALL"},
Add: []corev1.Capability{"cap1", "cap2"},
},
SELinuxOptions: &corev1.SELinuxOptions{
User: "userLabel",
Role: "roleLabel",
Type: "typeLabel",
Level: "levelLabel",
},
RunAsNonRoot: boolptr.True(),
ReadOnlyRootFilesystem: boolptr.True(),
AllowPrivilegeEscalation: boolptr.False(),
},
},
{
"valid securityContext with secCtx key override runAsUser runAsGroup and allowPrivilegeEscalation",
args{"1001", "999", "true", `
@@ -107,7 +147,7 @@ capabilities:
add:
- cap1
- cap2
sELinuxOptions:
seLinuxOptions:
user: userLabel
role: roleLabel
type: typeLabel
@@ -216,7 +256,7 @@ allowPrivilegeEscalation: false`},
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := ParseSecurityContext(tt.args.runAsUser, tt.args.runAsGroup, tt.args.allowPrivilegeEscalation, tt.args.secCtx)
if tt.wantErr {
if err != nil && tt.wantErr {
assert.Error(t, err)
return
}
@@ -226,6 +266,10 @@ allowPrivilegeEscalation: false`},
tt.expected = &corev1.SecurityContext{}
}
if tt.wantErr {
assert.NotEqual(t, *tt.expected, got)
return
}
assert.Equal(t, *tt.expected, got)
})
}