mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-08-15 11:46:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix broken docker login action (#3121)

Browse Source 
PR #3110 introduced a new action for performing the login to Dockerhub
as part of image building and pushing however there is an error with the
configuration and the credentials are not being passed through
correctly. This change reverts to the previous log in approach.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
This commit is contained in:
Bridget McErlean
2020-11-30 11:53:25 -08:00
committed by GitHub
parent c7531adda3
commit ad31e6eda7
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/push.yml
+3 -8
View File
@@ -41,13 +41,8 @@ jobs:
run: make test
# Only try to publish the container image from the root repo; forks don't have permission to do so and will always get failures.
- name: Login to DockerHub
if: github.repository == 'vmware-tanzu/velero'
uses: docker/login-action@v1
with:
username: ${{ secrets.DOCKERHUB_USER }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
- name: Publish container image
if: github.repository == 'vmware-tanzu/velero'
run: ./hack/docker-push.sh
run: |
docker login -u ${{ secrets.DOCKER_USER }} -p ${{ secrets.DOCKER_PASSWORD }}
./hack/docker-push.sh