golangci.yaml: comment out check-shawdowing, remove vet script

Per comment: https://github.com/vmware-tanzu/velero/pull/6154#issuecomment-1510946594

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

golangci.yaml

@@ -181,7 +181,7 @@ linters-settings:
         #     reason: "testing if blocked version constraint works."  # Reason why the version constraint exists. (Optional)
   govet:
     # report about shadowed variables
-    check-shadowing: true
+    # check-shadowing: true
 
     # settings per analyzer
     settings:
@@ -296,6 +296,7 @@ linters:
     - goheader
     - goimports
     - gosec
+    - govet
     - misspell
     - typecheck
     - unparam
@@ -340,4 +341,4 @@ severity:
   rules:
     - linters:
       - dupl
-      severity: info
+      severity: info

hack/verify-vet.sh

@@ -1,17 +0,0 @@
-#!/bin/bash
-#
-# Copyright 2023 the Velero contributors.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-go vet -mod=mod ./... || (echo "go vet is not happy, fix the errors above" && exit 1)