Remove username/password credential handling from newConfigCredential (#9041)

* remove username/password credential handling from newConfigCredential

Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* changelog update
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* remove username/password credential tests from newConfigCredential.
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

---------

Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

changelogs/unreleased/9041-priyansh17

@@ -0,0 +1 @@
+Removed username/password credential handling from newConfigCredential as azidentity.UsernamePasswordCredentialOptions is reported as deprecated.

pkg/util/azure/credential.go

@@ -113,17 +113,5 @@ func newConfigCredential(creds map[string]string, options configCredentialOption
 		return azidentity.NewClientCertificateCredential(tenantID, clientID, certs, key, o)
 	}
 
-	// username/password
-	if username := creds[CredentialKeyUsername]; username != "" {
-		if password := creds[CredentialKeyPassword]; password != "" {
-			return azidentity.NewUsernamePasswordCredential(tenantID, clientID, username, password,
-				&azidentity.UsernamePasswordCredentialOptions{ //nolint:staticcheck // will be solved by https://github.com/vmware-tanzu/velero/issues/9028
-					AdditionallyAllowedTenants: options.AdditionallyAllowedTenants,
-					ClientOptions:              options.ClientOptions,
-				})
-		}
-		return nil, errors.Errorf("%s is required", CredentialKeyPassword)
-	}
-
 	return nil, errors.New("incomplete credential configuration. Only AZURE_TENANT_ID and AZURE_CLIENT_ID are set")
 }

pkg/util/azure/credential_test.go

@@ -116,19 +116,6 @@ func Test_newConfigCredential(t *testing.T) {
 	require.NotNil(t, credential)
 	_, ok = credential.(*azidentity.ClientCertificateCredential)
 	require.True(t, ok)
-
-	// username/password
-	creds = map[string]string{
-		CredentialKeyTenantID: "clientid",
-		CredentialKeyClientID: "clientid",
-		CredentialKeyUsername: "username",
-		CredentialKeyPassword: "password",
-	}
-	credential, err = newConfigCredential(creds, options)
-	require.NoError(t, err)
-	require.NotNil(t, credential)
-	_, ok = credential.(*azidentity.UsernamePasswordCredential)
-	require.True(t, ok)
 }
 
 func readCertData() (string, error) {