Merge pull request #8538 from Lyndon-Li/hide-restic-deprecation-warning-for-install-crd-only
Run the E2E test on kind / build (push) Failing after 5m14s
Run the E2E test on kind / setup-test-matrix (push) Successful in 8s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 50s
Close stale issues and PRs / stale (push) Successful in 6s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m2s
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Failing after 52s

hide restic deprecation warning for install with crd-only
This commit is contained in:
lyndon-li
2024-12-20 16:00:33 +08:00
committed by GitHub
2 changed files with 6 additions and 5 deletions
+1
View File
@@ -0,0 +1 @@
Fix issue #8539, validate uploader types when o.CRDsOnly is set to false only since CRD installation doesn't rely on uploader types
+5 -5
View File
@@ -429,17 +429,17 @@ func (o *Options) Validate(c *cobra.Command, args []string, f client.Factory) er
return err
}
// If we're only installing CRDs, we can skip the rest of the validation.
if o.CRDsOnly {
return nil
}
if msg, err := uploader.ValidateUploaderType(o.UploaderType); err != nil {
return err
} else if msg != "" {
fmt.Printf("⚠️ %s\n", msg)
}
// If we're only installing CRDs, we can skip the rest of the validation.
if o.CRDsOnly {
return nil
}
// Our main 3 providers don't support bucket names starting with a dash, and a bucket name starting with one
// can indicate that an environment variable was left blank.
// This case will help catch that error