mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-07-20 15:03:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

updated to reflect moving VolumeHelper interface

Browse Source 
Signed-off-by: Scott Seago <sseago@redhat.com>
This commit is contained in:
Scott Seago
2026-02-10 12:17:07 -05:00
parent ddd83a66c5
commit eadacf43e1
1 changed files with 12 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
design/custom-volume-policy-action.md
+12 -20
View File
@@ -68,28 +68,20 @@ type VolumeHelper interface {
}
```
In `pkg/plugin/utils/volumehelper/volume_policy_helper.go`, the funcs
corresponding to the above will be added, which can be called by
plugins implementing custom volume actions:
```go
func ShouldPerformCustomActionWithVolumeHelper(
unstructured runtime.Unstructured,
groupResource schema.GroupResource,
map[string]any,
backup velerov1api.Backup,
crClient crclient.Client,
logger logrus.FieldLogger,
vh volumehelper.VolumeHelper,
) (bool, error)
In addition, since the VolumeHelper interface is expected to be called by external plugins, the interface (but not the implementation) should be moved from `internal/volumehelper` to `pkg/util/volumehelper`.
func GetActionParameters(
unstructured runtime.Unstructured,
groupResource schema.GroupResource,
backup velerov1api.Backup,
crClient crclient.Client,
In `pkg/plugin/utils/volumehelper/volume_policy_helper.go`, a new helper func will be added which delegates to the internal volumehelper.NewVolumeHelperImplWithNamespaces
```go
func NewVolumeHelper(
volumePolicy *resourcepolicies.Policies,
snapshotVolumes *bool,
logger logrus.FieldLogger,
vh volumehelper.VolumeHelper,
) (map[string]any, error)
client crclient.Client,
defaultVolumesToFSBackup bool,
backupExcludePVC bool,
namespaces []string,
) (VolumeHelper, error) {
```