mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-08-17 20:56:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cap the metadata decompression in object store (#10270)

Browse Source 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
This commit is contained in:
lyndon-li
2026-08-17 16:19:55 +08:00
committed by GitHub
parent 856c3398f7
commit ff4783470e
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changelogs/unreleased/10270-Lyndon-Li
+1
View File
@@ -0,0 +1 @@
Cap the metadata decompression in object store
pkg/persistence/object_store.go
+6 -2
View File
@@ -94,6 +94,7 @@ type BackupStore interface {
// DownloadURLTTL is how long a download URL is valid for.
const DownloadURLTTL = 10 * time.Minute
const maxDecompressedSize = 1024 * 1024 * 1024 // 1 GB
type objectBackupStore struct {
objectStore velero.ObjectStore
@@ -323,7 +324,8 @@ func (s *objectBackupStore) GetBackupMetadata(name string) (*velerov1api.Backup,
}
defer res.Close()
data, err := io.ReadAll(res)
limitReader := io.LimitReader(res, maxDecompressedSize)
data, err := io.ReadAll(limitReader)
if err != nil {
return nil, errors.WithStack(err)
}
@@ -434,7 +436,9 @@ func decode(jsongzReader io.Reader, into any) error {
}
defer gzr.Close()
if err := json.NewDecoder(gzr).Decode(into); err != nil {
limitReader := io.LimitReader(gzr, maxDecompressedSize)
if err := json.NewDecoder(limitReader).Decode(into); err != nil {
return errors.Wrap(err, "error decoding object data")
}