Tiger Kaovilai
8688568ffc
feat: Resolve caCertRef in object store getter for plugin compatibility
...
This change enables BSL validation to work when using caCertRef
(Secret-based CA certificate) by resolving the certificate from
the Secret in velero core before passing it to the object store
plugin as 'caCert' in the config map.
This approach requires no changes to provider plugins since they
already understand the 'caCert' config key.
Changes:
- Add SecretStore to objectBackupStoreGetter struct
- Add NewObjectBackupStoreGetterWithSecretStore constructor
- Update Get method to resolve caCertRef from Secret
- Update server.go to use new constructor with SecretStore
- Add CACertRef builder method and unit tests
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-12-12 21:07:38 +07:00
Tiger Kaovilai
61bf2ef777
feat: Enhance BackupStorageLocation with Secret-based CA certificate support
...
- Introduced `CACertRef` field in `ObjectStorageLocation` to reference a Secret containing the CA certificate, replacing the deprecated `CACert` field.
- Implemented validation logic to ensure mutual exclusivity between `CACert` and `CACertRef`.
- Updated BSL controller and repository provider to handle the new certificate resolution logic.
- Enhanced CLI to support automatic certificate discovery from BSL configurations.
- Added unit and integration tests to validate new functionality and ensure backward compatibility.
- Documented migration strategy for users transitioning from inline certificates to Secret-based management.
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-12-12 21:07:37 +07:00
Xun Jiang/Bruce Jiang
554b04e6ca
Merge pull request #9132 from mjnagel/crd-upgrade
...
Run the E2E test on kind / get-go-version (push) Failing after 56s
Run the E2E test on kind / build (push) Has been skipped
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / get-go-version (push) Successful in 13s
Main CI / Build (push) Failing after 25s
Close stale issues and PRs / stale (push) Successful in 12s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m36s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m16s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m13s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 1m4s
feat: add apply flag to install command
2025-12-10 16:41:56 +08:00
Xun Jiang/Bruce Jiang
c594026c1f
Merge pull request #9446 from vmware-tanzu/dependabot/github_actions/actions/stale-10.1.1
...
Run the E2E test on kind / get-go-version (push) Failing after 1m5s
Run the E2E test on kind / build (push) Has been skipped
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / get-go-version (push) Successful in 13s
Main CI / Build (push) Failing after 32s
Bump actions/stale from 10.1.0 to 10.1.1
2025-12-10 13:31:28 +08:00
Xun Jiang/Bruce Jiang
46776898ab
Merge branch 'main' into dependabot/github_actions/actions/stale-10.1.1
2025-12-10 11:34:29 +08:00
Xun Jiang/Bruce Jiang
fdcfed84f9
Add the node-agent ConfigMap document. ( #9434 )
...
Run the E2E test on kind / get-go-version (push) Failing after 1m1s
Run the E2E test on kind / build (push) Has been skipped
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / get-go-version (push) Successful in 13s
Main CI / Build (push) Failing after 31s
Close stale issues and PRs / stale (push) Successful in 15s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m45s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m9s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m6s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 1m14s
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2025-12-09 04:57:30 -05:00
dependabot[bot]
dbeb16aad7
Bump actions/stale from 10.1.0 to 10.1.1
...
Bumps [actions/stale](https://github.com/actions/stale ) from 10.1.0 to 10.1.1.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v10.1.0...v10.1.1 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-version: 10.1.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-12-08 19:02:57 +00:00
Shubham Pampattiwar
f0c97c489d
Merge pull request #9414 from shubham-pampattiwar/add-maintenance-job-metrics
...
Run the E2E test on kind / get-go-version (push) Failing after 1m8s
Run the E2E test on kind / build (push) Has been skipped
Run the E2E test on kind / setup-test-matrix (push) Successful in 5s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / get-go-version (push) Successful in 14s
Main CI / Build (push) Failing after 37s
Close stale issues and PRs / stale (push) Successful in 15s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m43s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 58s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m8s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 58s
Add Prometheus metrics for maintenance jobs
2025-12-08 09:23:44 -08:00
Micah Nagel
3244cc605f
feat: add apply flag to install command
...
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com >
2025-12-05 11:26:10 +08:00
Shubham Pampattiwar
6a0307142c
Merge pull request #9307 from sseago/parallel-backup
...
Run the E2E test on kind / get-go-version (push) Failing after 1m4s
Run the E2E test on kind / build (push) Has been skipped
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / get-go-version (push) Successful in 13s
Main CI / Build (push) Failing after 30s
Close stale issues and PRs / stale (push) Successful in 17s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m46s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m30s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m36s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 1m31s
Parallel backup processing
2025-12-04 11:37:24 -08:00
Shubham Pampattiwar
1ec622245b
Run make update to fix gofmt alignment
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
2025-12-03 16:13:13 -08:00
Shubham Pampattiwar
31fb828f8e
Add clarifying comment for histogram metric
...
Explain that the duration histogram tracks distribution of individual
job durations, not accumulated sums, to address reviewer concerns.
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
2025-12-03 16:05:32 -08:00
Scott Seago
7286d24c35
Updates for merge conflict and to refine reconciler queueing logic
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-03 16:55:59 -05:00
Scott Seago
7e4797f588
Track running backup count via BackupTracker
...
This avoids an unnecessary apiserver List call when
the backup reconciler is already at capacity.
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 17:23:47 -05:00
Scott Seago
f238a7e47b
make update
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 17:23:21 -05:00
Scott Seago
0b2e7d1238
Minor refactoring
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 17:23:21 -05:00
Scott Seago
73864e31ff
Fix linters
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 17:04:55 -05:00
Scott Seago
8a95d512b3
make update, changelog
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 17:04:07 -05:00
Scott Seago
4d1802233a
add various scenarios to queue controller unit tests
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 17:01:09 -05:00
Scott Seago
f73443659a
Backup queue controller implementation
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:57:18 -05:00
Scott Seago
7111f3cea2
feat: Remove pvc-for-tmp install arg
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:49:17 -05:00
Scott Seago
845eee4e60
feat: Create backup queue controller and add to disableable list
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:46:56 -05:00
Scott Seago
c50ab4a6ea
feat: Add pvc-for-tmp install arg to use PVC for server /tmp dir
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:40:49 -05:00
Scott Seago
6a3f821606
fix lint
...
Signed-off-by: Scott Seago <sseago@redhat.com >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:39:10 -05:00
Scott Seago
34dc381182
Refactor after review
...
Signed-off-by: Scott Seago <sseago@redhat.com >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:39:10 -05:00
Scott Seago
29b01c3170
make update
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:39:10 -05:00
Scott Seago
84571bc54d
Added doc note around parallel backups and resource limits
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:39:10 -05:00
Scott Seago
9c1c7d20ff
Minor refactoring
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:39:10 -05:00
Scott Seago
7bc57b5a5f
Refactor queue controller to reduce apiserver list calls
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:39:10 -05:00
Scott Seago
e7b5d20f4c
Fix linters
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:39:10 -05:00
Scott Seago
aedc0fe5e2
make update, changelog
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:39:07 -05:00
Scott Seago
dbaa25405d
move podVolumeContext into backupRequest
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:38:41 -05:00
Scott Seago
91357b28c4
Move worker pool creation to backup reconcile.
...
ItemBlockWorkerPool is now created for each backup.
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:38:41 -05:00
Scott Seago
e0c08f03cf
add various scenarios to queue controller unit tests
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:38:41 -05:00
Scott Seago
a56ab10f23
Move debug logs to info
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:38:41 -05:00
Scott Seago
d39ad6f208
run multiple backup reconcilers, only reconcile ReadyToStart backups
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:38:41 -05:00
Scott Seago
300bc70c68
Add queue position to backup list/describe
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:38:41 -05:00
Scott Seago
13041b40c2
Backup queue controller implementation
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:38:41 -05:00
Scott Seago
4ffb29d750
feat: Remove pvc-for-tmp install arg
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
fe799d7546
feat: Add concurrent backups configuration to backup reconciler
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
d91d50f696
feat: Add concurrentBackups to backupQueueReconciler
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
9dfa108579
feat: initialize backup queue controller
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
4cac891fb9
refactor: Extract backup-queue controller name to constant
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
5d02af3ce3
feat: Create backup queue controller and add to disableable list
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
2944c0dad4
update CRDs
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
cd103add11
feat: Add QueuePosition field to BackupStatus
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
dc91d6ee67
feat: Add pvc-for-tmp install arg to use PVC for server /tmp dir
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
cfc12dc6bf
feat: Add install arg and config for concurrent backups
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Scott Seago
9c09d04979
feat: Add Queued and ReadyToStart phases to BackupPhase
...
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat >
Signed-off-by: Scott Seago <sseago@redhat.com >
2025-12-02 16:28:08 -05:00
Shubham Pampattiwar
27ca08b5a5
Address review comments: rename metrics to repo_maintenance_*
...
- Rename metric constants from maintenance_job_* to repo_maintenance_*
- Update metric help text to clarify these are for repo maintenance
- Rename functions: RegisterMaintenanceJob* → RegisterRepoMaintenance*
- Update all test references to use new names
Addresses review comments from @Lyndon-Li on PR #9414
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
2025-12-02 11:36:15 -08:00
