Dump the github context content

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>

.github/workflows/get-go-version.yaml

@@ -16,6 +16,11 @@ jobs:
       outputs:
         version: ${{ steps.pick-version.outputs.version }}
       steps:
+        - name: Dump github context
+          env:
+            GITHUB_CONTEXT: ${{ toJson(github) }}
+          run: echo "$GITHUB_CONTEXT"
+
         - name: Check out the code
           uses: actions/checkout@v5
 

.github/workflows/nightly-trivy-scan.yml

@@ -31,6 +31,6 @@ jobs:
           output: 'trivy-results.sarif'
 
       - name: Upload Trivy scan results to GitHub Security tab
-        uses: github/codeql-action/upload-sarif@v4
+        uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: 'trivy-results.sarif'

changelogs/unreleased/9296-Lyndon-Li

@@ -1 +0,0 @@
-Fix issue #9267, add events to data mover prepare diagnostic

changelogs/unreleased/9329-T4iFooN-IX

@@ -1 +0,0 @@
-Fix typos in documentation

pkg/exposer/csi_snapshot.go

@@ -381,13 +381,8 @@ func (e *csiSnapshotExposer) DiagnoseExpose(ctx context.Context, ownerObject cor
 		diag += fmt.Sprintf("error getting backup vs %s, err: %v\n", backupVSName, err)
 	}
 
-	events, err := e.kubeClient.CoreV1().Events(ownerObject.Namespace).List(ctx, metav1.ListOptions{})
-	if err != nil {
-		diag += fmt.Sprintf("error listing events, err: %v\n", err)
-	}
-
 	if pod != nil {
-		diag += kube.DiagnosePod(pod, events)
+		diag += kube.DiagnosePod(pod)
 
 		if pod.Spec.NodeName != "" {
 			if err := nodeagent.KbClientIsRunningInNode(ctx, ownerObject.Namespace, pod.Spec.NodeName, e.kubeClient); err != nil {
@@ -397,7 +392,7 @@ func (e *csiSnapshotExposer) DiagnoseExpose(ctx context.Context, ownerObject cor
 	}
 
 	if pvc != nil {
-		diag += kube.DiagnosePVC(pvc, events)
+		diag += kube.DiagnosePVC(pvc)
 
 		if pvc.Spec.VolumeName != "" {
 			if pv, err := e.kubeClient.CoreV1().PersistentVolumes().Get(ctx, pvc.Spec.VolumeName, metav1.GetOptions{}); err != nil {
@@ -409,7 +404,7 @@ func (e *csiSnapshotExposer) DiagnoseExpose(ctx context.Context, ownerObject cor
 	}
 
 	if vs != nil {
-		diag += csi.DiagnoseVS(vs, events)
+		diag += csi.DiagnoseVS(vs)
 
 		if vs.Status != nil && vs.Status.BoundVolumeSnapshotContentName != nil && *vs.Status.BoundVolumeSnapshotContentName != "" {
 			if vsc, err := e.csiSnapshotClient.VolumeSnapshotContents().Get(ctx, *vs.Status.BoundVolumeSnapshotContentName, metav1.GetOptions{}); err != nil {

pkg/exposer/csi_snapshot_test.go

@@ -1288,7 +1288,6 @@ func Test_csiSnapshotExposer_DiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-backup",
-			UID:       "fake-pod-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: backup.APIVersion,
@@ -1314,7 +1313,6 @@ func Test_csiSnapshotExposer_DiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-backup",
-			UID:       "fake-pod-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: backup.APIVersion,
@@ -1343,7 +1341,6 @@ func Test_csiSnapshotExposer_DiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-backup",
-			UID:       "fake-pvc-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: backup.APIVersion,
@@ -1362,7 +1359,6 @@ func Test_csiSnapshotExposer_DiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-backup",
-			UID:       "fake-pvc-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: backup.APIVersion,
@@ -1408,7 +1404,6 @@ func Test_csiSnapshotExposer_DiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-backup",
-			UID:       "fake-vs-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: backup.APIVersion,
@@ -1424,7 +1419,6 @@ func Test_csiSnapshotExposer_DiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-backup",
-			UID:       "fake-vs-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: backup.APIVersion,
@@ -1442,7 +1436,6 @@ func Test_csiSnapshotExposer_DiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-backup",
-			UID:       "fake-vs-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: backup.APIVersion,
@@ -1640,74 +1633,6 @@ PVC velero/fake-backup, phase Pending, binding to fake-pv
 PV fake-pv, phase Pending, reason , message fake-pv-message
 VS velero/fake-backup, bind to fake-vsc, readyToUse false, errMessage fake-vs-message
 VSC fake-vsc, readyToUse false, errMessage fake-vsc-message, handle 
-end diagnose CSI exposer`,
-		},
-		{
-			name:        "with events",
-			ownerBackup: backup,
-			kubeClientObj: []runtime.Object{
-				&backupPodWithNodeName,
-				&backupPVCWithVolumeName,
-				&backupPV,
-				&nodeAgentPod,
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-1"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-uid-1"},
-					Reason:         "reason-1",
-					Message:        "message-1",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-2"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Reason:         "reason-2",
-					Message:        "message-2",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-3"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pvc-uid"},
-					Reason:         "reason-3",
-					Message:        "message-3",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-4"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-vs-uid"},
-					Reason:         "reason-4",
-					Message:        "message-4",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: "other-namespace", Name: "event-5"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Reason:         "reason-5",
-					Message:        "message-5",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-6"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Reason:         "reason-6",
-					Message:        "message-6",
-				},
-			},
-			snapshotClientObj: []runtime.Object{
-				&backupVSWithVSC,
-				&backupVSC,
-			},
-			expected: `begin diagnose CSI exposer
-Pod velero/fake-backup, phase Pending, node name fake-node
-Pod condition Initialized, status True, reason , message fake-pod-message
-Pod event reason reason-2, message message-2
-Pod event reason reason-6, message message-6
-PVC velero/fake-backup, phase Pending, binding to fake-pv
-PVC event reason reason-3, message message-3
-PV fake-pv, phase Pending, reason , message fake-pv-message
-VS velero/fake-backup, bind to fake-vsc, readyToUse false, errMessage fake-vs-message
-VS event reason reason-4, message message-4
-VSC fake-vsc, readyToUse false, errMessage fake-vsc-message, handle 
 end diagnose CSI exposer`,
 		},
 	}

pkg/exposer/generic_restore.go

@@ -287,13 +287,8 @@ func (e *genericRestoreExposer) DiagnoseExpose(ctx context.Context, ownerObject
 		diag += fmt.Sprintf("error getting restore pvc %s, err: %v\n", restorePVCName, err)
 	}
 
-	events, err := e.kubeClient.CoreV1().Events(ownerObject.Namespace).List(ctx, metav1.ListOptions{})
-	if err != nil {
-		diag += fmt.Sprintf("error listing events, err: %v\n", err)
-	}
-
 	if pod != nil {
-		diag += kube.DiagnosePod(pod, events)
+		diag += kube.DiagnosePod(pod)
 
 		if pod.Spec.NodeName != "" {
 			if err := nodeagent.KbClientIsRunningInNode(ctx, ownerObject.Namespace, pod.Spec.NodeName, e.kubeClient); err != nil {
@@ -303,7 +298,7 @@ func (e *genericRestoreExposer) DiagnoseExpose(ctx context.Context, ownerObject
 	}
 
 	if pvc != nil {
-		diag += kube.DiagnosePVC(pvc, events)
+		diag += kube.DiagnosePVC(pvc)
 
 		if pvc.Spec.VolumeName != "" {
 			if pv, err := e.kubeClient.CoreV1().PersistentVolumes().Get(ctx, pvc.Spec.VolumeName, metav1.GetOptions{}); err != nil {

pkg/exposer/generic_restore_test.go

@@ -549,7 +549,6 @@ func Test_ReastoreDiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-restore",
-			UID:       "fake-pod-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: restore.APIVersion,
@@ -575,7 +574,6 @@ func Test_ReastoreDiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-restore",
-			UID:       "fake-pod-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: restore.APIVersion,
@@ -604,7 +602,6 @@ func Test_ReastoreDiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-restore",
-			UID:       "fake-pvc-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: restore.APIVersion,
@@ -623,7 +620,6 @@ func Test_ReastoreDiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-restore",
-			UID:       "fake-pvc-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: restore.APIVersion,
@@ -762,60 +758,6 @@ Pod velero/fake-restore, phase Pending, node name fake-node
 Pod condition Initialized, status True, reason , message fake-pod-message
 PVC velero/fake-restore, phase Pending, binding to fake-pv
 PV fake-pv, phase Pending, reason , message fake-pv-message
-end diagnose restore exposer`,
-		},
-		{
-			name:         "with events",
-			ownerRestore: restore,
-			kubeClientObj: []runtime.Object{
-				&restorePodWithNodeName,
-				&restorePVCWithVolumeName,
-				&restorePV,
-				&nodeAgentPod,
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-1"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-uid-1"},
-					Reason:         "reason-1",
-					Message:        "message-1",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-2"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Reason:         "reason-2",
-					Message:        "message-2",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-3"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pvc-uid"},
-					Reason:         "reason-3",
-					Message:        "message-3",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: "other-namespace", Name: "event-4"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Reason:         "reason-4",
-					Message:        "message-4",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-5"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Reason:         "reason-5",
-					Message:        "message-5",
-				},
-			},
-			expected: `begin diagnose restore exposer
-Pod velero/fake-restore, phase Pending, node name fake-node
-Pod condition Initialized, status True, reason , message fake-pod-message
-Pod event reason reason-2, message message-2
-Pod event reason reason-5, message message-5
-PVC velero/fake-restore, phase Pending, binding to fake-pv
-PVC event reason reason-3, message message-3
-PV fake-pv, phase Pending, reason , message fake-pv-message
 end diagnose restore exposer`,
 		},
 	}

pkg/exposer/pod_volume.go

@@ -251,13 +251,8 @@ func (e *podVolumeExposer) DiagnoseExpose(ctx context.Context, ownerObject corev
 		diag += fmt.Sprintf("error getting hosting pod %s, err: %v\n", hostingPodName, err)
 	}
 
-	events, err := e.kubeClient.CoreV1().Events(ownerObject.Namespace).List(ctx, metav1.ListOptions{})
-	if err != nil {
-		diag += fmt.Sprintf("error listing events, err: %v\n", err)
-	}
-
 	if pod != nil {
-		diag += kube.DiagnosePod(pod, events)
+		diag += kube.DiagnosePod(pod)
 
 		if pod.Spec.NodeName != "" {
 			if err := nodeagent.KbClientIsRunningInNode(ctx, ownerObject.Namespace, pod.Spec.NodeName, e.kubeClient); err != nil {

pkg/exposer/pod_volume_test.go

@@ -466,7 +466,6 @@ func TestPodVolumeDiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-backup",
-			UID:       "fake-pod-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: backup.APIVersion,
@@ -492,7 +491,6 @@ func TestPodVolumeDiagnoseExpose(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: velerov1.DefaultNamespace,
 			Name:      "fake-backup",
-			UID:       "fake-pod-uid",
 			OwnerReferences: []metav1.OwnerReference{
 				{
 					APIVersion: backup.APIVersion,
@@ -589,48 +587,6 @@ end diagnose pod volume exposer`,
 			expected: `begin diagnose pod volume exposer
 Pod velero/fake-backup, phase Pending, node name fake-node
 Pod condition Initialized, status True, reason , message fake-pod-message
-end diagnose pod volume exposer`,
-		},
-		{
-			name:        "with events",
-			ownerBackup: backup,
-			kubeClientObj: []runtime.Object{
-				&backupPodWithNodeName,
-				&nodeAgentPod,
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-1"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-uid-1"},
-					Reason:         "reason-1",
-					Message:        "message-1",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-2"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Reason:         "reason-2",
-					Message:        "message-2",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: "other-namespace", Name: "event-3"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Reason:         "reason-3",
-					Message:        "message-3",
-				},
-				&corev1api.Event{
-					ObjectMeta:     metav1.ObjectMeta{Namespace: velerov1.DefaultNamespace, Name: "event-4"},
-					Type:           corev1api.EventTypeWarning,
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Reason:         "reason-4",
-					Message:        "message-4",
-				},
-			},
-			expected: `begin diagnose pod volume exposer
-Pod velero/fake-backup, phase Pending, node name fake-node
-Pod condition Initialized, status True, reason , message fake-pod-message
-Pod event reason reason-2, message message-2
-Pod event reason reason-4, message message-4
 end diagnose pod volume exposer`,
 		},
 	}

pkg/util/csi/volume_snapshot.go

@@ -689,7 +689,7 @@ func WaitUntilVSCHandleIsReady(
 	return vsc, nil
 }
 
-func DiagnoseVS(vs *snapshotv1api.VolumeSnapshot, events *corev1api.EventList) string {
+func DiagnoseVS(vs *snapshotv1api.VolumeSnapshot) string {
 	vscName := ""
 	readyToUse := false
 	errMessage := ""
@@ -710,14 +710,6 @@ func DiagnoseVS(vs *snapshotv1api.VolumeSnapshot, events *corev1api.EventList) s
 
 	diag := fmt.Sprintf("VS %s/%s, bind to %s, readyToUse %v, errMessage %s\n", vs.Namespace, vs.Name, vscName, readyToUse, errMessage)
 
-	if events != nil {
-		for _, e := range events.Items {
-			if e.InvolvedObject.UID == vs.UID && e.Type == corev1api.EventTypeWarning {
-				diag += fmt.Sprintf("VS event reason %s, message %s\n", e.Reason, e.Message)
-			}
-		}
-	}
-
 	return diag
 }
 

pkg/util/csi/volume_snapshot_test.go

@@ -1699,7 +1699,6 @@ func TestDiagnoseVS(t *testing.T) {
 	testCases := []struct {
 		name     string
 		vs       *snapshotv1api.VolumeSnapshot
-		events   *corev1api.EventList
 		expected string
 	}{
 		{
@@ -1782,81 +1781,11 @@ func TestDiagnoseVS(t *testing.T) {
 			},
 			expected: "VS fake-ns/fake-vs, bind to fake-vsc, readyToUse true, errMessage fake-message\n",
 		},
-		{
-			name: "VS with VSC and empty event",
-			vs: &snapshotv1api.VolumeSnapshot{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "fake-vs",
-					Namespace: "fake-ns",
-				},
-				Status: &snapshotv1api.VolumeSnapshotStatus{
-					BoundVolumeSnapshotContentName: &vscName,
-					ReadyToUse:                     &readyToUse,
-					Error:                          &snapshotv1api.VolumeSnapshotError{},
-				},
-			},
-			events:   &corev1api.EventList{},
-			expected: "VS fake-ns/fake-vs, bind to fake-vsc, readyToUse true, errMessage \n",
-		},
-		{
-			name: "VS with VSC and events",
-			vs: &snapshotv1api.VolumeSnapshot{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "fake-vs",
-					Namespace: "fake-ns",
-					UID:       "fake-vs-uid",
-				},
-				Status: &snapshotv1api.VolumeSnapshotStatus{
-					BoundVolumeSnapshotContentName: &vscName,
-					ReadyToUse:                     &readyToUse,
-					Error:                          &snapshotv1api.VolumeSnapshotError{},
-				},
-			},
-			events: &corev1api.EventList{Items: []corev1api.Event{
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-uid-1"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-1",
-					Message:        "message-1",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-uid-2"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-2",
-					Message:        "message-2",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-vs-uid"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-3",
-					Message:        "message-3",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-vs-uid"},
-					Type:           corev1api.EventTypeNormal,
-					Reason:         "reason-4",
-					Message:        "message-4",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-vs-uid"},
-					Type:           corev1api.EventTypeNormal,
-					Reason:         "reason-5",
-					Message:        "message-5",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-vs-uid"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-6",
-					Message:        "message-6",
-				},
-			}},
-			expected: "VS fake-ns/fake-vs, bind to fake-vsc, readyToUse true, errMessage \nVS event reason reason-3, message message-3\nVS event reason reason-6, message message-6\n",
-		},
 	}
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			diag := DiagnoseVS(tc.vs, tc.events)
+			diag := DiagnoseVS(tc.vs)
 			assert.Equal(t, tc.expected, diag)
 		})
 	}

pkg/util/kube/pod.go

@@ -268,21 +268,13 @@ func ToSystemAffinity(loadAffinities []*LoadAffinity) *corev1api.Affinity {
 	return nil
 }
 
-func DiagnosePod(pod *corev1api.Pod, events *corev1api.EventList) string {
+func DiagnosePod(pod *corev1api.Pod) string {
 	diag := fmt.Sprintf("Pod %s/%s, phase %s, node name %s\n", pod.Namespace, pod.Name, pod.Status.Phase, pod.Spec.NodeName)
 
 	for _, condition := range pod.Status.Conditions {
 		diag += fmt.Sprintf("Pod condition %s, status %s, reason %s, message %s\n", condition.Type, condition.Status, condition.Reason, condition.Message)
 	}
 
-	if events != nil {
-		for _, e := range events.Items {
-			if e.InvolvedObject.UID == pod.UID && e.Type == corev1api.EventTypeWarning {
-				diag += fmt.Sprintf("Pod event reason %s, message %s\n", e.Reason, e.Message)
-			}
-		}
-	}
-
 	return diag
 }
 

pkg/util/kube/pod_test.go

@@ -896,11 +896,10 @@ func TestDiagnosePod(t *testing.T) {
 	testCases := []struct {
 		name     string
 		pod      *corev1api.Pod
-		events   *corev1api.EventList
 		expected string
 	}{
 		{
-			name: "pod with all info but event",
+			name: "pod with all info",
 			pod: &corev1api.Pod{
 				ObjectMeta: metav1.ObjectMeta{
 					Name:      "fake-pod",
@@ -929,111 +928,11 @@ func TestDiagnosePod(t *testing.T) {
 			},
 			expected: "Pod fake-ns/fake-pod, phase Pending, node name fake-node\nPod condition Initialized, status True, reason fake-reason-1, message fake-message-1\nPod condition PodScheduled, status False, reason fake-reason-2, message fake-message-2\n",
 		},
-		{
-			name: "pod with all info and empty event list",
-			pod: &corev1api.Pod{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "fake-pod",
-					Namespace: "fake-ns",
-				},
-				Spec: corev1api.PodSpec{
-					NodeName: "fake-node",
-				},
-				Status: corev1api.PodStatus{
-					Phase: corev1api.PodPending,
-					Conditions: []corev1api.PodCondition{
-						{
-							Type:    corev1api.PodInitialized,
-							Status:  corev1api.ConditionTrue,
-							Reason:  "fake-reason-1",
-							Message: "fake-message-1",
-						},
-						{
-							Type:    corev1api.PodScheduled,
-							Status:  corev1api.ConditionFalse,
-							Reason:  "fake-reason-2",
-							Message: "fake-message-2",
-						},
-					},
-				},
-			},
-			events:   &corev1api.EventList{},
-			expected: "Pod fake-ns/fake-pod, phase Pending, node name fake-node\nPod condition Initialized, status True, reason fake-reason-1, message fake-message-1\nPod condition PodScheduled, status False, reason fake-reason-2, message fake-message-2\n",
-		},
-		{
-			name: "pod with all info and events",
-			pod: &corev1api.Pod{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "fake-pod",
-					Namespace: "fake-ns",
-					UID:       "fake-pod-uid",
-				},
-				Spec: corev1api.PodSpec{
-					NodeName: "fake-node",
-				},
-				Status: corev1api.PodStatus{
-					Phase: corev1api.PodPending,
-					Conditions: []corev1api.PodCondition{
-						{
-							Type:    corev1api.PodInitialized,
-							Status:  corev1api.ConditionTrue,
-							Reason:  "fake-reason-1",
-							Message: "fake-message-1",
-						},
-						{
-							Type:    corev1api.PodScheduled,
-							Status:  corev1api.ConditionFalse,
-							Reason:  "fake-reason-2",
-							Message: "fake-message-2",
-						},
-					},
-				},
-			},
-			events: &corev1api.EventList{Items: []corev1api.Event{
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-uid-1"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-1",
-					Message:        "message-1",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-uid-2"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-2",
-					Message:        "message-2",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-3",
-					Message:        "message-3",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Type:           corev1api.EventTypeNormal,
-					Reason:         "reason-4",
-					Message:        "message-4",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Type:           corev1api.EventTypeNormal,
-					Reason:         "reason-5",
-					Message:        "message-5",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pod-uid"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-6",
-					Message:        "message-6",
-				},
-			}},
-			expected: "Pod fake-ns/fake-pod, phase Pending, node name fake-node\nPod condition Initialized, status True, reason fake-reason-1, message fake-message-1\nPod condition PodScheduled, status False, reason fake-reason-2, message fake-message-2\nPod event reason reason-3, message message-3\nPod event reason reason-6, message message-6\n",
-		},
 	}
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			diag := DiagnosePod(tc.pod, tc.events)
+			diag := DiagnosePod(tc.pod)
 			assert.Equal(t, tc.expected, diag)
 		})
 	}

pkg/util/kube/pvc_pv.go

@@ -463,18 +463,8 @@ func GetPVCForPodVolume(vol *corev1api.Volume, pod *corev1api.Pod, crClient crcl
 	return pvc, nil
 }
 
-func DiagnosePVC(pvc *corev1api.PersistentVolumeClaim, events *corev1api.EventList) string {
-	diag := fmt.Sprintf("PVC %s/%s, phase %s, binding to %s\n", pvc.Namespace, pvc.Name, pvc.Status.Phase, pvc.Spec.VolumeName)
-
-	if events != nil {
-		for _, e := range events.Items {
-			if e.InvolvedObject.UID == pvc.UID && e.Type == corev1api.EventTypeWarning {
-				diag += fmt.Sprintf("PVC event reason %s, message %s\n", e.Reason, e.Message)
-			}
-		}
-	}
-
-	return diag
+func DiagnosePVC(pvc *corev1api.PersistentVolumeClaim) string {
+	return fmt.Sprintf("PVC %s/%s, phase %s, binding to %s\n", pvc.Namespace, pvc.Name, pvc.Status.Phase, pvc.Spec.VolumeName)
 }
 
 func DiagnosePV(pv *corev1api.PersistentVolume) string {

pkg/util/kube/pvc_pv_test.go

@@ -1593,11 +1593,10 @@ func TestDiagnosePVC(t *testing.T) {
 	testCases := []struct {
 		name     string
 		pvc      *corev1api.PersistentVolumeClaim
-		events   *corev1api.EventList
 		expected string
 	}{
 		{
-			name: "pvc with all info but events",
+			name: "pvc with all info",
 			pvc: &corev1api.PersistentVolumeClaim{
 				ObjectMeta: metav1.ObjectMeta{
 					Name:      "fake-pvc",
@@ -1612,83 +1611,11 @@ func TestDiagnosePVC(t *testing.T) {
 			},
 			expected: "PVC fake-ns/fake-pvc, phase Pending, binding to fake-pv\n",
 		},
-		{
-			name: "pvc with all info and empty events",
-			pvc: &corev1api.PersistentVolumeClaim{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "fake-pvc",
-					Namespace: "fake-ns",
-				},
-				Spec: corev1api.PersistentVolumeClaimSpec{
-					VolumeName: "fake-pv",
-				},
-				Status: corev1api.PersistentVolumeClaimStatus{
-					Phase: corev1api.ClaimPending,
-				},
-			},
-			events:   &corev1api.EventList{},
-			expected: "PVC fake-ns/fake-pvc, phase Pending, binding to fake-pv\n",
-		},
-		{
-			name: "pvc with all info and events",
-			pvc: &corev1api.PersistentVolumeClaim{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "fake-pvc",
-					Namespace: "fake-ns",
-					UID:       "fake-pvc-uid",
-				},
-				Spec: corev1api.PersistentVolumeClaimSpec{
-					VolumeName: "fake-pv",
-				},
-				Status: corev1api.PersistentVolumeClaimStatus{
-					Phase: corev1api.ClaimPending,
-				},
-			},
-			events: &corev1api.EventList{Items: []corev1api.Event{
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-uid-1"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-1",
-					Message:        "message-1",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-uid-2"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-2",
-					Message:        "message-2",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pvc-uid"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-3",
-					Message:        "message-3",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pvc-uid"},
-					Type:           corev1api.EventTypeNormal,
-					Reason:         "reason-4",
-					Message:        "message-4",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pvc-uid"},
-					Type:           corev1api.EventTypeNormal,
-					Reason:         "reason-5",
-					Message:        "message-5",
-				},
-				{
-					InvolvedObject: corev1api.ObjectReference{UID: "fake-pvc-uid"},
-					Type:           corev1api.EventTypeWarning,
-					Reason:         "reason-6",
-					Message:        "message-6",
-				},
-			}},
-			expected: "PVC fake-ns/fake-pvc, phase Pending, binding to fake-pv\nPVC event reason reason-3, message message-3\nPVC event reason reason-6, message message-6\n",
-		},
 	}
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			diag := DiagnosePVC(tc.pvc, tc.events)
+			diag := DiagnosePVC(tc.pvc)
 			assert.Equal(t, tc.expected, diag)
 		})
 	}

site/content/docs/main/data-movement-pod-resource-configuration.md

@@ -15,7 +15,7 @@ Note: If less resources are assigned to data mover pods, the data movement activ
 Refer to [Performance Guidance][3] for a guidance of performance vs. resource usage, and it is highly recommended that you perform your own testing to find the best resource limits for your data.  
 
 Velero introduces a new section in the node-agent configMap, called ```podResources```, through which you can set customized resources configurations for data mover pods.  
-If it is not there, a configMap should be created manually. The configMap should be in the same namespace where Velero is installed. If multiple Velero instances are installed in different namespaces, there should be one configMap in each namespace which applies to node-agent in that namespace only. The name of the configMap should be specified in the node-agent server parameter ```--node-agent-configmap```.  
+If it is not there, a configMap should be created manually. The configMap should be in the same namespace where Velero is installed. If multiple Velero instances are installed in different namespaces, there should be one configMap in each namespace which applies to node-agent in that namespace only. The name of the configMap should be specified in the node-agent server parameter ```--node-agent-config```.  
 Node-agent server checks these configurations at startup time. Therefore, you could edit this configMap any time, but in order to make the changes effective, node-agent server needs to be restarted.  
 
 ### Sample
@@ -39,19 +39,19 @@ To create the configMap, save something like the above sample to a json file and
 kubectl create cm node-agent-config -n velero --from-file=<json file name>
 ```
 
-To provide the configMap to node-agent, edit the node-agent daemonset and add the ```- --node-agent-configmap``` argument to the spec:
+To provide the configMap to node-agent, edit the node-agent daemonset and add the ```- --node-agent-config``` argument to the spec:
 1. Open the node-agent daemonset spec  
 ```
 kubectl edit ds node-agent -n velero
 ```
-2. Add ```- --node-agent-configmap``` to ```spec.template.spec.containers```  
+2. Add ```- --node-agent-config``` to ```spec.template.spec.containers```  
 ```
 spec:
   template:
     spec:
       containers:
       - args:
-        - --node-agent-configmap=<configMap name>
+        - --node-agent-config=<configMap name>
 ```
 
 ### Priority Class
@@ -126,4 +126,4 @@ kubectl create cm node-agent-config -n velero --from-file=node-agent-config.json
 [1]: csi-snapshot-data-movement.md
 [2]: file-system-backup.md
 [3]: https://kubernetes.io/docs/concepts/workloads/pods/pod-qos/
-[4]: performance-guidance.md
+[4]: performance-guidance.md

site/content/docs/main/node-agent-prepare-queue-length.md

@@ -27,22 +27,22 @@ To create the configMap, save something like the above sample to a json file and
 kubectl create cm node-agent-config -n velero --from-file=<json file name>
 ```
 
-To provide the configMap to node-agent, edit the node-agent daemonset and add the ```- --node-agent-configmap`` argument to the spec:
+To provide the configMap to node-agent, edit the node-agent daemonset and add the ```- --node-agent-config``` argument to the spec:
 1. Open the node-agent daemonset spec  
 ```
 kubectl edit ds node-agent -n velero
 ```
-2. Add ```- --node-agent-configmap``` to ```spec.template.spec.containers```  
+2. Add ```- --node-agent-config``` to ```spec.template.spec.containers```  
 ```
 spec:
   template:
     spec:
       containers:
       - args:
-        - --node-agent-configmap=<configMap name>
+        - --node-agent-config=<configMap name>
 ```
 
 [1]: csi-snapshot-data-movement.md
 [2]: file-system-backup.md
 [3]: node-agent-concurrency.md
-[4]: data-movement-node-selection.md
+[4]: data-movement-node-selection.md