Merge pull request #6842 from allenxu404/release-1.12

Modify changelogs for v1.12

.github/auto-assignees.yml

@@ -16,7 +16,6 @@ reviewers:
       - qiuming-best
       - shubham-pampattiwar
       - Lyndon-Li
-      - anshulahuja98
 
     tech-writer:
       - sseago

.github/workflows/crds-verify-kind.yaml

@@ -14,7 +14,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: '1.21.6'
+          go-version: '1.20.7'
         id: go
       # Look for a CLI that's made for this PR
       - name: Fetch built CLI

.github/workflows/e2e-test-kind.yaml

@@ -14,7 +14,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: '1.21.6'
+          go-version: '1.20.7'
         id: go
       # Look for a CLI that's made for this PR
       - name: Fetch built CLI
@@ -72,7 +72,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: '1.21.6'
+          go-version: '1.20.7'
         id: go
       - name: Check out the code
         uses: actions/checkout@v2

.github/workflows/pr-ci-check.yml

@@ -10,7 +10,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: '1.21.6'
+          go-version: '1.20.7'
         id: go
       - name: Check out the code
         uses: actions/checkout@v2

.github/workflows/push.yml

@@ -18,7 +18,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v4
       with:
-        go-version: '1.21.6'
+        go-version: '1.20.7'
       id: go
 
     - uses: actions/checkout@v3
@@ -48,10 +48,7 @@ jobs:
         version: latest
 
     - name: Build
-      run: |
-        make local
-        # Clean go cache to ease the build environment storage pressure.
-        go clean -modcache -cache
+      run: make local
 
     - name: Test
       run: make test
@@ -76,7 +73,7 @@ jobs:
       run: |
         sudo swapoff -a
         sudo rm -f /mnt/swapfile
-        docker system prune -a --force
+        docker image prune -a --force
               
         # Build and push Velero image to docker registry
         docker login -u ${{ secrets.DOCKER_USER }} -p ${{ secrets.DOCKER_PASSWORD }}

.github/workflows/stale-issues.yml

@@ -7,7 +7,7 @@ jobs:
   stale:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@v6.0.1
+      - uses: actions/stale@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           stale-issue-message: "This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands."

ADOPTERS.md

@@ -16,7 +16,6 @@ If you're using Velero and want to add your organization to this list,
 <a href="https://mayadata.io/" border="0" target="_blank"><img alt="mayadata.io" src="site/static/img/adopters/mayadata.svg" height="50"></a>&nbsp; &nbsp; &nbsp;
 <a href="https://www.replicated.com/" border="0" target="_blank"><img alt="replicated.com" src="site/static/img/adopters/replicated-logo-red.svg" height="50"></a>
 <a href="https://cloudcasa.io/" border="0" target="_blank"><img alt="cloudcasa.io" src="site/static/img/adopters/cloudcasa.svg" height="50"></a>
-<a href="https://azure.microsoft.com/" border="0" target="_blank"><img alt="azure.com" src="site/static/img/adopters/azure.svg" height="50"></a>
 ## Success Stories
 
 Below is a list of adopters of Velero in **production environments** that have
@@ -65,9 +64,6 @@ Replicated uses the Velero open source project to enable snapshots in [KOTS][101
 **[CloudCasa][103]**<br>
 [Catalogic Software][104] integrates Velero with [CloudCasa][103] - A Smart Home in the Cloud for Backups. CloudCasa is a simple, scalable, cloud-native solution providing data protection and disaster recovery as a service. This solution is built using Kubernetes for protecting Kubernetes clusters.<br>
 
-**[Microsoft Azure][105]**<br>
-[Azure Backup for AKS][106] is an Azure native, Kubernetes aware, Enterprise ready backup for containerized applications deployed on Azure Kubernetes Service (AKS). AKS Backup utilizes Velero to perform backup and restore operations to protect stateful applications in AKS clusters.<br>
-
 ## Adding your organization to the list of Velero Adopters
 
 If you are using Velero and would like to be included in the list of `Velero Adopters`, add an SVG version of your logo to the `site/static/img/adopters` directory in this repo and submit a [pull request][3] with your change. Name the image file something that reflects your company (e.g., if your company is called Acme, name the image acme.png). See this for an example [PR][4].
@@ -122,6 +118,3 @@ If you would like to add your logo to a future `Adopters of Velero` section on [
 
 [103]: https://cloudcasa.io/
 [104]: https://www.catalogicsoftware.com/
-
-[105]: https://azure.microsoft.com/
-[106]: https://learn.microsoft.com/azure/backup/backup-overview

CHANGELOG.md

@@ -1,9 +1,7 @@
 ## Current release:
-  * [CHANGELOG-1.13.md][23]
+  * [CHANGELOG-1.11.md][21]
 
 ## Older releases:
-  * [CHANGELOG-1.12.md][22]
-  * [CHANGELOG-1.11.md][21]
   * [CHANGELOG-1.10.md][20]
   * [CHANGELOG-1.9.md][19]
   * [CHANGELOG-1.8.md][18]
@@ -26,8 +24,6 @@
   * [CHANGELOG-0.3.md][1]
 
 
-[23]: https://github.com/vmware-tanzu/velero/blob/main/changelogs/CHANGELOG-1.13.md
-[22]: https://github.com/vmware-tanzu/velero/blob/main/changelogs/CHANGELOG-1.12.md
 [21]: https://github.com/vmware-tanzu/velero/blob/main/changelogs/CHANGELOG-1.11.md
 [20]: https://github.com/vmware-tanzu/velero/blob/main/changelogs/CHANGELOG-1.10.md
 [19]: https://github.com/vmware-tanzu/velero/blob/main/changelogs/CHANGELOG-1.9.md

Dockerfile

@@ -13,7 +13,7 @@
 # limitations under the License.
 
 # Velero binary build section
-FROM --platform=$BUILDPLATFORM golang:1.21.6-bookworm as velero-builder
+FROM --platform=$BUILDPLATFORM golang:1.20.7-bullseye as velero-builder
 
 ARG GOPROXY
 ARG BIN
@@ -43,11 +43,10 @@ RUN mkdir -p /output/usr/bin && \
     go build -o /output/${BIN} \
     -ldflags "${LDFLAGS}" ${PKG}/cmd/${BIN} && \
     go build -o /output/velero-helper \
-    -ldflags "${LDFLAGS}" ${PKG}/cmd/velero-helper && \
-    go clean -modcache -cache
+    -ldflags "${LDFLAGS}" ${PKG}/cmd/velero-helper
 
 # Restic binary build section
-FROM --platform=$BUILDPLATFORM golang:1.21.6-bookworm as restic-builder
+FROM --platform=$BUILDPLATFORM golang:1.20.7-bullseye as restic-builder
 
 ARG BIN
 ARG TARGETOS
@@ -66,11 +65,10 @@ COPY . /go/src/github.com/vmware-tanzu/velero
 
 RUN mkdir -p /output/usr/bin && \
     export GOARM=$(echo "${GOARM}" | cut -c2-) && \
-    /go/src/github.com/vmware-tanzu/velero/hack/build-restic.sh && \
-    go clean -modcache -cache
+    /go/src/github.com/vmware-tanzu/velero/hack/build-restic.sh
 
 # Velero image packing section
-FROM paketobuildpacks/run-jammy-tiny:0.2.19
+FROM gcr.io/distroless/base-nossl-debian11@sha256:f10e1fbf558c630a4b74a987e6c754d45bf59f9ddcefce090f6b111925996767
 
 LABEL maintainer="Xun Jiang <jxun@vmware.com>"
 
@@ -78,5 +76,5 @@ COPY --from=velero-builder /output /
 
 COPY --from=restic-builder /output /
 
-USER cnb:cnb
+USER nonroot:nonroot
 

MAINTAINERS.md

@@ -4,16 +4,16 @@
 
 ## Maintainers
 
-| Maintainer          | GitHub ID                                                     | Affiliation                                      |
-|---------------------|---------------------------------------------------------------|--------------------------------------------------|
-| Scott Seago         | [sseago](https://github.com/sseago)                           | [OpenShift](https://github.com/openshift)        |
-| Daniel Jiang        | [reasonerjt](https://github.com/reasonerjt)                   | [VMware](https://www.github.com/vmware/)         |
-| Wenkai Yin          | [ywk253100](https://github.com/ywk253100)                     | [VMware](https://www.github.com/vmware/)         |
-| Xun Jiang           | [blackpiglet](https://github.com/blackpiglet)                 | [VMware](https://www.github.com/vmware/)         |
-| Ming Qiu            | [qiuming-best](https://github.com/qiuming-best)               | [VMware](https://www.github.com/vmware/)         |
-| Shubham Pampattiwar | [shubham-pampattiwar](https://github.com/shubham-pampattiwar) | [OpenShift](https://github.com/openshift)        |
-| Yonghui Li          | [Lyndon-Li](https://github.com/Lyndon-Li)                     | [VMware](https://www.github.com/vmware/)         |
-| Anshul Ahuja        | [anshulahuja98](https://github.com/anshulahuja98)             | [Microsoft Azure](https://www.github.com/azure/) |
+| Maintainer          | GitHub ID                                                     | Affiliation                               |
+|---------------------|---------------------------------------------------------------|-------------------------------------------|
+| Dave Smith-Uchida   | [dsu-igeek](https://github.com/dsu-igeek)                     | [Kasten](https://github.com/kastenhq/)    |
+| Scott Seago         | [sseago](https://github.com/sseago)                           | [OpenShift](https://github.com/openshift) |
+| Daniel Jiang        | [reasonerjt](https://github.com/reasonerjt)                   | [VMware](https://www.github.com/vmware/)  |
+| Wenkai Yin          | [ywk253100](https://github.com/ywk253100)                     | [VMware](https://www.github.com/vmware/)  |
+| Xun Jiang           | [blackpiglet](https://github.com/blackpiglet)                 | [VMware](https://www.github.com/vmware/)  |
+| Ming Qiu            | [qiuming-best](https://github.com/qiuming-best)               | [VMware](https://www.github.com/vmware/)  |
+| Shubham Pampattiwar | [shubham-pampattiwar](https://github.com/shubham-pampattiwar) | [OpenShift](https://github.com/openshift) |
+| Yonghui Li          | [Lyndon-Li](https://github.com/Lyndon-Li)                     | [VMware](https://www.github.com/vmware/)  |
 
 ## Emeritus Maintainers
 * Adnan Abdulhussein ([prydonius](https://github.com/prydonius))
@@ -25,12 +25,12 @@
 * Carlisia Thompson ([carlisia](https://github.com/carlisia))
 * Bridget McErlean ([zubron](https://github.com/zubron))
 * JenTing Hsiao ([jenting](https://github.com/jenting))
-* Dave Smith-Uchida ([dsu-igeek](https://github.com/dsu-igeek))
-  
+
 ## Velero Contributors & Stakeholders
 
 | Feature Area           |                                         Lead                                         |
 |------------------------|:------------------------------------------------------------------------------------:|
+| Architect              |             Dave Smith-Uchida [dsu-igeek](https://github.com/dsu-igeek)              |
 | Technical Lead         |               Daniel Jiang [reasonerjt](https://github.com/reasonerjt)               |
 | Kubernetes CSI Liaison |                                                                                      |
 | Deployment             |                                                                                      |

README.md

@@ -42,7 +42,6 @@ The following is a list of the supported Kubernetes versions for each Velero ver
 
 | Velero version | Expected Kubernetes version compatibility | Tested on Kubernetes version           |
 |----------------|-------------------------------------------|----------------------------------------|
-| 1.13           | 1.18-latest                               | 1.26.5, 1.27.3, 1.27.8, and 1.28.3     |
 | 1.12           | 1.18-latest                               | 1.25.7, 1.26.5, 1.26.7, and 1.27.3     |
 | 1.11           | 1.18-latest                               | 1.23.10, 1.24.9, 1.25.5, and 1.26.1    |
 | 1.10           | 1.18-latest                               | 1.22.5, 1.23.8, 1.24.6 and 1.25.1      |

Tiltfile

@@ -52,7 +52,7 @@ git_sha = str(local("git rev-parse HEAD", quiet = True, echo_off = True)).strip(
 
 tilt_helper_dockerfile_header = """
 # Tilt image
-FROM golang:1.21.6 as tilt-helper
+FROM golang:1.20.7 as tilt-helper
 
 # Support live reloading with Tilt
 RUN wget --output-document /restart.sh --quiet https://raw.githubusercontent.com/windmilleng/rerun-process-wrapper/master/restart.sh  && \

changelogs/CHANGELOG-1.11.md

@@ -100,7 +100,7 @@ To fix CVEs and keep pace with Golang, Velero made changes as follows:
 * Enable staticcheck linter. (#5788, @blackpiglet)
 * Set Kopia IgnoreUnknownTypes in ErrorHandlingPolicy to True for ignoring backup unknown file type (#5786, @qiuming-best)
 * Bump up Restic version to 0.15.0  (#5784, @qiuming-best)
-* Add File system backup related metrics to Grafana dashboard
+* Add File system backup related matrics to Grafana dashboard
   - Add metrics backup_warning_total for record of total warnings
   - Add metrics backup_last_status for record of last status of the backup  (#5779, @allenxu404)
 * Design for Handling backup of volumes by resources filters (#5773, @qiuming-best)

changelogs/CHANGELOG-1.12.md

@@ -51,6 +51,7 @@ To fix CVEs and keep pace with Golang, Velero made changes as follows:
 * Prior to v1.12, the parameter `uploader-type` for Velero installation had a default value of "restic". However, starting from this version, the default value has been changed to "kopia". This means that Velero will now use Kopia as the default path for file system backup.
 * The ways of setting CSI snapshot time have changed in v1.12. First, the sync waiting time for creating a snapshot handle in the CSI plugin is changed from the fixed 10 minutes into backup.Spec.CSISnapshotTimeout. The second, the async waiting time for VolumeSnapshot and VolumeSnapshotContent's status turning into `ReadyToUse` in operation uses the operation's timeout. The default value is 4 hours.
 * As from [Velero helm chart v4.0.0](https://github.com/vmware-tanzu/helm-charts/releases/tag/velero-4.0.0), it supports multiple BSL and VSL, and the BSL and VSL have changed from the map into a slice, and[ this breaking change](https://github.com/vmware-tanzu/helm-charts/pull/413) is not backward compatible. So it would be best to change the BSL and VSL configuration into slices before the Upgrade.
+* Prior to v1.12, deleting the Velero namespace would easily remove all the resources within it. However, with the introduction of finalizers attached to the Velero CR including `restore`, `dataupload`, and `datadownload` in this version, directly deleting Velero namespace may get stuck indefinitely because the pods responsible for handling the finalizers might be deleted before the resources attached to the finalizers. To avoid this issue, please use the command `velero uninstall` to delete all the Velero resources or ensure that you handle the finalizer appropriately before deleting the Velero namespace.
 
 
 ### Limitations/Known issues
@@ -132,3 +133,10 @@ prior PVC restores with CSI (#6111, @eemcmullan)
 * Make GetPluginConfig accessible from other packages. (#6151, @tkaovila)
 * Ignore not found error during patching managedFields (#6136, @ywk253100)
 * Fix the goreleaser issues and add a new goreleaser action (#6109, @blackpiglet)
+* Add CSI snapshot data movement doc (#6793, @Lyndon-Li)
+* Use old(origin) namespace in resource modifier conditions in case namespace may change during restore (#6724, @27149chen)
+* Fix #6752: add namespace exclude check. (#6762, @blackpiglet)
+* Update restore controller logic for restore deletion (#6761, @ywk253100)
+* Fix issue #6753, remove the check for read-only BSL in restore async operation controller since Velero cannot fully support read-only mode BSL in restore at present (#6758, @Lyndon-Li)
+* Fixes #6636, skip subresource in resource discovery (#6688, @27149chen)
+* This pr made some improvements in Resource Modifiers:1. add label selector 2. change the field name from groupKind to groupResource (#6704, @27149chen)

changelogs/CHANGELOG-1.13.md

@@ -1,167 +0,0 @@
-## v1.13
-### 2024-01-10
-
-### Download
-https://github.com/vmware-tanzu/velero/releases/tag/v1.13.0
-
-### Container Image
-`velero/velero:v1.13.0`
-
-### Documentation
-https://velero.io/docs/v1.13/
-
-### Upgrading
-https://velero.io/docs/v1.13/upgrade-to-1.13/
-
-### Highlights
-
-#### Resource Modifier Enhancement
-Velero introduced the Resource Modifiers in v1.12.0. This feature allows users to specify a ConfigMap with a set of rules to modify the resources during restoration. However, only the JSON Patch is supported when creating the rules, and JSON Patch has some limitations, which cannot cover all use cases. In v1.13.0, Velero adds new support for JSON Merge Patch and Strategic Merge Patch, which provide more power and flexibility and allow users to use the same ConfigMap to apply patches on the resources. More design details can be found in [Support JSON Merge Patch and Strategic Merge Patch in Resource Modifiers](https://github.com/vmware-tanzu/velero/blob/main/design/Implemented/merge-patch-and-strategic-in-resource-modifier.md) design. For instructions on how to use the feature, please refer to the [Resource Modifiers](https://velero.io/docs/v1.13/restore-resource-modifiers/) doc.
-
-#### Node-Agent Concurrency
-Velero data movement activities from fs-backups and CSI snapshot data movements run in Velero node-agent, so may be hosted by every node in the cluster and consume resources (i.e. CPU, memory, network bandwidth) from there. With v1.13, users are allowed to configure how many data movement activities (a.k.a, loads) run in each node globally or by node, so that users can better leverage the performance of Velero data movement activities and the resource consumption in the cluster. For more information, check the [Node-Agent Concurrency](https://velero.io/docs/v1.13/node-agent-concurrency/) document. 
-
-#### Parallel Files Upload Options
-Velero now supports configurable options for parallel files upload when using Kopia uploader to do fs-backups or CSI snapshot data movements which makes speed up backup possible.
-For more information, please check [Here](https://velero.io/docs/v1.13/backup-reference/#parallel-files-upload).
-
-#### Write Sparse Files Options
-If using fs-restore or CSI snapshot data movements, it’s supported to write sparse files during restore. For more information, please check [Here](https://velero.io/docs/v1.13/restore-reference/#write-sparse-files).
-
-#### Backup Describe
-In v1.13, the Backup Volume section is added to the velero backup describe command output. The backup Volumes section describes information for all the volumes included in the backup of various backup types, i.e. native snapshot, fs-backup, CSI snapshot, and CSI snapshot data movement. Particularly, the velero backup description now supports showing the information of CSI snapshot data movements, which is not supported in v1.12.
-
-Additionally, backup describe command will not check EnableCSI feature gate from client side, so if a backup has volumes with CSI snapshot or CSI snapshot data movement, backup describe command always shows the corresponding information in its output.
-
-#### Backup's new VolumeInfo metadata
-Create a new metadata file in the backup repository's backup name sub-directory to store the backup-including PVC and PV information. The information includes the backing-up method of the PVC and PV data, snapshot information, and status. The VolumeInfo metadata file determines how the PV resource should be restored. The Velero downstream software can also use this metadata file to get a summary of the backup's volume data information.
-
-#### Enhancement for CSI Snapshot Data Movements when Velero Pod Restart
-When performing backup and restore operations, enhancements have been implemented for Velero server pods or node agents to ensure that the current backup or restore process is not stuck or interrupted after restart due to certain exceptional circumstances.
-
-#### New status fields added to show hook execution details
-Hook execution status is now included in the backup/restore CR status and displayed in the backup/restore describe command output. Specifically, it will show the number of hooks which attempted to execute under the HooksAttempted  field and the number of hooks which failed to execute under the HooksFailed  field. 
-
-#### AWS SDK Bump Up
-Bump up AWS SDK for Go to version 2, which offers significant performance improvements in CPU and memory utilization over version 1.
-
-#### Azure AD/Workload Identity Support
-Azure AD/Workload Identity is the recommended approach to do the authentication with Azure services/AKS, Velero has introduced support for Azure AD/Workload Identity on the Velero Azure plugin side in previous releases, and in v1.13.0 Velero adds new support for Kopia operations(file system backup/data mover/etc.) with Azure AD/Workload Identity.
-
-#### Runtime and dependencies
-To fix CVEs and keep pace with Golang, Velero made changes as follows:
-* Bump Golang runtime to v1.21.6.
-* Bump several dependent libraries to new versions.
-* Bump Kopia to v0.15.0.
-
-
-### Breaking changes
-* Backup describe command: due to the backup describe output enhancement, some existing information (i.e. the output for native snapshot, CSI snapshot, and fs-backup) has been moved to the Backup Volumes section with some format changes.
-* API type changes: changes the field [DataMoverConfig](https://github.com/vmware-tanzu/velero/blob/v1.13.0/pkg/apis/velero/v2alpha1/data_upload_types.go#L54) in DataUploadSpec from `*map[string][string]`` to `map[string]string`
-* Velero install command: due to the issue [#7264](https://github.com/vmware-tanzu/velero/issues/7264), v1.13.0 introduces a break change that make the informer cache enabled by default to keep the actual behavior consistent with the helper message(the informer cache is disabled by default before the change).
-
-
-### Limitations/Known issues
-* The backup's VolumeInfo metadata doesn't have the information updated in the async operations. This function could be supported in v1.14 release. 
-
-### Note
-* Velero introduces the informer cache which is enabled by default. The informer cache improves the restore performance but may cause higher memory consumption. Increase the memory limit of the Velero pod or disable the informer cache by specifying the `--disable-informer-cache` option when installing Velero if you get the OOM error.
-
-### Deprecation announcement
-* The generated k8s clients, informers, and listers are deprecated in the Velero v1.13 release. They are put in the Velero repository's pkg/generated directory. According to the n+2 supporting policy, the deprecated are kept for two more releases. The pkg/generated directory should be deleted in the v1.15 release.
-* After the backup VolumeInfo metadata file is added to the backup, Velero decides how to restore the PV resource according to the VolumeInfo content. To support the backup generated by the older version of Velero, the old logic is also kept. The support for the backup without the VolumeInfo metadata file will be kept for two releases. The support logic will be deleted in the v1.15 release.
-
-### All Changes
-  * Check resource Group Version and Kind is available in cluster before attempting restore to prevent being stuck (#7336, @kaovilai)
-  * Make "disable-informer-cache" option false(enabled) by default to keep it consistent with the help message (#7294, @ywk253100)
-  * Fix issue #6928, remove snapshot deletion timeout for PVB (#7282, @Lyndon-Li)
-  * Do not set "targetNamespace" to namespace items (#7274, @reasonerjt)
-  * Fix issue #7244. By the end of the upload, check the outstanding incomplete snapshots and delete them by calling ApplyRetentionPolicy (#7245, @Lyndon-Li)
-  * Adjust the newline output of resource list in restore describer (#7238, @allenxu404)
-  * Remove the redundant newline in backup describe output (#7229, @allenxu404)
-  * Fix issue #7189, data mover generic restore - don't assume the first volume as the restore volume (#7201, @Lyndon-Li)
-  * Update CSIVolumeSnapshotsCompleted in backup's status and the metric
-during backup finalize stage according to async operations content. (#7184, @blackpiglet)
-  * Refactor DownloadRequest Stream function (#7175, @blackpiglet)
-  * Add `--skip-immediately` flag to schedule commands; `--schedule-skip-immediately` server and install (#7169, @kaovilai)
-  * Add node-agent concurrency doc and change the config name from dataPathConcurrency to loadCocurrency (#7161, @Lyndon-Li)
-  * Enhance hooks tracker by adding a returned error to record function (#7153, @allenxu404)
-  * Track the skipped PV when SnapshotVolumes set as false (#7152, @reasonerjt)
-  * Add more linters part 2. (#7151, @blackpiglet)
-  * Fix issue #7135, check pod status before checking node-agent pod status (#7150, @Lyndon-Li)
-  * Treat namespace as a regular restorable item (#7143, @reasonerjt)
-  * Allow sparse option for Kopia & Restic restore  (#7141, @qiuming-best)
-  * Use VolumeInfo to help restore the PV. (#7138, @blackpiglet)
-  * Node agent restart enhancement (#7130, @qiuming-best)
-  * Fix issue #6695, add describe for data mover backups (#7125, @Lyndon-Li)
-  * Add hooks status to backup/restore CR (#7117, @allenxu404)
-  * Include plugin name in the error message by operations (#7115, @reasonerjt)
-  * Fix issue #7068, due to a behavior of CSI external snapshotter, manipulations of VS and VSC may not be handled in the same order inside external snapshotter as the API is called. So add a protection finalizer to ensure the order (#7102, @Lyndon-Li)
-  * Generate VolumeInfo for backup. (#7100, @blackpiglet)
-  * Fix issue #7094, fallback to full backup if previous snapshot is not found (#7096, @Lyndon-Li)
-  * Fix issue #7068, due to an behavior of CSI external snapshotter, manipulations of VS and VSC may not be handled in the same order inside external snapshotter as the API is called. So add a protection finalizer to ensure the order (#7095, @Lyndon-Li)
-  * Skip syncing the backup which doesn't contain backup metadata (#7081, @ywk253100)
-  * Fix issue #6693, partially fail restore if CSI snapshot is involved but CSI feature is not ready, i.e., CSI feature gate is not enabled or CSI plugin is not installed. (#7077, @Lyndon-Li)
-  * Truncate the credential file to avoid the change of secret content messing it up (#7072, @ywk253100)
-  * Add VolumeInfo metadata structures. (#7070, @blackpiglet)
-  * improve discoveryHelper.Refresh() in restore (#7069, @27149chen)
-  * Add DataUpload Result and CSI VolumeSnapshot check for restore PV. (#7061, @blackpiglet)
-  * Add the implementation for design #6950, configurable data path concurrency (#7059, @Lyndon-Li)
-  * Make data mover fail early (#7052, @qiuming-best)
-  * Remove dependency of generated client part 3. (#7051, @blackpiglet)
-  * Update Backup.Status.CSIVolumeSnapshotsCompleted during finalize (#7046, @kaovilai)
-  * Remove the Velero generated client. (#7041, @blackpiglet)
-  * Fix issue #7027, data mover backup exposer should not assume the first volume as the backup volume in backup pod (#7038, @Lyndon-Li)
-  * Read information from the credential specified by BSL (#7034, @ywk253100)
-  * Fix #6857. Added check for matching Owner References when synchronizing backups, removing references that are not found/have mismatched uid. (#7032, @deefdragon)
-  * Add description markers for dataupload and datadownload CRDs (#7028, @shubham-pampattiwar)
-  * Add HealthCheckNodePort deletion logic for Service restore. (#7026, @blackpiglet)
-  * Fix inconsistent behavior of Backup and Restore hook execution (#7022, @allenxu404)
-  * Fix #6964. Don't use csiSnapshotTimeout (10 min) for waiting snapshot to readyToUse for data mover, so as to make the behavior complied with CSI snapshot backup (#7011, @Lyndon-Li)
-  * restore: Use warning when Create IsAlreadyExist and Get error (#7004, @kaovilai)
-  * Bump kopia to 0.15.0 (#7001, @Lyndon-Li)
-  * Make Kopia file parallelism configurable (#7000, @qiuming-best)
-  * Fix unified repository (kopia) s3 credentials profile selection (#6995, @kaovilai)
-  * Fix #6988, always get region from BSL if it is not empty (#6990, @Lyndon-Li)
-  * Limit PVC block mode logic to non-Windows platform. (#6989, @blackpiglet)
-  * It is a valid case that the Status.RestoreSize field in VolumeSnapshot is not set, if so, get the volume size from the source PVC to create the backup PVC (#6976, @Lyndon-Li)
-  * Check whether the action is a CSI action and whether CSI feature is enabled, before executing the action. (#6968, @blackpiglet)
-  * Add the PV backup information design document. (#6962, @blackpiglet)
-  * Change controller-runtime List option from MatchingFields to ListOptions (#6958, @blackpiglet)
-  * Add the design for node-agent concurrency (#6950, @Lyndon-Li)
-  * Import auth provider plugins (#6947, @0x113)
-  * Fix #6668, add a limitation for file system restore parallelism with other types of restores (CSI snapshot restore, CSI snapshot movement restore) (#6946, @Lyndon-Li)
-  * Add MSI Support for Azure plugin. (#6938, @yanggangtony)
-  * Partially fix #6734, guide Kubernetes' scheduler to spread backup pods evenly across nodes as much as possible, so that data mover backup could achieve better parallelism (#6926, @Lyndon-Li)
-  * Bump up aws sdk to aws-sdk-go-v2 (#6923, @reasonerjt)
-  * Optional check if targeted container is ready before executing a hook (#6918, @Ripolin)
-  * Support JSON Merge Patch and Strategic Merge Patch in Resource Modifiers (#6917, @27149chen)
-  * Fix issue 6913: Velero Built-in Datamover: Backup stucks in phase WaitingForPluginOperations when Node Agent pod gets restarted (#6914, @shubham-pampattiwar)
-  * Set ParallelUploadAboveSize as MaxInt64 and flush repo after setting up policy so that policy is retrieved correctly by TreeForSource (#6885, @Lyndon-Li)
-  * Replace the base image with paketobuildpacks image (#6883, @ywk253100)
-  * Fix issue #6859, move plugin depending podvolume functions to util pkg, so as to remove the dependencies to unnecessary repository packages like kopia, azure, etc. (#6875, @Lyndon-Li)
-  * Fix #6861. Only Restic path requires repoIdentifier, so for non-restic path, set the repoIdentifier fields as empty in PVB and PVR and also remove the RepoIdentifier column in the get output of PVBs and PVRs (#6872, @Lyndon-Li)
-  * Add volume types filter in resource policies (#6863, @qiuming-best)
-  * change the metrics backup_attempt_total default value to 1. (#6838, @yanggangtony)
-  * Bump kopia to v0.14 (#6833, @Lyndon-Li)
-  * Retry failed create when using generateName (#6830, @sseago)
-  * Fix issue #6786, always delete VSC regardless of the deletion policy (#6827, @Lyndon-Li)
-  * Proposal to support JSON Merge Patch and Strategic Merge Patch in Resource Modifiers (#6797, @27149chen)
-  * Fix the node-agent missing metrics-address defines. (#6784, @yanggangtony)
-  * Fix default BSL setting not work (#6771, @qiuming-best)
-  * Update restore controller logic for restore deletion (#6770, @ywk253100)
-  * Fix #6752: add namespace exclude check. (#6760, @blackpiglet)
-  * Fix issue #6753, remove the check for read-only BSL in restore async operation controller since Velero cannot fully support read-only mode BSL in restore at present (#6757, @Lyndon-Li)
-  * Fix issue #6647, add the --default-snapshot-move-data parameter to Velero install, so that users don't need to specify --snapshot-move-data per backup when they want to move snapshot data for all backups (#6751, @Lyndon-Li)
-  * Use old(origin) namespace in resource modifier conditions in case namespace may change during restore (#6724, @27149chen)
-  * Perf improvements for existing resource restore (#6723, @sseago)
-  * Remove schedule-related metrics on schedule delete (#6715, @nilesh-akhade)
-  * Kubernetes 1.27 new job label batch.kubernetes.io/controller-uid are deleted during restore per https://github.com/kubernetes/kubernetes/pull/114930 (#6712, @kaovilai)
-  * This pr made some improvements in Resource Modifiers: 1. add label selector 2. change the field name from groupKind to groupResource (#6704, @27149chen)
-  * Make Kopia support Azure AD (#6686, @ywk253100)
-  * Add support for block volumes with Kopia (#6680, @dzaninovic)
-  * Delete PartiallyFailed orphaned backups as well as Completed ones (#6649, @sseago)
-  * Add CSI snapshot data movement doc (#6637, @Lyndon-Li)
-  * Fixes #6636, skip subresource in resource discovery (#6635, @27149chen)
-  * Add `orLabelSelectors` for backup, restore commands (#6475, @nilesh-akhade)
-  * fix run preHook and postHook on completed pods (#5211, @cleverhu)

changelogs/CHANGELOG-1.8.md

@@ -61,7 +61,7 @@ in progress for 1.9.
 * Add rbac and annotation test cases (#4455, @mqiu)
 * remove --crds-version in velero install command. (#4446, @jxun)
 * Upgrade e2e test vsphere plugin (#4440, @mqiu)
-* Fix e2e test failures for the inappropriate optimize of velero install (#4438, @mqiu)
+* Fix e2e test failures for the inappropriate optimaze of velero install (#4438, @mqiu)
 * Limit backup namespaces on test resource filtering cases (#4437, @mqiu)
 * Bump up Go to 1.17 (#4431, @reasonerjt)
 * Added `<backup name>`-itemsnapshots.json.gz to the backup format.  This file exists

cmd/velero-helper/velero-helper.go

@@ -1,19 +1,3 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
 package main
 
 import (

config/crd/v1/bases/velero.io_backups.yaml

@@ -477,15 +477,6 @@ spec:
                 description: TTL is a time.Duration-parseable string describing how
                   long the Backup should be retained for.
                 type: string
-              uploaderConfig:
-                description: UploaderConfig specifies the configuration for the uploader.
-                nullable: true
-                properties:
-                  parallelFilesUpload:
-                    description: ParallelFilesUpload is the number of files parallel
-                      uploads to perform when using the uploader.
-                    type: integer
-                type: object
               volumeSnapshotLocations:
                 description: VolumeSnapshotLocations is a list containing names of
                   VolumeSnapshotLocations associated with this backup.
@@ -544,22 +535,6 @@ spec:
                 description: FormatVersion is the backup format version, including
                   major, minor, and patch version.
                 type: string
-              hookStatus:
-                description: HookStatus contains information about the status of the
-                  hooks.
-                nullable: true
-                properties:
-                  hooksAttempted:
-                    description: HooksAttempted is the total number of attempted hooks
-                      Specifically, HooksAttempted represents the number of hooks
-                      that failed to execute and the number of hooks that executed
-                      successfully.
-                    type: integer
-                  hooksFailed:
-                    description: HooksFailed is the total number of hooks which ended
-                      with an error
-                    type: integer
-                type: object
               phase:
                 description: Phase is the current state of the Backup.
                 enum:

config/crd/v1/bases/velero.io_downloadrequests.yaml

@@ -53,7 +53,6 @@ spec:
                     - RestoreItemOperations
                     - CSIBackupVolumeSnapshots
                     - CSIBackupVolumeSnapshotContents
-                    - BackupVolumeInfos
                     type: string
                   name:
                     description: Name is the name of the Kubernetes resource with

config/crd/v1/bases/velero.io_podvolumebackups.yaml

@@ -35,6 +35,10 @@ spec:
       jsonPath: .spec.volume
       name: Volume
       type: string
+    - description: Backup repository identifier for this backup
+      jsonPath: .spec.repoIdentifier
+      name: Repository ID
+      type: string
     - description: The type of the uploader to handle data transfer
       jsonPath: .spec.uploaderType
       name: Uploader Type
@@ -121,13 +125,6 @@ spec:
                 description: Tags are a map of key-value pairs that should be applied
                   to the volume backup as tags.
                 type: object
-              uploaderSettings:
-                additionalProperties:
-                  type: string
-                description: UploaderSettings are a map of key-value pairs that should
-                  be applied to the uploader configuration.
-                nullable: true
-                type: object
               uploaderType:
                 description: UploaderType is the type of the uploader to handle the
                   data transfer.

config/crd/v1/bases/velero.io_podvolumerestores.yaml

@@ -119,13 +119,6 @@ spec:
                 description: SourceNamespace is the original namespace for namaspace
                   mapping.
                 type: string
-              uploaderSettings:
-                additionalProperties:
-                  type: string
-                description: UploaderSettings are a map of key-value pairs that should
-                  be applied to the uploader configuration.
-                nullable: true
-                type: object
               uploaderType:
                 description: UploaderType is the type of the uploader to handle the
                   data transfer.

config/crd/v1/bases/velero.io_restores.yaml

@@ -186,12 +186,6 @@ spec:
                                     - Continue
                                     - Fail
                                     type: string
-                                  waitForReady:
-                                    description: WaitForReady ensures command will
-                                      be launched when container is Ready instead
-                                      of Running.
-                                    nullable: true
-                                    type: boolean
                                   waitTimeout:
                                     description: WaitTimeout defines the maximum amount
                                       of time Velero should wait for the container
@@ -418,16 +412,6 @@ spec:
                   restore from the most recent successful backup created from this
                   schedule.
                 type: string
-              uploaderConfig:
-                description: UploaderConfig specifies the configuration for the restore.
-                nullable: true
-                properties:
-                  writeSparseFiles:
-                    description: WriteSparseFiles is a flag to indicate whether write
-                      files sparsely or not.
-                    nullable: true
-                    type: boolean
-                type: object
             required:
             - backupName
             type: object
@@ -450,22 +434,6 @@ spec:
                 description: FailureReason is an error that caused the entire restore
                   to fail.
                 type: string
-              hookStatus:
-                description: HookStatus contains information about the status of the
-                  hooks.
-                nullable: true
-                properties:
-                  hooksAttempted:
-                    description: HooksAttempted is the total number of attempted hooks
-                      Specifically, HooksAttempted represents the number of hooks
-                      that failed to execute and the number of hooks that executed
-                      successfully.
-                    type: integer
-                  hooksFailed:
-                    description: HooksFailed is the total number of hooks which ended
-                      with an error
-                    type: integer
-                type: object
               phase:
                 description: Phase is the current state of the Restore
                 enum:

config/crd/v1/bases/velero.io_schedules.yaml

@@ -61,16 +61,6 @@ spec:
                 description: Schedule is a Cron expression defining when to run the
                   Backup.
                 type: string
-              skipImmediately:
-                description: 'SkipImmediately specifies whether to skip backup if
-                  schedule is due immediately from `schedule.status.lastBackup` timestamp
-                  when schedule is unpaused or if schedule is new. If true, backup
-                  will be skipped immediately when schedule is unpaused if it is due
-                  based on .Status.LastBackupTimestamp or schedule is new, and will
-                  run at next schedule time. If false, backup will not be skipped
-                  immediately when schedule is unpaused, but will run at next schedule
-                  time. If empty, will follow server configuration (default: false).'
-                type: boolean
               template:
                 description: Template is the definition of the Backup to be run on
                   the provided schedule
@@ -524,16 +514,6 @@ spec:
                     description: TTL is a time.Duration-parseable string describing
                       how long the Backup should be retained for.
                     type: string
-                  uploaderConfig:
-                    description: UploaderConfig specifies the configuration for the
-                      uploader.
-                    nullable: true
-                    properties:
-                      parallelFilesUpload:
-                        description: ParallelFilesUpload is the number of files parallel
-                          uploads to perform when using the uploader.
-                        type: integer
-                    type: object
                   volumeSnapshotLocations:
                     description: VolumeSnapshotLocations is a list containing names
                       of VolumeSnapshotLocations associated with this backup.
@@ -559,11 +539,6 @@ spec:
                 format: date-time
                 nullable: true
                 type: string
-              lastSkipped:
-                description: LastSkipped is the last time a Schedule was skipped
-                format: date-time
-                nullable: true
-                type: string
               phase:
                 description: Phase is the current phase of the Schedule
                 enum:

config/crd/v2alpha1/bases/velero.io_datadownloads.yaml

@@ -48,8 +48,6 @@ spec:
     name: v2alpha1
     schema:
       openAPIV3Schema:
-        description: DataDownload acts as the protocol between data mover plugins
-          and data mover controller for the datamover restore operation
         properties:
           apiVersion:
             description: 'APIVersion defines the versioned schema of this representation

config/crd/v2alpha1/bases/velero.io_datauploads.yaml

@@ -49,8 +49,6 @@ spec:
     name: v2alpha1
     schema:
       openAPIV3Schema:
-        description: DataUpload acts as the protocol between data mover plugins and
-          data mover controller for the datamover backup operation
         properties:
           apiVersion:
             description: 'APIVersion defines the versioned schema of this representation

design/CLI/PoC/overlays/plugins/node-agent.yaml

@@ -49,9 +49,6 @@ spec:
             - mountPath: /host_pods
               mountPropagation: HostToContainer
               name: host-pods
-            - mountPath: /var/lib/kubelet/plugins
-              mountPropagation: HostToContainer
-              name: host-plugins
             - mountPath: /scratch
               name: scratch
             - mountPath: /credentials
@@ -63,9 +60,6 @@ spec:
         - hostPath:
             path: /var/lib/kubelet/pods
           name: host-pods
-        - hostPath:
-            path: /var/lib/kubelet/plugins
-          name: host-plugins
         - emptyDir: {}
           name: scratch
         - name: cloud-credentials

design/Implemented/delete-item-action.md

@@ -175,7 +175,7 @@ If there are one or more, download the backup tarball from backup storage, untar
 
 ## Alternatives Considered
 
-Another proposal for higher level `DeleteItemActions` was initially included, which would require implementers to individually download the backup tarball themselves.
+Another proposal for higher level `DeleteItemActions` was initially included, which would require implementors to individually download the backup tarball themselves.
 While this may be useful long term, it is not a good fit for the current goals as each plugin would be re-implementing a lot of boilerplate.
 See the deletion-plugins.md file for this alternative proposal in more detail.
 

design/Implemented/merge-patch-and-strategic-in-resource-modifier.md

@@ -1,193 +0,0 @@
-# Proposal to Support JSON Merge Patch and Strategic Merge Patch in Resource Modifiers
-
-- [Proposal to Support JSON Merge Patch and Strategic Merge Patch in Resource Modifiers](#proposal-to-support-json-merge-patch-and-strategic-merge-patch-in-resource-modifiers)
-    - [Abstract](#abstract)
-    - [Goals](#goals)
-    - [Non Goals](#non-goals)
-    - [User Stories](#user-stories)
-        - [Scenario 1](#scenario-1)
-        - [Scenario 2](#scenario-2)
-    - [Detailed Design](#detailed-design)
-        - [How to choose the right patch type](#how-to-choose-the-right-patch-type)
-        - [New Field MergePatches](#new-field-mergepatches)
-        - [New Field StrategicPatches](#new-field-strategicpatches)
-        - [Conditional Patches in ALL Patch Types](#conditional-patches-in-all-patch-types)
-        - [Wildcard Support for GroupResource](#wildcard-support-for-groupresource)
-        - [Helper Command to Generate Merge Patch and Strategic Merge Patch](#helper-command-to-generate-merge-patch-and-strategic-merge-patch)
-    - [Security Considerations](#security-considerations)
-    - [Compatibility](#compatibility)
-    - [Implementation](#implementation)
-    - [Future Enhancements](#future-enhancements)
-    - [Open Issues](#open-issues)
-
-## Abstract
-Velero introduced the concept of Resource Modifiers in v1.12.0. This feature allows the user to specify a configmap with a set of rules to modify the resources during restore. The user can specify the filters to select the resources and then specify the JSON Patch to apply on the resource. This feature is currently limited to the operations supported by JSON Patch RFC.
-This proposal is to add support for JSON Merge Patch and Strategic Merge Patch in the Resource Modifiers. This will allow the user to use the same configmap to apply JSON Merge Patch and Strategic Merge Patch on the resources during restore.
-
-## Goals
-- Allow the user to specify a JSON patch, JSON Merge Patch or Strategic Merge Patch for modification.
-- Allow the user to specify multiple JSON Patch, JSON Merge Patch or Strategic Merge Patch.
-- Allow the user to specify mixed JSON Patch, JSON Merge Patch and Strategic Merge Patch in the same configmap.
-
-## Non Goals
-- Deprecating the existing RestoreItemAction plugins for standard substitutions(like changing the namespace, changing the storage class, etc.)
-
-## User Stories
-
-### Scenario 1
-- Alice has some Pods and part of them have an annotation `{"for": "bar"}`.
-- Alice wishes to restore these Pods to a different cluster without this annotation.
-- Alice can use this feature to remove this annotation during restore.
-
-### Scenario 2
-- Bob has a Pod with several containers and one container with name nginx has an image `repo1/nginx`.
-- Bob wishes to restore this Pod to a different cluster, but new cluster can not access repo1, so he pushes the image to repo2.
-- Bob can use this feature to update the image of container nginx to `repo2/nginx` during restore.
-
-## Detailed Design
-- The design and approach is inspired by kubectl patch command and [this doc](https://kubernetes.io/docs/tasks/manage-kubernetes-objects/update-api-object-kubectl-patch/).
-- New fields `MergePatches` and `StrategicPatches` will be added to the `ResourceModifierRule` struct to support all three patch types.
-- Only one of the three patch types can be specified in a single `ResourceModifierRule`.
-- Add wildcard support for `groupResource` in `conditions` struct.
-- The workflow to create Resource Modifier ConfigMap and reference it in RestoreSpec will remain the same as described in document [Resource Modifiers](https://github.com/vmware-tanzu/velero/blob/main/site/content/docs/main/restore-resource-modifiers.md).
-
-### How to choose the right patch type
-- [JSON Merge Patch](https://datatracker.ietf.org/doc/html/rfc7386) is a naively simple format, with limited usability. Probably it is a good choice if you are building something small, with very simple JSON Schema.
-- [JSON Patch](https://datatracker.ietf.org/doc/html/rfc6902) is a more complex format, but it is applicable to any JSON documents. For a comparison of JSON patch and JSON merge patch, see [JSON Patch and JSON Merge Patch](https://erosb.github.io/post/json-patch-vs-merge-patch/).
-- Strategic Merge Patch is a Kubernetes defined patch type, mainly used to process resources of type list. You can replace/merge a list, add/remove items from a list by key, change the order of items in a list, etc. Strategic merge patch is not supported for custom resources. For more details, see [this doc](https://kubernetes.io/docs/tasks/manage-kubernetes-objects/update-api-object-kubectl-patch/).
-
-### New Field MergePatches
-MergePatches is a list to specify the merge patches to be applied on the resource. The merge patches will be applied in the order specified in the configmap. A subsequent patch is applied in order and if multiple patches are specified for the same path, the last patch will override the previous patches.
-
-Example of MergePatches in ResourceModifierRule
-```yaml
-version: v1
-resourceModifierRules:
-- conditions:
-    groupResource: pods
-    namespaces:
-    - ns1
-  mergePatches:
-  - patchData: |
-      {
-        "metadata": {
-          "annotations": {
-            "foo": null
-          }
-        }
-      }
-```
-- The above configmap will apply the Merge Patch to all the pods in namespace ns1 and remove the annotation `foo` from the pods.
-- Both json and yaml format are supported for the patchData.
-
-### New Field StrategicPatches
-StrategicPatches is a list to specify the strategic merge patches to be applied on the resource. The strategic merge patches will be applied in the order specified in the configmap. A subsequent patch is applied in order and if multiple patches are specified for the same path, the last patch will override the previous patches.
-
-Example of StrategicPatches in ResourceModifierRule
-```yaml
-version: v1
-resourceModifierRules:
-- conditions:
-    groupResource: pods
-    resourceNameRegex: "^my-pod$"
-    namespaces:
-    - ns1
-  strategicPatches:
-  - patchData: |
-      {
-        "spec": {
-          "containers": [
-            {
-              "name": "nginx",
-              "image": "repo2/nginx"
-            }
-          ]
-        }
-      }
-```
-- The above configmap will apply the Strategic Merge Patch to the pod with name my-pod in namespace ns1 and update the image of container nginx to `repo2/nginx`.
-- Both json and yaml format are supported for the patchData.
-
-### Conditional Patches in ALL Patch Types
-Since JSON Merge Patch and Strategic Merge Patch do not support conditional patches, we will use the `test` operation of JSON Patch to support conditional patches in all patch types by adding it to `Conditions` struct in `ResourceModifierRule`.
-
-Example of test in conditions
-```yaml
-version: v1
-resourceModifierRules:
-- conditions:
-    groupResource: persistentvolumeclaims.storage.k8s.io
-    matches:
-    - path: "/spec/storageClassName"
-      value: "premium"
-  mergePatches:
-  - patchData: |
-      {
-        "metadata": {
-          "annotations": {
-            "foo": null
-          }
-        }
-      }
-```
-- The above configmap will apply the Merge Patch to all the PVCs in all namespaces with storageClassName premium and remove the annotation `foo` from the PVCs.
-- You can specify multiple rules in the `matches` list. The patch will be applied only if all the matches are satisfied.
-
-### Wildcard Support for GroupResource
-The user can specify a wildcard for groupResource in the conditions' struct. This will allow the user to apply the patches for all the resources of a particular group or all resources in all groups. For example, `*.apps` will apply to all the resources in the `apps` group, `*` will apply to all the resources in all groups.
-
-### Helper Command to Generate Merge Patch and Strategic Merge Patch
-The patchData of Strategic Merge Patch is sometimes a bit complex for user to write. We can provide a helper command to generate the patchData for Strategic Merge Patch. The command will take the original resource and the modified resource as input and generate the patchData.
-It can also be used in JSON Merge Patch.
-
-Here is a sample code snippet to achieve this:
-```go
-package main
-
-import (
-	"fmt"
-
-	corev1 "k8s.io/api/core/v1"
-	"sigs.k8s.io/controller-runtime/pkg/client"
-)
-
-func main() {
-	pod := &corev1.Pod{
-		Spec: corev1.PodSpec{
-			Containers: []corev1.Container{
-				{
-					Name:  "web",
-					Image: "nginx",
-				},
-			},
-		},
-	}
-	newPod := pod.DeepCopy()
-	patch := client.StrategicMergeFrom(pod)
-	newPod.Spec.Containers[0].Image = "nginx1"
-
-	data, _ := patch.Data(newPod)
-	fmt.Println(string(data))
-	// Output:
-	// {"spec":{"$setElementOrder/containers":[{"name":"web"}],"containers":[{"image":"nginx1","name":"web"}]}}
-}
-```
-
-## Security Considerations
-No security impact.
-
-## Compatibility
-Compatible with current Resource Modifiers.
-
-## Implementation
-- Use "github.com/evanphx/json-patch" to support JSON Merge Patch.
-- Use "k8s.io/apimachinery/pkg/util/strategicpatch" to support Strategic Merge Patch.
-- Use glob to support wildcard for `groupResource` in `conditions` struct.
-- Use `test` operation of JSON Patch to calculate the `matches` in `conditions` struct.
-
-## Future enhancements
-- add a Velero subcommand to generate/validate the patchData for Strategic Merge Patch and JSON Merge Patch.
-- add jq support for more complex conditions or patches, to meet the situations that the current conditions or patches can not handle. like [this issue](https://github.com/vmware-tanzu/velero/issues/6344)
-
-## Open Issues
-N/A

design/Implemented/node-agent-concurrency.md

@@ -1,131 +0,0 @@
-# Node-agent Concurrency Design
-
-## Glossary & Abbreviation
-
-**Velero Generic Data Path (VGDP)**: VGDP is the collective of modules that is introduced in [Unified Repository design][1]. Velero uses these modules to finish data transfer for various purposes (i.e., PodVolume backup/restore, Volume Snapshot Data Movement). VGDP modules include uploaders and the backup repository.  
-
-## Background
-
-Velero node-agent is a daemonset hosting controllers and VGDP modules to complete the concrete work of backups/restores, i.e., PodVolume backup/restore, Volume Snapshot Data Movement backup/restore.  
-For example, node-agent runs DataUpload controllers to watch DataUpload CRs for Volume Snapshot Data Movement backups, so there is one controller instance in each node. One controller instance takes a DataUpload CR and then launches a VGDP instance, which initializes a uploader instance and the backup repository connection, to finish the data transfer. The VGDP instance runs inside the node-agent pod or in a pod associated to the node-agent pod in the same node.  
-
-Varying from the data size, data complexity, resource availability, VGDP may take a long time and remarkable resources (CPU, memory, network bandwidth, etc.).  
-Technically, VGDP instances are able to run in concurrent regardless of the requesters. For example, a VGDP instance for a PodVolume backup could run in parallel with another VGDP instance for a DataUpload. Then the two VGDP instances share the same resources if they are running in the same node.  
-
-Therefore, in order to gain the optimized performance with the limited resources, it is worthy to configure the concurrent number of VGDP per node. When the resources are sufficient in nodes, users can set a large concurrent number, so as to reduce the backup/restore time; otherwise, the concurrency should be reduced, otherwise, the backup/restore may encounter problems, i.e., time lagging, hang or OOM kill.  
-
-## Goals
-
-- Define the behaviors of concurrent VGDP instances in node-agent
-- Create a mechanism for users to specify the concurrent number of VGDP per node
-
-## Non-Goals
-- VGDP instances from different nodes always run in concurrent since in most common cases the resources are isolated. For special cases that some resources are shared across nodes, there is no support at present
-- In practice, restores run in prioritized scenarios, e.g., disaster recovery. However, the current design doesn't consider this difference, a VGDP instance for a restore is blocked if it reaches to the limit of the concurrency, even though the ones block it are for backups. If users do meet some problems here, they should consider to stop the backups first
-- Sometimes, users wants to totally block backups/restores from running in a specific node, this is out of the scope the current design. To archive this, more modules need to be considered (i.e., expoers of data movers), simply blocking the VGDP (e.g., by setting its concurrent number to 0) doesn't work. E.g., for a fs backup, VGDP instance must run in the node the source pod is running in, if we simply block from VGDP instance, the PodVolumeBackup CR is still submitted but never processed.  
-
-## Solution
-
-We introduce a configMap named ```node-agent-config``` for users to specify the node-agent related configurations. This configMap is not created by Velero, users should create it manually on demand. The configMap should be in the same namespace where Velero is installed. If multiple Velero instances are installed in different namespaces, there should be one configMap in each namespace which applies to node-agent in that namespace only.  
-Node-agent server checks these configurations at startup time and use it to initiate the related VGDP modules. Therefore, users could edit this configMap any time, but in order to make the changes effective, node-agent server needs to be restarted.  
-The ```node-agent-config``` configMap may be used for other purpose of configuring node-agent in future, at present, there is only one kind of configuration as the data in the configMap, the name is ```loadConcurrency```.  
-
-The data structure for ```node-agent-config``` is as below:
-```go
-type Configs struct {
-	// LoadConcurrency is the config for load concurrency per node.
-	LoadConcurrency *LoadConcurrency `json:"loadConcurrency,omitempty"`
-}
-
-type LoadConcurrency struct {
-    // GlobalConfig specifies the concurrency number to all nodes for which per-node config is not specified
-    GlobalConfig int `json:"globalConfig,omitempty"`
-
-    // PerNodeConfig specifies the concurrency number to nodes matched by rules
-    PerNodeConfig []RuledConfigs `json:"perNodeConfig,omitempty"`
-}
-
-type RuledConfigs struct {
-    // NodeSelector specifies the label selector to match nodes
-    NodeSelector metav1.LabelSelector `json:"nodeSelector"`
-
-    // Number specifies the number value associated to the matched nodes
-    Number int `json:"number"`
-}
-```
-
-### Global concurrent number
-We allow users to specify a concurrent number that will be applied to all nodes if the per-node number is not specified. This number is set through ```globalConfig```.  
-The number starts from 1 which means there is no concurrency, only one instance of VGDP is allowed. There is no roof limit.    
-If this number is not specified or not valid, a hard-coded default value will be used, the value is set to 1. 
-
-### Per-node concurrent number
-We allow users to specify different concurrent number per node, for example, users can set 3 concurrent instances in Node-1, 2 instances in Node-2 and 1 instance in Node-3. This is for below considerations:
-- The resources may be different among nodes. Then users could specify smaller concurrent number for nodes with less resources while larger number for the ones with more resources
-- Help users to isolate critical environments. Users may run some critical workloads in some specified nodes, since VGDP instances may take large resource consumption, users may want to run less number of instances in the nodes with critical workloads
-
-The range of Per-node concurrent number is the same with Global concurrent number.  
-Per-node concurrent number is preferable to Global concurrent number, so it will overwrite the Global concurrent number for that node.  
-
-Per-node concurrent number is implemented through ```perNodeConfig``` field.  
-
-```perNodeConfig``` is a list of ```RuledConfigs``` each item of which matches one or more nodes by label selectors and specify the concurrent number for the matched nodes. This means, the nodes are identified by labels.  
-
-For example, the ```perNodeConfig`` could have below elements:
-```
-"nodeSelector: kubernetes.io/hostname=node1; number: 3"
-"nodeSelector: beta.kubernetes.io/instance-type=Standard_B4ms; number: 5"
-```
-The first element means the node with host name ```node1``` gets the Per-node concurrent number of 3.  
-The second element means all the nodes with label ```beta.kubernetes.io/instance-type``` of value ```Standard_B4ms``` get the Per-node concurrent number of 5. 
-At least one node is expected to have a label with the specified ```RuledConfigs``` element (rule). If no node is with this label, the Per-node rule makes no effect.  
-If one node falls into more than one rules, e.g., if node1 also has the label ```beta.kubernetes.io/instance-type=Standard_B4ms```, the smallest number (3) will be used.  
-
-### Sample
-A sample of the ```node-agent-config``` configMap is as below:
-```json
-{
-    "loadConcurrency": {
-        "globalConfig": 2,
-        "perNodeConfig": [
-            {
-                "nodeSelector": {
-                    "matchLabels": {
-                        "kubernetes.io/hostname": "node1"
-                    }
-                },
-                "number": 3
-            },
-            {
-                "nodeSelector": {
-                    "matchLabels": {
-                        "beta.kubernetes.io/instance-type": "Standard_B4ms"
-                    }
-                },
-                "number": 5
-            }
-        ]
-    }
-}
-```
-To create the configMap, users need to save something like the above sample to a json file and then run below command:
-```
-kubectl create cm node-agent-config -n velero --from-file=<json file name>
-```
-
-### Global data path manager
-As for the code implementation, data path manager is to maintain the total number of the running VGDP instances and ensure the limit is not excceeded. At present, there is one data path manager instance per controller, as a result, the concurrent numbers are calculated separately for each controller. This doesn't help to limit the concurrency among different requesters.  
-Therefore, we need to create one global data path manager instance server-wide, and pass it to different controllers. The instance will be created at node-agent server startup.  
-The concurrent number is required to initiate a data path manager, the number comes from either Per-node concurrent number or Global concurrent number.    
-Below are some prototypes related to data path manager:  
-
-```go
-func NewManager(cocurrentNum int) *Manager
-func (m *Manager) CreateFileSystemBR(jobName string, requestorType string, ctx context.Context, client client.Client, namespace string, callbacks Callbacks, log logrus.FieldLogger) (AsyncBR, error)
-```
-
-
-
-
-
-[1]: Implemented/unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md

design/Implemented/pv_backup_info.md

@@ -1,186 +0,0 @@
-# PersistentVolume backup information design
-
-## Abstract
-Create a new metadata file in the backup repository's backup name sub-directory to store the backup-including PVC and PV information. The information includes the way of backing up the PVC and PV data, snapshot information, and status. The needed snapshot status can also be recorded there, but the Velero-Native snapshot plugin doesn't provide a way to get the snapshot size from the API, so it's possible that not all snapshot size information is available.
-
-This new additional metadata file is needed when:
-* Get a summary of the backup's PVC and PV information, including how the data in them is backed up, or whether the data in them is skipped from backup.
-* Find out how the PVC and PV should be restored in the restore process.
-* Retrieve the PV's snapshot information for backup.
-
-## Background
-There is already a [PR](https://github.com/vmware-tanzu/velero/pull/6496) to track the skipped PVC in the backup. This design will depend on it and go further to get a summary of PVC and PV information, then persist into a metadata file in the backup repository.
-
-In the restore process, the Velero server needs to decide how the PV resource should be restored according to how the PV is backed up. The current logic is to check whether it's backed up by Velero-native snapshot, by file-system backup, or having `DeletionPolicy` set as `Delete`.
-
-The checks are made by the backup-generated PVBs or Snapshots. There is no generic way to find this information, and the CSI backup and Snapshot data movement backup are not covered.
-
-Another thing that needs noticing is when describing the backup, there is no generic way to find the PV's snapshot information.
-
-## Goals
-- Create a new metadata file to store backup's PVCs and PVs information and volume data backing up method. The file can be used to let downstream consumers generate a summary.
-- Create a generic way to let the Velero server know how the PV resources are backed up.
-- Create a generic way to let the Velero server find the PV corresponding snapshot information.
-
-## Non Goals
-- Unify how to get snapshot size information for all PV backing-up methods, and all other currently not ready PVs' information.
-
-## High-Level Design
-Create _backup-name_-volumes-info.json metadata file in the backup's repository. This file will be encoded to contain all the PVC and PV information included in the backup. The information covers whether the PV or PVC's data is skipped during backup, how its data is backed up, and the backed-up detail information.
-
-Please notice that the new metadata file includes all skipped volume information. This is used to address [the second phase needs of skipped volumes information](https://github.com/vmware-tanzu/velero/issues/5834#issuecomment-1526624211).
-
-The `restoreItem` function can decode the _backup-name_-volumes-info.json file to determine how to handle the PV resource. 
-
-## Detailed Design
-
-### The VolumeInfo structure
-_backup-name_-volumes-info.json file is a structure that contains an array of structure `VolumeInfo`.
-
-``` golang
-type VolumeInfo struct {
-    PVCName        string    // The PVC's name.
-    PVCNamespace   string    // The PVC's namespace.
-    PVName         string    // The PV name.
-    BackupMethod   string    // The way the volume data is backed up. The valid value includes `VeleroNativeSnapshot`, `PodVolumeBackup` and `CSISnapshot`.
-    SnapshotDataMoved bool   // Whether the volume's snapshot data is moved to specified storage.
-
-    Skipped         boolean   // Whether the Volume is skipped in this backup.
-    SkippedReason   string    // The reason for the volume is skipped in the backup.
-    StartTimestamp  *metav1.Time // Snapshot starts timestamp.
-
-    OperationID     string   // The Async Operation's ID.
-
-    CSISnapshotInfo          CSISnapshotInfo
-    SnapshotDataMovementInfo SnapshotDataMovementInfo
-    NativeSnapshotInfo       VeleroNativeSnapshotInfo
-    PVBInfo                  PodVolumeBackupInfo
-    PVInfo                   PVInfo
-}
-
-// CSISnapshotInfo is used for displaying the CSI snapshot status
-type CSISnapshotInfo struct {
-    SnapshotHandle  string       // It's the storage provider's snapshot ID for CSI.
-    Size            int64        // The snapshot corresponding volume size.
-
-    Driver          string  // The name of the CSI driver.
-    VSCName         string // The name of the VolumeSnapshotContent. 
-}
-
-// SnapshotDataMovementInfo is used for displaying the snapshot data mover status.
-type SnapshotDataMovementInfo struct {
-    DataMover        string    // The data mover used by the backup. The valid values are `velero` and ``(equals to `velero`).
-    UploaderType     string    // The type of the uploader that uploads the snapshot data. The valid values are `kopia` and `restic`.
-    RetainedSnapshot string    // The name or ID of the snapshot associated object(SAO). SAO is used to support local snapshots for the snapshot data mover, e.g. it could be a VolumeSnapshot for CSI snapshot data moign/pv_backup_info.
-    SnapshotHandle string  	   // It's the filesystem repository's snapshot ID.
-	
-}
-
-// VeleroNativeSnapshotInfo is used for displaying the Velero native snapshot status.
-type VeleroNativeSnapshotInfo struct {
-    SnapshotHandle      string       // It's the storage provider's snapshot ID for the Velero-native snapshot.
-
-    VolumeType string    // The cloud provider snapshot volume type.
-    VolumeAZ   string    // The cloud provider snapshot volume's availability zones.
-    IOPS       string    // The cloud provider snapshot volume's IOPS.
-}
-
-// PodVolumeBackupInfo is used for displaying the PodVolumeBackup snapshot status.
-type PodVolumeBackupInfo struct {
-    SnapshotHandle      string       // It's the file-system uploader's snapshot ID for PodVolumeBackup.
-    Size                int64        // The snapshot corresponding volume size.
-
-    UploaderType  string    // The type of the uploader that uploads the data. The valid values are `kopia` and `restic`.
-    VolumeName    string   // The PVC's corresponding volume name used by Pod: https://github.com/kubernetes/kubernetes/blob/e4b74dd12fa8cb63c174091d5536a10b8ec19d34/pkg/apis/core/types.go#L48
-    PodName       string   // The Pod name mounting this PVC.
-    PodNamespace  string   // The Pod namespace.
-    NodeName      string   // The PVB-taken k8s node's name.
-}
-
-// PVInfo is used to store some PV information modified after creation.
-// Those information are lost after PV recreation.
-type PVInfo struct {
-    ReclaimPolicy string            // ReclaimPolicy of PV. It could be different from the referenced StorageClass.
-    Labels        map[string]string // The PV's labels should be kept after recreation.
-}
-```
-
-### How the VolumeInfo array is generated.
-The function `persistBackup` has `backup *pkgbackup.Request` in parameters.
-From it, the `VolumeSnapshots`, `PodVolumeBackups`, `CSISnapshots`, `itemOperationsList`, and `SkippedPVTracker` can be read. All of them will be iterated and merged into the `VolumeInfo` array, and then persisted into backup repository in function `persistBackup`.
-
-Please notice that the change happened in async operations are not reflected in the new metadata file. The file only covers the volume changes happen in the Velero server process scope.
-
-A new methods are added to BackupStore to download the VolumeInfo metadata file.
-Uploading the metadata file is covered in the exiting `PutBackup` method.
-
-``` golang
-type BackupStore interface {
-    ...
-    GetVolumeInfos(name string) ([]*VolumeInfo, error)
-    ...
-}
-```
-
-### How the VolumeInfo array is used.
-
-#### Generate the PVC backed-up information summary
-The downstream tools can use this VolumeInfo array to format and display their volume information. This is not in the scope of this feature.
-
-#### Retrieve volume backed-up information for `velero backup describe` command
-The `velero backup describe` can also use this VolumeInfo array structure to display the volume information. The snapshot data mover volume should use this structure at first, then the Velero native snapshot, CSI snapshot, and PodVolumeBackup can also use this structure. The detailed implementation is also not in this feature's scope.
-
-#### Let restore know how to restore the PV
-In the function `restoreItem`, it will determine whether to restore the PV resource by checking it in the Velero native snapshots list, PodVolumeBackup list, and its DeletionPolicy. This logic is still kept. The logic will be used when the new `VolumeInfo` metadata cannot be found to support backward compatibility.
-
-``` golang
-	if groupResource == kuberesource.PersistentVolumes {
-		switch {
-		case hasSnapshot(name, ctx.volumeSnapshots):
-            ...
-        case hasPodVolumeBackup(obj, ctx):
-            ...
-        case hasDeleteReclaimPolicy(obj.Object):
-            ...
-        default:
-            ...
-```
-
-After introducing the VolumeInfo array, the following logic will be added.
-``` golang
-	if groupResource == kuberesource.PersistentVolumes {
-        volumeInfo := GetVolumeInfo(pvName)
-		switch volumeInfo.BackupMethod {
-		case VeleroNativeSnapshot:
-            ...
-        case PodVolumeBackup:
-            ...
-        case CSISnapshot:
-            ...
-        default:
-            // Need to check whether the volume is backed up by the SnapshotDataMover.
-            if volumeInfo.SnapshotDataMovement:
-
-            // Check whether the Velero server should restore the PV depending on the DeletionPolicy setting.
-            if volumeInfo.Skipped:
-```
-
-### How the VolumeInfo metadata file is deleted
-_backup-name_-volumes-info.json file is deleted during backup deletion.
-
-## Alternatives Considered
-The restore process needs more information about how the PVs are backed up to determine whether this PV should be restored. The released branches also need a similar function, but backporting a new feature into previous releases may not be a good idea, so according to [Anshul Ahuja's suggestion](https://github.com/vmware-tanzu/velero/issues/6595#issuecomment-1731081580), adding more cases here to support checking PV backed-up by CSI plugin and CSI snapshot data mover: https://github.com/vmware-tanzu/velero/blob/5ff5073cc3f364bafcfbd26755e2a92af68ba180/pkg/restore/restore.go#L1206-L1324.
-
-## Security Considerations
-There should be no security impact introduced by this design.
-
-## Compatibility
-After this design is implemented, there should be no impact on the existing [skipped PVC summary feature](https://github.com/vmware-tanzu/velero/pull/6496).
-
-To support older version backup, which doesn't have the VolumeInfo metadata file, the old logic, which is checking the Velero native snapshots list, PodVolumeBackup list, and PVC DeletionPolicy, is still kept, and supporting CSI snapshots and snapshot data mover logic will be added too.
-
-## Implementation
-This will be implemented in the Velero v1.13 development cycle.
-
-## Open Issues
-There are no open issues identified by now.

design/Implemented/restore-with-EnableAPIGroupVersions-feature.md

@@ -29,7 +29,7 @@ During restore, the proposal is that Velero will determine if the `APIGroupVersi
 The proposed code starts with creating three lists for each backed up resource. The three lists will be created by
   (1) reading the directory names in the backup tarball file and seeing which API group versions were backed up from the source cluster,
   (2) looking at the target cluster and determining which API group versions are supported, and
-  (3) getting ConfigMaps from the target cluster in order to get user-defined prioritization of versions.
+  (3) getting config maps from the target cluster in order to get user-defined prioritization of versions.
 
   The three lists will be used to create a map of chosen versions for each resource to restore. If there is a user-defined list of priority versions, the versions will be checked against the supported versions lists. The highest user-defined priority version that is/was supported by both target and source clusters will be the chosen version for that resource. If no user specified versions are supported by neither target nor source, the versions will be logged and the restore will continue with other prioritizations.
 

design/Implemented/schedule-skip-immediately-config_design.md

@@ -1,145 +0,0 @@
-# Schedule Skip Immediately Config Design
-## Abstract
-When unpausing schedule, a backup could be due immediately.
-New Schedules also create new backup immediately.
-
-This design allows user to *skip **immediately due** backup run upon unpausing or schedule creation*.
-
-## Background
-Currently, the default behavior of schedule when `.Status.LastBackup` is nil or is due immediately after unpausing, a backup will be created. This may not be a desired by all users (https://github.com/vmware-tanzu/velero/issues/6517)
-
-User want ability to skip the first immediately due backup when schedule is unpaused and or created.
-
-If you create a schedule with cron "45 * * * *" and pause it at say the 43rd minute and then unpause it at say 50th minute, a backup gets triggered (since .Status.LastBackup is nil or >60min ago).
-
-With this design, user can skip the first immediately due backup when schedule is unpaused and or created.
-
-## Goals
-- Add an option so user can when unpausing (when immediately due) or creating new schedule, to not create a backup immediately.
-
-## Non Goals
-- Changing the default behavior
-
-## High-Level Design
-Add a new field with to the schedule spec and as a new cli flags for install, server, schedule commands; allowing user to skip immediately due backup when unpausing or schedule creation.
-
-If CLI flag is specified during schedule unpause, velero will update the schedule spec accordingly and override prior spec for `skipImmediately``.
-
-## Detailed Design
-### CLI Changes
-`velero schedule unpause` will now take an optional bool flag `--skip-immediately` to allow user to override the behavior configured for velero server (see `velero server` below).
-
-`velero schedule unpause schedule-1 --skip-immediately=false` will unpause the schedule but not skip the backup if due immediately from `Schedule.Status.LastBackup` timestamp. Backup will be run at the next cron schedule.
-
-`velero schedule unpause schedule-1 --skip-immediately=true` will unpause the schedule and skip the backup if due immediately from `Schedule.Status.LastBackup` timestamp. Backup will also be run at the next cron schedule.
-
-`velero schedule unpause schedule-1` will check `.spec.SkipImmediately` in the schedule to determine behavior. This field will default to false to maintain prior behavior.
-
-`velero server` will add a new flag `--schedule-skip-immediately` to configure default value to patch new schedules created without the field. This flag will default to false to maintain prior behavior if not set.
-
-`velero install` will add a new flag `--schedule-skip-immediately` to configure default value to patch new schedules created without the field. This flag will default to false to maintain prior behavior if not set.
-
-### API Changes
-`pkg/apis/velero/v1/schedule_types.go`
-```diff
-// ScheduleSpec defines the specification for a Velero schedule
-type ScheduleSpec struct {
-	// Template is the definition of the Backup to be run
-	// on the provided schedule
-	Template BackupSpec `json:"template"`
-
-	// Schedule is a Cron expression defining when to run
-	// the Backup.
-	Schedule string `json:"schedule"`
-
-	// UseOwnerReferencesBackup specifies whether to use
-	// OwnerReferences on backups created by this Schedule.
-	// +optional
-	// +nullable
-	UseOwnerReferencesInBackup *bool `json:"useOwnerReferencesInBackup,omitempty"`
-
-	// Paused specifies whether the schedule is paused or not
-	// +optional
-	Paused bool `json:"paused,omitempty"`
-
-+	// SkipImmediately specifies whether to skip backup if schedule is due immediately from `Schedule.Status.LastBackup` timestamp when schedule is unpaused or if schedule is new.
-+	// If true, backup will be skipped immediately when schedule is unpaused if it is due based on .Status.LastBackupTimestamp or schedule is new, and will run at next schedule time.
-+	// If false, backup will not be skipped immediately when schedule is unpaused, but will run at next schedule time.
-+	// If empty, will follow server configuration (default: false). 
-+	// +optional
-+	SkipImmediately bool `json:"skipImmediately,omitempty"`
-}
-```
-
-`LastSkipped` will be added to `ScheduleStatus` struct to track the last time a schedule was skipped.
-```diff
-// ScheduleStatus captures the current state of a Velero schedule
-type ScheduleStatus struct {
-	// Phase is the current phase of the Schedule
-	// +optional
-	Phase SchedulePhase `json:"phase,omitempty"`
-
-	// LastBackup is the last time a Backup was run for this
-	// Schedule schedule
-	// +optional
-	// +nullable
-	LastBackup *metav1.Time `json:"lastBackup,omitempty"`
-
-+	// LastSkipped is the last time a Schedule was skipped
-+	// +optional
-+	// +nullable
-+	LastSkipped *metav1.Time `json:"lastSkipped,omitempty"`
-
-	// ValidationErrors is a slice of all validation errors (if
-	// applicable)
-	// +optional
-	ValidationErrors []string `json:"validationErrors,omitempty"`
-}
-```
-
-When `schedule.spec.SkipImmediately` is `true`, `LastSkipped` will be set to the current time, and `schedule.spec.SkipImmediately` set to nil so it can be used again.
-
-The `getNextRunTime()` function below is updated so `LastSkipped` which is after `LastBackup` will be used to determine next run time.
-
-```go
-func getNextRunTime(schedule *velerov1.Schedule, cronSchedule cron.Schedule, asOf time.Time) (bool, time.Time) {
-	var lastBackupTime time.Time
-	if schedule.Status.LastBackup != nil {
-		lastBackupTime = schedule.Status.LastBackup.Time
-	} else {
-		lastBackupTime = schedule.CreationTimestamp.Time
-	}
-	if schedule.Status.LastSkipped != nil && schedule.Status.LastSkipped.After(lastBackupTime) {
-		lastBackupTime = schedule.Status.LastSkipped.Time
-	}
-
-	nextRunTime := cronSchedule.Next(lastBackupTime)
-
-	return asOf.After(nextRunTime), nextRunTime
-}
-```
-
-When schedule is unpaused, and `Schedule.Status.LastBackup` is not nil, if `Schedule.Status.LastSkipped` is recent, a backup will not be created.
-
-When schedule is unpaused or created with `Schedule.Status.LastBackup` set to nil or schedule is newly created, normally a backup will be created immediately. If `Schedule.Status.LastSkipped` is recent, a backup will not be created.
-
-Backup will be run at the next cron schedule based on LastBackup or LastSkipped whichever is more recent.
-
-## Alternatives Considered
-
-N/A
-
-
-## Security Considerations
-None
-
-## Compatibility
-Upon upgrade, the new field will be added to the schedule spec automatically and will default to the prior behavior of running a backup when schedule is unpaused if it is due based on .Status.LastBackup or schedule is new.
-
-Since this is a new field, it will be ignored by older versions of velero.
-
-## Implementation
-TBD
-
-## Open Issues
-N/A

design/Implemented/unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md

@@ -433,24 +433,23 @@ spec:
   volume: nginx-log
 ```
 We will add the flag for both CLI installation and Helm Chart Installation. Specifically:
-- Helm Chart Installation: add the "--uploaderType" and "--default-volumes-to-fs-backup" flag into its value.yaml and then generate the deployments according to the value. Value.yaml is the user-provided configuration file, therefore, users could set this value at the time of installation. The changes in Value.yaml are as below:
+- Helm Chart Installation: add the "--pod-volume-backup-uploader" flag into its value.yaml and then generate the deployments according to the value. Value.yaml is the user-provided configuration file, therefore, users could set this value at the time of installation. The changes in Value.yaml are as below:
 ```
           command:
             - /velero
           args:
             - server
           {{- with .Values.configuration }}
-		    - --uploader-type={{ default "restic" .uploaderType }}
-			{{- if .defaultVolumesToFsBackup }}
-            - --default-volumes-to-fs-backup
-            {{- end }}
+            {{- if .pod-volume-backup-uploader "restic" }}
+            - --legacy
+            {{- end }} 
 ```     
-- CLI Installation: add the "--uploaderType" and "--default-volumes-to-fs-backup" flag into the installation command line, and then create the two deployments accordingly. Users could change the option at the time of installation. The CLI is as below:  
-```velero install --uploader-type=restic --default-volumes-to-fs-backup --use-node-agent```  
-```velero install --uploader-type=kopia --default-volumes-to-fs-backup --use-node-agent``` 
+- CLI Installation: add the "--pod-volume-backup-uploader" flag into the installation command line, and then create the two deployments accordingly. Users could change the option at the time of installation. The CLI is as below:  
+```velero install --pod-volume-backup-uploader=restic```  
+```velero install --pod-volume-backup-uploader=kopia``` 
 
 ## Upgrade
-For upgrade, we allow users to change the path by specifying "--uploader-type" flag in the same way as the fresh installation. Therefore, the flag change should be applied to the Velero server after upgrade. Additionally, We need to add a label to Velero server to indicate the current path, so as to provide an easy for querying it.  
+For upgrade, we allow users to change the path by specifying "--pod-volume-backup-uploader" flag in the same way as the fresh installation. Therefore, the flag change should be applied to the Velero server after upgrade. Additionally, We need to add a label to Velero server to indicate the current path, so as to provide an easy for querying it.  
 Moreover, if users upgrade from the old release, we need to change the existing Restic Daemonset name to VeleroNodeAgent daemonSet. The name change should be applied after upgrade.  
 The recommended way for upgrade is to modify the related Velero resource directly through kubectl, the above changes will be applied in the same way. We need to modify the Velero doc for all these changes.  
 
@@ -460,7 +459,7 @@ Below Velero CLI or its output needs some changes:
 - ```Velero restore describe```: the output should indicate the path  
 - ```Velero restic repo get```: the name of this CLI should be changed to a generic one, for example, "Velero repo get"; the output of this CLI should print all the backup repository if Restic repository and Unified Repository exist at the same time  
 
-At present, we don't have a requirement for selecting the path during backup, so we don't change the ```Velero backup create``` CLI for now. If there is a requirement in future, we could simply add a flag similar to "--uploader-type" to select the path.  
+At present, we don't have a requirement for selecting the path during backup, so we don't change the ```Velero backup create``` CLI for now. If there is a requirement in future, we could simply add a flag similar to "--pod-volume-backup-uploader" to select the path.  
 
 ## CR Example
 Below sample files demonstrate complete CRs with all the changes mentioned above:

design/Implemented/velero-uploader-configuration.md

@@ -1,181 +0,0 @@
-# Velero Uploader Configuration Integration and Extensibility
-
-## Abstract
-This design proposal aims to make Velero Uploader configurable by introducing a structured approach for managing Uploader settings. we will define and standardize a data structure to facilitate future additions to Uploader configurations. This enhancement provides a template for extending Uploader-related options. And also includes examples of adding sub-options to the Uploader Configuration.
-
-## Background
-Velero is widely used for backing up and restoring Kubernetes clusters. In various scenarios, optimizing the backup process is essential, future needs may arise for adding more configuration options related to the Uploader component especially when dealing with large datasets. Therefore, a standardized configuration template is required.
-
-## Goals
-1. **Extensible Uploader Configuration**: Provide an extensible approach to manage Uploader configurations, making it easy to add and modify configuration options related to the Velero uploader.
-2. **User-friendliness**: Ensure that the new Uploader configuration options are easy to understand and use for Velero users without introducing excessive complexity.
-
-## Non Goals
-1. Expanding to other Velero components: The primary focus of this design is Uploader configuration and does not include extending to other components or modules within Velero. Configuration changes for other components may require separate design and implementation.
-
-## High-Level Design
-To achieve extensibility in Velero Uploader configurations, the following key components and changes are proposed:
-
-### UploaderConfig Structure
-Two new data structures, `UploaderConfigForBackup` and `UploaderConfigForRestore`, will be defined to store Uploader configurations. These structures will include the configuration options related to backup and restore for Uploader:
-
-```go
-type UploaderConfigForBackup struct {
-}
-
-type UploaderConfigForRestore struct {
-}
-```
-
-### Integration with Backup & Restore CRD
-The Velero CLI will support an uploader configuration-related flag, allowing users to set the value when creating backups or restores. This value will be stored in the `UploaderConfig` field within the `Backup` CRD and `Restore` CRD:
-
-```go
-type BackupSpec struct {
-	// UploaderConfig specifies the configuration for the uploader.
-	// +optional
-	// +nullable
-	UploaderConfig *UploaderConfigForBackup `json:"uploaderConfig,omitempty"`
-}
-
-type RestoreSpec struct {
-	// UploaderConfig specifies the configuration for the restore.
-	// +optional
-	// +nullable
-	UploaderConfig *UploaderConfigForRestore `json:"uploaderConfig,omitempty"`
-}
-```
-
-### Configuration Propagated to Different CRDs
-The configuration specified in `UploaderConfig` needs to be effective for backup and restore both by file system way and data-mover way. 
-Therefore, the `UploaderConfig` field value from the `Backup` CRD should be propagated to `PodVolumeBackup` and `DataUpload` CRDs.
-
-We aim for the configurations in PodVolumeBackup to originate not only from UploaderConfig in Backup but also potentially from other sources such as the server or configmap. Simultaneously, to align with the configurations in DataUpload's `DataMoverConfig map[string]string`, we have defined an `UploaderSettings map[string]string` here to record the configurations in PodVolumeBackup.
-
-```go
-type PodVolumeBackupSpec struct {
-	// UploaderSettings are a map of key-value pairs that should be applied to the
-	// uploader configuration.
-	// +optional
-	// +nullable
-	UploaderSettings map[string]string `json:"uploaderSettings,omitempty"`
-}
-```
-
-`UploaderConfig` will be stored in DataUpload's `DataMoverConfig map[string]string` field.
-
-Also the `UploaderConfig` field value from the `Restore` CRD should be propagated to `PodVolumeRestore` and `DataDownload` CRDs:
-
-```go
-type PodVolumeRestoreSpec struct {
-	// UploaderSettings are a map of key-value pairs that should be applied to the
-	// uploader configuration.
-	// +optional
-	// +nullable
-	UploaderSettings map[string]string `json:"uploaderSettings,omitempty"`
-}
-```
-Also `UploaderConfig` will be stored in DataUpload's `DataMoverConfig map[string]string` field.
-
-### Store and Get Configuration
-We need to store and retrieve configurations in the PodVolumeBackup and DataUpload structs. This involves type conversion based on the configuration type, storing it in a map[string]string, or performing type conversion from this map for retrieval.
-
-PodVolumeRestore and DataDownload are also similar.
-
-## Sub-options in UploaderConfig
-Adding fields above in CRDs can accommodate any future additions to Uploader configurations by adding new fields to the `UploaderConfigForBackup` or `UploaderConfigForRestore` structures.
-
-### Parallel Files Upload
-This section focuses on enabling the configuration for the number of parallel file uploads during backups.
-below are the key steps that should be added to support this new feature.
-
-#### Velero CLI
-The Velero CLI will support a `--parallel-files-upload` flag, allowing users to set the `ParallelFilesUpload` value when creating backups.
-
-#### UploaderConfig
-below the sub-option `ParallelFilesUpload` is added into UploaderConfig:
-
-```go
-// UploaderConfigForBackup defines the configuration for the uploader when doing backup.
-type UploaderConfigForBackup struct {
-	// ParallelFilesUpload is the number of files parallel uploads to perform when using the uploader.
-	// +optional
-	ParallelFilesUpload int `json:"parallelFilesUpload,omitempty"`
-}
-```
-
-#### Kopia Parallel Upload Policy
-Velero Uploader can set upload policies when calling Kopia APIs. In the Kopia codebase, the structure for upload policies is defined as follows:
-
-```go
-// UploadPolicy describes the policy to apply when uploading snapshots.
-type UploadPolicy struct {
-    ...
-    MaxParallelFileReads *OptionalInt `json:"maxParallelFileReads,omitempty"`
-}
-```
-
-Velero can set the `MaxParallelFileReads` parameter for Kopia's upload policy as follows:
-
-```go
-curPolicy := getDefaultPolicy()
-if parallelUpload > 0 {
-	curPolicy.UploadPolicy.MaxParallelFileReads = newOptionalInt(parallelUpload)
-}
-```
-
-#### Restic Parallel Upload Policy
-As Restic does not support parallel file upload, the configuration would not take effect, so we should output a warning when the user sets the `ParallelFilesUpload` value by using Restic to do a backup.
-
-```go
-if parallelFilesUpload > 0 {
-	log.Warnf("ParallelFilesUpload is set to %d, but Restic does not support parallel file uploads. Ignoring", parallelFilesUpload)
-	}
-```
-
-Roughly, the process is as follows: 
-1. Users pass the ParallelFilesUpload parameter and its value through the Velero CLI. This parameter and its value are stored as a sub-option within UploaderConfig and then placed into the Backup CR. 
-2. When users perform file system backups, UploaderConfig is passed to the PodVolumeBackup CR. When users use the Data-mover for backups, it is passed to the DataUpload CR. 
-3. The configuration will be stored in map[string]string type of field in CR.
-3. Each respective controller within the CRs calls the uploader, and the ParallelFilesUpload from map in CRs is passed to the uploader.
-4. When the uploader subsequently calls the Kopia API, it can use the ParallelFilesUpload to set the MaxParallelFileReads parameter, and if the uploader calls the Restic command it would output one warning log for Restic does not support this feature.
-
-### Sparse Option For Kopia & Restic Restore
-In many system files, numerous zero bytes or empty blocks persist, occupying physical storage space. Sparse restore employs a more intelligent approach, including appropriately handling empty blocks, thereby achieving the correct system state. This write sparse files mechanism aims to enhance restore efficiency while maintaining restoration accuracy.
-Below are the key steps that should be added to support this new feature.
-#### Velero CLI
-The Velero CLI will support a `--write-sparse-files` flag, allowing users to set the `WriteSparseFiles` value when creating restores with Restic or Kopia uploader.
-#### UploaderConfig
-below the sub-option `WriteSparseFiles` is added into UploaderConfig:
-```go
-// UploaderConfigForRestore defines the configuration for the restore.
-type UploaderConfigForRestore struct {
-	// WriteSparseFiles is a flag to indicate whether write files sparsely or not.
-	// +optional
-	// +nullable
-	WriteSparseFiles *bool `json:"writeSparseFiles,omitempty"`
-}
-```
-
-### Enable Sparse in Restic
-For Restic, it could be enabled by pass the flag `--sparse` in creating restore:
-```bash
-restic restore create --sparse $snapshotID
-```
-### Enable Sparse in Kopia
-For Kopia, it could be enabled this feature by the `WriteSparseFiles` field in the [FilesystemOutput](https://pkg.go.dev/github.com/kopia/kopia@v0.13.0/snapshot/restore#FilesystemOutput).
-
-```go
-fsOutput := &restore.FilesystemOutput{
-		WriteSparseFiles:       uploaderutil.GetWriteSparseFiles(uploaderCfg),
-	}
-```
-Roughly, the process is as follows:
-1. Users pass the WriteSparseFiles parameter and its value through the Velero CLI. This parameter and its value are stored as a sub-option within UploaderConfig and then placed into the Restore CR.
-2. When users perform file system restores, UploaderConfig is passed to the PodVolumeRestore CR. When users use the Data-mover for restores, it is passed to the DataDownload CR.
-3. The configuration will be stored in map[string]string type of field in CR.
-4. Each respective controller within the CRs calls the uploader, and the WriteSparseFiles from map in CRs is passed to the uploader.
-5. When the uploader subsequently calls the Kopia API, it can use the WriteSparseFiles to set the WriteSparseFiles parameter, and if the uploader calls the Restic command it would append `--sparse` flag within the restore command.
-
-## Alternatives Considered
-To enhance extensibility further, the option of storing `UploaderConfig` in a Kubernetes ConfigMap can be explored, this approach would allow the addition and modification of configuration options without the need to modify the CRD.

design/volume-snapshot-data-movement/volume-snapshot-data-movement.md

@@ -397,7 +397,7 @@ Target volume information includes PVC and PV that represents the volume and the
 The data mover information and backup repository information are the same with DataUpload CRD.
 DataDownload CRD defines the same status as DataUpload CRD with nearly the same meanings.  
 
-Below is the full spec of DataDownload CRD:
+Below is the full spec of DataUpload CRD:
 ```
 apiVersion: apiextensions.k8s.io/v1alpha1
 kind: CustomResourceDefinition
@@ -626,9 +626,10 @@ Therefore, we have below principles:
 
 We will address the two principles step by step. As the first step, VBDM’s parallelism is designed as below:  
 - We don’t create the load balancing mechanism for the first step, we don’t detect the accessibility of the volume/volume snapshot explicitly. Instead, we create the backupPod/restorePod under the help of Kubernetes, Kubernetes schedules the backupPod/restorePod to the appropriate node, then the data movement controller on that node will handle the DataUpload/DataDownload CR there, so the resource will be consumed from that node.
-- We expose the configurable concurrency value per node, for details of how the concurrency number constraints various backups and restores which share VGDP, check the [node-agent concurrency design][3].  
+- We don’t expose the configurable concurrency value in one node, instead, the concurrency value in value will be set to 1, that is, there is no concurrency in one node.
 
 As for the resource consumption, it is related to the data scale of the data movement activity and it is charged to node-agent pods, so users should configure enough resource to node-agent pods.  
+Meanwhile, Pod Volume Backup/Restore are also running in node-agent pods, we don’t restrict the concurrency of these two types. For example, in one node, one Pod Volume Backup and one DataUpload could run at the same time, in this case, the resource will be shared by the two activities.  
 
 ## Progress Report
 When a DUCR/DDCR is in InProgress phase, users could check the progress.  
@@ -665,9 +666,6 @@ At present, VBDM doesn't support recovery, so it will follow the second rule.
 ## Kopia For Block Device
 To work with block devices, VGDP will be updated. Today, when Kopia attempts to create a snapshot of the block device, it will error because kopia does not support this file type. Kopia does have a nice set of interfaces that are able to be extended though.
 
-**Notice**
-The Kopia block mode uploader only supports non-Windows platforms, because the block mode code invokes some system calls that are not present in the Windows platform.
-
 To achieve the necessary information to determine the type of volume that is being used, we will need to pass in the volume mode in provider interface.
 
 ```go
@@ -691,8 +689,7 @@ type Provider interface {
 		tags map[string]string,
 		forceFull bool,
 		parentSnapshot string,
-                volMode uploader.PersistentVolumeMode,
-		uploaderCfg shared.UploaderConfig,
+		volMode uploader.PersistentVolumeMode,
 		updater uploader.ProgressUpdater) (string, bool, error)
 
   RunRestore(
@@ -706,38 +703,33 @@ type Provider interface {
 In this case, we will extend the default kopia uploader to add the ability, when a given volume is for a block mode and is mapped as a device, we will use the [StreamingFile](https://pkg.go.dev/github.com/kopia/kopia@v0.13.0/fs#StreamingFile) to stream the device and backup to the kopia repository. 
 
 ```go
-func getLocalBlockEntry(sourcePath string) (fs.Entry, error) {
-	source, err := resolveSymlink(sourcePath)
-	if err != nil {
-		return nil, errors.Wrap(err, "resolveSymlink")
-	}
+func getLocalBlockEntry(kopiaEntry fs.Entry, log logrus.FieldLogger) (fs.Entry, error) {
+	path := kopiaEntry.LocalFilesystemPath()
 
-	fileInfo, err := os.Lstat(source)
+	fileInfo, err := os.Lstat(path)
 	if err != nil {
-		return nil, errors.Wrapf(err, "unable to get the source device information %s", source)
+		return nil, errors.Wrapf(err, "Unable to get the source device information %s", path)
 	}
 
 	if (fileInfo.Sys().(*syscall.Stat_t).Mode & syscall.S_IFMT) != syscall.S_IFBLK {
-		return nil, errors.Errorf("source path %s is not a block device", source)
+		return nil, errors.Errorf("Source path %s is not a block device", path)
 	}
-
-	device, err := os.Open(source)
+  	device, err := os.Open(path)
 	if err != nil {
 		if os.IsPermission(err) || err.Error() == ErrNotPermitted {
-			return nil, errors.Wrapf(err, "no permission to open the source device %s, make sure that node agent is running in privileged mode", source)
+			return nil, errors.Wrapf(err, "No permission to open the source device %s, make sure that node agent is running in privileged mode", path)
 		}
-		return nil, errors.Wrapf(err, "unable to open the source device %s", source)
+		return nil, errors.Wrapf(err, "Unable to open the source device %s", path)
 	}
+	return virtualfs.StreamingFileFromReader(kopiaEntry.Name(), device), nil
 
-	sf := virtualfs.StreamingFileFromReader(source, device)
-	return virtualfs.NewStaticDirectory(source, []fs.Entry{sf}), nil
 }
 ```
 
 In the `pkg/uploader/kopia/snapshot.go` this is used in the Backup call like
 
 ```go
-	if volMode == uploader.PersistentVolumeFilesystem {
+	if volMode == PersistentVolumeFilesystem {
 		// to be consistent with restic when backup empty dir returns one error for upper logic handle
 		dirs, err := os.ReadDir(source)
 		if err != nil {
@@ -750,17 +742,15 @@ In the `pkg/uploader/kopia/snapshot.go` this is used in the Backup call like
   source = filepath.Clean(source)
   ...
 
-	var sourceEntry fs.Entry
+  sourceEntry, err := getLocalFSEntry(source)
+	if err != nil {
+		return nil, false, errors.Wrap(err, "Unable to get local filesystem entry")
+	}
 
-	if volMode == uploader.PersistentVolumeBlock {
-		sourceEntry, err = getLocalBlockEntry(source)
+  if volMode == PersistentVolumeBlock {
+		sourceEntry, err = getLocalBlockEntry(sourceEntry, log)
 		if err != nil {
-			return nil, false, errors.Wrap(err, "unable to get local block device entry")
-		}
-	} else {
-		sourceEntry, err = getLocalFSEntry(source)
-		if err != nil {
-			return nil, false, errors.Wrap(err, "unable to get local filesystem entry")
+			return nil, false, errors.Wrap(err, "Unable to get local block device entry")
 		}
 	}
 
@@ -776,8 +766,6 @@ We only need to extend two functions the rest will be passed through.
 ```go
 type BlockOutput struct {
 	*restore.FilesystemOutput
-
-	targetFileName string
 }
 
 var _ restore.Output = &BlockOutput{}
@@ -785,15 +773,30 @@ var _ restore.Output = &BlockOutput{}
 const bufferSize = 128 * 1024
 
 func (o *BlockOutput) WriteFile(ctx context.Context, relativePath string, remoteFile fs.File) error {
+
+	targetFileName, err := filepath.EvalSymlinks(o.TargetPath)
+	if err != nil {
+		return errors.Wrapf(err, "Unable to evaluate symlinks for %s", targetFileName)
+	}
+
+	fileInfo, err := os.Lstat(targetFileName)
+	if err != nil {
+		return errors.Wrapf(err, "Unable to get the target device information for %s", targetFileName)
+	}
+
+	if (fileInfo.Sys().(*syscall.Stat_t).Mode & syscall.S_IFMT) != syscall.S_IFBLK {
+		return errors.Errorf("Target file %s is not a block device", targetFileName)
+	}
+
 	remoteReader, err := remoteFile.Open(ctx)
 	if err != nil {
-		return errors.Wrapf(err, "failed to open remote file %s", remoteFile.Name())
+		return errors.Wrapf(err, "Failed to open remote file %s", remoteFile.Name())
 	}
 	defer remoteReader.Close()
 
-	targetFile, err := os.Create(o.targetFileName)
+	targetFile, err := os.Create(targetFileName)
 	if err != nil {
-		return errors.Wrapf(err, "failed to open file %s", o.targetFileName)
+		return errors.Wrapf(err, "Failed to open file %s", targetFileName)
 	}
 	defer targetFile.Close()
 
@@ -804,7 +807,7 @@ func (o *BlockOutput) WriteFile(ctx context.Context, relativePath string, remote
 		bytesToWrite, err := remoteReader.Read(buffer)
 		if err != nil {
 			if err != io.EOF {
-				return errors.Wrapf(err, "failed to read data from remote file %s", o.targetFileName)
+				return errors.Wrapf(err, "Failed to read data from remote file %s", targetFileName)
 			}
 			readData = false
 		}
@@ -816,7 +819,7 @@ func (o *BlockOutput) WriteFile(ctx context.Context, relativePath string, remote
 					bytesToWrite -= bytesWritten
 					offset += bytesWritten
 				} else {
-					return errors.Wrapf(err, "failed to write data to file %s", o.targetFileName)
+					return errors.Wrapf(err, "Failed to write data to file %s", targetFileName)
 				}
 			}
 		}
@@ -826,43 +829,42 @@ func (o *BlockOutput) WriteFile(ctx context.Context, relativePath string, remote
 }
 
 func (o *BlockOutput) BeginDirectory(ctx context.Context, relativePath string, e fs.Directory) error {
-	var err error
-	o.targetFileName, err = filepath.EvalSymlinks(o.TargetPath)
+	targetFileName, err := filepath.EvalSymlinks(o.TargetPath)
 	if err != nil {
-		return errors.Wrapf(err, "unable to evaluate symlinks for %s", o.targetFileName)
+		return errors.Wrapf(err, "Unable to evaluate symlinks for %s", targetFileName)
 	}
 
-	fileInfo, err := os.Lstat(o.targetFileName)
+	fileInfo, err := os.Lstat(targetFileName)
 	if err != nil {
-		return errors.Wrapf(err, "unable to get the target device information for %s", o.TargetPath)
+		return errors.Wrapf(err, "Unable to get the target device information for %s", o.TargetPath)
 	}
 
 	if (fileInfo.Sys().(*syscall.Stat_t).Mode & syscall.S_IFMT) != syscall.S_IFBLK {
-		return errors.Errorf("target file %s is not a block device", o.TargetPath)
+		return errors.Errorf("Target file %s is not a block device", o.TargetPath)
 	}
 
 	return nil
 }
 ```
 
-Additional mount is required in the node-agent specification to resolve symlinks to the block devices from /host_pods/POD_ID/volumeDevices/kubernetes.io~csi directory.
+Of note, we do need to add root access to the daemon set node agent to access the new mount. 
 
 ```yaml
+...
             - mountPath: /var/lib/kubelet/plugins
               mountPropagation: HostToContainer
               name: host-plugins
+
 ....
         - hostPath:
             path: /var/lib/kubelet/plugins
           name: host-plugins
-```
 
-Privileged mode is required to access the block devices in /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/publish directory as confirmed by testing on EKS and Minikube.
-
-```yaml
+...
 							SecurityContext: &corev1.SecurityContext{
-								Privileged: &c.privilegedNodeAgent,
+								Privileged: &c.privilegedAgent,
 							},
+
 ```
 
 ## Plugin Data Movers
@@ -969,6 +971,5 @@ Restore command is kept as is.
 
 
 
-[1]: ../Implemented/unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md
-[2]: ../Implemented/general-progress-monitoring.md
-[3]: ../node-agent-concurrency.md
+[1]: ../unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md
+[2]: ../general-progress-monitoring.md

go.mod

@@ -1,58 +1,48 @@
 module github.com/vmware-tanzu/velero
 
-go 1.21
-
-toolchain go1.21.6
+go 1.20
 
 require (
-	cloud.google.com/go/storage v1.33.0
+	cloud.google.com/go/storage v1.30.1
 	github.com/Azure/azure-pipeline-go v0.2.3
 	github.com/Azure/azure-sdk-for-go v67.2.0+incompatible
-	github.com/Azure/azure-sdk-for-go/sdk/azcore v1.8.0
-	github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.3.1
-	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage v1.3.0
-	github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.1.0
 	github.com/Azure/azure-storage-blob-go v0.15.0
 	github.com/Azure/go-autorest/autorest v0.11.27
 	github.com/Azure/go-autorest/autorest/azure/auth v0.5.8
 	github.com/Azure/go-autorest/autorest/to v0.3.0
-	github.com/aws/aws-sdk-go-v2 v1.21.0
-	github.com/aws/aws-sdk-go-v2/config v1.18.42
-	github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.11.87
-	github.com/aws/aws-sdk-go-v2/service/ec2 v1.123.0
-	github.com/aws/aws-sdk-go-v2/service/s3 v1.40.0
+	github.com/aws/aws-sdk-go v1.44.253
 	github.com/bombsimon/logrusr/v3 v3.0.0
 	github.com/evanphx/json-patch v5.6.0+incompatible
 	github.com/fatih/color v1.15.0
 	github.com/gobwas/glob v0.2.3
 	github.com/golang/protobuf v1.5.3
 	github.com/google/go-cmp v0.5.9
-	github.com/google/uuid v1.3.1
+	github.com/google/uuid v1.3.0
 	github.com/hashicorp/go-hclog v0.14.1
 	github.com/hashicorp/go-plugin v1.4.3
 	github.com/joho/godotenv v1.3.0
-	github.com/kopia/kopia v0.14.1
+	github.com/kopia/kopia v0.13.0
 	github.com/kubernetes-csi/external-snapshotter/client/v4 v4.2.0
 	github.com/onsi/ginkgo v1.16.5
 	github.com/onsi/gomega v1.20.1
 	github.com/pkg/errors v0.9.1
-	github.com/prometheus/client_golang v1.17.0
+	github.com/prometheus/client_golang v1.15.0
 	github.com/robfig/cron v1.1.0
-	github.com/sirupsen/logrus v1.9.3
+	github.com/sirupsen/logrus v1.9.0
 	github.com/spf13/afero v1.6.0
 	github.com/spf13/cobra v1.4.0
 	github.com/spf13/pflag v1.0.5
-	github.com/stretchr/testify v1.8.4
+	github.com/stretchr/testify v1.8.2
 	github.com/vmware-tanzu/crash-diagnostics v0.3.7
-	go.uber.org/zap v1.26.0
-	golang.org/x/exp v0.0.0-20230522175609-2e198f4a06a1
-	golang.org/x/mod v0.13.0
-	golang.org/x/net v0.17.0
-	golang.org/x/oauth2 v0.13.0
-	golang.org/x/text v0.14.0
-	google.golang.org/api v0.146.0
-	google.golang.org/grpc v1.58.3
-	google.golang.org/protobuf v1.31.0
+	go.uber.org/zap v1.24.0
+	golang.org/x/exp v0.0.0-20221028150844-83b7d23a625f
+	golang.org/x/mod v0.10.0
+	golang.org/x/net v0.9.0
+	golang.org/x/oauth2 v0.7.0
+	golang.org/x/text v0.9.0
+	google.golang.org/api v0.120.0
+	google.golang.org/grpc v1.54.0
+	google.golang.org/protobuf v1.30.0
 	gopkg.in/yaml.v3 v3.0.1
 	k8s.io/api v0.25.6
 	k8s.io/apiextensions-apiserver v0.24.2
@@ -64,16 +54,17 @@ require (
 	k8s.io/metrics v0.25.6
 	k8s.io/utils v0.0.0-20220728103510-ee6ede2d64ed
 	sigs.k8s.io/controller-runtime v0.12.2
-	sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd
 	sigs.k8s.io/yaml v1.3.0
 )
 
 require (
-	cloud.google.com/go v0.110.7 // indirect
-	cloud.google.com/go/compute v1.23.0 // indirect
+	cloud.google.com/go v0.110.0 // indirect
+	cloud.google.com/go/compute v1.19.0 // indirect
 	cloud.google.com/go/compute/metadata v0.2.3 // indirect
-	cloud.google.com/go/iam v1.1.1 // indirect
-	github.com/Azure/azure-sdk-for-go/sdk/internal v1.3.0 // indirect
+	cloud.google.com/go/iam v0.13.0 // indirect
+	github.com/Azure/azure-sdk-for-go/sdk/azcore v0.21.1 // indirect
+	github.com/Azure/azure-sdk-for-go/sdk/internal v0.8.3 // indirect
+	github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v0.3.0 // indirect
 	github.com/Azure/go-autorest v14.2.0+incompatible // indirect
 	github.com/Azure/go-autorest/autorest/adal v0.9.20 // indirect
 	github.com/Azure/go-autorest/autorest/azure/cli v0.4.2 // indirect
@@ -81,22 +72,6 @@ require (
 	github.com/Azure/go-autorest/autorest/validation v0.2.0 // indirect
 	github.com/Azure/go-autorest/logger v0.2.1 // indirect
 	github.com/Azure/go-autorest/tracing v0.6.0 // indirect
-	github.com/AzureAD/microsoft-authentication-library-for-go v1.1.1 // indirect
-	github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.13 // indirect
-	github.com/aws/aws-sdk-go-v2/credentials v1.13.40 // indirect
-	github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.13.11 // indirect
-	github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.41 // indirect
-	github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.4.35 // indirect
-	github.com/aws/aws-sdk-go-v2/internal/ini v1.3.43 // indirect
-	github.com/aws/aws-sdk-go-v2/internal/v4a v1.1.4 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.9.14 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.1.36 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.35 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.15.4 // indirect
-	github.com/aws/aws-sdk-go-v2/service/sso v1.14.1 // indirect
-	github.com/aws/aws-sdk-go-v2/service/ssooidc v1.17.1 // indirect
-	github.com/aws/aws-sdk-go-v2/service/sts v1.22.0 // indirect
-	github.com/aws/smithy-go v1.14.2 // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/cespare/xxhash/v2 v2.2.0 // indirect
 	github.com/chmduquesne/rollinghash v4.0.0+incompatible // indirect
@@ -106,7 +81,7 @@ require (
 	github.com/edsrzf/mmap-go v1.1.0 // indirect
 	github.com/emicklei/go-restful/v3 v3.8.0 // indirect
 	github.com/fsnotify/fsnotify v1.5.4 // indirect
-	github.com/go-logr/logr v1.2.4 // indirect
+	github.com/go-logr/logr v1.2.3 // indirect
 	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/go-logr/zapr v1.2.0 // indirect
 	github.com/go-openapi/jsonpointer v0.19.5 // indirect
@@ -115,34 +90,31 @@ require (
 	github.com/gofrs/flock v0.8.1 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/golang-jwt/jwt/v4 v4.5.0 // indirect
-	github.com/golang-jwt/jwt/v5 v5.0.0 // indirect
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
 	github.com/google/gnostic v0.6.9 // indirect
 	github.com/google/gofuzz v1.2.0 // indirect
-	github.com/google/s2a-go v0.1.7 // indirect
-	github.com/googleapis/enterprise-certificate-proxy v0.3.1 // indirect
-	github.com/googleapis/gax-go/v2 v2.12.0 // indirect
-	github.com/hashicorp/cronexpr v1.1.2 // indirect
+	github.com/google/s2a-go v0.1.2 // indirect
+	github.com/googleapis/enterprise-certificate-proxy v0.2.3 // indirect
+	github.com/googleapis/gax-go/v2 v2.8.0 // indirect
 	github.com/hashicorp/yamux v0.0.0-20180604194846-3520598351bb // indirect
 	github.com/imdario/mergo v0.3.13 // indirect
 	github.com/inconshreveable/mousetrap v1.0.0 // indirect
 	github.com/jmespath/go-jmespath v0.4.0 // indirect
 	github.com/josharian/intern v1.0.0 // indirect
 	github.com/json-iterator/go v1.1.12 // indirect
-	github.com/klauspost/compress v1.17.0 // indirect
-	github.com/klauspost/cpuid/v2 v2.2.5 // indirect
-	github.com/klauspost/pgzip v1.2.6 // indirect
-	github.com/klauspost/reedsolomon v1.11.8 // indirect
-	github.com/kylelemons/godebug v1.1.0 // indirect
+	github.com/klauspost/compress v1.16.5 // indirect
+	github.com/klauspost/cpuid/v2 v2.2.4 // indirect
+	github.com/klauspost/pgzip v1.2.5 // indirect
+	github.com/klauspost/reedsolomon v1.11.7 // indirect
 	github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de // indirect
 	github.com/mailru/easyjson v0.7.7 // indirect
 	github.com/mattn/go-colorable v0.1.13 // indirect
 	github.com/mattn/go-ieproxy v0.0.1 // indirect
-	github.com/mattn/go-isatty v0.0.19 // indirect
+	github.com/mattn/go-isatty v0.0.17 // indirect
 	github.com/matttproud/golang_protobuf_extensions v1.0.4 // indirect
 	github.com/minio/md5-simd v1.1.2 // indirect
-	github.com/minio/minio-go/v7 v7.0.63 // indirect
-	github.com/minio/sha256-simd v1.0.1 // indirect
+	github.com/minio/minio-go/v7 v7.0.52 // indirect
+	github.com/minio/sha256-simd v1.0.0 // indirect
 	github.com/mitchellh/go-homedir v1.1.0 // indirect
 	github.com/mitchellh/go-testing-interface v1.0.0 // indirect
 	github.com/moby/spdystream v0.2.0 // indirect
@@ -153,39 +125,38 @@ require (
 	github.com/nxadm/tail v1.4.8 // indirect
 	github.com/oklog/run v1.0.0 // indirect
 	github.com/pierrec/lz4 v2.6.1+incompatible // indirect
-	github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	github.com/prometheus/client_model v0.5.0 // indirect
-	github.com/prometheus/common v0.44.0 // indirect
-	github.com/prometheus/procfs v0.11.1 // indirect
-	github.com/rs/xid v1.5.0 // indirect
+	github.com/prometheus/client_model v0.3.0 // indirect
+	github.com/prometheus/common v0.42.0 // indirect
+	github.com/prometheus/procfs v0.9.0 // indirect
+	github.com/rogpeppe/go-internal v1.9.0 // indirect
+	github.com/rs/xid v1.4.0 // indirect
 	github.com/stretchr/objx v0.5.0 // indirect
 	github.com/vladimirvivien/gexe v0.1.1 // indirect
 	github.com/zeebo/blake3 v0.2.3 // indirect
 	go.opencensus.io v0.24.0 // indirect
-	go.opentelemetry.io/otel v1.19.0 // indirect
-	go.opentelemetry.io/otel/metric v1.19.0 // indirect
-	go.opentelemetry.io/otel/trace v1.19.0 // indirect
+	go.opentelemetry.io/otel v1.14.0 // indirect
+	go.opentelemetry.io/otel/trace v1.14.0 // indirect
 	go.starlark.net v0.0.0-20201006213952-227f4aabceb5 // indirect
+	go.uber.org/atomic v1.9.0 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
-	golang.org/x/crypto v0.17.0 // indirect
-	golang.org/x/sync v0.4.0 // indirect
-	golang.org/x/sys v0.15.0 // indirect
-	golang.org/x/term v0.15.0 // indirect
+	golang.org/x/crypto v0.8.0 // indirect
+	golang.org/x/sync v0.1.0 // indirect
+	golang.org/x/sys v0.7.0 // indirect
+	golang.org/x/term v0.7.0 // indirect
 	golang.org/x/time v0.0.0-20220609170525-579cf78fd858 // indirect
 	golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
 	gomodules.xyz/jsonpatch/v2 v2.2.0 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
-	google.golang.org/genproto v0.0.0-20230913181813-007df8e322eb // indirect
-	google.golang.org/genproto/googleapis/api v0.0.0-20230913181813-007df8e322eb // indirect
-	google.golang.org/genproto/googleapis/rpc v0.0.0-20230920204549-e6e6cdab5c13 // indirect
+	google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/ini.v1 v1.67.0 // indirect
 	gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	k8s.io/component-base v0.24.2 // indirect
 	k8s.io/kube-openapi v0.0.0-20220803162953-67bda5d908f1 // indirect
+	sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 // indirect
 	sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
 )
 
-replace github.com/kopia/kopia => github.com/project-velero/kopia v0.0.0-20231023031817-cf7bbc7f8519
+replace github.com/kopia/kopia => github.com/project-velero/kopia v0.13.0-velero.1

go.sum

@@ -19,23 +19,24 @@ cloud.google.com/go v0.74.0/go.mod h1:VV1xSbzvo+9QJOxLDaJfTjx5e+MePCpCWwvftOeQmW
 cloud.google.com/go v0.78.0/go.mod h1:QjdrLG0uq+YwhjoVOLsS1t7TW8fs36kLs4XO5R5ECHg=
 cloud.google.com/go v0.79.0/go.mod h1:3bzgcEeQlzbuEAYu4mrWhKqWjmpprinYgKJLgKHnbb8=
 cloud.google.com/go v0.81.0/go.mod h1:mk/AM35KwGk/Nm2YSeZbxXdrNK3KZOYHmLkOqC2V6E0=
-cloud.google.com/go v0.110.7 h1:rJyC7nWRg2jWGZ4wSJ5nY65GTdYJkg0cd/uXb+ACI6o=
-cloud.google.com/go v0.110.7/go.mod h1:+EYjdK8e5RME/VY/qLCAtuyALQ9q67dvuum8i+H5xsI=
+cloud.google.com/go v0.110.0 h1:Zc8gqp3+a9/Eyph2KDmcGaPtbKRIoqq4YTlL4NMD0Ys=
+cloud.google.com/go v0.110.0/go.mod h1:SJnCLqQ0FCFGSZMUNUf84MV3Aia54kn7pi8st7tMzaY=
 cloud.google.com/go/bigquery v1.0.1/go.mod h1:i/xbL2UlR5RvWAURpBYZTtm/cXjCha9lbfbpx4poX+o=
 cloud.google.com/go/bigquery v1.3.0/go.mod h1:PjpwJnslEMmckchkHFfq+HTD2DmtT67aNFKH1/VBDHE=
 cloud.google.com/go/bigquery v1.4.0/go.mod h1:S8dzgnTigyfTmLBfrtrhyYhwRxG72rYxvftPBK2Dvzc=
 cloud.google.com/go/bigquery v1.5.0/go.mod h1:snEHRnqQbz117VIFhE8bmtwIDY80NLUZUMb4Nv6dBIg=
 cloud.google.com/go/bigquery v1.7.0/go.mod h1://okPTzCYNXSlb24MZs83e2Do+h+VXtc4gLoIoXIAPc=
 cloud.google.com/go/bigquery v1.8.0/go.mod h1:J5hqkt3O0uAFnINi6JXValWIb1v0goeZM77hZzJN/fQ=
-cloud.google.com/go/compute v1.23.0 h1:tP41Zoavr8ptEqaW6j+LQOnyBBhO7OkOMAGrgLopTwY=
-cloud.google.com/go/compute v1.23.0/go.mod h1:4tCnrn48xsqlwSAiLf1HXMQk8CONslYbdiEZc9FEIbM=
+cloud.google.com/go/compute v1.19.0 h1:+9zda3WGgW1ZSTlVppLCYFIr48Pa35q1uG2N1itbCEQ=
+cloud.google.com/go/compute v1.19.0/go.mod h1:rikpw2y+UMidAe9tISo04EHNOIf42RLYF/q8Bs93scU=
 cloud.google.com/go/compute/metadata v0.2.3 h1:mg4jlk7mCAj6xXp9UJ4fjI9VUI5rubuGBW5aJ7UnBMY=
 cloud.google.com/go/compute/metadata v0.2.3/go.mod h1:VAV5nSsACxMJvgaAuX6Pk2AawlZn8kiOGuCv6gTkwuA=
 cloud.google.com/go/datastore v1.0.0/go.mod h1:LXYbyblFSglQ5pkeyhO+Qmw7ukd3C+pD7TKLgZqpHYE=
 cloud.google.com/go/datastore v1.1.0/go.mod h1:umbIZjpQpHh4hmRpGhH4tLFup+FVzqBi1b3c64qFpCk=
 cloud.google.com/go/firestore v1.1.0/go.mod h1:ulACoGHTpvq5r8rxGJ4ddJZBZqakUQqClKRT5SZwBmk=
-cloud.google.com/go/iam v1.1.1 h1:lW7fzj15aVIXYHREOqjRBV9PsH0Z6u8Y46a1YGvQP4Y=
-cloud.google.com/go/iam v1.1.1/go.mod h1:A5avdyVL2tCppe4unb0951eI9jreack+RJ0/d+KUZOU=
+cloud.google.com/go/iam v0.13.0 h1:+CmB+K0J/33d0zSQ9SlFWUeCCEn5XJA0ZMZ3pHE9u8k=
+cloud.google.com/go/iam v0.13.0/go.mod h1:ljOg+rcNfzZ5d6f1nAUJ8ZIxOaZUVoS14bKCtaLZ/D0=
+cloud.google.com/go/longrunning v0.4.1 h1:v+yFJOfKC3yZdY6ZUI933pIYdhyhV8S3NpWrXWmg7jM=
 cloud.google.com/go/pubsub v1.0.1/go.mod h1:R0Gpsv3s54REJCy4fxDixWD93lHJMoZTyQ2kNxGRt3I=
 cloud.google.com/go/pubsub v1.1.0/go.mod h1:EwwdRX2sKPjnvnqCa270oGRyludottCI76h+R3AArQw=
 cloud.google.com/go/pubsub v1.2.0/go.mod h1:jhfEVHT8odbXTkndysNHCcx0awwzvfOlguIAii9o8iA=
@@ -45,27 +46,19 @@ cloud.google.com/go/storage v1.5.0/go.mod h1:tpKbwo567HUNpVclU5sGELwQWBDZ8gh0Zeo
 cloud.google.com/go/storage v1.6.0/go.mod h1:N7U0C8pVQ/+NIKOBQyamJIeKQKkZ+mxpohlUTyfDhBk=
 cloud.google.com/go/storage v1.8.0/go.mod h1:Wv1Oy7z6Yz3DshWRJFhqM/UCfaWIRTdp0RXyy7KQOVs=
 cloud.google.com/go/storage v1.10.0/go.mod h1:FLPqc6j+Ki4BU591ie1oL6qBQGu2Bl/tZ9ullr3+Kg0=
-cloud.google.com/go/storage v1.33.0 h1:PVrDOkIC8qQVa1P3SXGpQvfuJhN2LHOoyZvWs8D2X5M=
-cloud.google.com/go/storage v1.33.0/go.mod h1:Hhh/dogNRGca7IWv1RC2YqEn0c0G77ctA/OxflYkiD8=
+cloud.google.com/go/storage v1.30.1 h1:uOdMxAs8HExqBlnLtnQyP0YkvbiDpdGShGKtx6U/oNM=
+cloud.google.com/go/storage v1.30.1/go.mod h1:NfxhC0UJE1aXSx7CIIbCf7y9HKT7BiccwkR7+P7gN8E=
 dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU=
 github.com/Azure/azure-pipeline-go v0.2.3 h1:7U9HBg1JFK3jHl5qmo4CTZKFTVgMwdFHMVtCdfBE21U=
 github.com/Azure/azure-pipeline-go v0.2.3/go.mod h1:x841ezTBIMG6O3lAcl8ATHnsOPVl2bqk7S3ta6S6u4k=
 github.com/Azure/azure-sdk-for-go v67.2.0+incompatible h1:Uu/Ww6ernvPTrpq31kITVTIm/I5jlJ1wjtEH/bmSB2k=
 github.com/Azure/azure-sdk-for-go v67.2.0+incompatible/go.mod h1:9XXNKU+eRnpl9moKnB4QOLf1HestfXbmab5FXxiDBjc=
-github.com/Azure/azure-sdk-for-go/sdk/azcore v1.8.0 h1:9kDVnTz3vbfweTqAUmk/a/pH5pWFCHtvRpHYC0G/dcA=
-github.com/Azure/azure-sdk-for-go/sdk/azcore v1.8.0/go.mod h1:3Ug6Qzto9anB6mGlEdgYMDF5zHQ+wwhEaYR4s17PHMw=
-github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.3.1 h1:LNHhpdK7hzUcx/k1LIcuh5k7k1LGIWLQfCjaneSj7Fc=
-github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.3.1/go.mod h1:uE9zaUfEQT/nbQjVi2IblCG9iaLtZsuYZ8ne+PuQ02M=
-github.com/Azure/azure-sdk-for-go/sdk/internal v1.3.0 h1:sXr+ck84g/ZlZUOZiNELInmMgOsuGwdjjVkEIde0OtY=
-github.com/Azure/azure-sdk-for-go/sdk/internal v1.3.0/go.mod h1:okt5dMMTOFjX/aovMlrjvvXoPMBVSPzk9185BT0+eZM=
-github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal v1.1.2 h1:mLY+pNLjCUeKhgnAJWAKhEUQM+RJQo2H1fuGSw1Ky1E=
-github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal v1.1.2/go.mod h1:FbdwsQ2EzwvXxOPcMFYO8ogEc9uMMIj3YkmCdXdAFmk=
-github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.0.0 h1:ECsQtyERDVz3NP3kvDOTLvbQhqWp/x9EsGKtb4ogUr8=
-github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.0.0/go.mod h1:s1tW/At+xHqjNFvWU4G0c0Qv33KOhvbGNj0RCTQDV8s=
-github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage v1.3.0 h1:LcJtQjCXJUm1s7JpUHZvu+bpgURhCatxVNbGADXniX0=
-github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage v1.3.0/go.mod h1:+OgGVo0Httq7N5oayfvaLQ/Jq+2gJdqfp++Hyyl7Tws=
-github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.1.0 h1:nVocQV40OQne5613EeLayJiRAJuKlBGy+m22qWG+WRg=
-github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.1.0/go.mod h1:7QJP7dr2wznCMeqIrhMgWGf7XpAQnVrJqDm9nvV3Cu4=
+github.com/Azure/azure-sdk-for-go/sdk/azcore v0.21.1 h1:qoVeMsc9/fh/yhxVaA0obYjVH/oI/ihrOoMwsLS9KSA=
+github.com/Azure/azure-sdk-for-go/sdk/azcore v0.21.1/go.mod h1:fBF9PQNqB8scdgpZ3ufzaLntG0AG7C1WjPMsiFOmfHM=
+github.com/Azure/azure-sdk-for-go/sdk/internal v0.8.3 h1:E+m3SkZCN0Bf5q7YdTs5lSm2CYY3CK4spn5OmUIiQtk=
+github.com/Azure/azure-sdk-for-go/sdk/internal v0.8.3/go.mod h1:KLF4gFr6DcKFZwSuH8w8yEK6DpFl3LP5rhdvAb7Yz5I=
+github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v0.3.0 h1:Px2UA+2RvSSvv+RvJNuUB6n7rs5Wsel4dXLe90Um2n4=
+github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v0.3.0/go.mod h1:tPaiy8S5bQ+S5sOiDlINkp7+Ef339+Nz5L5XO+cnOHo=
 github.com/Azure/azure-storage-blob-go v0.15.0 h1:rXtgp8tN1p29GvpGgfJetavIG0V7OgcSXPpwp3tx6qk=
 github.com/Azure/azure-storage-blob-go v0.15.0/go.mod h1:vbjsVbX0dlxnRc4FFMPsS9BsJWPcne7GB7onqlPvz58=
 github.com/Azure/go-ansiterm v0.0.0-20170929234023-d6e3b3328b78/go.mod h1:LmzpDX56iTiv29bbRTIsUNlaFfuhWRQBWjQdVyAevI8=
@@ -111,12 +104,9 @@ github.com/Azure/go-autorest/logger v0.2.1/go.mod h1:T9E3cAhj2VqvPOtCYAvby9aBXkZ
 github.com/Azure/go-autorest/tracing v0.5.0/go.mod h1:r/s2XiOKccPW3HrqB+W0TQzfbtp2fGCgRFtBroKn4Dk=
 github.com/Azure/go-autorest/tracing v0.6.0 h1:TYi4+3m5t6K48TGI9AUdb+IzbnSxvnvUMfuitfgcfuo=
 github.com/Azure/go-autorest/tracing v0.6.0/go.mod h1:+vhtPC754Xsa23ID7GlGsrdKBpUA79WCAKPPZVC2DeU=
-github.com/AzureAD/microsoft-authentication-library-for-go v1.1.1 h1:WpB/QDNLpMw72xHJc34BNNykqSOeEJDAWkhf0u12/Jk=
-github.com/AzureAD/microsoft-authentication-library-for-go v1.1.1/go.mod h1:wP83P5OoQ5p6ip3ScPr0BAq0BvuPAvacpEuSzyouqAI=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
-github.com/GehirnInc/crypt v0.0.0-20230320061759-8cc1b52080c5 h1:IEjq88XO4PuBDcvmjQJcQGg+w+UaafSy8G5Kcb5tBhI=
-github.com/GehirnInc/crypt v0.0.0-20230320061759-8cc1b52080c5/go.mod h1:exZ0C/1emQJAw5tHOaUDyY1ycttqBAPcxuzf7QbY6ec=
+github.com/GehirnInc/crypt v0.0.0-20200316065508-bb7000b8a962 h1:KeNholpO2xKjgaaSyd+DyQRrsQjhbSeS7qe4nEw8aQw=
 github.com/NYTimes/gziphandler v0.0.0-20170623195520-56545f4a5d46/go.mod h1:3wb06e3pkSAbeQ52E9H9iFoQsEEwGN64994WTCIhntQ=
 github.com/NYTimes/gziphandler v1.1.1/go.mod h1:n/CVRwUEOgIxrgPvAQhUUr9oeUtvrhMomdKFjzJNB0c=
 github.com/OneOfOne/xxhash v1.2.2/go.mod h1:HSdplMjZKSmBqAxg5vPj2TmRDmfkzw+cTzAElWljhcU=
@@ -130,7 +120,6 @@ github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRF
 github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
 github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d/go.mod h1:rBZYJk541a8SKzHPHnH3zbiI+7dagKZ0cgpgrD7Fyho=
 github.com/alessio/shellescape v1.4.1 h1:V7yhSDDn8LP4lc4jS8pFkt0zCnzVJlG5JXy9BVKJUX0=
-github.com/alessio/shellescape v1.4.1/go.mod h1:PZAiSCk0LJaZkiCSkPv8qIobYglO3FPpyFjDCtHLS30=
 github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY=
 github.com/antlr/antlr4/runtime/Go/antlr v0.0.0-20210826220005-b48c857c3a0e/go.mod h1:F7bn7fEU90QkQ3tnmaTx3LTKLEDqnwWODIYppRQ5hnY=
 github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e/go.mod h1:3U/XgcO3hCbHZ8TKRvWD2dDTCfh9M9ya+I9JpbB7O8o=
@@ -140,47 +129,10 @@ github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod h1:ufUuZ+zHj
 github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5 h1:0CwZNZbxp69SHPdPJAN/hZIm0C4OItdklCFmMRWYpio=
 github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5/go.mod h1:wHh0iHkYZB8zMSxRWpUBQtwG5a7fFgvEO+odwuTv2gs=
 github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
-github.com/aws/aws-sdk-go-v2 v1.21.0 h1:gMT0IW+03wtYJhRqTVYn0wLzwdnK9sRMcxmtfGzRdJc=
-github.com/aws/aws-sdk-go-v2 v1.21.0/go.mod h1:/RfNgGmRxI+iFOB1OeJUyxiU+9s88k3pfHvDagGEp0M=
-github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.13 h1:OPLEkmhXf6xFPiz0bLeDArZIDx1NNS4oJyG4nv3Gct0=
-github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.13/go.mod h1:gpAbvyDGQFozTEmlTFO8XcQKHzubdq0LzRyJpG6MiXM=
-github.com/aws/aws-sdk-go-v2/config v1.18.42 h1:28jHROB27xZwU0CB88giDSjz7M1Sba3olb5JBGwina8=
-github.com/aws/aws-sdk-go-v2/config v1.18.42/go.mod h1:4AZM3nMMxwlG+eZlxvBKqwVbkDLlnN2a4UGTL6HjaZI=
-github.com/aws/aws-sdk-go-v2/credentials v1.13.40 h1:s8yOkDh+5b1jUDhMBtngF6zKWLDs84chUk2Vk0c38Og=
-github.com/aws/aws-sdk-go-v2/credentials v1.13.40/go.mod h1:VtEHVAAqDWASwdOqj/1huyT6uHbs5s8FUHfDQdky/Rs=
-github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.13.11 h1:uDZJF1hu0EVT/4bogChk8DyjSF6fof6uL/0Y26Ma7Fg=
-github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.13.11/go.mod h1:TEPP4tENqBGO99KwVpV9MlOX4NSrSLP8u3KRy2CDwA8=
-github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.11.87 h1:e20ZrsgDPUXqg8+rZVuPwNSp6yniUN2Yr2tzFZ+Yvl0=
-github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.11.87/go.mod h1:0i0TAT6W+5i48QTlDU2KmY6U2hBZeY/LCP0wktya2oc=
-github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.41 h1:22dGT7PneFMx4+b3pz7lMTRyN8ZKH7M2cW4GP9yUS2g=
-github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.41/go.mod h1:CrObHAuPneJBlfEJ5T3szXOUkLEThaGfvnhTf33buas=
-github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.4.35 h1:SijA0mgjV8E+8G45ltVHs0fvKpTj8xmZJ3VwhGKtUSI=
-github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.4.35/go.mod h1:SJC1nEVVva1g3pHAIdCp7QsRIkMmLAgoDquQ9Rr8kYw=
-github.com/aws/aws-sdk-go-v2/internal/ini v1.3.43 h1:g+qlObJH4Kn4n21g69DjspU0hKTjWtq7naZ9OLCv0ew=
-github.com/aws/aws-sdk-go-v2/internal/ini v1.3.43/go.mod h1:rzfdUlfA+jdgLDmPKjd3Chq9V7LVLYo1Nz++Wb91aRo=
-github.com/aws/aws-sdk-go-v2/internal/v4a v1.1.4 h1:6lJvvkQ9HmbHZ4h/IEwclwv2mrTW8Uq1SOB/kXy0mfw=
-github.com/aws/aws-sdk-go-v2/internal/v4a v1.1.4/go.mod h1:1PrKYwxTM+zjpw9Y41KFtoJCQrJ34Z47Y4VgVbfndjo=
-github.com/aws/aws-sdk-go-v2/service/ec2 v1.123.0 h1:AkjjaINgZQlz3valIVmlrs18jsl+fzYuoxED8oOVrYo=
-github.com/aws/aws-sdk-go-v2/service/ec2 v1.123.0/go.mod h1:0FhI2Rzcv5BNM3dNnbcCx2qa2naFZoAidJi11cQgzL0=
-github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.9.14 h1:m0QTSI6pZYJTk5WSKx3fm5cNW/DCicVzULBgU/6IyD0=
-github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.9.14/go.mod h1:dDilntgHy9WnHXsh7dDtUPgHKEfTJIBUTHM8OWm0f/0=
-github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.1.36 h1:eev2yZX7esGRjqRbnVk1UxMLw4CyVZDpZXRCcy75oQk=
-github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.1.36/go.mod h1:lGnOkH9NJATw0XEPcAknFBj3zzNTEGRHtSw+CwC1YTg=
-github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.35 h1:CdzPW9kKitgIiLV1+MHobfR5Xg25iYnyzWZhyQuSlDI=
-github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.35/go.mod h1:QGF2Rs33W5MaN9gYdEQOBBFPLwTZkEhRwI33f7KIG0o=
-github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.15.4 h1:v0jkRigbSD6uOdwcaUQmgEwG1BkPfAPDqaeNt/29ghg=
-github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.15.4/go.mod h1:LhTyt8J04LL+9cIt7pYJ5lbS/U98ZmXovLOR/4LUsk8=
-github.com/aws/aws-sdk-go-v2/service/s3 v1.40.0 h1:wl5dxN1NONhTDQD9uaEvNsDRX29cBmGED/nl0jkWlt4=
-github.com/aws/aws-sdk-go-v2/service/s3 v1.40.0/go.mod h1:rDGMZA7f4pbmTtPOk5v5UM2lmX6UAbRnMDJeDvnH7AM=
-github.com/aws/aws-sdk-go-v2/service/sso v1.14.1 h1:YkNzx1RLS0F5qdf9v1Q8Cuv9NXCL2TkosOxhzlUPV64=
-github.com/aws/aws-sdk-go-v2/service/sso v1.14.1/go.mod h1:fIAwKQKBFu90pBxx07BFOMJLpRUGu8VOzLJakeY+0K4=
-github.com/aws/aws-sdk-go-v2/service/ssooidc v1.17.1 h1:8lKOidPkmSmfUtiTgtdXWgaKItCZ/g75/jEk6Ql6GsA=
-github.com/aws/aws-sdk-go-v2/service/ssooidc v1.17.1/go.mod h1:yygr8ACQRY2PrEcy3xsUI357stq2AxnFM6DIsR9lij4=
-github.com/aws/aws-sdk-go-v2/service/sts v1.22.0 h1:s4bioTgjSFRwOoyEFzAVCmFmoowBgjTR8gkrF/sQ4wk=
-github.com/aws/aws-sdk-go-v2/service/sts v1.22.0/go.mod h1:VC7JDqsqiwXukYEDjoHh9U0fOJtNWh04FPQz4ct4GGU=
-github.com/aws/smithy-go v1.14.2 h1:MJU9hqBGbvWZdApzpvoF2WAIJDbtjK2NDJSiJP7HblQ=
-github.com/aws/smithy-go v1.14.2/go.mod h1:Tg+OJXh4MB2R/uN61Ko2f6hTZwB/ZYGOtib8J3gBHzA=
+github.com/aws/aws-sdk-go v1.44.253 h1:iqDd0okcH4ShfFexz2zzf4VmeDFf6NOMm07pHnEb8iY=
+github.com/aws/aws-sdk-go v1.44.253/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
 github.com/benbjohnson/clock v1.0.3/go.mod h1:bGMdMPoPVvcYyt1gHDf4J2KE153Yf9BuiUKYMaxlTDM=
+github.com/benbjohnson/clock v1.1.0 h1:Q92kusRqC1XV2MjkWETPvjJVqKetz1OzxZB7mHJLju8=
 github.com/benbjohnson/clock v1.1.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA=
 github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q=
 github.com/beorn7/perks v1.0.0/go.mod h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8=
@@ -211,7 +163,11 @@ github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDk
 github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
 github.com/cncf/udpa/go v0.0.0-20200629203442-efcf912fb354/go.mod h1:WmhPx2Nbnhtbo57+VJT5O0JRkEi1Wbu0z5j0R8u5Hbk=
 github.com/cncf/udpa/go v0.0.0-20201120205902-5459f2c99403/go.mod h1:WmhPx2Nbnhtbo57+VJT5O0JRkEi1Wbu0z5j0R8u5Hbk=
+github.com/cncf/udpa/go v0.0.0-20210930031921-04548b0d99d4/go.mod h1:6pvJx4me5XPnfI9Z40ddWsdw2W/uZgQLFXToKeRcDiI=
 github.com/cncf/xds/go v0.0.0-20210312221358-fbca930ec8ed/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
+github.com/cncf/xds/go v0.0.0-20210805033703-aa0b78936158/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
+github.com/cncf/xds/go v0.0.0-20210922020428-25de7278fc84/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
+github.com/cncf/xds/go v0.0.0-20211011173535-cb28da3451f1/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
 github.com/cockroachdb/datadriven v0.0.0-20190809214429-80d97fb3cbaa/go.mod h1:zn76sxSg3SzpJ0PPJaLDCu+Bu0Lg3sKTORVIj19EIF8=
 github.com/cockroachdb/datadriven v0.0.0-20200714090401-bf6692d28da5/go.mod h1:h6jFvWxBdQXxjopDMZyH2UVceIRfR84bdzbkoKrsWNo=
 github.com/cockroachdb/errors v1.2.4/go.mod h1:rQD95gz6FARkaKkQXUksEje/d9a6wBJoCr5oaCLELYA=
@@ -232,8 +188,7 @@ github.com/cpuguy83/go-md2man/v2 v2.0.1/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46t
 github.com/creack/pty v1.1.7/go.mod h1:lj5s0c3V2DBrqTV7llrYr5NG6My20zk30Fl46Y7DoTY=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/creack/pty v1.1.11/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
-github.com/danieljoos/wincred v1.2.0 h1:ozqKHaLK0W/ii4KVbbvluM91W2H3Sh0BncbUNPS7jLE=
-github.com/danieljoos/wincred v1.2.0/go.mod h1:FzQLLMKBFdvu+osBrnFODiv32YGwCfx0SkRa/eYHgec=
+github.com/danieljoos/wincred v1.1.2 h1:QLdCxFs1/Yl4zduvBdcHB8goaYk9RARS2SgLLRuAyr0=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
@@ -242,6 +197,7 @@ github.com/dgryski/go-sip13 v0.0.0-20181026042036-e10d5fee7954/go.mod h1:vAd38F8
 github.com/dimchansky/utfbom v1.1.0/go.mod h1:rO41eb7gLfo8SF1jd9F8HplJm1Fewwi4mQvIirEdv+8=
 github.com/dimchansky/utfbom v1.1.1 h1:vV6w1AhK4VMnhBno/TPVCoK9U/LP0PkLCS9tbxHdi/U=
 github.com/dimchansky/utfbom v1.1.1/go.mod h1:SxdoEBH5qIqFocHMyGOXVAybYJdr71b1Q/j0mACtrfE=
+github.com/dnaeon/go-vcr v1.1.0/go.mod h1:M7tiix8f0r6mKKJ3Yq/kqU1OYf3MnfmBWVbPx/yU9ko=
 github.com/dnaeon/go-vcr v1.2.0 h1:zHCHvJYTMh1N7xnV7zf1m1GPBF9Ad0Jk/whtQ1663qI=
 github.com/dnaeon/go-vcr v1.2.0/go.mod h1:R4UdLID7HZT3taECzJs4YgbbH6PIGXB6W/sc5OLb6RQ=
 github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96/go.mod h1:Qh8CwZgvJUkLughtfhJv5dyTYa91l1fOUCrgjqmcifM=
@@ -265,6 +221,7 @@ github.com/envoyproxy/go-control-plane v0.9.7/go.mod h1:cwu0lG7PUMfa9snN8LXBig5y
 github.com/envoyproxy/go-control-plane v0.9.9-0.20201210154907-fd9021fe5dad/go.mod h1:cXg6YxExXjJnVBQHBLXeUAgxn2UodCpnH306RInaBQk=
 github.com/envoyproxy/go-control-plane v0.9.9-0.20210217033140-668b12f5399d/go.mod h1:cXg6YxExXjJnVBQHBLXeUAgxn2UodCpnH306RInaBQk=
 github.com/envoyproxy/go-control-plane v0.9.9-0.20210512163311-63b5d3c536b0/go.mod h1:hliV/p42l8fGbc6Y9bQ70uLwIvmJyVE5k4iMKlh8wCQ=
+github.com/envoyproxy/go-control-plane v0.9.10-0.20210907150352-cf90f659a021/go.mod h1:AFq3mo9L8Lqqiid3OhADV3RfLJnjiw63cSpi+fDTRC0=
 github.com/envoyproxy/protoc-gen-validate v0.1.0/go.mod h1:iSmxcyjqTsJpI2R4NaDN7+kN2VEUnK/pcBlmesArF7c=
 github.com/evanphx/json-patch v0.5.2/go.mod h1:ZWS5hhDbVDyob71nXKNL0+PWn6ToqBHMikGIFbs31qQ=
 github.com/evanphx/json-patch v4.9.0+incompatible/go.mod h1:50XU6AFN0ol/bzJsmQLiYLvXMP4fmwYFNcr97nuDLSk=
@@ -280,7 +237,6 @@ github.com/flowstack/go-jsonschema v0.1.1/go.mod h1:yL7fNggx1o8rm9RlgXv7hTBWxdBM
 github.com/form3tech-oss/jwt-go v3.2.2+incompatible/go.mod h1:pbq4aXjuKjdthFRnoDwaVPLA+WlJuPGy+QneDUgJi2k=
 github.com/form3tech-oss/jwt-go v3.2.3+incompatible/go.mod h1:pbq4aXjuKjdthFRnoDwaVPLA+WlJuPGy+QneDUgJi2k=
 github.com/frankban/quicktest v1.13.1 h1:xVm/f9seEhZFL9+n5kv5XLrGwy6elc4V9v/XFY2vmd8=
-github.com/frankban/quicktest v1.13.1/go.mod h1:NeW+ay9A/U67EYXNFA1nPE8e/tnQv/09mUdL/ijj8og=
 github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
 github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=
 github.com/fsnotify/fsnotify v1.5.1/go.mod h1:T3375wBYaZdLLcVNkcVbzGHY7f1l/uK5T5Ai1i3InKU=
@@ -305,8 +261,8 @@ github.com/go-logr/logr v0.2.0/go.mod h1:z6/tIYblkpsD+a4lm/fGIIU9mZ+XfAiaFtq7xTg
 github.com/go-logr/logr v0.4.0/go.mod h1:z6/tIYblkpsD+a4lm/fGIIU9mZ+XfAiaFtq7xTgseGU=
 github.com/go-logr/logr v1.2.0/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
 github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
-github.com/go-logr/logr v1.2.4 h1:g01GSCwiDw2xSZfjJ2/T9M+S6pFdcNtFYsp+Y43HYDQ=
-github.com/go-logr/logr v1.2.4/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
+github.com/go-logr/logr v1.2.3 h1:2DntVwHkVopvECVRSlL5PSo9eG+cAkDCuckLubN+rq0=
+github.com/go-logr/logr v1.2.3/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
 github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag=
 github.com/go-logr/stdr v1.2.2/go.mod h1:mMo/vtBO5dYbehREoey6XUKy/eSumjCCveDpRre4VKE=
 github.com/go-logr/zapr v1.2.0 h1:n4JnPI1T3Qq1SFEi/F8rwLrZERp2bso19PJZDB9dayk=
@@ -336,7 +292,6 @@ github.com/gobwas/glob v0.2.3 h1:A4xDbljILXROh+kObIiy5kIaPYD8e96x1tgBhUI5J+Y=
 github.com/gobwas/glob v0.2.3/go.mod h1:d3Ez4x06l9bZtSvzIay5+Yzi0fmZzPgnTbPcKjJAkT8=
 github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=
 github.com/godbus/dbus/v5 v5.1.0 h1:4KLkAxT3aOY8Li4FRJe/KvhoNFFxo0m6fNuFUO8QJUk=
-github.com/godbus/dbus/v5 v5.1.0/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=
 github.com/gofrs/flock v0.8.1 h1:+gYjHKf32LDeiEEFhQaotPbLuUXjY5ZqxKgXy7n59aw=
 github.com/gofrs/flock v0.8.1/go.mod h1:F1TvTiK9OcQqauNUHlbJvyl9Qa1QvF/gOUDKA14jxHU=
 github.com/gogo/protobuf v1.1.1/go.mod h1:r8qH/GZQm5c6nD/R0oafs1akxWv10x8SbQlK7atdtwQ=
@@ -348,8 +303,6 @@ github.com/golang-jwt/jwt/v4 v4.0.0/go.mod h1:/xlHOz8bRuivTWchD4jCa+NbatV+wEUSzw
 github.com/golang-jwt/jwt/v4 v4.2.0/go.mod h1:/xlHOz8bRuivTWchD4jCa+NbatV+wEUSzwAxVc6locg=
 github.com/golang-jwt/jwt/v4 v4.5.0 h1:7cYmW1XlMY7h7ii7UhUyChSgS5wUJEnm9uZVTGqOWzg=
 github.com/golang-jwt/jwt/v4 v4.5.0/go.mod h1:m21LjoU+eqJr34lmDMbreY2eSTRJ1cv77w39/MY0Ch0=
-github.com/golang-jwt/jwt/v5 v5.0.0 h1:1n1XNM9hk7O9mnQoNBGolZvzebBQ7p93ULHRc28XJUE=
-github.com/golang-jwt/jwt/v5 v5.0.0/go.mod h1:pqrtFR0X4osieyHYxtmOUWsAWrfe1Q5UVIyoH402zdk=
 github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=
 github.com/golang/glog v1.0.0/go.mod h1:EWib/APOK0SL3dFbYqvxE3UYd8E6s1ouQ7iEp/0LWV4=
 github.com/golang/groupcache v0.0.0-20160516000752-02826c3e7903/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
@@ -406,7 +359,6 @@ github.com/google/go-cmp v0.5.3/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/
 github.com/google/go-cmp v0.5.4/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/google/go-cmp v0.5.6/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
-github.com/google/go-cmp v0.5.8/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38=
 github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
@@ -418,7 +370,6 @@ github.com/google/martian v2.1.0+incompatible/go.mod h1:9I4somxYTbIHy5NJKHRl3wXi
 github.com/google/martian/v3 v3.0.0/go.mod h1:y5Zk1BBys9G+gd6Jrk0W3cC1+ELVxBWuIGO+w/tUAp0=
 github.com/google/martian/v3 v3.1.0/go.mod h1:y5Zk1BBys9G+gd6Jrk0W3cC1+ELVxBWuIGO+w/tUAp0=
 github.com/google/martian/v3 v3.3.2 h1:IqNFLAmvJOgVlpdEBiQbDc2EwKW77amAycfTuWKdfvw=
-github.com/google/martian/v3 v3.3.2/go.mod h1:oBOf6HBosgwRXnUGWUB05QECsc6uvmMiJ3+6W4l/CUk=
 github.com/google/pprof v0.0.0-20181206194817-3ea8567a2e57/go.mod h1:zfwlbNMJ+OItoe0UupaVj+oy1omPYYDuagoSzA8v9mc=
 github.com/google/pprof v0.0.0-20190515194954-54271f7e092f/go.mod h1:zfwlbNMJ+OItoe0UupaVj+oy1omPYYDuagoSzA8v9mc=
 github.com/google/pprof v0.0.0-20191218002539-d4f498aebedc/go.mod h1:ZgVRPoUq/hfqzAqh7sHMqb3I9Rq5C59dIz2SbBwJ4eM=
@@ -431,21 +382,21 @@ github.com/google/pprof v0.0.0-20201203190320-1bf35d6f28c2/go.mod h1:kpwsk12EmLe
 github.com/google/pprof v0.0.0-20210122040257-d980be63207e/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE=
 github.com/google/pprof v0.0.0-20210226084205-cbba55b83ad5/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE=
 github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI=
-github.com/google/s2a-go v0.1.7 h1:60BLSyTrOV4/haCDW4zb1guZItoSq8foHCXrAnjBo/o=
-github.com/google/s2a-go v0.1.7/go.mod h1:50CgR4k1jNlWBu4UfS4AcfhVe1r6pdZPygJ3R8F0Qdw=
+github.com/google/s2a-go v0.1.2 h1:WVtYAYuYxKeYajAmThMRYWP6K3wXkcqbGHeUgeubUHY=
+github.com/google/s2a-go v0.1.2/go.mod h1:OJpEgntRZo8ugHpF9hkoLJbS5dSI20XZeXJ9JVywLlM=
 github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510/go.mod h1:pupxD2MaaD3pAXIBCelhxNneeOaAeabZDe5s4K6zSpQ=
 github.com/google/uuid v1.0.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
 github.com/google/uuid v1.1.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
 github.com/google/uuid v1.1.2/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
 github.com/google/uuid v1.2.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
-github.com/google/uuid v1.3.1 h1:KjJaJ9iWZ3jOFZIf1Lqf4laDRCasjl0BCmnEGxkdLb4=
-github.com/google/uuid v1.3.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
-github.com/googleapis/enterprise-certificate-proxy v0.3.1 h1:SBWmZhjUDRorQxrN0nwzf+AHBxnbFjViHQS4P0yVpmQ=
-github.com/googleapis/enterprise-certificate-proxy v0.3.1/go.mod h1:VLSiSSBs/ksPL8kq3OBOQ6WRI2QnaFynd1DCjZ62+V0=
+github.com/google/uuid v1.3.0 h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I=
+github.com/google/uuid v1.3.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
+github.com/googleapis/enterprise-certificate-proxy v0.2.3 h1:yk9/cqRKtT9wXZSsRH9aurXEpJX+U6FLtpYTdC3R06k=
+github.com/googleapis/enterprise-certificate-proxy v0.2.3/go.mod h1:AwSRAtLfXpU5Nm3pW+v7rGDHp09LsPtGY9MduiEsR9k=
 github.com/googleapis/gax-go/v2 v2.0.4/go.mod h1:0Wqv26UfaUD9n4G6kQubkQ+KchISgw+vpHVxEJEs9eg=
 github.com/googleapis/gax-go/v2 v2.0.5/go.mod h1:DWXyrwAJ9X0FpwwEdw+IPEYBICEFu5mhpdKc/us6bOk=
-github.com/googleapis/gax-go/v2 v2.12.0 h1:A+gCJKdRfqXkr+BIRGtZLibNXf0m1f9E4HG56etFpas=
-github.com/googleapis/gax-go/v2 v2.12.0/go.mod h1:y+aIqrI5eb1YGMVJfuV3185Ts/D7qKpsEkdD5+I6QGU=
+github.com/googleapis/gax-go/v2 v2.8.0 h1:UBtEZqx1bjXtOQ5BVTkuYghXrr3N4V123VKJK67vJZc=
+github.com/googleapis/gax-go/v2 v2.8.0/go.mod h1:4orTrqY6hXxxaUL4LHIPl6lGo8vAE38/qKbhSAKP6QI=
 github.com/googleapis/gnostic v0.4.1/go.mod h1:LRhVm6pbyptWbWbuZ38d1eyptfvIytN3ir6b65WBswg=
 github.com/googleapis/gnostic v0.5.1/go.mod h1:6U4PtQXGIEt/Z3h5MAT7FNofLnw9vXk2cUuW7uA/OeU=
 github.com/googleapis/gnostic v0.5.5/go.mod h1:7+EbHbldMins07ALC74bsA81Ovc97DwqyJO1AENw9kA=
@@ -463,12 +414,9 @@ github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0/go.mod h1:8NvIoxWQoOIhqOTXgf
 github.com/grpc-ecosystem/grpc-gateway v1.9.0/go.mod h1:vNeuVxBJEsws4ogUvrchl83t/GYV9WGTSLVdBhOQFDY=
 github.com/grpc-ecosystem/grpc-gateway v1.9.5/go.mod h1:vNeuVxBJEsws4ogUvrchl83t/GYV9WGTSLVdBhOQFDY=
 github.com/grpc-ecosystem/grpc-gateway v1.16.0/go.mod h1:BDjrQk3hbvj6Nolgz8mAMFbcEtjT1g+wF4CSlocrBnw=
-github.com/hanwen/go-fuse/v2 v2.4.0 h1:12OhD7CkXXQdvxG2osIdBQLdXh+nmLXY9unkUIe/xaU=
-github.com/hanwen/go-fuse/v2 v2.4.0/go.mod h1:xKwi1cF7nXAOBCXujD5ie0ZKsxc8GGSA1rlMJc+8IJs=
+github.com/hanwen/go-fuse/v2 v2.3.0 h1:t5ivNIH2PK+zw4OBul/iJjsoG9K6kXo4nMDoBpciC8A=
 github.com/hashicorp/consul/api v1.1.0/go.mod h1:VmuI/Lkw1nC05EYQWNKwWGbkg+FbDBtguAZLlVdkD9Q=
 github.com/hashicorp/consul/sdk v0.1.1/go.mod h1:VKf9jXwCTEY1QZP2MOLRhb5i/I/ssyNV1vwHyQBF0x8=
-github.com/hashicorp/cronexpr v1.1.2 h1:wG/ZYIKT+RT3QkOdgYc+xsKWVRgnxJ1OJtjjy84fJ9A=
-github.com/hashicorp/cronexpr v1.1.2/go.mod h1:P4wA0KBl9C5q2hABiMO7cp6jcIg96CDh1Efb3g1PWA4=
 github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
 github.com/hashicorp/go-cleanhttp v0.5.1/go.mod h1:JpRdi6/HCYpAwUzNwuwqhbovhLtngrth3wmdIIUrZ80=
 github.com/hashicorp/go-hclog v0.14.1 h1:nQcJDQwIAGnmoUWp8ubocEX40cCml/17YkF6csQLReU=
@@ -531,27 +479,26 @@ github.com/kisielk/errcheck v1.1.0/go.mod h1:EZBBE59ingxPouuu3KfxchcWSUPOHkagtvW
 github.com/kisielk/errcheck v1.2.0/go.mod h1:/BMXB+zMLi60iA8Vv6Ksmxu/1UDYcXs4uQLJ+jE2L00=
 github.com/kisielk/errcheck v1.5.0/go.mod h1:pFxgyoBC7bSaBwPgfKdkLd5X25qrDl4LWUI2bnpBCr8=
 github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck=
-github.com/klauspost/compress v1.17.0 h1:Rnbp4K9EjcDuVuHtd0dgA4qNuv9yKDYKK1ulpJwgrqM=
-github.com/klauspost/compress v1.17.0/go.mod h1:ntbaceVETuRiXiv4DpjP66DpAtAGkEQskQzEyD//IeE=
+github.com/klauspost/compress v1.16.5 h1:IFV2oUNUzZaz+XyusxpLzpzS8Pt5rh0Z16For/djlyI=
+github.com/klauspost/compress v1.16.5/go.mod h1:ntbaceVETuRiXiv4DpjP66DpAtAGkEQskQzEyD//IeE=
 github.com/klauspost/cpuid/v2 v2.0.1/go.mod h1:FInQzS24/EEf25PyTYn52gqo7WaD8xa0213Md/qVLRg=
+github.com/klauspost/cpuid/v2 v2.0.4/go.mod h1:FInQzS24/EEf25PyTYn52gqo7WaD8xa0213Md/qVLRg=
 github.com/klauspost/cpuid/v2 v2.0.12/go.mod h1:g2LTdtYhdyuGPqyWyv7qRAmj1WBqxuObKfj5c0PQa7c=
-github.com/klauspost/cpuid/v2 v2.2.5 h1:0E5MSMDEoAulmXNFquVs//DdoomxaoTY1kUhbc/qbZg=
-github.com/klauspost/cpuid/v2 v2.2.5/go.mod h1:Lcz8mBdAVJIBVzewtcLocK12l3Y+JytZYpaMropDUws=
-github.com/klauspost/pgzip v1.2.6 h1:8RXeL5crjEUFnR2/Sn6GJNWtSQ3Dk8pq4CL3jvdDyjU=
-github.com/klauspost/pgzip v1.2.6/go.mod h1:Ch1tH69qFZu15pkjo5kYi6mth2Zzwzt50oCQKQE9RUs=
-github.com/klauspost/reedsolomon v1.11.8 h1:s8RpUW5TK4hjr+djiOpbZJB4ksx+TdYbRH7vHQpwPOY=
-github.com/klauspost/reedsolomon v1.11.8/go.mod h1:4bXRN+cVzMdml6ti7qLouuYi32KHJ5MGv0Qd8a47h6A=
+github.com/klauspost/cpuid/v2 v2.2.4 h1:acbojRNwl3o09bUq+yDCtZFc1aiwaAAxtcn8YkZXnvk=
+github.com/klauspost/cpuid/v2 v2.2.4/go.mod h1:RVVoqg1df56z8g3pUjL/3lE5UfnlrJX8tyFgg4nqhuY=
+github.com/klauspost/pgzip v1.2.5 h1:qnWYvvKqedOF2ulHpMG72XQol4ILEJ8k2wwRl/Km8oE=
+github.com/klauspost/pgzip v1.2.5/go.mod h1:Ch1tH69qFZu15pkjo5kYi6mth2Zzwzt50oCQKQE9RUs=
+github.com/klauspost/reedsolomon v1.11.7 h1:9uaHU0slncktTEEg4+7Vl7q7XUNMBUOK4R9gnKhMjAU=
+github.com/klauspost/reedsolomon v1.11.7/go.mod h1:4bXRN+cVzMdml6ti7qLouuYi32KHJ5MGv0Qd8a47h6A=
 github.com/konsorten/go-windows-terminal-sequences v1.0.1/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ=
 github.com/konsorten/go-windows-terminal-sequences v1.0.3/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ=
-github.com/kopia/htmluibuild v0.0.1-0.20231019063300-75c2a788c7d0 h1:TvupyyfbUZzsO4DQJpQhKZnUa61xERcJ+ejCbHWG2NY=
-github.com/kopia/htmluibuild v0.0.1-0.20231019063300-75c2a788c7d0/go.mod h1:cSImbrlwvv2phvj5RfScL2v08ghX6xli0PcK6f+t8S0=
+github.com/kopia/htmluibuild v0.0.0-20230326183719-f482ef17e2c9 h1:s5Wa89s8RlPjuwqd8K8kuf+T9Kz4+NsbKwR/pJ3PAT0=
 github.com/kr/fs v0.1.0/go.mod h1:FFnZGqtBN9Gxj7eW1uZ42v5BccTP0vu6NEaFoC2HwRg=
 github.com/kr/logfmt v0.0.0-20140226030751-b84e30acd515/go.mod h1:+0opPa2QZZtGFBFZlji/RkVcI2GknAs/DXo4wKdlNEc=
 github.com/kr/pretty v0.1.0/go.mod h1:dAy3ld7l9f0ibDNOQOHHMYYIIbhfbHSm3C4ZsoJORNo=
 github.com/kr/pretty v0.2.0/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
 github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
 github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
-github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
 github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
 github.com/kr/pty v1.1.5/go.mod h1:9r2w37qlBe7rQ6e1fg1S/9xpWHSnaqNdHD3WcMdbPDA=
 github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
@@ -560,7 +507,6 @@ github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
 github.com/kubernetes-csi/external-snapshotter/client/v4 v4.2.0 h1:nHHjmvjitIiyPlUHk/ofpgvBcNcawJLtf4PYHORLjAA=
 github.com/kubernetes-csi/external-snapshotter/client/v4 v4.2.0/go.mod h1:YBCo4DoEeDndqvAn6eeu0vWM7QdXmHEeI9cFWplmBys=
 github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc=
-github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
 github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de h1:9TO3cAIGXtEhnIaL+V+BEER86oLrvS+kWobKpbJuye0=
 github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de/go.mod h1:zAbeS9B/r2mtpb6U+EI2rYA5OAXxsYw6wTamcNW+zcE=
 github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=
@@ -584,8 +530,8 @@ github.com/mattn/go-isatty v0.0.4/go.mod h1:M+lRXTBqGeGNdLjl/ufCoiOlB5xdOkqRJdNx
 github.com/mattn/go-isatty v0.0.8/go.mod h1:Iq45c/XA43vh69/j3iqttzPXn0bhXyGjM0Hdxcsrc5s=
 github.com/mattn/go-isatty v0.0.10/go.mod h1:qgIWMr58cqv1PHHyhnkY9lrL7etaEgOFcMEpPG5Rm84=
 github.com/mattn/go-isatty v0.0.16/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM=
-github.com/mattn/go-isatty v0.0.19 h1:JITubQf0MOLdlGRuRq+jtsDlekdYPia9ZFsB8h/APPA=
-github.com/mattn/go-isatty v0.0.19/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=
+github.com/mattn/go-isatty v0.0.17 h1:BTarxUcIeDqL27Mc+vyvdWYSL28zpIhv3RoTdsLMPng=
+github.com/mattn/go-isatty v0.0.17/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM=
 github.com/mattn/go-runewidth v0.0.2/go.mod h1:LwmH8dsx7+W8Uxz3IHJYH5QSwggIsqBzpuz5H//U1FU=
 github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
 github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369/go.mod h1:BSXmuO+STAnVfrANrmjBb36TMTDstsz7MSK+HVaYKv4=
@@ -594,10 +540,10 @@ github.com/matttproud/golang_protobuf_extensions v1.0.4/go.mod h1:BSXmuO+STAnVfr
 github.com/miekg/dns v1.0.14/go.mod h1:W1PPwlIAgtquWBMBEV9nkV9Cazfe8ScdGz/Lj7v3Nrg=
 github.com/minio/md5-simd v1.1.2 h1:Gdi1DZK69+ZVMoNHRXJyNcxrMA4dSxoYHZSQbirFg34=
 github.com/minio/md5-simd v1.1.2/go.mod h1:MzdKDxYpY2BT9XQFocsiZf/NKVtR7nkE4RoEpN+20RM=
-github.com/minio/minio-go/v7 v7.0.63 h1:GbZ2oCvaUdgT5640WJOpyDhhDxvknAJU2/T3yurwcbQ=
-github.com/minio/minio-go/v7 v7.0.63/go.mod h1:Q6X7Qjb7WMhvG65qKf4gUgA5XaiSox74kR1uAEjxRS4=
-github.com/minio/sha256-simd v1.0.1 h1:6kaan5IFmwTNynnKKpDHe6FWHohJOHhCPchzK49dzMM=
-github.com/minio/sha256-simd v1.0.1/go.mod h1:Pz6AKMiUdngCLpeTL/RJY1M9rUuPMYujV5xJjtbRSN8=
+github.com/minio/minio-go/v7 v7.0.52 h1:8XhG36F6oKQUDDSuz6dY3rioMzovKjW40W6ANuN0Dps=
+github.com/minio/minio-go/v7 v7.0.52/go.mod h1:IbbodHyjUAguneyucUaahv+VMNs/EOTV9du7A7/Z3HU=
+github.com/minio/sha256-simd v1.0.0 h1:v1ta+49hkWZyvaKwrQB8elexRqm6Y0aMLjCNsrYxo6g=
+github.com/minio/sha256-simd v1.0.0/go.mod h1:OuYzVNI5vcoYIAmbIvHPl3N3jUzVedXbKy5RFepssQM=
 github.com/mitchellh/cli v1.0.0/go.mod h1:hNIlj7HEI86fIcpObd7a0FcrxTWetlwJDGcceTlRvqc=
 github.com/mitchellh/go-homedir v1.0.0/go.mod h1:SfyaCUpYCn1Vlf4IUYiD9fPX4A5wJrkLzIz1N1q0pr0=
 github.com/mitchellh/go-homedir v1.1.0 h1:lukF9ziXFxDFPkA1vsr5zpc1XuPDn/wFntq5mG+4E0Y=
@@ -621,6 +567,7 @@ github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742/go.mod h1:bx2lN
 github.com/modern-go/reflect2 v1.0.1/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0=
 github.com/modern-go/reflect2 v1.0.2 h1:xBagoLtFs94CBntxluKeaWgTMpvLxC4ur3nMaC9Gz0M=
 github.com/modern-go/reflect2 v1.0.2/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk=
+github.com/modocache/gover v0.0.0-20171022184752-b58185e213c5/go.mod h1:caMODM3PzxT8aQXRPkAt8xlV/e7d7w8GM5g0fa5F0D8=
 github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00/go.mod h1:Pm3mSP3c5uWn86xMLZ5Sa7JB9GsEZySvHYXCTK4E9q4=
 github.com/munnerz/goautoneg v0.0.0-20120707110453-a547fc61f48d/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
 github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq1c1nUAm88MOHcQC9l5mIlSMApZMrHA=
@@ -646,7 +593,6 @@ github.com/onsi/ginkgo v1.14.0/go.mod h1:iSB4RoI2tjJc9BBv4NKIKWKya62Rps+oPG/Lv9k
 github.com/onsi/ginkgo v1.16.5 h1:8xi0RTUf59SOSfEtZMvwTvXYMzG4gV23XVHOZiXNtnE=
 github.com/onsi/ginkgo v1.16.5/go.mod h1:+E8gABHa3K6zRBolWtd+ROzc/U5bkGt0FwiG042wbpU=
 github.com/onsi/ginkgo/v2 v2.1.6 h1:Fx2POJZfKRQcM1pH49qSZiYeu319wji004qX+GDovrU=
-github.com/onsi/ginkgo/v2 v2.1.6/go.mod h1:MEH45j8TBi6u9BMogfbp0stKC5cdGjumZj5Y7AG4VIk=
 github.com/onsi/gomega v0.0.0-20170829124025-dcabb60a477c/go.mod h1:C1qb7wdrVGGVU+Z6iS04AVkA3Q65CEZX59MT0QO5uiA=
 github.com/onsi/gomega v1.7.0/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY=
 github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7JYyY=
@@ -660,8 +606,6 @@ github.com/pelletier/go-toml v1.9.3/go.mod h1:u1nR/EPcESfeI/szUZKdtJ0xRNbUoANCko
 github.com/peterbourgon/diskv v2.0.1+incompatible/go.mod h1:uqqh8zWWbv1HBMNONnaR/tNboyR3/BZd58JJSHlUSCU=
 github.com/pierrec/lz4 v2.6.1+incompatible h1:9UY3+iC23yxF0UfGaYrGplQ+79Rg+h/q9FV9ix19jjM=
 github.com/pierrec/lz4 v2.6.1+incompatible/go.mod h1:pdkljMzZIN41W+lC3N2tnIh5sFi+IEE17M5jbnwPHcY=
-github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 h1:KoWmjvw+nsYOo29YJK9vDA65RGE3NrOnUtO7a+RF9HU=
-github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8/go.mod h1:HKlIX3XHQyzLZPlr7++PzdhaXEj94dEiJgZDTsxEqUI=
 github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
@@ -671,48 +615,48 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/posener/complete v1.1.1/go.mod h1:em0nMJCgc9GFtwrmVmEMR/ZL6WyhyjMBndrE9hABlRI=
 github.com/pquerna/cachecontrol v0.0.0-20171018203845-0dec1b30a021/go.mod h1:prYjPmNq4d1NPVmpShWobRqXY3q7Vp+80DqgxxUrUIA=
-github.com/project-velero/kopia v0.0.0-20231023031817-cf7bbc7f8519 h1:DiikAMR1wBIY6oFoN76WEJz4f+6OM99ZiGzZ9m9v32I=
-github.com/project-velero/kopia v0.0.0-20231023031817-cf7bbc7f8519/go.mod h1:V/zpEMjxzqEf3lF52m0b0nAIVQGolPYIOXRjVxeK1j0=
+github.com/project-velero/kopia v0.13.0-velero.1 h1:rjiP7os4Eaek/gbyIKqzwkp2XLbJHl0NkczSgJ7AOEo=
+github.com/project-velero/kopia v0.13.0-velero.1/go.mod h1:Iic7CcKhsq+A7MLR9hh6VJfgpcJhLx3Kn+BgjY+azvI=
 github.com/prometheus/client_golang v0.9.1/go.mod h1:7SWBe2y4D6OKWSNQJUaRYU/AaXPKyh/dDVn+NZz0KFw=
 github.com/prometheus/client_golang v0.9.3/go.mod h1:/TN21ttK/J9q6uSwhBd54HahCDft0ttaMvbicHlPoso=
 github.com/prometheus/client_golang v1.0.0/go.mod h1:db9x61etRT2tGnBNRi70OPL5FsnadC4Ky3P0J6CfImo=
 github.com/prometheus/client_golang v1.7.1/go.mod h1:PY5Wy2awLA44sXw4AOSfFBetzPP4j5+D6mVACh+pe2M=
 github.com/prometheus/client_golang v1.11.0/go.mod h1:Z6t4BnS23TR94PD6BsDNk8yVqroYurpAkEiz0P2BEV0=
 github.com/prometheus/client_golang v1.12.1/go.mod h1:3Z9XVyYiZYEO+YQWt3RD2R3jrbd179Rt297l4aS6nDY=
-github.com/prometheus/client_golang v1.17.0 h1:rl2sfwZMtSthVU752MqfjQozy7blglC+1SOtjMAMh+Q=
-github.com/prometheus/client_golang v1.17.0/go.mod h1:VeL+gMmOAxkS2IqfCq0ZmHSL+LjWfWDUmp1mBz9JgUY=
+github.com/prometheus/client_golang v1.15.0 h1:5fCgGYogn0hFdhyhLbw7hEsWxufKtY9klyvdNfFlFhM=
+github.com/prometheus/client_golang v1.15.0/go.mod h1:e9yaBhRPU2pPNsZwE+JdQl0KEt1N9XgF6zxWmaC0xOk=
 github.com/prometheus/client_model v0.0.0-20180712105110-5c3871d89910/go.mod h1:MbSGuTsp3dbXC40dX6PRTWyKYBIrTGTE9sqQNg2J8bo=
 github.com/prometheus/client_model v0.0.0-20190129233127-fd36f4220a90/go.mod h1:xMI15A0UPsDsEKsMN9yxemIoYk6Tm2C1GtYGdfGttqA=
 github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4/go.mod h1:xMI15A0UPsDsEKsMN9yxemIoYk6Tm2C1GtYGdfGttqA=
 github.com/prometheus/client_model v0.2.0/go.mod h1:xMI15A0UPsDsEKsMN9yxemIoYk6Tm2C1GtYGdfGttqA=
-github.com/prometheus/client_model v0.5.0 h1:VQw1hfvPvk3Uv6Qf29VrPF32JB6rtbgI6cYPYQjL0Qw=
-github.com/prometheus/client_model v0.5.0/go.mod h1:dTiFglRmd66nLR9Pv9f0mZi7B7fk5Pm3gvsjB5tr+kI=
+github.com/prometheus/client_model v0.3.0 h1:UBgGFHqYdG/TPFD1B1ogZywDqEkwp3fBMvqdiQ7Xew4=
+github.com/prometheus/client_model v0.3.0/go.mod h1:LDGWKZIo7rky3hgvBe+caln+Dr3dPggB5dvjtD7w9+w=
 github.com/prometheus/common v0.0.0-20181113130724-41aa239b4cce/go.mod h1:daVV7qP5qjZbuso7PdcryaAu0sAZbrN9i7WWcTMWvro=
 github.com/prometheus/common v0.4.0/go.mod h1:TNfzLD0ON7rHzMJeJkieUDPYmFC7Snx/y86RQel1bk4=
 github.com/prometheus/common v0.4.1/go.mod h1:TNfzLD0ON7rHzMJeJkieUDPYmFC7Snx/y86RQel1bk4=
 github.com/prometheus/common v0.10.0/go.mod h1:Tlit/dnDKsSWFlCLTWaA1cyBgKHSMdTB80sz/V91rCo=
 github.com/prometheus/common v0.26.0/go.mod h1:M7rCNAaPfAosfx8veZJCuw84e35h3Cfd9VFqTh1DIvc=
 github.com/prometheus/common v0.32.1/go.mod h1:vu+V0TpY+O6vW9J44gczi3Ap/oXXR10b+M/gUGO4Hls=
-github.com/prometheus/common v0.44.0 h1:+5BrQJwiBB9xsMygAB3TNvpQKOwlkc25LbISbrdOOfY=
-github.com/prometheus/common v0.44.0/go.mod h1:ofAIvZbQ1e/nugmZGz4/qCb9Ap1VoSTIO7x0VV9VvuY=
+github.com/prometheus/common v0.42.0 h1:EKsfXEYo4JpWMHH5cg+KOUWeuJSov1Id8zGR8eeI1YM=
+github.com/prometheus/common v0.42.0/go.mod h1:xBwqVerjNdUDjgODMpudtOMwlOwf2SaTr1yjz4b7Zbc=
 github.com/prometheus/procfs v0.0.0-20181005140218-185b4288413d/go.mod h1:c3At6R/oaqEKCNdg8wHV1ftS6bRYblBhIjjI8uT2IGk=
 github.com/prometheus/procfs v0.0.0-20190507164030-5867b95ac084/go.mod h1:TjEm7ze935MbeOT/UhFTIMYKhuLP4wbCsTZCD3I8kEA=
 github.com/prometheus/procfs v0.0.2/go.mod h1:TjEm7ze935MbeOT/UhFTIMYKhuLP4wbCsTZCD3I8kEA=
 github.com/prometheus/procfs v0.1.3/go.mod h1:lV6e/gmhEcM9IjHGsFOCxxuZ+z1YqCvr4OA4YeYWdaU=
 github.com/prometheus/procfs v0.6.0/go.mod h1:cz+aTbrPOrUb4q7XlbU9ygM+/jj0fzG6c1xBZuNvfVA=
 github.com/prometheus/procfs v0.7.3/go.mod h1:cz+aTbrPOrUb4q7XlbU9ygM+/jj0fzG6c1xBZuNvfVA=
-github.com/prometheus/procfs v0.11.1 h1:xRC8Iq1yyca5ypa9n1EZnWZkt7dwcoRPQwX/5gwaUuI=
-github.com/prometheus/procfs v0.11.1/go.mod h1:eesXgaPo1q7lBpVMoMy0ZOFTth9hBn4W/y0/p/ScXhY=
+github.com/prometheus/procfs v0.9.0 h1:wzCHvIvM5SxWqYvwgVL7yJY8Lz3PKn49KQtpgMYJfhI=
+github.com/prometheus/procfs v0.9.0/go.mod h1:+pB4zwohETzFnmlpe6yd2lSc+0/46IYZRB/chUwxUZY=
 github.com/prometheus/tsdb v0.7.1/go.mod h1:qhTCs0VvXwvX/y3TZrWD7rabWM+ijKTux40TwIPHuXU=
 github.com/robfig/cron v1.1.0 h1:jk4/Hud3TTdcrJgUOBgsqrZBarcxl6ADIjSC2iniwLY=
 github.com/robfig/cron v1.1.0/go.mod h1:JGuDeoQd7Z6yL4zQhZ3OPEVHB7fL6Ka6skscFHfmt2k=
 github.com/rogpeppe/fastuuid v0.0.0-20150106093220-6724a57986af/go.mod h1:XWv6SoW27p1b0cqNHllgS5HIMJraePCO15w5zCzIWYg=
 github.com/rogpeppe/fastuuid v1.2.0/go.mod h1:jVj6XXZzXRy/MSR5jhDC/2q6DgLz+nrA6LYCDYWNEvQ=
 github.com/rogpeppe/go-internal v1.3.0/go.mod h1:M8bDsm7K2OlrFYOpmOWEs/qY81heoFRclV5y23lUDJ4=
-github.com/rogpeppe/go-internal v1.10.0 h1:TMyTOH3F/DB16zRVcYyreMH6GnZZrwQVAoYjRBZyWFQ=
-github.com/rogpeppe/go-internal v1.10.0/go.mod h1:UQnix2H7Ngw/k4C5ijL5+65zddjncjaFoBhdsK/akog=
-github.com/rs/xid v1.5.0 h1:mKX4bl4iPYJtEIxp6CYiUuLQ/8DYMoz0PUdtGgMFRVc=
-github.com/rs/xid v1.5.0/go.mod h1:trrq9SKmegXys3aeAKXMUTdJsYXVwGY3RLcfgqegfbg=
+github.com/rogpeppe/go-internal v1.9.0 h1:73kH8U+JUqXU8lRuOHeVHaa/SZPifC7BkcraZVejAe8=
+github.com/rogpeppe/go-internal v1.9.0/go.mod h1:WtVeX8xhTBvf0smdhujwtBcq4Qrzq/fJaraNFVN+nFs=
+github.com/rs/xid v1.4.0 h1:qd7wPTDkN6KQx2VmMBLrpHkiyQwgFXRnkOLacUiaSNY=
+github.com/rs/xid v1.4.0/go.mod h1:trrq9SKmegXys3aeAKXMUTdJsYXVwGY3RLcfgqegfbg=
 github.com/russross/blackfriday/v2 v2.0.1/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/ryanuber/columnize v0.0.0-20160712163229-9b3edd62028f/go.mod h1:sm1tb6uqfes/u+d4ooFouqFdy9/2g9QGwK3SQygK0Ts=
@@ -724,8 +668,8 @@ github.com/sirupsen/logrus v1.4.2/go.mod h1:tLMulIdttU9McNUspp0xgXVQah82FyeX6Mwd
 github.com/sirupsen/logrus v1.6.0/go.mod h1:7uNnSEd1DgxDLC74fIahvMZmmYsHGZGEOFrfsX/uA88=
 github.com/sirupsen/logrus v1.7.0/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic61uBYv0=
 github.com/sirupsen/logrus v1.8.1/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic61uBYv0=
-github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
-github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
+github.com/sirupsen/logrus v1.9.0 h1:trlNQbNUG3OdDrDil03MCb1H2o9nJ1x4/5LYw7byDE0=
+github.com/sirupsen/logrus v1.9.0/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
 github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d/go.mod h1:OnSkiWE9lh6wB0YB77sQom3nweQdgAjqCqsofrRNTgc=
 github.com/smartystreets/goconvey v1.6.4/go.mod h1:syvi0/a8iFYH4r/RixwvyeAJjdLS9QV7WQ/tjFTllLA=
 github.com/soheilhy/cmux v0.1.4/go.mod h1:IM3LyeVVIOuxMH7sFAkER9+bJ4dT7Ms6E4xg4kGIyLM=
@@ -769,11 +713,10 @@ github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
 github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
 github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
-github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
-github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
+github.com/stretchr/testify v1.8.2 h1:+h33VjcLVPDHtOdpUCuF+7gSuG3yGIftsP1YvFihtJ8=
+github.com/stretchr/testify v1.8.2/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
 github.com/subosito/gotenv v1.2.0/go.mod h1:N0PQaV/YGNqwC0u51sEeR/aUtSLEXKX9iv69rRypqCw=
 github.com/tg123/go-htpasswd v1.2.1 h1:i4wfsX1KvvkyoMiHZzjS0VzbAPWfxzI8INcZAKtutoU=
-github.com/tg123/go-htpasswd v1.2.1/go.mod h1:erHp1B86KXdwQf1X5ZrLb7erXZnWueEQezb2dql4q58=
 github.com/tmc/grpc-websocket-proxy v0.0.0-20170815181823-89b8d40f7ca8/go.mod h1:ncp9v5uamzpCO7NfCPTXjqaC+bZgJeR0sMTm6dMHP7U=
 github.com/tmc/grpc-websocket-proxy v0.0.0-20190109142713-0ad062ec5ee5/go.mod h1:ncp9v5uamzpCO7NfCPTXjqaC+bZgJeR0sMTm6dMHP7U=
 github.com/tmc/grpc-websocket-proxy v0.0.0-20201229170055-e5319fda7802/go.mod h1:ncp9v5uamzpCO7NfCPTXjqaC+bZgJeR0sMTm6dMHP7U=
@@ -795,8 +738,8 @@ github.com/yuin/goldmark v1.1.32/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9de
 github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
 github.com/yuin/goldmark v1.3.5/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k=
 github.com/yuin/goldmark v1.4.1/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k=
-github.com/zalando/go-keyring v0.2.3 h1:v9CUu9phlABObO4LPWycf+zwMG7nlbb3t/B5wa97yms=
-github.com/zalando/go-keyring v0.2.3/go.mod h1:HL4k+OXQfJUWaMnqyuSOc0drfGPX2b51Du6K+MRgZMk=
+github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=
+github.com/zalando/go-keyring v0.2.2 h1:f0xmpYiSrHtSNAVgwip93Cg8tuF45HJM6rHq/A5RI/4=
 github.com/zeebo/assert v1.1.0 h1:hU1L1vLTHsnO8x8c9KAR5GmM5QscxHg5RNU5z5qbUWY=
 github.com/zeebo/assert v1.1.0/go.mod h1:Pq9JiuJQpG8JLJdtkwrJESF0Foym2/D9XMU5ciN/wJ0=
 github.com/zeebo/blake3 v0.2.3 h1:TFoLXsjeXqRNFxSbk35Dk4YtszE/MQQGK10BH4ptoTg=
@@ -831,19 +774,17 @@ go.opentelemetry.io/contrib v0.20.0/go.mod h1:G/EtFaa6qaN7+LxqfIAT3GiZa7Wv5DTBUz
 go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.20.0/go.mod h1:oVGt1LRbBOBq1A5BQLlUg9UaU/54aiHw8cgjV3aWZ/E=
 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.20.0/go.mod h1:2AboqHi0CiIZU0qwhtUfCYD1GeUzvvIXWNkhDt7ZMG4=
 go.opentelemetry.io/otel v0.20.0/go.mod h1:Y3ugLH2oa81t5QO+Lty+zXf8zC9L26ax4Nzoxm/dooo=
-go.opentelemetry.io/otel v1.19.0 h1:MuS/TNf4/j4IXsZuJegVzI1cwut7Qc00344rgH7p8bs=
-go.opentelemetry.io/otel v1.19.0/go.mod h1:i0QyjOq3UPoTzff0PJB2N66fb4S0+rSbSB15/oyH9fY=
+go.opentelemetry.io/otel v1.14.0 h1:/79Huy8wbf5DnIPhemGB+zEPVwnN6fuQybr/SRXa6hM=
+go.opentelemetry.io/otel v1.14.0/go.mod h1:o4buv+dJzx8rohcUeRmWUZhqupFvzWis188WlggnNeU=
 go.opentelemetry.io/otel/exporters/otlp v0.20.0/go.mod h1:YIieizyaN77rtLJra0buKiNBOm9XQfkPEKBeuhoMwAM=
 go.opentelemetry.io/otel/metric v0.20.0/go.mod h1:598I5tYlH1vzBjn+BTuhzTCSb/9debfNp6R3s7Pr1eU=
-go.opentelemetry.io/otel/metric v1.19.0 h1:aTzpGtV0ar9wlV4Sna9sdJyII5jTVJEvKETPiOKwvpE=
-go.opentelemetry.io/otel/metric v1.19.0/go.mod h1:L5rUsV9kM1IxCj1MmSdS+JQAcVm319EUrDVLrt7jqt8=
 go.opentelemetry.io/otel/oteltest v0.20.0/go.mod h1:L7bgKf9ZB7qCwT9Up7i9/pn0PWIa9FqQ2IQ8LoxiGnw=
 go.opentelemetry.io/otel/sdk v0.20.0/go.mod h1:g/IcepuwNsoiX5Byy2nNV0ySUF1em498m7hBWC279Yc=
 go.opentelemetry.io/otel/sdk/export/metric v0.20.0/go.mod h1:h7RBNMsDJ5pmI1zExLi+bJK+Dr8NQCh0qGhm1KDnNlE=
 go.opentelemetry.io/otel/sdk/metric v0.20.0/go.mod h1:knxiS8Xd4E/N+ZqKmUPf3gTTZ4/0TjTXukfxjzSTpHE=
 go.opentelemetry.io/otel/trace v0.20.0/go.mod h1:6GjCW8zgDjwGHGa6GkyeB8+/5vjT16gUEi0Nf1iBdgw=
-go.opentelemetry.io/otel/trace v1.19.0 h1:DFVQmlVbfVeOuBRrwdtaehRrWiL1JoVs9CPIQ1Dzxpg=
-go.opentelemetry.io/otel/trace v1.19.0/go.mod h1:mfaSyvGyEJEI0nyV2I4qhNQnbBOUUmYZpYojqMnX2vo=
+go.opentelemetry.io/otel/trace v1.14.0 h1:wp2Mmvj41tDsyAJXiWDWpfNsOiIyd38fy85pyKcFq/M=
+go.opentelemetry.io/otel/trace v1.14.0/go.mod h1:8avnQLK+CG77yNLUae4ea2JDQ6iT+gozhnZjy/rw9G8=
 go.opentelemetry.io/proto/otlp v0.7.0/go.mod h1:PqfVotwruBrMGOCsRd/89rSnXhoiJIqeYNgFYFoEGnI=
 go.starlark.net v0.0.0-20200306205701-8dd3e2ee1dd5/go.mod h1:nmDLcffg48OtT/PSW0Hg7FvpRQsQh5OSqIylirxKC7o=
 go.starlark.net v0.0.0-20201006213952-227f4aabceb5 h1:ApvY/1gw+Yiqb/FKeks3KnVPWpkR3xzij82XPKLjJVw=
@@ -851,9 +792,10 @@ go.starlark.net v0.0.0-20201006213952-227f4aabceb5/go.mod h1:f0znQkUKRrkk36XxWbG
 go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
 go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
 go.uber.org/atomic v1.7.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc=
+go.uber.org/atomic v1.9.0 h1:ECmE8Bn/WFTYwEW/bpKD3M8VtR/zQVbavAoalC1PYyE=
+go.uber.org/atomic v1.9.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc=
 go.uber.org/goleak v1.1.10/go.mod h1:8a7PlsEVH3e/a/GLqe5IIrQx6GzcnRmZEufDUTk4A7A=
-go.uber.org/goleak v1.2.0 h1:xqgm/S+aQvhWFTtR0XK3Jvg7z8kGV8P4X14IzwN3Eqk=
-go.uber.org/goleak v1.2.0/go.mod h1:XJYK+MuIchqpmGmUSAzotztawfKvYLUIgg7guXrwVUo=
+go.uber.org/goleak v1.1.12 h1:gZAh5/EyT/HQwlpkCy6wTpqfH9H8Lz8zbm3dZh+OyzA=
 go.uber.org/multierr v1.1.0/go.mod h1:wR5kodmAFQ0UK8QlbwjlSNy0Z68gJhDJUG5sjR94q/0=
 go.uber.org/multierr v1.6.0/go.mod h1:cdWPpRnG4AhwMwsgIHip0KRBQjJy5kYEpYjJxpXp9iU=
 go.uber.org/multierr v1.11.0 h1:blXXJkSxSSfBVBlC76pxqeO+LN3aDfLQo+309xJstO0=
@@ -861,8 +803,8 @@ go.uber.org/multierr v1.11.0/go.mod h1:20+QtiLqy0Nd6FdQB9TLXag12DsQkrbs3htMFfDN8
 go.uber.org/zap v1.10.0/go.mod h1:vwi/ZaCAaUcBkycHslxD9B2zi4UTXhF60s6SWpuDF0Q=
 go.uber.org/zap v1.17.0/go.mod h1:MXVU+bhUf/A7Xi2HNOnopQOrmycQ5Ih87HtOu4q5SSo=
 go.uber.org/zap v1.19.0/go.mod h1:xg/QME4nWcxGxrpdeYfq7UvYrLh66cuVKdrbD1XF/NI=
-go.uber.org/zap v1.26.0 h1:sI7k6L95XOKS281NhVKOFCUNIvv9e0w4BF8N3u+tCRo=
-go.uber.org/zap v1.26.0/go.mod h1:dtElttAiwGvoJ/vj4IwHBS/gXsEu/pZ50mUIRWuG0so=
+go.uber.org/zap v1.24.0 h1:FiJd5l1UOLj0wCgbSE0rwwXHzEdAZS6hiiSnxJN/D60=
+go.uber.org/zap v1.24.0/go.mod h1:2kMP+WWQ8aoFoedH3T2sq6iJ2yDWpHbP0f6MQbS9Gkg=
 golang.org/x/crypto v0.0.0-20180904163835-0709b304e793/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
 golang.org/x/crypto v0.0.0-20181029021203-45a5f77698d3/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
@@ -880,8 +822,8 @@ golang.org/x/crypto v0.0.0-20210513164829-c07d793c2f9a/go.mod h1:P+XmwS30IXTQdn5
 golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
 golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
 golang.org/x/crypto v0.0.0-20220214200702-86341886e292/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
-golang.org/x/crypto v0.17.0 h1:r8bRNjWL3GshPW3gkd+RpvzWrZAwPS49OmTGZ/uhM4k=
-golang.org/x/crypto v0.17.0/go.mod h1:gCAAfMLgwOJRpTjQ2zCCt2OcSfYMTeZVSRtQlPC7Nq4=
+golang.org/x/crypto v0.8.0 h1:pd9TJtTueMTVQXzk8E2XESSMQDj/U7OUu0PqJqPXQjQ=
+golang.org/x/crypto v0.8.0/go.mod h1:mRqEX+O9/h5TFCrQhkgjo2yKi0yYA+9ecGkdQoHrywE=
 golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8=
@@ -892,8 +834,8 @@ golang.org/x/exp v0.0.0-20191227195350-da58074b4299/go.mod h1:2RIsYlXP63K8oxa1u0
 golang.org/x/exp v0.0.0-20200119233911-0405dc783f0a/go.mod h1:2RIsYlXP63K8oxa1u096TMicItID8zy7Y6sNkU49FU4=
 golang.org/x/exp v0.0.0-20200207192155-f17229e696bd/go.mod h1:J/WKrq2StrnmMY6+EHIKF9dgMWnmCNThgcyBT1FY9mM=
 golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6/go.mod h1:3jZMyOhIsHpP37uCMkUooju7aAi5cS1Q23tOzKc+0MU=
-golang.org/x/exp v0.0.0-20230522175609-2e198f4a06a1 h1:k/i9J1pBpvlfR+9QsetwPyERsqu1GIbi967PQMq3Ivc=
-golang.org/x/exp v0.0.0-20230522175609-2e198f4a06a1/go.mod h1:V1LtkGg67GoY2N1AnLN78QLrzxkLyJw7RJb1gzOOz9w=
+golang.org/x/exp v0.0.0-20221028150844-83b7d23a625f h1:Al51T6tzvuh3oiwX11vex3QgJ2XTedFPGmbEVh8cdoc=
+golang.org/x/exp v0.0.0-20221028150844-83b7d23a625f/go.mod h1:CxIveKay+FTh1D0yPZemJVgC/95VzuuOLq5Qi4xnoYc=
 golang.org/x/image v0.0.0-20190227222117-0694c2d4d067/go.mod h1:kZ7UVZpmo3dzQBMxlp+ypCbDeSB+sBbTgSJuh5dn5js=
 golang.org/x/image v0.0.0-20190802002840-cff245a6509b/go.mod h1:FeLwcggjj3mMvU+oOTbSwawSJRM1uh48EjtB4UJZlP0=
 golang.org/x/lint v0.0.0-20181026193005-c67002cb31c3/go.mod h1:UVdnD1Gm6xHRNCYTkRU2/jEulfH38KcIWyp/GAMgvoE=
@@ -920,8 +862,9 @@ golang.org/x/mod v0.4.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.4.1/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3/go.mod h1:3p9vT2HGsQu2K1YbXdKPJLVgG5VJdoTa1poYQBtP1AY=
-golang.org/x/mod v0.13.0 h1:I/DsJXRlw/8l/0c24sM9yb0T4z9liZTduXvdAWYiysY=
-golang.org/x/mod v0.13.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
+golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4/go.mod h1:jJ57K6gSWd91VN4djpZkiMVwK6gcyfeH4XE8wZrZaV4=
+golang.org/x/mod v0.10.0 h1:lFO9qtOdlre5W1jxS3r/4szv2/6iXxScdzjoBMXNhYk=
+golang.org/x/mod v0.10.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
 golang.org/x/net v0.0.0-20180530234432-1e491301e022/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
@@ -960,6 +903,7 @@ golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2/go.mod h1:qpuaurCH72eLCgpAm/
 golang.org/x/net v0.0.0-20200625001655-4c5254603344/go.mod h1:/O7V0waA8r7cgGh81Ro3o1hOxt32SMVPicZroKQ2sZA=
 golang.org/x/net v0.0.0-20200707034311-ab3426394381/go.mod h1:/O7V0waA8r7cgGh81Ro3o1hOxt32SMVPicZroKQ2sZA=
 golang.org/x/net v0.0.0-20200822124328-c89045814202/go.mod h1:/O7V0waA8r7cgGh81Ro3o1hOxt32SMVPicZroKQ2sZA=
+golang.org/x/net v0.0.0-20201010224723-4f7140c49acb/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
 golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
 golang.org/x/net v0.0.0-20201031054903-ff519b6c9102/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
 golang.org/x/net v0.0.0-20201110031124-69a78807bb2b/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
@@ -977,8 +921,10 @@ golang.org/x/net v0.0.0-20210825183410-e898025ed96a/go.mod h1:9nx3DQGgdP8bBQD5qx
 golang.org/x/net v0.0.0-20211015210444-4f30a5c0130f/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
 golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
 golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd/go.mod h1:CfG3xpIq0wQ8r1q4Su4UZFWDARRcnwPjda9FqA0JpMk=
-golang.org/x/net v0.17.0 h1:pVaXccu2ozPjCXewfr1S7xza/zcXTity9cCdXQYSjIM=
-golang.org/x/net v0.17.0/go.mod h1:NxSsAGuq816PNPmqtQdLE42eU2Fs7NoRIZrHJAlaCOE=
+golang.org/x/net v0.0.0-20220722155237-a158d28d115b/go.mod h1:XRhObCWvk6IyKnWLug+ECip1KBveYUHfp+8e9klMJ9c=
+golang.org/x/net v0.1.0/go.mod h1:Cx3nUiGt4eDBEyega/BKRp+/AlGL8hYe7U9odMt2Cco=
+golang.org/x/net v0.9.0 h1:aWJ/m6xSmxWBx+V0XRHTlrYrPG56jKsLdTFmsSsCzOM=
+golang.org/x/net v0.9.0/go.mod h1:d48xBJpPfHeWQsugry2m+kC02ZBRGRgulfHnEXEuWns=
 golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
 golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
 golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
@@ -994,8 +940,8 @@ golang.org/x/oauth2 v0.0.0-20210402161424-2e8d93401602/go.mod h1:KelEdhl1UZF7XfJ
 golang.org/x/oauth2 v0.0.0-20210514164344-f6687ab2804c/go.mod h1:KelEdhl1UZF7XfJ4dDtk6s++YSgaE7mD/BuKKDLBl4A=
 golang.org/x/oauth2 v0.0.0-20210819190943-2bc19b11175f/go.mod h1:KelEdhl1UZF7XfJ4dDtk6s++YSgaE7mD/BuKKDLBl4A=
 golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8/go.mod h1:KelEdhl1UZF7XfJ4dDtk6s++YSgaE7mD/BuKKDLBl4A=
-golang.org/x/oauth2 v0.13.0 h1:jDDenyj+WgFtmV3zYVoi8aE2BwtXFLWOA67ZfNWftiY=
-golang.org/x/oauth2 v0.13.0/go.mod h1:/JMhi4ZRXAf4HG9LiNmxvk+45+96RUlVThiH8FzNBn0=
+golang.org/x/oauth2 v0.7.0 h1:qe6s0zUXlPX80/dITx3440hWZ7GwMwgDDyrSGTPJG/g=
+golang.org/x/oauth2 v0.7.0/go.mod h1:hPLQkd9LyjfXTiRohC/41GhcFqxisoUQ99sCUOHO9x4=
 golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
 golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
 golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
@@ -1007,8 +953,9 @@ golang.org/x/sync v0.0.0-20200625203802-6e8e738ad208/go.mod h1:RxMgew5VJxzue5/jJ
 golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
 golang.org/x/sync v0.0.0-20201207232520-09787c993a3a/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
 golang.org/x/sync v0.0.0-20210220032951-036812b2e83c/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
-golang.org/x/sync v0.4.0 h1:zxkM55ReGkDlKSM+Fu41A+zmbZuaPVbGMzvvdUPznYQ=
-golang.org/x/sync v0.4.0/go.mod h1:FU7BRWz2tNW+3quACPkgCx/L+uEAv1htQ0V83Z9Rj+Y=
+golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
+golang.org/x/sync v0.1.0 h1:wsuoTGHzEhffawBOhz5CYhcrV4IdKZbEyZjBMuTp12o=
+golang.org/x/sync v0.1.0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
 golang.org/x/sys v0.0.0-20180823144017-11551d06cbcc/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20180830151530-49385e6e1522/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20180905080454-ebe1bf3edb33/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
@@ -1076,7 +1023,6 @@ golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7w
 golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210603081109-ebe580a85c40/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.0.0-20210616045830-e2b7044e8c71/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210616094352-59db8d763f22/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210831042530-f4d43177bf5e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
@@ -1085,18 +1031,21 @@ golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e/go.mod h1:oPkhp1MJrh7nUepCBc
 golang.org/x/sys v0.0.0-20220114195835-da31bd327af9/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220209214540-3681064d5158/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220412211240-33da011f77ad/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20220704084225-05e143d24a9e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.15.0 h1:h48lPFYpsTvQJZF4EKyI4aLHaev3CxivZmv7yZig9pc=
-golang.org/x/sys v0.15.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
+golang.org/x/sys v0.1.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.7.0 h1:3jlCCIQZPdOYu1h8BkNvLz8Kgwtae2cagcG/VamtZRU=
+golang.org/x/sys v0.7.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/term v0.0.0-20201117132131-f5c789dd3221/go.mod h1:Nr5EML6q2oocZ2LXRh80K7BxOlk5/8JxuGnuhpl+muw=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
 golang.org/x/term v0.0.0-20210220032956-6a3ed077a48d/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
 golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
-golang.org/x/term v0.15.0 h1:y/Oo/a/q3IXu26lQgl04j/gjuBDOBlx7X6Om1j2CPW4=
-golang.org/x/term v0.15.0/go.mod h1:BDl952bC7+uMoWR75FIrCDx79TPU9oHkTZ9yRbYOrX0=
+golang.org/x/term v0.1.0/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
+golang.org/x/term v0.7.0 h1:BEvjmm5fURWqcfbSKTdpkDXYBrUS1c0m8agp14W48vQ=
+golang.org/x/term v0.7.0/go.mod h1:P32HKFT3hSsZrRxla30E9HqToFYAQPCMs/zFMBUFqPY=
 golang.org/x/text v0.0.0-20170915032832-14c0d48ead0c/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/text v0.3.1-0.20180807135948-17ff2d5776d2/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
@@ -1106,8 +1055,9 @@ golang.org/x/text v0.3.4/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.5/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
-golang.org/x/text v0.14.0 h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ=
-golang.org/x/text v0.14.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU=
+golang.org/x/text v0.4.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
+golang.org/x/text v0.9.0 h1:2sjJmO8cDvYveuX97RDLsxlyUxLl+GHoLxBiRdHllBE=
+golang.org/x/text v0.9.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8=
 golang.org/x/time v0.0.0-20180412165947-fbb02b2291d2/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
@@ -1180,6 +1130,7 @@ golang.org/x/tools v0.1.0/go.mod h1:xkSsbof2nBLbhDlRMhhhyNLN/zl3eTqcnHD5viDpcZ0=
 golang.org/x/tools v0.1.2/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk=
 golang.org/x/tools v0.1.5/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk=
 golang.org/x/tools v0.1.10-0.20220218145154-897bd77cd717/go.mod h1:Uh6Zz+xoGYZom868N8YTex3t7RhtHDBrE8Gzo9bV56E=
+golang.org/x/tools v0.1.12/go.mod h1:hNGJHUnrk76NpqgfD5Aqm5Crs+Hm0VOH/i9J2+nxYbc=
 golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
@@ -1210,8 +1161,8 @@ google.golang.org/api v0.40.0/go.mod h1:fYKFpnQN0DsDSKRVRcQSDQNtqWPfM9i+zNPxepjR
 google.golang.org/api v0.41.0/go.mod h1:RkxM5lITDfTzmyKFPt+wGrCJbVfniCr2ool8kTBzRTU=
 google.golang.org/api v0.43.0/go.mod h1:nQsDGjRXMo4lvh5hP0TKqF244gqhGcr/YSIykhUk/94=
 google.golang.org/api v0.44.0/go.mod h1:EBOGZqzyhtvMDoxwS97ctnh0zUmYY6CxqXsc1AvkYD8=
-google.golang.org/api v0.146.0 h1:9aBYT4vQXt9dhCuLNfwfd3zpwu8atg0yPkjBymwSrOM=
-google.golang.org/api v0.146.0/go.mod h1:OARJqIfoYjXJj4C1AiBSXYZt03qsoz8FQYU6fBEfrHM=
+google.golang.org/api v0.120.0 h1:TTmhTei0mkR+kiBSW2UzZmAbkTaBfUUzfchyXnzG9Hs=
+google.golang.org/api v0.120.0/go.mod h1:CrSvlNEFCFLae9ZUtL1z+61+rEBD7J/aCYwVYKZoWFU=
 google.golang.org/appengine v1.1.0/go.mod h1:EbEs0AVv82hx2wNQdGPgUI5lhzA/G0D9YwlJXL52JkM=
 google.golang.org/appengine v1.4.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=
 google.golang.org/appengine v1.5.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=
@@ -1267,12 +1218,8 @@ google.golang.org/genproto v0.0.0-20210402141018-6c239bbf2bb1/go.mod h1:9lPAdzaE
 google.golang.org/genproto v0.0.0-20210602131652-f16073e35f0c/go.mod h1:UODoCrxHCcBojKKwX1terBiRUaqAsFqJiF615XL43r0=
 google.golang.org/genproto v0.0.0-20210831024726-fe130286e0e2/go.mod h1:eFjDcFEctNawg4eG61bRv87N7iHBWyVhJu7u1kqDUXY=
 google.golang.org/genproto v0.0.0-20220107163113-42d7afdf6368/go.mod h1:5CzLGKJ67TSI2B9POpiiyGha0AjJvZIUgRMt1dSmuhc=
-google.golang.org/genproto v0.0.0-20230913181813-007df8e322eb h1:XFBgcDwm7irdHTbz4Zk2h7Mh+eis4nfJEFQFYzJzuIA=
-google.golang.org/genproto v0.0.0-20230913181813-007df8e322eb/go.mod h1:yZTlhN0tQnXo3h00fuXNCxJdLdIdnVFVBaRJ5LWBbw4=
-google.golang.org/genproto/googleapis/api v0.0.0-20230913181813-007df8e322eb h1:lK0oleSc7IQsUxO3U5TjL9DWlsxpEBemh+zpB7IqhWI=
-google.golang.org/genproto/googleapis/api v0.0.0-20230913181813-007df8e322eb/go.mod h1:KjSP20unUpOx5kyQUFa7k4OJg0qeJ7DEZflGDu2p6Bk=
-google.golang.org/genproto/googleapis/rpc v0.0.0-20230920204549-e6e6cdab5c13 h1:N3bU/SQDCDyD6R528GJ/PwW9KjYcJA3dgyH+MovAkIM=
-google.golang.org/genproto/googleapis/rpc v0.0.0-20230920204549-e6e6cdab5c13/go.mod h1:KSqppvjFjtoCI+KGd4PELB0qLNxdJHRGqRI09mB6pQA=
+google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 h1:KpwkzHKEF7B9Zxg18WzOa7djJ+Ha5DzthMyZYQfEn2A=
+google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1/go.mod h1:nKE/iIaLqn2bQwXBg8f1g2Ylh6r5MN5CmZvuzZCgsCU=
 google.golang.org/grpc v1.8.0/go.mod h1:yo6s7OP7yaDglbqo1J04qKzAhqBH6lvTonzMVmEdcZw=
 google.golang.org/grpc v1.19.0/go.mod h1:mqu4LbDTu4XGKhr4mRzUsmM4RtVoemTSY81AxZiDr8c=
 google.golang.org/grpc v1.20.1/go.mod h1:10oTOabMzJvdu6/UiuZezV6QK5dSlG84ov/aaiqXj38=
@@ -1297,8 +1244,9 @@ google.golang.org/grpc v1.36.1/go.mod h1:qjiiYl8FncCW8feJPdyg3v6XW24KsRHe+dy9BAG
 google.golang.org/grpc v1.37.0/go.mod h1:NREThFqKR1f3iQ6oBuvc5LadQuXVGo9rkm5ZGrQdJfM=
 google.golang.org/grpc v1.38.0/go.mod h1:NREThFqKR1f3iQ6oBuvc5LadQuXVGo9rkm5ZGrQdJfM=
 google.golang.org/grpc v1.40.0/go.mod h1:ogyxbiOoUXAkP+4+xa6PZSE9DZgIHtSpzjDTB9KAK34=
-google.golang.org/grpc v1.58.3 h1:BjnpXut1btbtgN/6sp+brB2Kbm2LjNXnidYujAVbSoQ=
-google.golang.org/grpc v1.58.3/go.mod h1:tgX3ZQDlNJGU96V6yHh1T/JeoBQ2TXdr43YbYSsCJk0=
+google.golang.org/grpc v1.45.0/go.mod h1:lN7owxKUQEqMfSyQikvvk5tf/6zMPsrK+ONuO11+0rQ=
+google.golang.org/grpc v1.54.0 h1:EhTqbhiYeixwWQtAEZAxmV9MGqcjEU2mFx52xCzNyag=
+google.golang.org/grpc v1.54.0/go.mod h1:PUSEXI6iWghWaB6lXM4knEgpJNu2qUcKfDtNci3EC2g=
 google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=
 google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0=
 google.golang.org/protobuf v0.0.0-20200228230310-ab0ca4ff8a60/go.mod h1:cfTl7dwQJ+fmap5saPgwCLgHXTUD7jkjRqWcaiX5VyM=
@@ -1312,8 +1260,8 @@ google.golang.org/protobuf v1.25.0/go.mod h1:9JNX74DMeImyA3h4bdi1ymwjUzf21/xIlba
 google.golang.org/protobuf v1.26.0-rc.1/go.mod h1:jlhhOSvTdKEhbULTjvd4ARK9grFBp09yW+WbY/TyQbw=
 google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc=
 google.golang.org/protobuf v1.27.1/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc=
-google.golang.org/protobuf v1.31.0 h1:g0LDEJHgrBl9N9r17Ru3sqWhkIx2NB67okBHPwC7hs8=
-google.golang.org/protobuf v1.31.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
+google.golang.org/protobuf v1.30.0 h1:kPPoIgf3TsEvrm0PFe15JQ+570QVxYzEvvHqChK+cng=
+google.golang.org/protobuf v1.30.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
 gopkg.in/alecthomas/kingpin.v2 v2.2.6/go.mod h1:FMv+mEhP44yOT+4EoQTLFTRgOQ1FBLkstjWtayDeSgw=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
@@ -1428,8 +1376,8 @@ sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.30/go.mod h1:fEO7lR
 sigs.k8s.io/controller-runtime v0.12.2 h1:nqV02cvhbAj7tbt21bpPpTByrXGn2INHRsi39lXy9sE=
 sigs.k8s.io/controller-runtime v0.12.2/go.mod h1:qKsk4WE6zW2Hfj0G4v10EnNB2jMG1C+NTb8h+DwCoU0=
 sigs.k8s.io/json v0.0.0-20211208200746-9f7c6b3444d2/go.mod h1:B+TnT182UBxE84DiCz4CVE26eOSDAeYCpfDnC2kdKMY=
-sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd h1:EDPBXCAspyGV4jQlpZSudPeMmr1bNJefnuqLsRAsHZo=
-sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd/go.mod h1:B8JuhiUyNFVKdsE8h686QcCxMaH6HrOAZj4vswFpcB0=
+sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 h1:iXTIw73aPyC+oRdyqqvVJuloN1p0AC/kzH07hu3NE+k=
+sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2/go.mod h1:B8JuhiUyNFVKdsE8h686QcCxMaH6HrOAZj4vswFpcB0=
 sigs.k8s.io/kustomize/api v0.8.11/go.mod h1:a77Ls36JdfCWojpUqR6m60pdGY1AYFix4AH83nJtY1g=
 sigs.k8s.io/kustomize/api v0.11.4/go.mod h1:k+8RsqYbgpkIrJ4p9jcdPqe8DprLxFUUO0yNOq8C+xI=
 sigs.k8s.io/kustomize/kyaml v0.11.0/go.mod h1:GNMwjim4Ypgp/MueD3zXHLRJEjz7RvtPae0AwlvEMFM=

golangci.yaml

@@ -326,12 +326,6 @@ linters:
     - unused
     - usestdlibvars
     - whitespace
-    - dupword
-    - errchkjson
-    - ginkgolinter
-    - nilerr
-    - noctx
-    - nolintlint
   fast: false
 
 

hack/build-image/Dockerfile

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM --platform=linux/amd64 golang:1.21.6-bookworm
+FROM --platform=linux/amd64 golang:1.20.7-bullseye
 
 ARG GOPROXY
 
@@ -56,7 +56,7 @@ RUN wget --quiet https://github.com/goreleaser/goreleaser/releases/download/v1.1
     chmod +x /usr/bin/goreleaser
 
 # get golangci-lint
-RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.54.2
+RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.51.0
 
 # install kubectl
 RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl

hack/docker-push.sh

@@ -89,7 +89,7 @@ else
 fi
 
 if [[ -z "$BUILDX_PLATFORMS" ]]; then
-    BUILDX_PLATFORMS="linux/amd64,linux/arm64"
+    BUILDX_PLATFORMS="linux/amd64,linux/arm64,linux/arm/v7,linux/ppc64le"
 fi
 
 # Debugging info

hack/fix_restic_cve.txt

@@ -1,215 +1,60 @@
 diff --git a/go.mod b/go.mod
-index 5f939c481..a2c584c4d 100644
+index 5f939c481..6f281b45d 100644
 --- a/go.mod
 +++ b/go.mod
-@@ -24,32 +24,32 @@ require (
- 	github.com/restic/chunker v0.4.0
+@@ -25,12 +25,12 @@ require (
  	github.com/spf13/cobra v1.6.1
  	github.com/spf13/pflag v1.0.5
--	golang.org/x/crypto v0.5.0
+ 	golang.org/x/crypto v0.5.0
 -	golang.org/x/net v0.5.0
--	golang.org/x/oauth2 v0.4.0
-+	golang.org/x/crypto v0.17.0
-+	golang.org/x/net v0.17.0
-+	golang.org/x/oauth2 v0.7.0
++	golang.org/x/net v0.7.0
+ 	golang.org/x/oauth2 v0.4.0
  	golang.org/x/sync v0.1.0
 -	golang.org/x/sys v0.4.0
 -	golang.org/x/term v0.4.0
 -	golang.org/x/text v0.6.0
--	google.golang.org/api v0.106.0
-+	golang.org/x/sys v0.15.0
-+	golang.org/x/term v0.15.0
-+	golang.org/x/text v0.14.0
-+	google.golang.org/api v0.114.0
++	golang.org/x/sys v0.5.0
++	golang.org/x/term v0.5.0
++	golang.org/x/text v0.7.0
+ 	google.golang.org/api v0.106.0
  )
  
- require (
--	cloud.google.com/go v0.108.0 // indirect
--	cloud.google.com/go/compute v1.15.1 // indirect
-+	cloud.google.com/go v0.110.0 // indirect
-+	cloud.google.com/go/compute v1.19.1 // indirect
- 	cloud.google.com/go/compute/metadata v0.2.3 // indirect
--	cloud.google.com/go/iam v0.10.0 // indirect
-+	cloud.google.com/go/iam v0.13.0 // indirect
- 	github.com/Azure/azure-sdk-for-go/sdk/internal v1.1.2 // indirect
- 	github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
- 	github.com/dnaeon/go-vcr v1.2.0 // indirect
- 	github.com/dustin/go-humanize v1.0.0 // indirect
- 	github.com/felixge/fgprof v0.9.3 // indirect
- 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
--	github.com/golang/protobuf v1.5.2 // indirect
-+	github.com/golang/protobuf v1.5.3 // indirect
- 	github.com/google/pprof v0.0.0-20230111200839-76d1ae5aea2b // indirect
- 	github.com/google/uuid v1.3.0 // indirect
--	github.com/googleapis/enterprise-certificate-proxy v0.2.1 // indirect
--	github.com/googleapis/gax-go/v2 v2.7.0 // indirect
-+	github.com/googleapis/enterprise-certificate-proxy v0.2.3 // indirect
-+	github.com/googleapis/gax-go/v2 v2.7.1 // indirect
- 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
- 	github.com/json-iterator/go v1.1.12 // indirect
- 	github.com/klauspost/cpuid/v2 v2.2.3 // indirect
-@@ -63,9 +63,9 @@ require (
- 	go.opencensus.io v0.24.0 // indirect
- 	golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
- 	google.golang.org/appengine v1.6.7 // indirect
--	google.golang.org/genproto v0.0.0-20230110181048-76db0878b65f // indirect
--	google.golang.org/grpc v1.52.0 // indirect
--	google.golang.org/protobuf v1.28.1 // indirect
-+	google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 // indirect
-+	google.golang.org/grpc v1.56.3 // indirect
-+	google.golang.org/protobuf v1.30.0 // indirect
- 	gopkg.in/ini.v1 v1.67.0 // indirect
- 	gopkg.in/yaml.v3 v3.0.1 // indirect
- )
 diff --git a/go.sum b/go.sum
-index 026e1d2fa..8387b4e2f 100644
+index 026e1d2fa..da35b7a6c 100644
 --- a/go.sum
 +++ b/go.sum
-@@ -1,13 +1,13 @@
- cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
--cloud.google.com/go v0.108.0 h1:xntQwnfn8oHGX0crLVinvHM+AhXvi3QHQIEcX/2hiWk=
--cloud.google.com/go v0.108.0/go.mod h1:lNUfQqusBJp0bgAg6qrHgYFYbTB+dOiob1itwnlD33Q=
--cloud.google.com/go/compute v1.15.1 h1:7UGq3QknM33pw5xATlpzeoomNxsacIVvTqTTvbfajmE=
--cloud.google.com/go/compute v1.15.1/go.mod h1:bjjoF/NtFUrkD/urWfdHaKuOPDR5nWIs63rR+SXhcpA=
-+cloud.google.com/go v0.110.0 h1:Zc8gqp3+a9/Eyph2KDmcGaPtbKRIoqq4YTlL4NMD0Ys=
-+cloud.google.com/go v0.110.0/go.mod h1:SJnCLqQ0FCFGSZMUNUf84MV3Aia54kn7pi8st7tMzaY=
-+cloud.google.com/go/compute v1.19.1 h1:am86mquDUgjGNWxiGn+5PGLbmgiWXlE/yNWpIpNvuXY=
-+cloud.google.com/go/compute v1.19.1/go.mod h1:6ylj3a05WF8leseCdIf77NK0g1ey+nj5IKd5/kvShxE=
- cloud.google.com/go/compute/metadata v0.2.3 h1:mg4jlk7mCAj6xXp9UJ4fjI9VUI5rubuGBW5aJ7UnBMY=
- cloud.google.com/go/compute/metadata v0.2.3/go.mod h1:VAV5nSsACxMJvgaAuX6Pk2AawlZn8kiOGuCv6gTkwuA=
--cloud.google.com/go/iam v0.10.0 h1:fpP/gByFs6US1ma53v7VxhvbJpO2Aapng6wabJ99MuI=
--cloud.google.com/go/iam v0.10.0/go.mod h1:nXAECrMt2qHpF6RZUZseteD6QyanL68reN4OXPw0UWM=
--cloud.google.com/go/longrunning v0.3.0 h1:NjljC+FYPV3uh5/OwWT6pVU+doBqMg2x/rZlE+CamDs=
-+cloud.google.com/go/iam v0.13.0 h1:+CmB+K0J/33d0zSQ9SlFWUeCCEn5XJA0ZMZ3pHE9u8k=
-+cloud.google.com/go/iam v0.13.0/go.mod h1:ljOg+rcNfzZ5d6f1nAUJ8ZIxOaZUVoS14bKCtaLZ/D0=
-+cloud.google.com/go/longrunning v0.4.1 h1:v+yFJOfKC3yZdY6ZUI933pIYdhyhV8S3NpWrXWmg7jM=
- cloud.google.com/go/storage v1.28.1 h1:F5QDG5ChchaAVQhINh24U99OWHURqrW8OmQcGKXcbgI=
- cloud.google.com/go/storage v1.28.1/go.mod h1:Qnisd4CqDdo6BGs2AD5LLnEsmSQ80wQ5ogcBBKhU86Y=
- github.com/Azure/azure-sdk-for-go/sdk/azcore v1.3.0 h1:VuHAcMq8pU1IWNT/m5yRaGqbK0BiQKHT8X4DTp9CHdI=
-@@ -70,8 +70,8 @@ github.com/golang/protobuf v1.4.0/go.mod h1:jodUvKwWbYaEsadDk5Fwe5c77LiNKVO9IDvq
- github.com/golang/protobuf v1.4.1/go.mod h1:U8fpvMrcmy5pZrNK1lt4xCsGvpyWQ/VVv6QDs8UjoX8=
- github.com/golang/protobuf v1.4.3/go.mod h1:oDoupMAO8OvCJWAcko0GGGIgR6R6ocIYbsSw735rRwI=
- github.com/golang/protobuf v1.5.0/go.mod h1:FsONVRAS9T7sI+LIUmWTfcYkHO4aIWwzhcaSAoJOfIk=
--github.com/golang/protobuf v1.5.2 h1:ROPKBNFfQgOUMifHyP+KYbvpjbdoFNs+aK7DXlji0Tw=
--github.com/golang/protobuf v1.5.2/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY=
-+github.com/golang/protobuf v1.5.3 h1:KhyjKVUg7Usr/dYsdSqoFveMYd5ko72D+zANwlG1mmg=
-+github.com/golang/protobuf v1.5.3/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY=
- github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5aqRK0M=
- github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
- github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
-@@ -82,17 +82,17 @@ github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/
- github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38=
- github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
- github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
--github.com/google/martian/v3 v3.2.1 h1:d8MncMlErDFTwQGBK1xhv026j9kqhvw1Qv9IbWT1VLQ=
-+github.com/google/martian/v3 v3.3.2 h1:IqNFLAmvJOgVlpdEBiQbDc2EwKW77amAycfTuWKdfvw=
- github.com/google/pprof v0.0.0-20211214055906-6f57359322fd/go.mod h1:KgnwoLYCZ8IQu3XUZ8Nc/bM9CCZFOyjUNOSygVozoDg=
- github.com/google/pprof v0.0.0-20230111200839-76d1ae5aea2b h1:8htHrh2bw9c7Idkb7YNac+ZpTqLMjRpI+FWu51ltaQc=
- github.com/google/pprof v0.0.0-20230111200839-76d1ae5aea2b/go.mod h1:dDKJzRmX4S37WGHujM7tX//fmj1uioxKzKxz3lo4HJo=
- github.com/google/uuid v1.1.2/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
- github.com/google/uuid v1.3.0 h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I=
- github.com/google/uuid v1.3.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
--github.com/googleapis/enterprise-certificate-proxy v0.2.1 h1:RY7tHKZcRlk788d5WSo/e83gOyyy742E8GSs771ySpg=
--github.com/googleapis/enterprise-certificate-proxy v0.2.1/go.mod h1:AwSRAtLfXpU5Nm3pW+v7rGDHp09LsPtGY9MduiEsR9k=
--github.com/googleapis/gax-go/v2 v2.7.0 h1:IcsPKeInNvYi7eqSaDjiZqDDKu5rsmunY0Y1YupQSSQ=
--github.com/googleapis/gax-go/v2 v2.7.0/go.mod h1:TEop28CZZQ2y+c0VxMUmu1lV+fQx57QpBWsYpwqHJx8=
-+github.com/googleapis/enterprise-certificate-proxy v0.2.3 h1:yk9/cqRKtT9wXZSsRH9aurXEpJX+U6FLtpYTdC3R06k=
-+github.com/googleapis/enterprise-certificate-proxy v0.2.3/go.mod h1:AwSRAtLfXpU5Nm3pW+v7rGDHp09LsPtGY9MduiEsR9k=
-+github.com/googleapis/gax-go/v2 v2.7.1 h1:gF4c0zjUP2H/s/hEGyLA3I0fA2ZWjzYiONAD6cvPr8A=
-+github.com/googleapis/gax-go/v2 v2.7.1/go.mod h1:4orTrqY6hXxxaUL4LHIPl6lGo8vAE38/qKbhSAKP6QI=
- github.com/hashicorp/golang-lru/v2 v2.0.1 h1:5pv5N1lT1fjLg2VQ5KWc7kmucp2x/kvFOnxuVTqZ6x4=
- github.com/hashicorp/golang-lru/v2 v2.0.1/go.mod h1:QeFd9opnmA6QUJc5vARoKUSoFhyfM2/ZepoAG6RGpeM=
- github.com/ianlancetaylor/demangle v0.0.0-20210905161508-09a460cdf81d/go.mod h1:aYm2/VgdVmcIU8iMfdMvDMsRAQjcfZSKFby6HOFvi/w=
-@@ -172,8 +172,8 @@ golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACk
- golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
- golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
- golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
--golang.org/x/crypto v0.5.0 h1:U/0M97KRkSFvyD/3FSmdP5W5swImpNgle/EHFhOsQPE=
--golang.org/x/crypto v0.5.0/go.mod h1:NK/OQwhpMQP3MwtdjgLlYHnH9ebylxKWv3e0fK+mkQU=
-+golang.org/x/crypto v0.17.0 h1:r8bRNjWL3GshPW3gkd+RpvzWrZAwPS49OmTGZ/uhM4k=
-+golang.org/x/crypto v0.17.0/go.mod h1:gCAAfMLgwOJRpTjQ2zCCt2OcSfYMTeZVSRtQlPC7Nq4=
- golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
- golang.org/x/lint v0.0.0-20181026193005-c67002cb31c3/go.mod h1:UVdnD1Gm6xHRNCYTkRU2/jEulfH38KcIWyp/GAMgvoE=
- golang.org/x/lint v0.0.0-20190227174305-5b3e6a55c961/go.mod h1:wehouNa3lNwaWXcvxsM5YxQ5yQlVC4a0KAMCusXpPoU=
-@@ -189,11 +189,11 @@ golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLL
+@@ -189,8 +189,8 @@ golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLL
  golang.org/x/net v0.0.0-20200226121028-0de0cce0169b/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
  golang.org/x/net v0.0.0-20201110031124-69a78807bb2b/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
  golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
 -golang.org/x/net v0.5.0 h1:GyT4nK/YDHSqa1c4753ouYCDajOYKTja9Xb/OHtgvSw=
 -golang.org/x/net v0.5.0/go.mod h1:DivGGAXEgPSlEBzxGzZI+ZLohi+xUj054jfeKui00ws=
-+golang.org/x/net v0.17.0 h1:pVaXccu2ozPjCXewfr1S7xza/zcXTity9cCdXQYSjIM=
-+golang.org/x/net v0.17.0/go.mod h1:NxSsAGuq816PNPmqtQdLE42eU2Fs7NoRIZrHJAlaCOE=
++golang.org/x/net v0.7.0 h1:rJrUqqhjsgNp7KqAIc25s9pZnjU7TUcSY7HcVZjdn1g=
++golang.org/x/net v0.7.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs=
  golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
--golang.org/x/oauth2 v0.4.0 h1:NF0gk8LVPg1Ml7SSbGyySuoxdsXitj7TvgvuRxIMc/M=
--golang.org/x/oauth2 v0.4.0/go.mod h1:RznEsdpjGAINPTOF0UH/t+xJ75L18YO3Ho6Pyn+uRec=
-+golang.org/x/oauth2 v0.7.0 h1:qe6s0zUXlPX80/dITx3440hWZ7GwMwgDDyrSGTPJG/g=
-+golang.org/x/oauth2 v0.7.0/go.mod h1:hPLQkd9LyjfXTiRohC/41GhcFqxisoUQ99sCUOHO9x4=
- golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
- golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
- golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
+ golang.org/x/oauth2 v0.4.0 h1:NF0gk8LVPg1Ml7SSbGyySuoxdsXitj7TvgvuRxIMc/M=
+ golang.org/x/oauth2 v0.4.0/go.mod h1:RznEsdpjGAINPTOF0UH/t+xJ75L18YO3Ho6Pyn+uRec=
 @@ -214,17 +214,17 @@ golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e/go.mod h1:oPkhp1MJrh7nUepCBc
  golang.org/x/sys v0.0.0-20220408201424-a24fb2fb8a0f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
  golang.org/x/sys v0.0.0-20220704084225-05e143d24a9e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
  golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 -golang.org/x/sys v0.4.0 h1:Zr2JFtRQNX3BCZ8YtxRE9hNJYC8J6I1MVbMg6owUp18=
 -golang.org/x/sys v0.4.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-+golang.org/x/sys v0.15.0 h1:h48lPFYpsTvQJZF4EKyI4aLHaev3CxivZmv7yZig9pc=
-+golang.org/x/sys v0.15.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
++golang.org/x/sys v0.5.0 h1:MUK/U/4lj1t1oPg0HfuXDN/Z1wv31ZJ/YcPiGccS4DU=
++golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
  golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
 -golang.org/x/term v0.4.0 h1:O7UWfv5+A2qiuulQk30kVinPoMtoIPeVaKLEgLpVkvg=
 -golang.org/x/term v0.4.0/go.mod h1:9P2UbLfCdcvo3p/nzKvsmas4TnlujnuoV9hGgYzW1lQ=
-+golang.org/x/term v0.15.0 h1:y/Oo/a/q3IXu26lQgl04j/gjuBDOBlx7X6Om1j2CPW4=
-+golang.org/x/term v0.15.0/go.mod h1:BDl952bC7+uMoWR75FIrCDx79TPU9oHkTZ9yRbYOrX0=
++golang.org/x/term v0.5.0 h1:n2a8QNdAb0sZNpU9R1ALUXBbY+w51fCQDN+7EdxNBsY=
++golang.org/x/term v0.5.0/go.mod h1:jMB1sMXY+tzblOD4FWmEbocvup2/aLOaQEp7JmGp78k=
  golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
  golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk=
  golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
  golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 -golang.org/x/text v0.6.0 h1:3XmdazWV+ubf7QgHSTWeykHOci5oeekaGJBLkrkaw4k=
 -golang.org/x/text v0.6.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
-+golang.org/x/text v0.14.0 h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ=
-+golang.org/x/text v0.14.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU=
++golang.org/x/text v0.7.0 h1:4BRB4x83lYWy72KwLD/qYDuTu7q9PjSagHvijDw7cLo=
++golang.org/x/text v0.7.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
  golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
  golang.org/x/tools v0.0.0-20190114222345-bf090417da8b/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
  golang.org/x/tools v0.0.0-20190226205152-f727befe758c/go.mod h1:9Yl7xja0Znq3iFh3HoIrodX9oNMXvdceNzlUR8zjMvY=
-@@ -237,8 +237,8 @@ golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8T
- golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
- golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 h1:H2TDz8ibqkAF6YGhCdN3jS9O0/s90v0rJh3X/OLHEUk=
- golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2/go.mod h1:K8+ghG5WaK9qNqU5K3HdILfMLy1f3aNYFI/wnl100a8=
--google.golang.org/api v0.106.0 h1:ffmW0faWCwKkpbbtvlY/K/8fUl+JKvNS5CVzRoyfCv8=
--google.golang.org/api v0.106.0/go.mod h1:2Ts0XTHNVWxypznxWOYUeI4g3WdP9Pk2Qk58+a/O9MY=
-+google.golang.org/api v0.114.0 h1:1xQPji6cO2E2vLiI+C/XiFAnsn1WV3mjaEwGLhi3grE=
-+google.golang.org/api v0.114.0/go.mod h1:ifYI2ZsFK6/uGddGfAD5BMxlnkBqCmqHSDUVi45N5Yg=
- google.golang.org/appengine v1.1.0/go.mod h1:EbEs0AVv82hx2wNQdGPgUI5lhzA/G0D9YwlJXL52JkM=
- google.golang.org/appengine v1.4.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=
- google.golang.org/appengine v1.6.7 h1:FZR1q0exgwxzPzp/aF+VccGrSfxfPpkBqjIIEq3ru6c=
-@@ -246,15 +246,15 @@ google.golang.org/appengine v1.6.7/go.mod h1:8WjMMxjGQR8xUklV/ARdw2HLXBOI7O7uCID
- google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8/go.mod h1:JiN7NxoALGmiZfu7CAH4rXhgtRTLTxftemlI0sWmxmc=
- google.golang.org/genproto v0.0.0-20190819201941-24fa4b261c55/go.mod h1:DMBHOl98Agz4BDEuKkezgsaosCRResVns1a3J2ZsMNc=
- google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013/go.mod h1:NbSheEEYHJ7i3ixzK3sjbqSGDJWnxyFXZblF3eUsNvo=
--google.golang.org/genproto v0.0.0-20230110181048-76db0878b65f h1:BWUVssLB0HVOSY78gIdvk1dTVYtT1y8SBWtPYuTJ/6w=
--google.golang.org/genproto v0.0.0-20230110181048-76db0878b65f/go.mod h1:RGgjbofJ8xD9Sq1VVhDM1Vok1vRONV+rg+CjzG4SZKM=
-+google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 h1:KpwkzHKEF7B9Zxg18WzOa7djJ+Ha5DzthMyZYQfEn2A=
-+google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1/go.mod h1:nKE/iIaLqn2bQwXBg8f1g2Ylh6r5MN5CmZvuzZCgsCU=
- google.golang.org/grpc v1.19.0/go.mod h1:mqu4LbDTu4XGKhr4mRzUsmM4RtVoemTSY81AxZiDr8c=
- google.golang.org/grpc v1.23.0/go.mod h1:Y5yQAOtifL1yxbo5wqy6BxZv8vAUGQwXBOALyacEbxg=
- google.golang.org/grpc v1.25.1/go.mod h1:c3i+UQWmh7LiEpx4sFZnkU36qjEYZ0imhYfXVyQciAY=
- google.golang.org/grpc v1.27.0/go.mod h1:qbnxyOmOxrQa7FizSgH+ReBfzJrCY1pSN7KXBS8abTk=
- google.golang.org/grpc v1.33.2/go.mod h1:JMHMWHQWaTccqQQlmk3MJZS+GWXOdAesneDmEnv2fbc=
--google.golang.org/grpc v1.52.0 h1:kd48UiU7EHsV4rnLyOJRuP/Il/UHE7gdDAQ+SZI7nZk=
--google.golang.org/grpc v1.52.0/go.mod h1:pu6fVzoFb+NBYNAvQL08ic+lvB2IojljRYuun5vorUY=
-+google.golang.org/grpc v1.56.3 h1:8I4C0Yq1EjstUzUJzpcRVbuYA2mODtEmpWiQoN/b2nc=
-+google.golang.org/grpc v1.56.3/go.mod h1:I9bI3vqKfayGqPUAwGdOSu7kt6oIJLixfffKrpXqQ9s=
- google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=
- google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0=
- google.golang.org/protobuf v0.0.0-20200228230310-ab0ca4ff8a60/go.mod h1:cfTl7dwQJ+fmap5saPgwCLgHXTUD7jkjRqWcaiX5VyM=
-@@ -266,8 +266,8 @@ google.golang.org/protobuf v1.23.1-0.20200526195155-81db48ad09cc/go.mod h1:EGpAD
- google.golang.org/protobuf v1.25.0/go.mod h1:9JNX74DMeImyA3h4bdi1ymwjUzf21/xIlbajtzgsN7c=
- google.golang.org/protobuf v1.26.0-rc.1/go.mod h1:jlhhOSvTdKEhbULTjvd4ARK9grFBp09yW+WbY/TyQbw=
- google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc=
--google.golang.org/protobuf v1.28.1 h1:d0NfwRgPtno5B1Wa6L2DAG+KivqkdutMf1UhdNx175w=
--google.golang.org/protobuf v1.28.1/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
-+google.golang.org/protobuf v1.30.0 h1:kPPoIgf3TsEvrm0PFe15JQ+570QVxYzEvvHqChK+cng=
-+google.golang.org/protobuf v1.30.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
- gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
- gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
- gopkg.in/ini.v1 v1.67.0 h1:Dgnx+6+nfE+IfzjUEISNeydPJh9AXNNsWbGP9KzCsOA=

hack/verify-generated-crd-code.sh

@@ -19,7 +19,7 @@ HACK_DIR=$(dirname "${BASH_SOURCE}")
 ${HACK_DIR}/update-3generated-crd-code.sh
 
 # ensure no changes to generated CRDs
-if ! git diff --exit-code config/crd/v1/crds/crds.go config/crd/v2alpha1/crds/crds.go &> /dev/null; then
+if [! git diff --exit-code config/crd/v1/crds/crds.go config/crd/v2alpha1/crds/crds.go >/dev/null]; then
   # revert changes to state before running CRD generation to stay consistent
   # with code-generator `--verify-only` option which discards generated changes
   git checkout config/crd

internal/credentials/file_store.go

@@ -71,7 +71,7 @@ func (n *namespacedFileStore) Path(selector *corev1api.SecretKeySelector) (strin
 
 	keyFilePath := filepath.Join(n.fsRoot, fmt.Sprintf("%s-%s", selector.Name, selector.Key))
 
-	file, err := n.fs.OpenFile(keyFilePath, os.O_RDWR|os.O_CREATE|os.O_TRUNC, 0644)
+	file, err := n.fs.OpenFile(keyFilePath, os.O_RDWR|os.O_CREATE, 0644)
 	if err != nil {
 		return "", errors.Wrap(err, "unable to open credentials file for writing")
 	}

internal/delete/delete_item_action_handler.go

@@ -119,7 +119,6 @@ func InvokeDeleteActions(ctx *Context) error {
 					if !action.Selector.Matches(labels.Set(obj.GetLabels())) {
 						continue
 					}
-
 					err = action.DeleteItemAction.Execute(&velero.DeleteItemActionExecuteInput{
 						Item:   obj,
 						Backup: ctx.Backup,

internal/hook/hook_tracker.go

@@ -1,148 +0,0 @@
-/*
-Copyright 2020 the Velero contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package hook
-
-import (
-	"fmt"
-	"sync"
-)
-
-const (
-	HookSourceAnnotation = "annotation"
-	HookSourceSpec       = "spec"
-)
-
-// hookTrackerKey identifies a backup/restore hook
-type hookTrackerKey struct {
-	// PodNamespace indicates the namespace of pod where hooks are executed.
-	// For hooks specified in the backup/restore spec, this field is the namespace of an applicable pod.
-	// For hooks specified in pod annotation, this field is the namespace of pod where hooks are annotated.
-	podNamespace string
-	// PodName indicates the pod where hooks are executed.
-	// For hooks specified in the backup/restore spec, this field is an applicable pod name.
-	// For hooks specified in pod annotation, this field is the pod where hooks are annotated.
-	podName string
-	// HookPhase is only for backup hooks, for restore hooks, this field is empty.
-	hookPhase hookPhase
-	// HookName is only for hooks specified in the backup/restore spec.
-	// For hooks specified in pod annotation, this field is empty or "<from-annotation>".
-	hookName string
-	// HookSource indicates where hooks come from.
-	hookSource string
-	// Container indicates the container hooks use.
-	// For hooks specified in the backup/restore spec, the container might be the same under different hookName.
-	container string
-}
-
-// hookTrackerVal records the execution status of a specific hook.
-// hookTrackerVal is extensible to accommodate additional fields as needs develop.
-type hookTrackerVal struct {
-	// HookFailed indicates if hook failed to execute.
-	hookFailed bool
-	// hookExecuted indicates if hook already execute.
-	hookExecuted bool
-}
-
-// HookTracker tracks all hooks' execution status
-type HookTracker struct {
-	lock    *sync.RWMutex
-	tracker map[hookTrackerKey]hookTrackerVal
-}
-
-// NewHookTracker creates a hookTracker.
-func NewHookTracker() *HookTracker {
-	return &HookTracker{
-		lock:    &sync.RWMutex{},
-		tracker: make(map[hookTrackerKey]hookTrackerVal),
-	}
-}
-
-// Add adds a hook to the tracker
-// Add must precede the Record for each individual hook.
-// In other words, a hook must be added to the tracker before its execution result is recorded.
-func (ht *HookTracker) Add(podNamespace, podName, container, source, hookName string, hookPhase hookPhase) {
-	ht.lock.Lock()
-	defer ht.lock.Unlock()
-
-	key := hookTrackerKey{
-		podNamespace: podNamespace,
-		podName:      podName,
-		hookSource:   source,
-		container:    container,
-		hookPhase:    hookPhase,
-		hookName:     hookName,
-	}
-
-	if _, ok := ht.tracker[key]; !ok {
-		ht.tracker[key] = hookTrackerVal{
-			hookFailed:   false,
-			hookExecuted: false,
-		}
-	}
-}
-
-// Record records the hook's execution status
-// Add must precede the Record for each individual hook.
-// In other words, a hook must be added to the tracker before its execution result is recorded.
-func (ht *HookTracker) Record(podNamespace, podName, container, source, hookName string, hookPhase hookPhase, hookFailed bool) error {
-	ht.lock.Lock()
-	defer ht.lock.Unlock()
-
-	key := hookTrackerKey{
-		podNamespace: podNamespace,
-		podName:      podName,
-		hookSource:   source,
-		container:    container,
-		hookPhase:    hookPhase,
-		hookName:     hookName,
-	}
-
-	var err error
-	if _, ok := ht.tracker[key]; ok {
-		ht.tracker[key] = hookTrackerVal{
-			hookFailed:   hookFailed,
-			hookExecuted: true,
-		}
-	} else {
-		err = fmt.Errorf("hook not exist in hooks tracker, hook key: %v", key)
-	}
-	return err
-}
-
-// Stat calculates the number of attempted hooks and failed hooks
-func (ht *HookTracker) Stat() (hookAttemptedCnt int, hookFailed int) {
-	ht.lock.RLock()
-	defer ht.lock.RUnlock()
-
-	for _, hookInfo := range ht.tracker {
-		if hookInfo.hookExecuted {
-			hookAttemptedCnt++
-			if hookInfo.hookFailed {
-				hookFailed++
-			}
-		}
-	}
-	return
-}
-
-// GetTracker gets the tracker inside HookTracker
-func (ht *HookTracker) GetTracker() map[hookTrackerKey]hookTrackerVal {
-	ht.lock.RLock()
-	defer ht.lock.RUnlock()
-
-	return ht.tracker
-}

internal/hook/hook_tracker_test.go

@@ -1,93 +0,0 @@
-/*
-Copyright 2020 the Velero contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package hook
-
-import (
-	"testing"
-
-	"github.com/stretchr/testify/assert"
-)
-
-func TestNewHookTracker(t *testing.T) {
-	tracker := NewHookTracker()
-
-	assert.NotNil(t, tracker)
-	assert.Empty(t, tracker.tracker)
-}
-
-func TestHookTracker_Add(t *testing.T) {
-	tracker := NewHookTracker()
-
-	tracker.Add("ns1", "pod1", "container1", HookSourceAnnotation, "h1", PhasePre)
-
-	key := hookTrackerKey{
-		podNamespace: "ns1",
-		podName:      "pod1",
-		container:    "container1",
-		hookPhase:    PhasePre,
-		hookSource:   HookSourceAnnotation,
-		hookName:     "h1",
-	}
-
-	_, ok := tracker.tracker[key]
-	assert.True(t, ok)
-}
-
-func TestHookTracker_Record(t *testing.T) {
-	tracker := NewHookTracker()
-	tracker.Add("ns1", "pod1", "container1", HookSourceAnnotation, "h1", PhasePre)
-	err := tracker.Record("ns1", "pod1", "container1", HookSourceAnnotation, "h1", PhasePre, true)
-
-	key := hookTrackerKey{
-		podNamespace: "ns1",
-		podName:      "pod1",
-		container:    "container1",
-		hookPhase:    PhasePre,
-		hookSource:   HookSourceAnnotation,
-		hookName:     "h1",
-	}
-
-	info := tracker.tracker[key]
-	assert.True(t, info.hookFailed)
-	assert.Nil(t, err)
-
-	err = tracker.Record("ns2", "pod2", "container1", HookSourceAnnotation, "h1", PhasePre, true)
-	assert.NotNil(t, err)
-
-}
-
-func TestHookTracker_Stat(t *testing.T) {
-	tracker := NewHookTracker()
-
-	tracker.Add("ns1", "pod1", "container1", HookSourceAnnotation, "h1", PhasePre)
-	tracker.Add("ns2", "pod2", "container1", HookSourceAnnotation, "h2", PhasePre)
-	tracker.Record("ns1", "pod1", "container1", HookSourceAnnotation, "h1", PhasePre, true)
-
-	attempted, failed := tracker.Stat()
-	assert.Equal(t, 1, attempted)
-	assert.Equal(t, 1, failed)
-}
-
-func TestHookTracker_Get(t *testing.T) {
-	tracker := NewHookTracker()
-	tracker.Add("ns1", "pod1", "container1", HookSourceAnnotation, "h1", PhasePre)
-
-	tr := tracker.GetTracker()
-	assert.NotNil(t, tr)
-
-	t.Logf("tracker :%+v", tr)
-}

internal/hook/item_hook_handler.go

@@ -19,7 +19,6 @@ package hook
 import (
 	"encoding/json"
 	"fmt"
-	"strconv"
 	"strings"
 	"time"
 
@@ -38,7 +37,6 @@ import (
 	"github.com/vmware-tanzu/velero/pkg/kuberesource"
 	"github.com/vmware-tanzu/velero/pkg/podexec"
 	"github.com/vmware-tanzu/velero/pkg/restorehelper"
-	"github.com/vmware-tanzu/velero/pkg/util/boolptr"
 	"github.com/vmware-tanzu/velero/pkg/util/collections"
 	"github.com/vmware-tanzu/velero/pkg/util/kube"
 )
@@ -63,7 +61,6 @@ const (
 	podRestoreHookOnErrorAnnotationKey              = "post.hook.restore.velero.io/on-error"
 	podRestoreHookTimeoutAnnotationKey              = "post.hook.restore.velero.io/exec-timeout"
 	podRestoreHookWaitTimeoutAnnotationKey          = "post.hook.restore.velero.io/wait-timeout"
-	podRestoreHookWaitForReadyAnnotationKey         = "post.hook.restore.velero.io/wait-for-ready"
 	podRestoreHookInitContainerImageAnnotationKey   = "init.hook.restore.velero.io/container-image"
 	podRestoreHookInitContainerNameAnnotationKey    = "init.hook.restore.velero.io/container-name"
 	podRestoreHookInitContainerCommandAnnotationKey = "init.hook.restore.velero.io/command"
@@ -82,7 +79,6 @@ type ItemHookHandler interface {
 		obj runtime.Unstructured,
 		resourceHooks []ResourceHook,
 		phase hookPhase,
-		hookTracker *HookTracker,
 	) error
 }
 
@@ -201,7 +197,6 @@ func (h *DefaultItemHookHandler) HandleHooks(
 	obj runtime.Unstructured,
 	resourceHooks []ResourceHook,
 	phase hookPhase,
-	hookTracker *HookTracker,
 ) error {
 	// We only support hooks on pods right now
 	if groupResource != kuberesource.Pods {
@@ -223,29 +218,18 @@ func (h *DefaultItemHookHandler) HandleHooks(
 		hookFromAnnotations = getPodExecHookFromAnnotations(metadata.GetAnnotations(), "", log)
 	}
 	if hookFromAnnotations != nil {
-		hookTracker.Add(namespace, name, hookFromAnnotations.Container, HookSourceAnnotation, "", phase)
-
 		hookLog := log.WithFields(
 			logrus.Fields{
-				"hookSource": HookSourceAnnotation,
+				"hookSource": "annotation",
 				"hookType":   "exec",
 				"hookPhase":  phase,
 			},
 		)
-
-		hookFailed := false
-		var errExec error
-		if errExec = h.PodCommandExecutor.ExecutePodCommand(hookLog, obj.UnstructuredContent(), namespace, name, "<from-annotation>", hookFromAnnotations); errExec != nil {
-			hookLog.WithError(errExec).Error("Error executing hook")
-			hookFailed = true
-		}
-		errTracker := hookTracker.Record(namespace, name, hookFromAnnotations.Container, HookSourceAnnotation, "", phase, hookFailed)
-		if errTracker != nil {
-			hookLog.WithError(errTracker).Warn("Error recording the hook in hook tracker")
-		}
-
-		if errExec != nil && hookFromAnnotations.OnError == velerov1api.HookErrorModeFail {
-			return errExec
+		if err := h.PodCommandExecutor.ExecutePodCommand(hookLog, obj.UnstructuredContent(), namespace, name, "<from-annotation>", hookFromAnnotations); err != nil {
+			hookLog.WithError(err).Error("Error executing hook")
+			if hookFromAnnotations.OnError == velerov1api.HookErrorModeFail {
+				return err
+			}
 		}
 
 		return nil
@@ -253,8 +237,6 @@ func (h *DefaultItemHookHandler) HandleHooks(
 
 	labels := labels.Set(metadata.GetLabels())
 	// Otherwise, check for hooks defined in the backup spec.
-	// modeFailError records the error from the hook with "Fail" error mode
-	var modeFailError error
 	for _, resourceHook := range resourceHooks {
 		if !resourceHook.Selector.applicableTo(groupResource, namespace, labels) {
 			continue
@@ -266,34 +248,21 @@ func (h *DefaultItemHookHandler) HandleHooks(
 		} else {
 			hooks = resourceHook.Post
 		}
-
 		for _, hook := range hooks {
 			if groupResource == kuberesource.Pods {
 				if hook.Exec != nil {
-					hookTracker.Add(namespace, name, hook.Exec.Container, HookSourceSpec, resourceHook.Name, phase)
-					// The remaining hooks will only be executed if modeFailError is nil.
-					// Otherwise, execution will stop and only hook collection will occur.
-					if modeFailError == nil {
-						hookLog := log.WithFields(
-							logrus.Fields{
-								"hookSource": HookSourceSpec,
-								"hookType":   "exec",
-								"hookPhase":  phase,
-							},
-						)
-
-						hookFailed := false
-						err := h.PodCommandExecutor.ExecutePodCommand(hookLog, obj.UnstructuredContent(), namespace, name, resourceHook.Name, hook.Exec)
-						if err != nil {
-							hookLog.WithError(err).Error("Error executing hook")
-							hookFailed = true
-							if hook.Exec.OnError == velerov1api.HookErrorModeFail {
-								modeFailError = err
-							}
-						}
-						errTracker := hookTracker.Record(namespace, name, hook.Exec.Container, HookSourceSpec, resourceHook.Name, phase, hookFailed)
-						if errTracker != nil {
-							hookLog.WithError(errTracker).Warn("Error recording the hook in hook tracker")
+					hookLog := log.WithFields(
+						logrus.Fields{
+							"hookSource": "backupSpec",
+							"hookType":   "exec",
+							"hookPhase":  phase,
+						},
+					)
+					err := h.PodCommandExecutor.ExecutePodCommand(hookLog, obj.UnstructuredContent(), namespace, name, resourceHook.Name, hook.Exec)
+					if err != nil {
+						hookLog.WithError(err).Error("Error executing hook")
+						if hook.Exec.OnError == velerov1api.HookErrorModeFail {
+							return err
 						}
 					}
 				}
@@ -301,7 +270,7 @@ func (h *DefaultItemHookHandler) HandleHooks(
 		}
 	}
 
-	return modeFailError
+	return nil
 }
 
 // NoOpItemHookHandler is the an itemHookHandler for the Finalize controller where hooks don't run
@@ -313,7 +282,6 @@ func (h *NoOpItemHookHandler) HandleHooks(
 	obj runtime.Unstructured,
 	resourceHooks []ResourceHook,
 	phase hookPhase,
-	hookTracker *HookTracker,
 ) error {
 	return nil
 }
@@ -509,23 +477,12 @@ func getPodExecRestoreHookFromAnnotations(annotations map[string]string, log log
 		}
 	}
 
-	waitForReadyString := annotations[podRestoreHookWaitForReadyAnnotationKey]
-	waitForReady := boolptr.False()
-	if waitForReadyString != "" {
-		var err error
-		*waitForReady, err = strconv.ParseBool(waitForReadyString)
-		if err != nil {
-			log.Warn(errors.Wrapf(err, "Unable to parse wait for ready %s, ignoring", waitForReadyString))
-		}
-	}
-
 	return &velerov1api.ExecRestoreHook{
-		Container:    container,
-		Command:      parseStringToCommand(commandValue),
-		OnError:      onError,
-		ExecTimeout:  metav1.Duration{Duration: execTimeout},
-		WaitTimeout:  metav1.Duration{Duration: waitTimeout},
-		WaitForReady: waitForReady,
+		Container:   container,
+		Command:     parseStringToCommand(commandValue),
+		OnError:     onError,
+		ExecTimeout: metav1.Duration{Duration: execTimeout},
+		WaitTimeout: metav1.Duration{Duration: waitTimeout},
 	}
 }
 
@@ -543,7 +500,6 @@ func GroupRestoreExecHooks(
 	resourceRestoreHooks []ResourceRestoreHook,
 	pod *corev1api.Pod,
 	log logrus.FieldLogger,
-	hookTrack *HookTracker,
 ) (map[string][]PodExecRestoreHook, error) {
 	byContainer := map[string][]PodExecRestoreHook{}
 
@@ -560,11 +516,10 @@ func GroupRestoreExecHooks(
 		if hookFromAnnotation.Container == "" {
 			hookFromAnnotation.Container = pod.Spec.Containers[0].Name
 		}
-		hookTrack.Add(metadata.GetNamespace(), metadata.GetName(), hookFromAnnotation.Container, HookSourceAnnotation, "<from-annotation>", hookPhase(""))
 		byContainer[hookFromAnnotation.Container] = []PodExecRestoreHook{
 			{
 				HookName:   "<from-annotation>",
-				HookSource: HookSourceAnnotation,
+				HookSource: "annotation",
 				Hook:       *hookFromAnnotation,
 			},
 		}
@@ -585,17 +540,12 @@ func GroupRestoreExecHooks(
 			named := PodExecRestoreHook{
 				HookName:   rrh.Name,
 				Hook:       *rh.Exec,
-				HookSource: HookSourceSpec,
-			}
-			// default to false if attr WaitForReady not set
-			if named.Hook.WaitForReady == nil {
-				named.Hook.WaitForReady = boolptr.False()
+				HookSource: "backupSpec",
 			}
 			// default to first container in pod if unset, without mutating resource restore hook
 			if named.Hook.Container == "" {
 				named.Hook.Container = pod.Spec.Containers[0].Name
 			}
-			hookTrack.Add(metadata.GetNamespace(), metadata.GetName(), named.Hook.Container, HookSourceSpec, rrh.Name, hookPhase(""))
 			byContainer[named.Hook.Container] = append(byContainer[named.Hook.Container], named)
 		}
 	}

internal/hook/item_hook_handler_test.go

@@ -36,7 +36,6 @@ import (
 	"github.com/vmware-tanzu/velero/pkg/builder"
 	"github.com/vmware-tanzu/velero/pkg/kuberesource"
 	velerotest "github.com/vmware-tanzu/velero/pkg/test"
-	"github.com/vmware-tanzu/velero/pkg/util/boolptr"
 	"github.com/vmware-tanzu/velero/pkg/util/collections"
 )
 
@@ -108,7 +107,6 @@ func TestHandleHooksSkips(t *testing.T) {
 		},
 	}
 
-	hookTracker := NewHookTracker()
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			podCommandExecutor := &velerotest.MockPodCommandExecutor{}
@@ -119,7 +117,7 @@ func TestHandleHooksSkips(t *testing.T) {
 			}
 
 			groupResource := schema.ParseGroupResource(test.groupResource)
-			err := h.HandleHooks(velerotest.NewLogger(), groupResource, test.item, test.hooks, PhasePre, hookTracker)
+			err := h.HandleHooks(velerotest.NewLogger(), groupResource, test.item, test.hooks, PhasePre)
 			assert.NoError(t, err)
 		})
 	}
@@ -486,8 +484,7 @@ func TestHandleHooks(t *testing.T) {
 			}
 
 			groupResource := schema.ParseGroupResource(test.groupResource)
-			hookTracker := NewHookTracker()
-			err := h.HandleHooks(velerotest.NewLogger(), groupResource, test.item, test.hooks, test.phase, hookTracker)
+			err := h.HandleHooks(velerotest.NewLogger(), groupResource, test.item, test.hooks, test.phase)
 
 			if test.expectedError != nil {
 				assert.EqualError(t, err, test.expectedError.Error())
@@ -727,8 +724,7 @@ func TestGetPodExecRestoreHookFromAnnotations(t *testing.T) {
 				podRestoreHookCommandAnnotationKey: "/usr/bin/foo",
 			},
 			expected: &velerov1api.ExecRestoreHook{
-				Command:      []string{"/usr/bin/foo"},
-				WaitForReady: boolptr.False(),
+				Command: []string{"/usr/bin/foo"},
 			},
 		},
 		{
@@ -737,8 +733,7 @@ func TestGetPodExecRestoreHookFromAnnotations(t *testing.T) {
 				podRestoreHookCommandAnnotationKey: `["a","b","c"]`,
 			},
 			expected: &velerov1api.ExecRestoreHook{
-				Command:      []string{"a", "b", "c"},
-				WaitForReady: boolptr.False(),
+				Command: []string{"a", "b", "c"},
 			},
 		},
 		{
@@ -748,9 +743,8 @@ func TestGetPodExecRestoreHookFromAnnotations(t *testing.T) {
 				podRestoreHookOnErrorAnnotationKey: string(velerov1api.HookErrorModeContinue),
 			},
 			expected: &velerov1api.ExecRestoreHook{
-				Command:      []string{"/usr/bin/foo"},
-				OnError:      velerov1api.HookErrorModeContinue,
-				WaitForReady: boolptr.False(),
+				Command: []string{"/usr/bin/foo"},
+				OnError: velerov1api.HookErrorModeContinue,
 			},
 		},
 		{
@@ -760,9 +754,8 @@ func TestGetPodExecRestoreHookFromAnnotations(t *testing.T) {
 				podRestoreHookOnErrorAnnotationKey: string(velerov1api.HookErrorModeFail),
 			},
 			expected: &velerov1api.ExecRestoreHook{
-				Command:      []string{"/usr/bin/foo"},
-				OnError:      velerov1api.HookErrorModeFail,
-				WaitForReady: boolptr.False(),
+				Command: []string{"/usr/bin/foo"},
+				OnError: velerov1api.HookErrorModeFail,
 			},
 		},
 		{
@@ -773,10 +766,9 @@ func TestGetPodExecRestoreHookFromAnnotations(t *testing.T) {
 				podRestoreHookWaitTimeoutAnnotationKey: "1h",
 			},
 			expected: &velerov1api.ExecRestoreHook{
-				Command:      []string{"/usr/bin/foo"},
-				ExecTimeout:  metav1.Duration{Duration: 45 * time.Second},
-				WaitTimeout:  metav1.Duration{Duration: time.Hour},
-				WaitForReady: boolptr.False(),
+				Command:     []string{"/usr/bin/foo"},
+				ExecTimeout: metav1.Duration{Duration: 45 * time.Second},
+				WaitTimeout: metav1.Duration{Duration: time.Hour},
 			},
 		},
 		{
@@ -786,9 +778,8 @@ func TestGetPodExecRestoreHookFromAnnotations(t *testing.T) {
 				podRestoreHookContainerAnnotationKey: "my-app",
 			},
 			expected: &velerov1api.ExecRestoreHook{
-				Command:      []string{"/usr/bin/foo"},
-				Container:    "my-app",
-				WaitForReady: boolptr.False(),
+				Command:   []string{"/usr/bin/foo"},
+				Container: "my-app",
 			},
 		},
 		{
@@ -799,10 +790,9 @@ func TestGetPodExecRestoreHookFromAnnotations(t *testing.T) {
 				podRestoreHookTimeoutAnnotationKey:   "none",
 			},
 			expected: &velerov1api.ExecRestoreHook{
-				Command:      []string{"/usr/bin/foo"},
-				Container:    "my-app",
-				ExecTimeout:  metav1.Duration{Duration: 0},
-				WaitForReady: boolptr.False(),
+				Command:     []string{"/usr/bin/foo"},
+				Container:   "my-app",
+				ExecTimeout: metav1.Duration{Duration: 0},
 			},
 		},
 		{
@@ -813,10 +803,9 @@ func TestGetPodExecRestoreHookFromAnnotations(t *testing.T) {
 				podRestoreHookWaitTimeoutAnnotationKey: "none",
 			},
 			expected: &velerov1api.ExecRestoreHook{
-				Command:      []string{"/usr/bin/foo"},
-				Container:    "my-app",
-				ExecTimeout:  metav1.Duration{Duration: 0},
-				WaitForReady: boolptr.False(),
+				Command:     []string{"/usr/bin/foo"},
+				Container:   "my-app",
+				ExecTimeout: metav1.Duration{Duration: 0},
 			},
 		},
 	}
@@ -853,7 +842,6 @@ func TestGroupRestoreExecHooks(t *testing.T) {
 					podRestoreHookOnErrorAnnotationKey, string(velerov1api.HookErrorModeContinue),
 					podRestoreHookTimeoutAnnotationKey, "1s",
 					podRestoreHookWaitTimeoutAnnotationKey, "1m",
-					podRestoreHookWaitForReadyAnnotationKey, "true",
 				)).
 				Containers(&corev1api.Container{
 					Name: "container1",
@@ -863,14 +851,13 @@ func TestGroupRestoreExecHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "<from-annotation>",
-						HookSource: HookSourceAnnotation,
+						HookSource: "annotation",
 						Hook: velerov1api.ExecRestoreHook{
-							Container:    "container1",
-							Command:      []string{"/usr/bin/foo"},
-							OnError:      velerov1api.HookErrorModeContinue,
-							ExecTimeout:  metav1.Duration{Duration: time.Second},
-							WaitTimeout:  metav1.Duration{Duration: time.Minute},
-							WaitForReady: boolptr.True(),
+							Container:   "container1",
+							Command:     []string{"/usr/bin/foo"},
+							OnError:     velerov1api.HookErrorModeContinue,
+							ExecTimeout: metav1.Duration{Duration: time.Second},
+							WaitTimeout: metav1.Duration{Duration: time.Minute},
 						},
 					},
 				},
@@ -894,14 +881,13 @@ func TestGroupRestoreExecHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "<from-annotation>",
-						HookSource: HookSourceAnnotation,
+						HookSource: "annotation",
 						Hook: velerov1api.ExecRestoreHook{
-							Container:    "container1",
-							Command:      []string{"/usr/bin/foo"},
-							OnError:      velerov1api.HookErrorModeContinue,
-							ExecTimeout:  metav1.Duration{Duration: time.Second},
-							WaitTimeout:  metav1.Duration{Duration: time.Minute},
-							WaitForReady: boolptr.False(),
+							Container:   "container1",
+							Command:     []string{"/usr/bin/foo"},
+							OnError:     velerov1api.HookErrorModeContinue,
+							ExecTimeout: metav1.Duration{Duration: time.Second},
+							WaitTimeout: metav1.Duration{Duration: time.Minute},
 						},
 					},
 				},
@@ -935,14 +921,13 @@ func TestGroupRestoreExecHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "hook1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
-							Container:    "container1",
-							Command:      []string{"/usr/bin/foo"},
-							OnError:      velerov1api.HookErrorModeContinue,
-							ExecTimeout:  metav1.Duration{Duration: time.Second},
-							WaitTimeout:  metav1.Duration{Duration: time.Minute},
-							WaitForReady: boolptr.False(),
+							Container:   "container1",
+							Command:     []string{"/usr/bin/foo"},
+							OnError:     velerov1api.HookErrorModeContinue,
+							ExecTimeout: metav1.Duration{Duration: time.Second},
+							WaitTimeout: metav1.Duration{Duration: time.Minute},
 						},
 					},
 				},
@@ -975,14 +960,13 @@ func TestGroupRestoreExecHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "hook1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
-							Container:    "container1",
-							Command:      []string{"/usr/bin/foo"},
-							OnError:      velerov1api.HookErrorModeContinue,
-							ExecTimeout:  metav1.Duration{Duration: time.Second},
-							WaitTimeout:  metav1.Duration{Duration: time.Minute},
-							WaitForReady: boolptr.False(),
+							Container:   "container1",
+							Command:     []string{"/usr/bin/foo"},
+							OnError:     velerov1api.HookErrorModeContinue,
+							ExecTimeout: metav1.Duration{Duration: time.Second},
+							WaitTimeout: metav1.Duration{Duration: time.Minute},
 						},
 					},
 				},
@@ -1023,14 +1007,13 @@ func TestGroupRestoreExecHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "<from-annotation>",
-						HookSource: HookSourceAnnotation,
+						HookSource: "annotation",
 						Hook: velerov1api.ExecRestoreHook{
-							Container:    "container1",
-							Command:      []string{"/usr/bin/foo"},
-							OnError:      velerov1api.HookErrorModeContinue,
-							ExecTimeout:  metav1.Duration{Duration: time.Second},
-							WaitTimeout:  metav1.Duration{Duration: time.Minute},
-							WaitForReady: boolptr.False(),
+							Container:   "container1",
+							Command:     []string{"/usr/bin/foo"},
+							OnError:     velerov1api.HookErrorModeContinue,
+							ExecTimeout: metav1.Duration{Duration: time.Second},
+							WaitTimeout: metav1.Duration{Duration: time.Minute},
 						},
 					},
 				},
@@ -1122,12 +1105,11 @@ func TestGroupRestoreExecHooks(t *testing.T) {
 					RestoreHooks: []velerov1api.RestoreResourceHook{
 						{
 							Exec: &velerov1api.ExecRestoreHook{
-								Container:    "container1",
-								Command:      []string{"/usr/bin/aaa"},
-								OnError:      velerov1api.HookErrorModeContinue,
-								ExecTimeout:  metav1.Duration{Duration: time.Second * 4},
-								WaitTimeout:  metav1.Duration{Duration: time.Minute * 4},
-								WaitForReady: boolptr.True(),
+								Container:   "container1",
+								Command:     []string{"/usr/bin/aaa"},
+								OnError:     velerov1api.HookErrorModeContinue,
+								ExecTimeout: metav1.Duration{Duration: time.Second * 4},
+								WaitTimeout: metav1.Duration{Duration: time.Minute * 4},
 							},
 						},
 					},
@@ -1142,63 +1124,57 @@ func TestGroupRestoreExecHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "hook1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
-							Container:    "container1",
-							Command:      []string{"/usr/bin/foo"},
-							OnError:      velerov1api.HookErrorModeFail,
-							ExecTimeout:  metav1.Duration{Duration: time.Second},
-							WaitTimeout:  metav1.Duration{Duration: time.Minute},
-							WaitForReady: boolptr.False(),
+							Container:   "container1",
+							Command:     []string{"/usr/bin/foo"},
+							OnError:     velerov1api.HookErrorModeFail,
+							ExecTimeout: metav1.Duration{Duration: time.Second},
+							WaitTimeout: metav1.Duration{Duration: time.Minute},
 						},
 					},
 					{
 						HookName:   "hook1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
-							Container:    "container1",
-							Command:      []string{"/usr/bin/bar"},
-							OnError:      velerov1api.HookErrorModeContinue,
-							ExecTimeout:  metav1.Duration{Duration: time.Second * 2},
-							WaitTimeout:  metav1.Duration{Duration: time.Minute * 2},
-							WaitForReady: boolptr.False(),
+							Container:   "container1",
+							Command:     []string{"/usr/bin/bar"},
+							OnError:     velerov1api.HookErrorModeContinue,
+							ExecTimeout: metav1.Duration{Duration: time.Second * 2},
+							WaitTimeout: metav1.Duration{Duration: time.Minute * 2},
 						},
 					},
 					{
 						HookName:   "hook2",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
-							Container:    "container1",
-							Command:      []string{"/usr/bin/aaa"},
-							OnError:      velerov1api.HookErrorModeContinue,
-							ExecTimeout:  metav1.Duration{Duration: time.Second * 4},
-							WaitTimeout:  metav1.Duration{Duration: time.Minute * 4},
-							WaitForReady: boolptr.True(),
+							Container:   "container1",
+							Command:     []string{"/usr/bin/aaa"},
+							OnError:     velerov1api.HookErrorModeContinue,
+							ExecTimeout: metav1.Duration{Duration: time.Second * 4},
+							WaitTimeout: metav1.Duration{Duration: time.Minute * 4},
 						},
 					},
 				},
 				"container2": {
 					{
 						HookName:   "hook1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
-							Container:    "container2",
-							Command:      []string{"/usr/bin/baz"},
-							OnError:      velerov1api.HookErrorModeContinue,
-							ExecTimeout:  metav1.Duration{Duration: time.Second * 3},
-							WaitTimeout:  metav1.Duration{Duration: time.Second * 3},
-							WaitForReady: boolptr.False(),
+							Container:   "container2",
+							Command:     []string{"/usr/bin/baz"},
+							OnError:     velerov1api.HookErrorModeContinue,
+							ExecTimeout: metav1.Duration{Duration: time.Second * 3},
+							WaitTimeout: metav1.Duration{Duration: time.Second * 3},
 						},
 					},
 				},
 			},
 		},
 	}
-
-	hookTracker := NewHookTracker()
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			actual, err := GroupRestoreExecHooks(tc.resourceRestoreHooks, tc.pod, velerotest.NewLogger(), hookTracker)
+			actual, err := GroupRestoreExecHooks(tc.resourceRestoreHooks, tc.pod, velerotest.NewLogger())
 			assert.Nil(t, err)
 			assert.Equal(t, tc.expected, actual)
 		})
@@ -1987,494 +1963,3 @@ func TestValidateContainer(t *testing.T) {
 	// noCommand string should return expected error as result.
 	assert.Equal(t, expectedError, ValidateContainer([]byte(noCommand)))
 }
-
-func TestBackupHookTracker(t *testing.T) {
-	type podWithHook struct {
-		item                  runtime.Unstructured
-		hooks                 []ResourceHook
-		hookErrorsByContainer map[string]error
-		expectedPodHook       *velerov1api.ExecHook
-		expectedPodHookError  error
-		expectedError         error
-	}
-	test1 := []struct {
-		name                  string
-		phase                 hookPhase
-		groupResource         string
-		pods                  []podWithHook
-		hookTracker           *HookTracker
-		expectedHookAttempted int
-		expectedHookFailed    int
-	}{
-		{
-			name:                  "a pod with spec hooks, no error",
-			phase:                 PhasePre,
-			groupResource:         "pods",
-			hookTracker:           NewHookTracker(),
-			expectedHookAttempted: 2,
-			expectedHookFailed:    0,
-			pods: []podWithHook{
-				{
-					item: velerotest.UnstructuredOrDie(`
-					{
-						"apiVersion": "v1",
-						"kind": "Pod",
-						"metadata": {
-							"namespace": "ns",
-							"name": "name"
-						}
-					}`),
-					hooks: []ResourceHook{
-						{
-							Name: "hook1",
-							Pre: []velerov1api.BackupResourceHook{
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1a",
-										Command:   []string{"pre-1a"},
-									},
-								},
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1b",
-										Command:   []string{"pre-1b"},
-									},
-								},
-							},
-						},
-					},
-				},
-			},
-		},
-		{
-			name:                  "a pod with spec hooks and same container under different hook name, no error",
-			phase:                 PhasePre,
-			groupResource:         "pods",
-			hookTracker:           NewHookTracker(),
-			expectedHookAttempted: 4,
-			expectedHookFailed:    0,
-			pods: []podWithHook{
-				{
-					item: velerotest.UnstructuredOrDie(`
-					{
-						"apiVersion": "v1",
-						"kind": "Pod",
-						"metadata": {
-							"namespace": "ns",
-							"name": "name"
-						}
-					}`),
-					hooks: []ResourceHook{
-						{
-							Name: "hook1",
-							Pre: []velerov1api.BackupResourceHook{
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1a",
-										Command:   []string{"pre-1a"},
-									},
-								},
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1b",
-										Command:   []string{"pre-1b"},
-									},
-								},
-							},
-						},
-						{
-							Name: "hook2",
-							Pre: []velerov1api.BackupResourceHook{
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1a",
-										Command:   []string{"2a"},
-									},
-								},
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "2b",
-										Command:   []string{"2b"},
-									},
-								},
-							},
-						},
-					},
-				},
-			},
-		},
-		{
-			name:                  "a pod with spec hooks, on error=fail",
-			phase:                 PhasePre,
-			groupResource:         "pods",
-			hookTracker:           NewHookTracker(),
-			expectedHookAttempted: 3,
-			expectedHookFailed:    2,
-			pods: []podWithHook{
-				{
-					item: velerotest.UnstructuredOrDie(`
-					{
-						"apiVersion": "v1",
-						"kind": "Pod",
-						"metadata": {
-							"namespace": "ns",
-							"name": "name"
-						}
-					}`),
-					hooks: []ResourceHook{
-						{
-							Name: "hook1",
-							Pre: []velerov1api.BackupResourceHook{
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1a",
-										Command:   []string{"1a"},
-										OnError:   velerov1api.HookErrorModeContinue,
-									},
-								},
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1b",
-										Command:   []string{"1b"},
-									},
-								},
-							},
-						},
-						{
-							Name: "hook2",
-							Pre: []velerov1api.BackupResourceHook{
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "2",
-										Command:   []string{"2"},
-										OnError:   velerov1api.HookErrorModeFail,
-									},
-								},
-							},
-						},
-						{
-							Name: "hook3",
-							Pre: []velerov1api.BackupResourceHook{
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "3",
-										Command:   []string{"3"},
-									},
-								},
-							},
-						},
-					},
-					hookErrorsByContainer: map[string]error{
-						"1a": errors.New("1a error, but continue"),
-						"2":  errors.New("2 error, fail"),
-					},
-				},
-			},
-		},
-		{
-			name:                  "a pod with annotation and spec hooks",
-			phase:                 PhasePre,
-			groupResource:         "pods",
-			hookTracker:           NewHookTracker(),
-			expectedHookAttempted: 1,
-			expectedHookFailed:    0,
-			pods: []podWithHook{
-				{
-					item: velerotest.UnstructuredOrDie(`
-					{
-						"apiVersion": "v1",
-						"kind": "Pod",
-						"metadata": {
-							"namespace": "ns",
-							"name": "name",
-							"annotations": {
-								"hook.backup.velero.io/container": "c",
-								"hook.backup.velero.io/command": "/bin/ls"
-							}
-						}
-					}`),
-					expectedPodHook: &velerov1api.ExecHook{
-						Container: "c",
-						Command:   []string{"/bin/ls"},
-					},
-					hooks: []ResourceHook{
-						{
-							Name: "hook1",
-							Pre: []velerov1api.BackupResourceHook{
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1a",
-										Command:   []string{"1a"},
-										OnError:   velerov1api.HookErrorModeContinue,
-									},
-								},
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1b",
-										Command:   []string{"1b"},
-									},
-								},
-							},
-						},
-					},
-				},
-			},
-		},
-		{
-			name:                  "a pod with annotation, on error=fail",
-			phase:                 PhasePre,
-			groupResource:         "pods",
-			hookTracker:           NewHookTracker(),
-			expectedHookAttempted: 1,
-			expectedHookFailed:    1,
-			pods: []podWithHook{
-				{
-					item: velerotest.UnstructuredOrDie(`
-					{
-						"apiVersion": "v1",
-						"kind": "Pod",
-						"metadata": {
-							"namespace": "ns",
-							"name": "name",
-							"annotations": {
-								"hook.backup.velero.io/container": "c",
-								"hook.backup.velero.io/command": "/bin/ls",
-								"hook.backup.velero.io/on-error": "Fail"
-							}
-						}
-					}`),
-					expectedPodHook: &velerov1api.ExecHook{
-						Container: "c",
-						Command:   []string{"/bin/ls"},
-						OnError:   velerov1api.HookErrorModeFail,
-					},
-					expectedPodHookError: errors.New("pod hook error"),
-				},
-			},
-		},
-		{
-			name:                  "two pods, one with annotation, the other with spec",
-			phase:                 PhasePre,
-			groupResource:         "pods",
-			hookTracker:           NewHookTracker(),
-			expectedHookAttempted: 3,
-			expectedHookFailed:    1,
-			pods: []podWithHook{
-				{
-					item: velerotest.UnstructuredOrDie(`
-					{
-						"apiVersion": "v1",
-						"kind": "Pod",
-						"metadata": {
-							"namespace": "ns",
-							"name": "name",
-							"annotations": {
-								"hook.backup.velero.io/container": "c",
-								"hook.backup.velero.io/command": "/bin/ls",
-								"hook.backup.velero.io/on-error": "Fail"
-							}
-						}
-					}`),
-					expectedPodHook: &velerov1api.ExecHook{
-						Container: "c",
-						Command:   []string{"/bin/ls"},
-						OnError:   velerov1api.HookErrorModeFail,
-					},
-					expectedPodHookError: errors.New("pod hook error"),
-				},
-				{
-					item: velerotest.UnstructuredOrDie(`
-					{
-						"apiVersion": "v1",
-						"kind": "Pod",
-						"metadata": {
-							"namespace": "ns",
-							"name": "name"
-						}
-					}`),
-					hooks: []ResourceHook{
-						{
-							Name: "hook1",
-							Pre: []velerov1api.BackupResourceHook{
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1a",
-										Command:   []string{"pre-1a"},
-									},
-								},
-								{
-									Exec: &velerov1api.ExecHook{
-										Container: "1b",
-										Command:   []string{"pre-1b"},
-									},
-								},
-							},
-						},
-					},
-				},
-			},
-		},
-	}
-
-	for _, test := range test1 {
-		t.Run(test.name, func(t *testing.T) {
-			podCommandExecutor := &velerotest.MockPodCommandExecutor{}
-			defer podCommandExecutor.AssertExpectations(t)
-
-			h := &DefaultItemHookHandler{
-				PodCommandExecutor: podCommandExecutor,
-			}
-
-			groupResource := schema.ParseGroupResource(test.groupResource)
-			hookTracker := test.hookTracker
-
-			for _, pod := range test.pods {
-				if pod.expectedPodHook != nil {
-					podCommandExecutor.On("ExecutePodCommand", mock.Anything, pod.item.UnstructuredContent(), "ns", "name", "<from-annotation>", pod.expectedPodHook).Return(pod.expectedPodHookError)
-				} else {
-				hookLoop:
-					for _, resourceHook := range pod.hooks {
-						for _, hook := range resourceHook.Pre {
-							hookError := pod.hookErrorsByContainer[hook.Exec.Container]
-							podCommandExecutor.On("ExecutePodCommand", mock.Anything, pod.item.UnstructuredContent(), "ns", "name", resourceHook.Name, hook.Exec).Return(hookError)
-							if hookError != nil && hook.Exec.OnError == velerov1api.HookErrorModeFail {
-								break hookLoop
-							}
-						}
-						for _, hook := range resourceHook.Post {
-							hookError := pod.hookErrorsByContainer[hook.Exec.Container]
-							podCommandExecutor.On("ExecutePodCommand", mock.Anything, pod.item.UnstructuredContent(), "ns", "name", resourceHook.Name, hook.Exec).Return(hookError)
-							if hookError != nil && hook.Exec.OnError == velerov1api.HookErrorModeFail {
-								break hookLoop
-							}
-						}
-					}
-				}
-				h.HandleHooks(velerotest.NewLogger(), groupResource, pod.item, pod.hooks, test.phase, hookTracker)
-
-			}
-			actualAtemptted, actualFailed := hookTracker.Stat()
-			assert.Equal(t, test.expectedHookAttempted, actualAtemptted)
-			assert.Equal(t, test.expectedHookFailed, actualFailed)
-		})
-	}
-
-}
-
-func TestRestoreHookTrackerAdd(t *testing.T) {
-	testCases := []struct {
-		name                 string
-		resourceRestoreHooks []ResourceRestoreHook
-		pod                  *corev1api.Pod
-		hookTracker          *HookTracker
-		expectedCnt          int
-	}{
-		{
-			name:                 "neither spec hooks nor annotations hooks are set",
-			resourceRestoreHooks: nil,
-			pod:                  builder.ForPod("default", "my-pod").Result(),
-			hookTracker:          NewHookTracker(),
-			expectedCnt:          0,
-		},
-		{
-			name:                 "a hook specified in pod annotation",
-			resourceRestoreHooks: nil,
-			pod: builder.ForPod("default", "my-pod").
-				ObjectMeta(builder.WithAnnotations(
-					podRestoreHookCommandAnnotationKey, "/usr/bin/foo",
-					podRestoreHookContainerAnnotationKey, "container1",
-					podRestoreHookOnErrorAnnotationKey, string(velerov1api.HookErrorModeContinue),
-					podRestoreHookTimeoutAnnotationKey, "1s",
-					podRestoreHookWaitTimeoutAnnotationKey, "1m",
-					podRestoreHookWaitForReadyAnnotationKey, "true",
-				)).
-				Containers(&corev1api.Container{
-					Name: "container1",
-				}).
-				Result(),
-			hookTracker: NewHookTracker(),
-			expectedCnt: 1,
-		},
-		{
-			name: "two hooks specified in restore spec",
-			resourceRestoreHooks: []ResourceRestoreHook{
-				{
-					Name:     "hook1",
-					Selector: ResourceHookSelector{},
-					RestoreHooks: []velerov1api.RestoreResourceHook{
-						{
-							Exec: &velerov1api.ExecRestoreHook{
-								Container:   "container1",
-								Command:     []string{"/usr/bin/foo"},
-								OnError:     velerov1api.HookErrorModeContinue,
-								ExecTimeout: metav1.Duration{Duration: time.Second},
-								WaitTimeout: metav1.Duration{Duration: time.Minute},
-							},
-						},
-						{
-							Exec: &velerov1api.ExecRestoreHook{
-								Container:   "container2",
-								Command:     []string{"/usr/bin/foo"},
-								OnError:     velerov1api.HookErrorModeContinue,
-								ExecTimeout: metav1.Duration{Duration: time.Second},
-								WaitTimeout: metav1.Duration{Duration: time.Minute},
-							},
-						},
-					},
-				},
-			},
-			pod: builder.ForPod("default", "my-pod").
-				Containers(&corev1api.Container{
-					Name: "container1",
-				}, &corev1api.Container{
-					Name: "container2",
-				}).
-				Result(),
-			hookTracker: NewHookTracker(),
-			expectedCnt: 2,
-		},
-		{
-			name: "both spec hooks and annotations hooks are set",
-			resourceRestoreHooks: []ResourceRestoreHook{
-				{
-					Name:     "hook1",
-					Selector: ResourceHookSelector{},
-					RestoreHooks: []velerov1api.RestoreResourceHook{
-						{
-							Exec: &velerov1api.ExecRestoreHook{
-								Container:   "container1",
-								Command:     []string{"/usr/bin/foo2"},
-								OnError:     velerov1api.HookErrorModeContinue,
-								ExecTimeout: metav1.Duration{Duration: time.Second},
-								WaitTimeout: metav1.Duration{Duration: time.Minute},
-							},
-						},
-					},
-				},
-			},
-			pod: builder.ForPod("default", "my-pod").
-				ObjectMeta(builder.WithAnnotations(
-					podRestoreHookCommandAnnotationKey, "/usr/bin/foo",
-					podRestoreHookContainerAnnotationKey, "container1",
-					podRestoreHookOnErrorAnnotationKey, string(velerov1api.HookErrorModeContinue),
-					podRestoreHookTimeoutAnnotationKey, "1s",
-					podRestoreHookWaitTimeoutAnnotationKey, "1m",
-					podRestoreHookWaitForReadyAnnotationKey, "true",
-				)).
-				Containers(&corev1api.Container{
-					Name: "container1",
-				}).
-				Result(),
-			hookTracker: NewHookTracker(),
-			expectedCnt: 1,
-		},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			_, _ = GroupRestoreExecHooks(tc.resourceRestoreHooks, tc.pod, velerotest.NewLogger(), tc.hookTracker)
-			tracker := tc.hookTracker.GetTracker()
-			assert.Equal(t, tc.expectedCnt, len(tracker))
-		})
-	}
-}

internal/hook/wait_exec_hook_handler.go

@@ -29,7 +29,6 @@ import (
 
 	velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
 	"github.com/vmware-tanzu/velero/pkg/podexec"
-	"github.com/vmware-tanzu/velero/pkg/util/boolptr"
 	"github.com/vmware-tanzu/velero/pkg/util/kube"
 )
 
@@ -39,7 +38,6 @@ type WaitExecHookHandler interface {
 		log logrus.FieldLogger,
 		pod *v1.Pod,
 		byContainer map[string][]PodExecRestoreHook,
-		hookTrack *HookTracker,
 	) []error
 }
 
@@ -51,11 +49,6 @@ type DefaultListWatchFactory struct {
 	PodsGetter cache.Getter
 }
 
-type HookErrInfo struct {
-	Namespace string
-	Err       error
-}
-
 func (d *DefaultListWatchFactory) NewListWatch(namespace string, selector fields.Selector) cache.ListerWatcher {
 	return cache.NewListWatchFromClient(d.PodsGetter, "pods", namespace, selector)
 }
@@ -74,7 +67,6 @@ func (e *DefaultWaitExecHookHandler) HandleHooks(
 	log logrus.FieldLogger,
 	pod *v1.Pod,
 	byContainer map[string][]PodExecRestoreHook,
-	hookTracker *HookTracker,
 ) []error {
 	if pod == nil {
 		return nil
@@ -134,8 +126,8 @@ func (e *DefaultWaitExecHookHandler) HandleHooks(
 		}
 
 		for containerName, hooks := range byContainer {
-			if !isContainerUp(newPod, containerName, hooks) {
-				podLog.Infof("Container %s is not up: post-restore hooks will not yet be executed", containerName)
+			if !isContainerRunning(newPod, containerName) {
+				podLog.Infof("Container %s is not running: post-restore hooks will not yet be executed", containerName)
 				continue
 			}
 			podMap, err := runtime.DefaultUnstructuredConverter.ToUnstructured(newPod)
@@ -165,14 +157,8 @@ func (e *DefaultWaitExecHookHandler) HandleHooks(
 				if hook.Hook.WaitTimeout.Duration != 0 && time.Since(waitStart) > hook.Hook.WaitTimeout.Duration {
 					err := fmt.Errorf("hook %s in container %s expired before executing", hook.HookName, hook.Hook.Container)
 					hookLog.Error(err)
-					errors = append(errors, err)
-
-					errTracker := hookTracker.Record(newPod.Namespace, newPod.Name, hook.Hook.Container, hook.HookSource, hook.HookName, hookPhase(""), true)
-					if errTracker != nil {
-						hookLog.WithError(errTracker).Warn("Error recording the hook in hook tracker")
-					}
-
 					if hook.Hook.OnError == velerov1api.HookErrorModeFail {
+						errors = append(errors, err)
 						cancel()
 						return
 					}
@@ -183,24 +169,13 @@ func (e *DefaultWaitExecHookHandler) HandleHooks(
 					OnError:   hook.Hook.OnError,
 					Timeout:   hook.Hook.ExecTimeout,
 				}
-
-				hookFailed := false
-				var hookErr error
-				if hookErr = e.PodCommandExecutor.ExecutePodCommand(hookLog, podMap, pod.Namespace, pod.Name, hook.HookName, eh); hookErr != nil {
-					hookLog.WithError(hookErr).Error("Error executing hook")
-					hookErr = fmt.Errorf("hook %s in container %s failed to execute, err: %v", hook.HookName, hook.Hook.Container, hookErr)
-					errors = append(errors, hookErr)
-					hookFailed = true
-				}
-
-				errTracker := hookTracker.Record(newPod.Namespace, newPod.Name, hook.Hook.Container, hook.HookSource, hook.HookName, hookPhase(""), hookFailed)
-				if errTracker != nil {
-					hookLog.WithError(errTracker).Warn("Error recording the hook in hook tracker")
-				}
-
-				if hookErr != nil && hook.Hook.OnError == velerov1api.HookErrorModeFail {
-					cancel()
-					return
+				if err := e.PodCommandExecutor.ExecutePodCommand(hookLog, podMap, pod.Namespace, pod.Name, hook.HookName, eh); err != nil {
+					hookLog.WithError(err).Error("Error executing hook")
+					if hook.Hook.OnError == velerov1api.HookErrorModeFail {
+						errors = append(errors, err)
+						cancel()
+						return
+					}
 				}
 			}
 			delete(byContainer, containerName)
@@ -228,9 +203,10 @@ func (e *DefaultWaitExecHookHandler) HandleHooks(
 	podWatcher.Run(ctx.Done())
 
 	// There are some cases where this function could return with unexecuted hooks: the pod may
-	// be deleted, a hook could fail, or it may timeout waiting for
+	// be deleted, a hook with OnError mode Fail could fail, or it may timeout waiting for
 	// containers to become ready.
-	// Each unexecuted hook is logged as an error and this error will be returned from this function.
+	// Each unexecuted hook is logged as an error but only hooks with OnError mode Fail return
+	// an error from this function.
 	for _, hooks := range byContainer {
 		for _, hook := range hooks {
 			if hook.executed {
@@ -244,14 +220,10 @@ func (e *DefaultWaitExecHookHandler) HandleHooks(
 					"hookPhase":  "post",
 				},
 			)
-
-			errTracker := hookTracker.Record(pod.Namespace, pod.Name, hook.Hook.Container, hook.HookSource, hook.HookName, hookPhase(""), true)
-			if errTracker != nil {
-				hookLog.WithError(errTracker).Warn("Error recording the hook in hook tracker")
-			}
-
 			hookLog.Error(err)
-			errors = append(errors, err)
+			if hook.Hook.OnError == velerov1api.HookErrorModeFail {
+				errors = append(errors, err)
+			}
 		}
 	}
 
@@ -271,24 +243,14 @@ func podHasContainer(pod *v1.Pod, containerName string) bool {
 	return false
 }
 
-func isContainerUp(pod *v1.Pod, containerName string, hooks []PodExecRestoreHook) bool {
+func isContainerRunning(pod *v1.Pod, containerName string) bool {
 	if pod == nil {
 		return false
 	}
-	var waitForReady bool
-	for _, hook := range hooks {
-		if boolptr.IsSetToTrue(hook.Hook.WaitForReady) {
-			waitForReady = true
-			break
-		}
-	}
 	for _, cs := range pod.Status.ContainerStatuses {
 		if cs.Name != containerName {
 			continue
 		}
-		if waitForReady {
-			return cs.Ready
-		}
 		return cs.State.Running != nil
 	}
 

internal/hook/wait_exec_hook_handler_test.go

@@ -35,7 +35,6 @@ import (
 	velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
 	"github.com/vmware-tanzu/velero/pkg/builder"
 	velerotest "github.com/vmware-tanzu/velero/pkg/test"
-	"github.com/vmware-tanzu/velero/pkg/util/boolptr"
 )
 
 type fakeListWatchFactory struct {
@@ -98,7 +97,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "<from-annotation>",
-						HookSource: HookSourceAnnotation,
+						HookSource: "annotation",
 						Hook: velerov1api.ExecRestoreHook{
 							Container:   "container1",
 							Command:     []string{"/usr/bin/foo"},
@@ -167,7 +166,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "<from-annotation>",
-						HookSource: HookSourceAnnotation,
+						HookSource: "annotation",
 						Hook: velerov1api.ExecRestoreHook{
 							Container:   "container1",
 							Command:     []string{"/usr/bin/foo"},
@@ -209,10 +208,10 @@ func TestWaitExecHandleHooks(t *testing.T) {
 						Result(),
 				},
 			},
-			expectedErrors: []error{errors.New("hook <from-annotation> in container container1 failed to execute, err: pod hook error")},
+			expectedErrors: []error{errors.New("pod hook error")},
 		},
 		{
-			name: "should return error when hook from annotation fails with on error mode continue",
+			name: "should return no error when hook from annotation fails with on error mode continue",
 			initialPod: builder.ForPod("default", "my-pod").
 				ObjectMeta(builder.WithAnnotations(
 					podRestoreHookCommandAnnotationKey, "/usr/bin/foo",
@@ -236,7 +235,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "<from-annotation>",
-						HookSource: HookSourceAnnotation,
+						HookSource: "annotation",
 						Hook: velerov1api.ExecRestoreHook{
 							Container:   "container1",
 							Command:     []string{"/usr/bin/foo"},
@@ -278,7 +277,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 						Result(),
 				},
 			},
-			expectedErrors: []error{errors.New("hook <from-annotation> in container container1 failed to execute, err: pod hook error")},
+			expectedErrors: nil,
 		},
 		{
 			name: "should return no error when hook from annotation executes after 10ms wait for container to start",
@@ -305,7 +304,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "<from-annotation>",
-						HookSource: HookSourceAnnotation,
+						HookSource: "annotation",
 						Hook: velerov1api.ExecRestoreHook{
 							Container:   "container1",
 							Command:     []string{"/usr/bin/foo"},
@@ -391,7 +390,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
 							Container: "container1",
 							Command:   []string{"/usr/bin/foo"},
@@ -422,7 +421,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 			},
 		},
 		{
-			name:          "should return error when spec hook with wait timeout expires with OnError mode Continue",
+			name:          "should return no error when spec hook with wait timeout expires with OnError mode Continue",
 			groupResource: "pods",
 			initialPod: builder.ForPod("default", "my-pod").
 				Containers(&v1.Container{
@@ -435,12 +434,12 @@ func TestWaitExecHandleHooks(t *testing.T) {
 					},
 				}).
 				Result(),
-			expectedErrors: []error{errors.New("hook my-hook-1 in container container1 in pod default/my-pod not executed: context deadline exceeded")},
+			expectedErrors: nil,
 			byContainer: map[string][]PodExecRestoreHook{
 				"container1": {
 					{
 						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
 							Container:   "container1",
 							Command:     []string{"/usr/bin/foo"},
@@ -471,7 +470,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
 							Container:   "container1",
 							Command:     []string{"/usr/bin/foo"},
@@ -502,7 +501,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
 							Container: "container1",
 							Command:   []string{"/usr/bin/foo"},
@@ -515,8 +514,8 @@ func TestWaitExecHandleHooks(t *testing.T) {
 			sharedHooksContextTimeout: time.Millisecond,
 		},
 		{
-			name:           "should return error when shared hooks context is canceled before spec hook with OnError mode Continue executes",
-			expectedErrors: []error{errors.New("hook my-hook-1 in container container1 in pod default/my-pod not executed: context deadline exceeded")},
+			name:           "should return no error when shared hooks context is canceled before spec hook with OnError mode Continue executes",
+			expectedErrors: nil,
 			groupResource:  "pods",
 			initialPod: builder.ForPod("default", "my-pod").
 				Containers(&v1.Container{
@@ -533,7 +532,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
 							Container: "container1",
 							Command:   []string{"/usr/bin/foo"},
@@ -574,7 +573,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container1": {
 					{
 						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
 							Container: "container1",
 							Command:   []string{"/usr/bin/foo"},
@@ -584,7 +583,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				"container2": {
 					{
 						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
+						HookSource: "backupSpec",
 						Hook: velerov1api.ExecRestoreHook{
 							Container: "container2",
 							Command:   []string{"/usr/bin/bar"},
@@ -744,8 +743,7 @@ func TestWaitExecHandleHooks(t *testing.T) {
 				defer ctxCancel()
 			}
 
-			hookTracker := NewHookTracker()
-			errs := h.HandleHooks(ctx, velerotest.NewLogger(), test.initialPod, test.byContainer, hookTracker)
+			errs := h.HandleHooks(ctx, velerotest.NewLogger(), test.initialPod, test.byContainer)
 
 			// for i, ee := range test.expectedErrors {
 			require.Len(t, errs, len(test.expectedErrors))
@@ -792,13 +790,12 @@ func TestPodHasContainer(t *testing.T) {
 	}
 }
 
-func TestIsContainerUp(t *testing.T) {
+func TestIsContainerRunning(t *testing.T) {
 	tests := []struct {
 		name      string
 		pod       *v1.Pod
 		container string
 		expect    bool
-		hooks     []PodExecRestoreHook
 	}{
 		{
 			name:      "should return true when running",
@@ -812,49 +809,6 @@ func TestIsContainerUp(t *testing.T) {
 					},
 				}).
 				Result(),
-			hooks: []PodExecRestoreHook{},
-		},
-		{
-			name:      "should return false when running but not ready",
-			container: "container1",
-			expect:    false,
-			pod: builder.ForPod("default", "my-pod").
-				ContainerStatuses(&v1.ContainerStatus{
-					Name: "container1",
-					State: v1.ContainerState{
-						Running: &v1.ContainerStateRunning{},
-					},
-					Ready: false,
-				}).
-				Result(),
-			hooks: []PodExecRestoreHook{
-				{
-					Hook: velerov1api.ExecRestoreHook{
-						WaitForReady: boolptr.True(),
-					},
-				},
-			},
-		},
-		{
-			name:      "should return true when running and ready",
-			container: "container1",
-			expect:    true,
-			pod: builder.ForPod("default", "my-pod").
-				ContainerStatuses(&v1.ContainerStatus{
-					Name: "container1",
-					State: v1.ContainerState{
-						Running: &v1.ContainerStateRunning{},
-					},
-					Ready: true,
-				}).
-				Result(),
-			hooks: []PodExecRestoreHook{
-				{
-					Hook: velerov1api.ExecRestoreHook{
-						WaitForReady: boolptr.True(),
-					},
-				},
-			},
 		},
 		{
 			name:      "should return false when no state is set",
@@ -866,7 +820,6 @@ func TestIsContainerUp(t *testing.T) {
 					State: v1.ContainerState{},
 				}).
 				Result(),
-			hooks: []PodExecRestoreHook{},
 		},
 		{
 			name:      "should return false when waiting",
@@ -880,7 +833,6 @@ func TestIsContainerUp(t *testing.T) {
 					},
 				}).
 				Result(),
-			hooks: []PodExecRestoreHook{},
 		},
 		{
 			name:      "should return true when running and first container is terminated",
@@ -900,12 +852,11 @@ func TestIsContainerUp(t *testing.T) {
 						},
 					}).
 				Result(),
-			hooks: []PodExecRestoreHook{},
 		},
 	}
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			actual := isContainerUp(test.pod, test.container, test.hooks)
+			actual := isContainerRunning(test.pod, test.container)
 			assert.Equal(t, actual, test.expect)
 		})
 	}
@@ -998,284 +949,3 @@ func TestMaxHookWait(t *testing.T) {
 		})
 	}
 }
-
-func TestRestoreHookTrackerUpdate(t *testing.T) {
-	type change struct {
-		// delta to wait since last change applied or pod added
-		wait    time.Duration
-		updated *v1.Pod
-	}
-	type expectedExecution struct {
-		hook  *velerov1api.ExecHook
-		name  string
-		error error
-		pod   *v1.Pod
-	}
-
-	hookTracker1 := NewHookTracker()
-	hookTracker1.Add("default", "my-pod", "container1", HookSourceAnnotation, "<from-annotation>", hookPhase(""))
-
-	hookTracker2 := NewHookTracker()
-	hookTracker2.Add("default", "my-pod", "container1", HookSourceSpec, "my-hook-1", hookPhase(""))
-
-	hookTracker3 := NewHookTracker()
-	hookTracker3.Add("default", "my-pod", "container1", HookSourceSpec, "my-hook-1", hookPhase(""))
-	hookTracker3.Add("default", "my-pod", "container2", HookSourceSpec, "my-hook-2", hookPhase(""))
-
-	tests1 := []struct {
-		name               string
-		initialPod         *v1.Pod
-		groupResource      string
-		byContainer        map[string][]PodExecRestoreHook
-		expectedExecutions []expectedExecution
-		hookTracker        *HookTracker
-		expectedFailed     int
-	}{
-		{
-			name: "a hook executes successfully",
-			initialPod: builder.ForPod("default", "my-pod").
-				ObjectMeta(builder.WithAnnotations(
-					podRestoreHookCommandAnnotationKey, "/usr/bin/foo",
-					podRestoreHookContainerAnnotationKey, "container1",
-					podRestoreHookOnErrorAnnotationKey, string(velerov1api.HookErrorModeContinue),
-					podRestoreHookTimeoutAnnotationKey, "1s",
-					podRestoreHookWaitTimeoutAnnotationKey, "1m",
-				)).
-				Containers(&v1.Container{
-					Name: "container1",
-				}).
-				ContainerStatuses(&v1.ContainerStatus{
-					Name: "container1",
-					State: v1.ContainerState{
-						Running: &v1.ContainerStateRunning{},
-					},
-				}).
-				Result(),
-			groupResource: "pods",
-			byContainer: map[string][]PodExecRestoreHook{
-				"container1": {
-					{
-						HookName:   "<from-annotation>",
-						HookSource: HookSourceAnnotation,
-						Hook: velerov1api.ExecRestoreHook{
-							Container:   "container1",
-							Command:     []string{"/usr/bin/foo"},
-							OnError:     velerov1api.HookErrorModeContinue,
-							ExecTimeout: metav1.Duration{Duration: time.Second},
-							WaitTimeout: metav1.Duration{Duration: time.Minute},
-						},
-					},
-				},
-			},
-			expectedExecutions: []expectedExecution{
-				{
-					name: "<from-annotation>",
-					hook: &velerov1api.ExecHook{
-						Container: "container1",
-						Command:   []string{"/usr/bin/foo"},
-						OnError:   velerov1api.HookErrorModeContinue,
-						Timeout:   metav1.Duration{Duration: time.Second},
-					},
-					error: nil,
-					pod: builder.ForPod("default", "my-pod").
-						ObjectMeta(builder.WithResourceVersion("1")).
-						ObjectMeta(builder.WithAnnotations(
-							podRestoreHookCommandAnnotationKey, "/usr/bin/foo",
-							podRestoreHookContainerAnnotationKey, "container1",
-							podRestoreHookOnErrorAnnotationKey, string(velerov1api.HookErrorModeContinue),
-							podRestoreHookTimeoutAnnotationKey, "1s",
-							podRestoreHookWaitTimeoutAnnotationKey, "1m",
-						)).
-						Containers(&v1.Container{
-							Name: "container1",
-						}).
-						ContainerStatuses(&v1.ContainerStatus{
-							Name: "container1",
-							State: v1.ContainerState{
-								Running: &v1.ContainerStateRunning{},
-							},
-						}).
-						Result(),
-				},
-			},
-			hookTracker:    hookTracker1,
-			expectedFailed: 0,
-		},
-		{
-			name:          "a hook with OnError mode Fail failed to execute",
-			groupResource: "pods",
-			initialPod: builder.ForPod("default", "my-pod").
-				Containers(&v1.Container{
-					Name: "container1",
-				}).
-				ContainerStatuses(&v1.ContainerStatus{
-					Name: "container1",
-					State: v1.ContainerState{
-						Waiting: &v1.ContainerStateWaiting{},
-					},
-				}).
-				Result(),
-			byContainer: map[string][]PodExecRestoreHook{
-				"container1": {
-					{
-						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
-						Hook: velerov1api.ExecRestoreHook{
-							Container:   "container1",
-							Command:     []string{"/usr/bin/foo"},
-							OnError:     velerov1api.HookErrorModeFail,
-							WaitTimeout: metav1.Duration{Duration: time.Millisecond},
-						},
-					},
-				},
-			},
-			hookTracker:    hookTracker2,
-			expectedFailed: 1,
-		},
-		{
-			name:          "a hook with OnError mode Continue failed to execute",
-			groupResource: "pods",
-			initialPod: builder.ForPod("default", "my-pod").
-				Containers(&v1.Container{
-					Name: "container1",
-				}).
-				ContainerStatuses(&v1.ContainerStatus{
-					Name: "container1",
-					State: v1.ContainerState{
-						Waiting: &v1.ContainerStateWaiting{},
-					},
-				}).
-				Result(),
-			byContainer: map[string][]PodExecRestoreHook{
-				"container1": {
-					{
-						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
-						Hook: velerov1api.ExecRestoreHook{
-							Container:   "container1",
-							Command:     []string{"/usr/bin/foo"},
-							OnError:     velerov1api.HookErrorModeContinue,
-							WaitTimeout: metav1.Duration{Duration: time.Millisecond},
-						},
-					},
-				},
-			},
-			hookTracker:    hookTracker2,
-			expectedFailed: 1,
-		},
-		{
-			name:          "two hooks with OnError mode Continue failed to execute",
-			groupResource: "pods",
-			initialPod: builder.ForPod("default", "my-pod").
-				Containers(&v1.Container{
-					Name: "container1",
-				}).
-				Containers(&v1.Container{
-					Name: "container2",
-				}).
-				// initially both are waiting
-				ContainerStatuses(&v1.ContainerStatus{
-					Name: "container1",
-					State: v1.ContainerState{
-						Waiting: &v1.ContainerStateWaiting{},
-					},
-				}).
-				ContainerStatuses(&v1.ContainerStatus{
-					Name: "container2",
-					State: v1.ContainerState{
-						Waiting: &v1.ContainerStateWaiting{},
-					},
-				}).
-				Result(),
-			byContainer: map[string][]PodExecRestoreHook{
-				"container1": {
-					{
-						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
-						Hook: velerov1api.ExecRestoreHook{
-							Container:   "container1",
-							Command:     []string{"/usr/bin/foo"},
-							OnError:     velerov1api.HookErrorModeContinue,
-							WaitTimeout: metav1.Duration{Duration: time.Millisecond},
-						},
-					},
-				},
-				"container2": {
-					{
-						HookName:   "my-hook-2",
-						HookSource: HookSourceSpec,
-						Hook: velerov1api.ExecRestoreHook{
-							Container:   "container2",
-							Command:     []string{"/usr/bin/bar"},
-							OnError:     velerov1api.HookErrorModeContinue,
-							WaitTimeout: metav1.Duration{Duration: time.Millisecond},
-						},
-					},
-				},
-			},
-			hookTracker:    hookTracker3,
-			expectedFailed: 2,
-		},
-		{
-			name:          "a hook was recorded before added to tracker",
-			groupResource: "pods",
-			initialPod: builder.ForPod("default", "my-pod").
-				Containers(&v1.Container{
-					Name: "container1",
-				}).
-				ContainerStatuses(&v1.ContainerStatus{
-					Name: "container1",
-					State: v1.ContainerState{
-						Waiting: &v1.ContainerStateWaiting{},
-					},
-				}).
-				Result(),
-			byContainer: map[string][]PodExecRestoreHook{
-				"container1": {
-					{
-						HookName:   "my-hook-1",
-						HookSource: HookSourceSpec,
-						Hook: velerov1api.ExecRestoreHook{
-							Container:   "container1",
-							Command:     []string{"/usr/bin/foo"},
-							OnError:     velerov1api.HookErrorModeContinue,
-							WaitTimeout: metav1.Duration{Duration: time.Millisecond},
-						},
-					},
-				},
-			},
-			hookTracker:    NewHookTracker(),
-			expectedFailed: 0,
-		},
-	}
-
-	for _, test := range tests1 {
-		t.Run(test.name, func(t *testing.T) {
-
-			source := fcache.NewFakeControllerSource()
-			go func() {
-				// This is the state of the pod that will be seen by the AddFunc handler.
-				source.Add(test.initialPod)
-			}()
-
-			podCommandExecutor := &velerotest.MockPodCommandExecutor{}
-			defer podCommandExecutor.AssertExpectations(t)
-
-			h := &DefaultWaitExecHookHandler{
-				PodCommandExecutor: podCommandExecutor,
-				ListWatchFactory:   &fakeListWatchFactory{source},
-			}
-
-			for _, e := range test.expectedExecutions {
-				obj, err := runtime.DefaultUnstructuredConverter.ToUnstructured(e.pod)
-				assert.Nil(t, err)
-				podCommandExecutor.On("ExecutePodCommand", mock.Anything, obj, e.pod.Namespace, e.pod.Name, e.name, e.hook).Return(e.error)
-			}
-
-			ctx := context.Background()
-			_ = h.HandleHooks(ctx, velerotest.NewLogger(), test.initialPod, test.byContainer, test.hookTracker)
-			_, actualFailed := test.hookTracker.Stat()
-			assert.Equal(t, test.expectedFailed, actualFailed)
-		})
-	}
-}

internal/resourcemodifiers/json_merge_patch.go

@@ -1,45 +0,0 @@
-package resourcemodifiers
-
-import (
-	"fmt"
-
-	jsonpatch "github.com/evanphx/json-patch"
-	"github.com/sirupsen/logrus"
-	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
-	"sigs.k8s.io/yaml"
-)
-
-type JSONMergePatch struct {
-	PatchData string `json:"patchData,omitempty"`
-}
-
-type JSONMergePatcher struct {
-	patches []JSONMergePatch
-}
-
-func (p *JSONMergePatcher) Patch(u *unstructured.Unstructured, _ logrus.FieldLogger) (*unstructured.Unstructured, error) {
-	objBytes, err := u.MarshalJSON()
-	if err != nil {
-		return nil, fmt.Errorf("error in marshaling object %s", err)
-	}
-
-	for _, patch := range p.patches {
-		patchBytes, err := yaml.YAMLToJSON([]byte(patch.PatchData))
-		if err != nil {
-			return nil, fmt.Errorf("error in converting YAML to JSON %s", err)
-		}
-
-		objBytes, err = jsonpatch.MergePatch(objBytes, patchBytes)
-		if err != nil {
-			return nil, fmt.Errorf("error in applying JSON Patch: %s", err.Error())
-		}
-	}
-
-	updated := &unstructured.Unstructured{}
-	err = updated.UnmarshalJSON(objBytes)
-	if err != nil {
-		return nil, fmt.Errorf("error in unmarshalling modified object %s", err.Error())
-	}
-
-	return updated, nil
-}

internal/resourcemodifiers/json_merge_patch_test.go

@@ -1,41 +0,0 @@
-package resourcemodifiers
-
-import (
-	"testing"
-
-	"github.com/sirupsen/logrus"
-	"github.com/stretchr/testify/assert"
-	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
-	"k8s.io/apimachinery/pkg/runtime"
-	clientgoscheme "k8s.io/client-go/kubernetes/scheme"
-)
-
-func TestJsonMergePatchFailure(t *testing.T) {
-	tests := []struct {
-		name string
-		data string
-	}{
-		{
-			name: "patch with bad yaml",
-			data: "a: b:",
-		},
-		{
-			name: "patch with bad json",
-			data: `{"a"::1}`,
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			scheme := runtime.NewScheme()
-			err := clientgoscheme.AddToScheme(scheme)
-			assert.NoError(t, err)
-			pt := &JSONMergePatcher{
-				patches: []JSONMergePatch{{PatchData: tt.data}},
-			}
-
-			u := &unstructured.Unstructured{}
-			_, err = pt.Patch(u, logrus.New())
-			assert.Error(t, err)
-		})
-	}
-}

internal/resourcemodifiers/json_patch.go

@@ -1,103 +0,0 @@
-package resourcemodifiers
-
-import (
-	"errors"
-	"fmt"
-	"strconv"
-	"strings"
-
-	jsonpatch "github.com/evanphx/json-patch"
-	"github.com/sirupsen/logrus"
-	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
-)
-
-type JSONPatch struct {
-	Operation string `json:"operation"`
-	From      string `json:"from,omitempty"`
-	Path      string `json:"path"`
-	Value     string `json:"value,omitempty"`
-}
-
-func (p *JSONPatch) ToString() string {
-	if addQuotes(&p.Value) {
-		return fmt.Sprintf(`{"op": "%s", "from": "%s", "path": "%s", "value": "%s"}`, p.Operation, p.From, p.Path, p.Value)
-	}
-	return fmt.Sprintf(`{"op": "%s", "from": "%s", "path": "%s", "value": %s}`, p.Operation, p.From, p.Path, p.Value)
-}
-
-func addQuotes(value *string) bool {
-	if *value == "" {
-		return true
-	}
-	// if value is escaped, remove escape and add quotes
-	// this is useful for scenarios where boolean, null and numbers are required to be set as string.
-	if strings.HasPrefix(*value, "\"") && strings.HasSuffix(*value, "\"") {
-		*value = strings.TrimPrefix(*value, "\"")
-		*value = strings.TrimSuffix(*value, "\"")
-		return true
-	}
-	// if value is null, then don't add quotes
-	if *value == "null" {
-		return false
-	}
-	// if value is a boolean, then don't add quotes
-	if strings.ToLower(*value) == "true" || strings.ToLower(*value) == "false" {
-		return false
-	}
-	// if value is a json object or array, then don't add quotes.
-	if strings.HasPrefix(*value, "{") || strings.HasPrefix(*value, "[") {
-		return false
-	}
-	// if value is a number, then don't add quotes
-	if _, err := strconv.ParseFloat(*value, 64); err == nil {
-		return false
-	}
-	return true
-}
-
-type JSONPatcher struct {
-	patches []JSONPatch `yaml:"patches"`
-}
-
-func (p *JSONPatcher) Patch(u *unstructured.Unstructured, logger logrus.FieldLogger) (*unstructured.Unstructured, error) {
-	modifiedObjBytes, err := p.applyPatch(u)
-	if err != nil {
-		if errors.Is(err, jsonpatch.ErrTestFailed) {
-			logger.Infof("Test operation failed for JSON Patch %s", err.Error())
-			return u.DeepCopy(), nil
-		}
-		return nil, fmt.Errorf("error in applying JSON Patch %s", err.Error())
-	}
-
-	updated := &unstructured.Unstructured{}
-	err = updated.UnmarshalJSON(modifiedObjBytes)
-	if err != nil {
-		return nil, fmt.Errorf("error in unmarshalling modified object %s", err.Error())
-	}
-
-	return updated, nil
-}
-
-func (p *JSONPatcher) applyPatch(u *unstructured.Unstructured) ([]byte, error) {
-	patchBytes := p.patchArrayToByteArray()
-	jsonPatch, err := jsonpatch.DecodePatch(patchBytes)
-	if err != nil {
-		return nil, fmt.Errorf("error in decoding json patch %s", err.Error())
-	}
-
-	objBytes, err := u.MarshalJSON()
-	if err != nil {
-		return nil, fmt.Errorf("error in marshaling object %s", err.Error())
-	}
-
-	return jsonPatch.Apply(objBytes)
-}
-
-func (p *JSONPatcher) patchArrayToByteArray() []byte {
-	var patches []string
-	for _, patch := range p.patches {
-		patches = append(patches, patch.ToString())
-	}
-	patchesStr := strings.Join(patches, ",\n\t")
-	return []byte(fmt.Sprintf(`[%s]`, patchesStr))
-}

internal/resourcemodifiers/resource_modifiers.go

@@ -1,33 +1,18 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
 package resourcemodifiers
 
 import (
 	"fmt"
 	"regexp"
+	"strconv"
+	"strings"
 
 	jsonpatch "github.com/evanphx/json-patch"
-	"github.com/gobwas/glob"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/labels"
-	"k8s.io/apimachinery/pkg/runtime"
 	"sigs.k8s.io/yaml"
 
 	"github.com/vmware-tanzu/velero/pkg/util/collections"
@@ -38,9 +23,11 @@ const (
 	ResourceModifierSupportedVersionV1 = "v1"
 )
 
-type MatchRule struct {
-	Path  string `json:"path,omitempty"`
-	Value string `json:"value,omitempty"`
+type JSONPatch struct {
+	Operation string `json:"operation"`
+	From      string `json:"from,omitempty"`
+	Path      string `json:"path"`
+	Value     string `json:"value,omitempty"`
 }
 
 type Conditions struct {
@@ -48,14 +35,11 @@ type Conditions struct {
 	GroupResource     string                `json:"groupResource"`
 	ResourceNameRegex string                `json:"resourceNameRegex,omitempty"`
 	LabelSelector     *metav1.LabelSelector `json:"labelSelector,omitempty"`
-	Matches           []MatchRule           `json:"matches,omitempty"`
 }
 
 type ResourceModifierRule struct {
-	Conditions       Conditions            `json:"conditions"`
-	Patches          []JSONPatch           `json:"patches,omitempty"`
-	MergePatches     []JSONMergePatch      `json:"mergePatches,omitempty"`
-	StrategicPatches []StrategicMergePatch `json:"strategicPatches,omitempty"`
+	Conditions Conditions  `json:"conditions"`
+	Patches    []JSONPatch `json:"patches"`
 }
 
 type ResourceModifiers struct {
@@ -68,7 +52,7 @@ func GetResourceModifiersFromConfig(cm *v1.ConfigMap) (*ResourceModifiers, error
 		return nil, fmt.Errorf("could not parse config from nil configmap")
 	}
 	if len(cm.Data) != 1 {
-		return nil, fmt.Errorf("illegal resource modifiers %s/%s configmap", cm.Namespace, cm.Name)
+		return nil, fmt.Errorf("illegal resource modifiers %s/%s configmap", cm.Name, cm.Namespace)
 	}
 
 	var yamlData string
@@ -84,10 +68,10 @@ func GetResourceModifiersFromConfig(cm *v1.ConfigMap) (*ResourceModifiers, error
 	return resModifiers, nil
 }
 
-func (p *ResourceModifiers) ApplyResourceModifierRules(obj *unstructured.Unstructured, groupResource string, scheme *runtime.Scheme, log logrus.FieldLogger) []error {
+func (p *ResourceModifiers) ApplyResourceModifierRules(obj *unstructured.Unstructured, groupResource string, log logrus.FieldLogger) []error {
 	var errs []error
 	for _, rule := range p.ResourceModifierRules {
-		err := rule.apply(obj, groupResource, scheme, log)
+		err := rule.Apply(obj, groupResource, log)
 		if err != nil {
 			errs = append(errs, err)
 		}
@@ -96,22 +80,13 @@ func (p *ResourceModifiers) ApplyResourceModifierRules(obj *unstructured.Unstruc
 	return errs
 }
 
-func (r *ResourceModifierRule) apply(obj *unstructured.Unstructured, groupResource string, scheme *runtime.Scheme, log logrus.FieldLogger) error {
-	ns := obj.GetNamespace()
-	if ns != "" {
-		namespaceInclusion := collections.NewIncludesExcludes().Includes(r.Conditions.Namespaces...)
-		if !namespaceInclusion.ShouldInclude(ns) {
-			return nil
-		}
+func (r *ResourceModifierRule) Apply(obj *unstructured.Unstructured, groupResource string, log logrus.FieldLogger) error {
+	namespaceInclusion := collections.NewIncludesExcludes().Includes(r.Conditions.Namespaces...)
+	if !namespaceInclusion.ShouldInclude(obj.GetNamespace()) {
+		return nil
 	}
 
-	g, err := glob.Compile(r.Conditions.GroupResource, '.')
-	if err != nil {
-		log.Errorf("Bad glob pattern of groupResource in condition, groupResource: %s, err: %s", r.Conditions.GroupResource, err)
-		return err
-	}
-
-	if !g.Match(groupResource) {
+	if r.Conditions.GroupResource != groupResource {
 		return nil
 	}
 
@@ -135,82 +110,87 @@ func (r *ResourceModifierRule) apply(obj *unstructured.Unstructured, groupResour
 		}
 	}
 
-	match, err := matchConditions(obj, r.Conditions.Matches, log)
+	patches, err := r.PatchArrayToByteArray()
 	if err != nil {
 		return err
-	} else if !match {
-		log.Info("Conditions do not match, skip it")
-		return nil
 	}
-
 	log.Infof("Applying resource modifier patch on %s/%s", obj.GetNamespace(), obj.GetName())
-	err = r.applyPatch(obj, scheme, log)
+	err = ApplyPatch(patches, obj, log)
 	if err != nil {
 		return err
 	}
 	return nil
 }
 
-func matchConditions(u *unstructured.Unstructured, rules []MatchRule, _ logrus.FieldLogger) (bool, error) {
-	if len(rules) == 0 {
-		return true, nil
+// PatchArrayToByteArray converts all JsonPatch to string array with the format of jsonpatch.Patch and then convert it to byte array
+func (r *ResourceModifierRule) PatchArrayToByteArray() ([]byte, error) {
+	var patches []string
+	for _, patch := range r.Patches {
+		patches = append(patches, patch.ToString())
 	}
+	patchesStr := strings.Join(patches, ",\n\t")
+	return []byte(fmt.Sprintf(`[%s]`, patchesStr)), nil
+}
 
-	var fixed []JSONPatch
-	for _, rule := range rules {
-		if rule.Path == "" {
-			return false, fmt.Errorf("path is required for match rule")
-		}
-
-		fixed = append(fixed, JSONPatch{
-			Operation: "test",
-			Path:      rule.Path,
-			Value:     rule.Value,
-		})
+func (p *JSONPatch) ToString() string {
+	if addQuotes(p.Value) {
+		return fmt.Sprintf(`{"op": "%s", "from": "%s", "path": "%s", "value": "%s"}`, p.Operation, p.From, p.Path, p.Value)
 	}
+	return fmt.Sprintf(`{"op": "%s", "from": "%s", "path": "%s", "value": %s}`, p.Operation, p.From, p.Path, p.Value)
+}
 
-	p := &JSONPatcher{patches: fixed}
-	_, err := p.applyPatch(u)
+func ApplyPatch(patch []byte, obj *unstructured.Unstructured, log logrus.FieldLogger) error {
+	jsonPatch, err := jsonpatch.DecodePatch(patch)
+	if err != nil {
+		return fmt.Errorf("error in decoding json patch %s", err.Error())
+	}
+	objBytes, err := obj.MarshalJSON()
+	if err != nil {
+		return fmt.Errorf("error in marshaling object %s", err.Error())
+	}
+	modifiedObjBytes, err := jsonPatch.Apply(objBytes)
 	if err != nil {
 		if errors.Is(err, jsonpatch.ErrTestFailed) {
-			return false, nil
+			log.Infof("Test operation failed for JSON Patch %s", err.Error())
+			return nil
 		}
-		return false, err
+		return fmt.Errorf("error in applying JSON Patch %s", err.Error())
 	}
-
-	return true, nil
+	err = obj.UnmarshalJSON(modifiedObjBytes)
+	if err != nil {
+		return fmt.Errorf("error in unmarshalling modified object %s", err.Error())
+	}
+	return nil
 }
 
 func unmarshalResourceModifiers(yamlData []byte) (*ResourceModifiers, error) {
 	resModifiers := &ResourceModifiers{}
 	err := yaml.UnmarshalStrict(yamlData, resModifiers)
 	if err != nil {
-		return nil, fmt.Errorf("failed to decode yaml data into resource modifiers, err: %s", err)
+		return nil, fmt.Errorf("failed to decode yaml data into resource modifiers  %v", err)
 	}
 	return resModifiers, nil
 }
 
-type patcher interface {
-	Patch(u *unstructured.Unstructured, logger logrus.FieldLogger) (*unstructured.Unstructured, error)
-}
-
-func (r *ResourceModifierRule) applyPatch(u *unstructured.Unstructured, scheme *runtime.Scheme, logger logrus.FieldLogger) error {
-	var p patcher
-	if len(r.Patches) > 0 {
-		p = &JSONPatcher{patches: r.Patches}
-	} else if len(r.MergePatches) > 0 {
-		p = &JSONMergePatcher{patches: r.MergePatches}
-	} else if len(r.StrategicPatches) > 0 {
-		p = &StrategicMergePatcher{patches: r.StrategicPatches, scheme: scheme}
-	} else {
-		return fmt.Errorf("no patch data found")
+func addQuotes(value string) bool {
+	if value == "" {
+		return true
 	}
-
-	updated, err := p.Patch(u, logger)
-	if err != nil {
-		return fmt.Errorf("error in applying patch %s", err)
+	// if value is null, then don't add quotes
+	if value == "null" {
+		return false
 	}
-
-	u.SetUnstructuredContent(updated.Object)
-	return nil
+	// if value is a boolean, then don't add quotes
+	if _, err := strconv.ParseBool(value); err == nil {
+		return false
+	}
+	// if value is a json object or array, then don't add quotes.
+	if strings.HasPrefix(value, "{") || strings.HasPrefix(value, "[") {
+		return false
+	}
+	// if value is a number, then don't add quotes
+	if _, err := strconv.ParseFloat(value, 64); err == nil {
+		return false
+	}
+	return true
 }

internal/resourcemodifiers/resource_modifiers_validator.go

@@ -1,18 +1,3 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
 package resourcemodifiers
 
 import (
@@ -24,21 +9,6 @@ func (r *ResourceModifierRule) Validate() error {
 	if err := r.Conditions.Validate(); err != nil {
 		return err
 	}
-
-	count := 0
-	for _, size := range []int{
-		len(r.Patches),
-		len(r.MergePatches),
-		len(r.StrategicPatches),
-	} {
-		if size != 0 {
-			count++
-		}
-		if count >= 2 {
-			return fmt.Errorf("only one of patches, mergePatches, strategicPatches can be specified")
-		}
-	}
-
 	for _, patch := range r.Patches {
 		if err := patch.Validate(); err != nil {
 			return err

internal/resourcemodifiers/resource_modifiers_validator_test.go

@@ -1,18 +1,3 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
 package resourcemodifiers
 
 import (
@@ -129,32 +114,6 @@ func TestResourceModifiers_Validate(t *testing.T) {
 			},
 			wantErr: true,
 		},
-		{
-			name: "More than one patch type in a rule",
-			fields: fields{
-				Version: "v1",
-				ResourceModifierRules: []ResourceModifierRule{
-					{
-						Conditions: Conditions{
-							GroupResource: "*",
-						},
-						Patches: []JSONPatch{
-							{
-								Operation: "test",
-								Path:      "/spec/storageClassName",
-								Value:     "premium",
-							},
-						},
-						MergePatches: []JSONMergePatch{
-							{
-								PatchData: `{"metadata":{"labels":{"a":null}}}`,
-							},
-						},
-					},
-				},
-			},
-			wantErr: true,
-		},
 	}
 
 	for _, tt := range tests {

internal/resourcemodifiers/strategic_merge_patch.go

@@ -1,143 +0,0 @@
-package resourcemodifiers
-
-import (
-	"fmt"
-	"net/http"
-
-	"github.com/sirupsen/logrus"
-	apierrors "k8s.io/apimachinery/pkg/api/errors"
-	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
-	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/apimachinery/pkg/runtime/schema"
-	"k8s.io/apimachinery/pkg/util/mergepatch"
-	"k8s.io/apimachinery/pkg/util/strategicpatch"
-	"k8s.io/apimachinery/pkg/util/validation/field"
-	kubejson "sigs.k8s.io/json"
-	"sigs.k8s.io/yaml"
-)
-
-type StrategicMergePatch struct {
-	PatchData string `json:"patchData,omitempty"`
-}
-
-type StrategicMergePatcher struct {
-	patches []StrategicMergePatch
-	scheme  *runtime.Scheme
-}
-
-func (p *StrategicMergePatcher) Patch(u *unstructured.Unstructured, _ logrus.FieldLogger) (*unstructured.Unstructured, error) {
-	gvk := u.GetObjectKind().GroupVersionKind()
-	schemaReferenceObj, err := p.scheme.New(gvk)
-	if err != nil {
-		return nil, err
-	}
-
-	origin := u.DeepCopy()
-	updated := u.DeepCopy()
-	for _, patch := range p.patches {
-		patchBytes, err := yaml.YAMLToJSON([]byte(patch.PatchData))
-		if err != nil {
-			return nil, fmt.Errorf("error in converting YAML to JSON %s", err)
-		}
-
-		err = strategicPatchObject(origin, patchBytes, updated, schemaReferenceObj)
-		if err != nil {
-			return nil, fmt.Errorf("error in applying Strategic Patch %s", err.Error())
-		}
-
-		origin = updated.DeepCopy()
-	}
-
-	return updated, nil
-}
-
-// strategicPatchObject applies a strategic merge patch of `patchBytes` to
-// `originalObject` and stores the result in `objToUpdate`.
-// It additionally returns the map[string]interface{} representation of the
-// `originalObject` and `patchBytes`.
-// NOTE: Both `originalObject` and `objToUpdate` are supposed to be versioned.
-func strategicPatchObject(
-	originalObject runtime.Object,
-	patchBytes []byte,
-	objToUpdate runtime.Object,
-	schemaReferenceObj runtime.Object,
-) error {
-	originalObjMap, err := runtime.DefaultUnstructuredConverter.ToUnstructured(originalObject)
-	if err != nil {
-		return err
-	}
-
-	patchMap := make(map[string]interface{})
-	var strictErrs []error
-	strictErrs, err = kubejson.UnmarshalStrict(patchBytes, &patchMap)
-	if err != nil {
-		return apierrors.NewBadRequest(err.Error())
-	}
-
-	if err := applyPatchToObject(originalObjMap, patchMap, objToUpdate, schemaReferenceObj, strictErrs); err != nil {
-		return err
-	}
-	return nil
-}
-
-// applyPatchToObject applies a strategic merge patch of <patchMap> to
-// <originalMap> and stores the result in <objToUpdate>.
-// NOTE: <objToUpdate> must be a versioned object.
-func applyPatchToObject(
-	originalMap map[string]interface{},
-	patchMap map[string]interface{},
-	objToUpdate runtime.Object,
-	schemaReferenceObj runtime.Object,
-	strictErrs []error,
-) error {
-	patchedObjMap, err := strategicpatch.StrategicMergeMapPatch(originalMap, patchMap, schemaReferenceObj)
-	if err != nil {
-		return interpretStrategicMergePatchError(err)
-	}
-
-	// Rather than serialize the patched map to JSON, then decode it to an object, we go directly from a map to an object
-	converter := runtime.DefaultUnstructuredConverter
-	if err := converter.FromUnstructuredWithValidation(patchedObjMap, objToUpdate, true); err != nil {
-		strictError, isStrictError := runtime.AsStrictDecodingError(err)
-		switch {
-		case !isStrictError:
-			// disregard any sttrictErrs, because it's an incomplete
-			// list of strict errors given that we don't know what fields were
-			// unknown because StrategicMergeMapPatch failed.
-			// Non-strict errors trump in this case.
-			return apierrors.NewInvalid(schema.GroupKind{}, "", field.ErrorList{
-				field.Invalid(field.NewPath("patch"), fmt.Sprintf("%+v", patchMap), err.Error()),
-			})
-		//case validationDirective == metav1.FieldValidationWarn:
-		//	addStrictDecodingWarnings(requestContext, append(strictErrs, strictError.Errors()...))
-		default:
-			strictDecodingError := runtime.NewStrictDecodingError(append(strictErrs, strictError.Errors()...))
-			return apierrors.NewInvalid(schema.GroupKind{}, "", field.ErrorList{
-				field.Invalid(field.NewPath("patch"), fmt.Sprintf("%+v", patchMap), strictDecodingError.Error()),
-			})
-		}
-	} else if len(strictErrs) > 0 {
-		switch {
-		//case validationDirective == metav1.FieldValidationWarn:
-		//	addStrictDecodingWarnings(requestContext, strictErrs)
-		default:
-			return apierrors.NewInvalid(schema.GroupKind{}, "", field.ErrorList{
-				field.Invalid(field.NewPath("patch"), fmt.Sprintf("%+v", patchMap), runtime.NewStrictDecodingError(strictErrs).Error()),
-			})
-		}
-	}
-
-	return nil
-}
-
-// interpretStrategicMergePatchError interprets the error type and returns an error with appropriate HTTP code.
-func interpretStrategicMergePatchError(err error) error {
-	switch err {
-	case mergepatch.ErrBadJSONDoc, mergepatch.ErrBadPatchFormatForPrimitiveList, mergepatch.ErrBadPatchFormatForRetainKeys, mergepatch.ErrBadPatchFormatForSetElementOrderList, mergepatch.ErrUnsupportedStrategicMergePatchFormat:
-		return apierrors.NewBadRequest(err.Error())
-	case mergepatch.ErrNoListOfLists, mergepatch.ErrPatchContentNotMatchRetainKeys:
-		return apierrors.NewGenericServerResponse(http.StatusUnprocessableEntity, "", schema.GroupResource{}, "", err.Error(), 0, false)
-	default:
-		return err
-	}
-}

internal/resourcemodifiers/strategic_merge_patch_test.go

@@ -1,52 +0,0 @@
-package resourcemodifiers
-
-import (
-	"testing"
-
-	"github.com/sirupsen/logrus"
-	"github.com/stretchr/testify/assert"
-	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
-	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/apimachinery/pkg/runtime/schema"
-	clientgoscheme "k8s.io/client-go/kubernetes/scheme"
-)
-
-func TestStrategicMergePatchFailure(t *testing.T) {
-	tests := []struct {
-		name string
-		data string
-		kind string
-	}{
-		{
-			name: "patch with unknown kind",
-			data: "{}",
-			kind: "BadKind",
-		},
-		{
-			name: "patch with bad yaml",
-			data: "a: b:",
-			kind: "Pod",
-		},
-		{
-			name: "patch with bad json",
-			data: `{"a"::1}`,
-			kind: "Pod",
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			scheme := runtime.NewScheme()
-			err := clientgoscheme.AddToScheme(scheme)
-			assert.NoError(t, err)
-			pt := &StrategicMergePatcher{
-				patches: []StrategicMergePatch{{PatchData: tt.data}},
-				scheme:  scheme,
-			}
-
-			u := &unstructured.Unstructured{}
-			u.SetGroupVersionKind(schema.GroupVersionKind{Version: "v1", Kind: tt.kind})
-			_, err = pt.Patch(u, logrus.New())
-			assert.Error(t, err)
-		})
-	}
-}

internal/resourcepolicies/resource_policies.go

@@ -1,18 +1,3 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
 package resourcepolicies
 
 import (
@@ -85,7 +70,6 @@ func (p *Policies) buildPolicy(resPolicies *resourcePolicies) error {
 		volP.conditions = append(volP.conditions, &storageClassCondition{storageClass: con.StorageClass})
 		volP.conditions = append(volP.conditions, &nfsCondition{nfs: con.NFS})
 		volP.conditions = append(volP.conditions, &csiCondition{csi: con.CSI})
-		volP.conditions = append(volP.conditions, &volumeTypeCondition{volumeTypes: con.VolumeTypes})
 		p.volumePolicies = append(p.volumePolicies, volP)
 	}
 
@@ -148,7 +132,7 @@ func GetResourcePoliciesFromConfig(cm *v1.ConfigMap) (*Policies, error) {
 		return nil, fmt.Errorf("could not parse config from nil configmap")
 	}
 	if len(cm.Data) != 1 {
-		return nil, fmt.Errorf("illegal resource policies %s/%s configmap", cm.Namespace, cm.Name)
+		return nil, fmt.Errorf("illegal resource policies %s/%s configmap", cm.Name, cm.Namespace)
 	}
 
 	var yamlData string

internal/resourcepolicies/resource_policies_test.go

@@ -1,18 +1,3 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
 package resourcepolicies
 
 import (
@@ -370,51 +355,6 @@ volumePolicies:
 			},
 			skip: false,
 		},
-		{
-			name: "match volume by types",
-			yamlData: `version: v1
-volumePolicies:
-- conditions:
-    capacity: "0,100Gi"
-    volumeTypes:
-      - local
-      - hostPath
-  action:
-    type: skip`,
-			vol: &v1.PersistentVolume{
-				Spec: v1.PersistentVolumeSpec{
-					Capacity: v1.ResourceList{
-						v1.ResourceStorage: resource.MustParse("1Gi"),
-					},
-					PersistentVolumeSource: v1.PersistentVolumeSource{
-						HostPath: &v1.HostPathVolumeSource{Path: "/mnt/data"},
-					},
-				},
-			},
-			skip: true,
-		},
-		{
-			name: "dismatch volume by types",
-			yamlData: `version: v1
-volumePolicies:
-- conditions:
-    capacity: "0,100Gi"
-    volumeTypes:
-      - local
-  action:
-    type: skip`,
-			vol: &v1.PersistentVolume{
-				Spec: v1.PersistentVolumeSpec{
-					Capacity: v1.ResourceList{
-						v1.ResourceStorage: resource.MustParse("1Gi"),
-					},
-					PersistentVolumeSource: v1.PersistentVolumeSource{
-						HostPath: &v1.HostPathVolumeSource{Path: "/mnt/data"},
-					},
-				},
-			},
-			skip: false,
-		},
 	}
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {

internal/resourcepolicies/volume_resources.go

@@ -1,18 +1,3 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
 package resourcepolicies
 
 import (
@@ -47,7 +32,6 @@ type structuredVolume struct {
 	storageClass string
 	nfs          *nFSVolumeSource
 	csi          *csiVolumeSource
-	volumeType   SupportedVolume
 }
 
 func (s *structuredVolume) parsePV(pv *corev1api.PersistentVolume) {
@@ -62,8 +46,6 @@ func (s *structuredVolume) parsePV(pv *corev1api.PersistentVolume) {
 	if csi != nil {
 		s.csi = &csiVolumeSource{Driver: csi.Driver}
 	}
-
-	s.volumeType = getVolumeTypeFromPV(pv)
 }
 
 func (s *structuredVolume) parsePodVolume(vol *corev1api.Volume) {
@@ -76,8 +58,6 @@ func (s *structuredVolume) parsePodVolume(vol *corev1api.Volume) {
 	if csi != nil {
 		s.csi = &csiVolumeSource{Driver: csi.Driver}
 	}
-
-	s.volumeType = getVolumeTypeFromVolume(vol)
 }
 
 type capacityCondition struct {

internal/resourcepolicies/volume_resources_test.go

@@ -1,18 +1,3 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
 package resourcepolicies
 
 import (

internal/resourcepolicies/volume_resources_validator.go

@@ -1,18 +1,3 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
 package resourcepolicies
 
 import (
@@ -38,11 +23,10 @@ type nFSVolumeSource struct {
 
 // volumeConditions defined the current format of conditions we parsed
 type volumeConditions struct {
-	Capacity     string            `yaml:"capacity,omitempty"`
-	StorageClass []string          `yaml:"storageClass,omitempty"`
-	NFS          *nFSVolumeSource  `yaml:"nfs,omitempty"`
-	CSI          *csiVolumeSource  `yaml:"csi,omitempty"`
-	VolumeTypes  []SupportedVolume `yaml:"volumeTypes,omitempty"`
+	Capacity     string           `yaml:"capacity,omitempty"`
+	StorageClass []string         `yaml:"storageClass,omitempty"`
+	NFS          *nFSVolumeSource `yaml:"nfs,omitempty"`
+	CSI          *csiVolumeSource `yaml:"csi,omitempty"`
 }
 
 func (c *capacityCondition) validate() error {

internal/resourcepolicies/volume_resources_validator_test.go

@@ -1,18 +1,3 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
 package resourcepolicies
 
 import (

internal/resourcepolicies/volume_types_conditions.go

@@ -1,247 +0,0 @@
-/*
-Copyright the Velero contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package resourcepolicies
-
-import (
-	corev1api "k8s.io/api/core/v1"
-)
-
-type volumeTypeCondition struct {
-	volumeTypes []SupportedVolume
-}
-
-type SupportedVolume string
-
-const (
-	AWSAzureDisk         SupportedVolume = "awsAzureDisk"
-	AWSElasticBlockStore SupportedVolume = "awsElasticBlockStore"
-	AzureDisk            SupportedVolume = "azureDisk"
-	AzureFile            SupportedVolume = "azureFile"
-	Cinder               SupportedVolume = "cinder"
-	CephFS               SupportedVolume = "cephfs"
-	ConfigMap            SupportedVolume = "configMap"
-	CSI                  SupportedVolume = "csi"
-	DownwardAPI          SupportedVolume = "downwardAPI"
-	EmptyDir             SupportedVolume = "emptyDir"
-	Ephemeral            SupportedVolume = "ephemeral"
-	FC                   SupportedVolume = "fc"
-	Flocker              SupportedVolume = "flocker"
-	FlexVolume           SupportedVolume = "flexVolume"
-	GitRepo              SupportedVolume = "gitRepo"
-	Glusterfs            SupportedVolume = "glusterfs"
-	GCEPersistentDisk    SupportedVolume = "gcePersistentDisk"
-	HostPath             SupportedVolume = "hostPath"
-	ISCSI                SupportedVolume = "iscsi"
-	Local                SupportedVolume = "local"
-	NFS                  SupportedVolume = "nfs"
-	PhotonPersistentDisk SupportedVolume = "photonPersistentDisk"
-	PortworxVolume       SupportedVolume = "portworxVolume"
-	Projected            SupportedVolume = "projected"
-	Quobyte              SupportedVolume = "quobyte"
-	RBD                  SupportedVolume = "rbd"
-	ScaleIO              SupportedVolume = "scaleIO"
-	Secret               SupportedVolume = "secret"
-	StorageOS            SupportedVolume = "storageOS"
-	VsphereVolume        SupportedVolume = "vsphereVolume"
-)
-
-func (v *volumeTypeCondition) match(s *structuredVolume) bool {
-	if len(v.volumeTypes) == 0 {
-		return true
-	}
-
-	for _, vt := range v.volumeTypes {
-		if vt == s.volumeType {
-			return true
-		}
-	}
-	return false
-}
-
-func (v *volumeTypeCondition) validate() error {
-	// validate by yamlv3
-	return nil
-}
-
-func getVolumeTypeFromPV(pv *corev1api.PersistentVolume) SupportedVolume {
-	if pv == nil {
-		return ""
-	}
-
-	if pv.Spec.AWSElasticBlockStore != nil {
-		return AWSElasticBlockStore
-	}
-	if pv.Spec.AzureDisk != nil {
-		return AzureDisk
-	}
-	if pv.Spec.AzureFile != nil {
-		return AzureFile
-	}
-	if pv.Spec.CephFS != nil {
-		return CephFS
-	}
-	if pv.Spec.Cinder != nil {
-		return Cinder
-	}
-	if pv.Spec.CSI != nil {
-		return CSI
-	}
-	if pv.Spec.FC != nil {
-		return FC
-	}
-	if pv.Spec.Flocker != nil {
-		return Flocker
-	}
-	if pv.Spec.FlexVolume != nil {
-		return FlexVolume
-	}
-	if pv.Spec.GCEPersistentDisk != nil {
-		return GCEPersistentDisk
-	}
-	if pv.Spec.Glusterfs != nil {
-		return Glusterfs
-	}
-	if pv.Spec.HostPath != nil {
-		return HostPath
-	}
-	if pv.Spec.ISCSI != nil {
-		return ISCSI
-	}
-	if pv.Spec.Local != nil {
-		return Local
-	}
-	if pv.Spec.NFS != nil {
-		return NFS
-	}
-	if pv.Spec.PhotonPersistentDisk != nil {
-		return PhotonPersistentDisk
-	}
-	if pv.Spec.PortworxVolume != nil {
-		return PortworxVolume
-	}
-	if pv.Spec.Quobyte != nil {
-		return Quobyte
-	}
-	if pv.Spec.RBD != nil {
-		return RBD
-	}
-	if pv.Spec.ScaleIO != nil {
-		return ScaleIO
-	}
-	if pv.Spec.StorageOS != nil {
-		return StorageOS
-	}
-	if pv.Spec.VsphereVolume != nil {
-		return VsphereVolume
-	}
-	return ""
-}
-
-func getVolumeTypeFromVolume(vol *corev1api.Volume) SupportedVolume {
-	if vol == nil {
-		return ""
-	}
-
-	if vol.AWSElasticBlockStore != nil {
-		return AWSElasticBlockStore
-	}
-	if vol.AzureDisk != nil {
-		return AzureDisk
-	}
-	if vol.AzureFile != nil {
-		return AzureFile
-	}
-	if vol.CephFS != nil {
-		return CephFS
-	}
-	if vol.Cinder != nil {
-		return Cinder
-	}
-	if vol.CSI != nil {
-		return CSI
-	}
-	if vol.FC != nil {
-		return FC
-	}
-	if vol.Flocker != nil {
-		return Flocker
-	}
-	if vol.FlexVolume != nil {
-		return FlexVolume
-	}
-	if vol.GCEPersistentDisk != nil {
-		return GCEPersistentDisk
-	}
-	if vol.GitRepo != nil {
-		return GitRepo
-	}
-	if vol.Glusterfs != nil {
-		return Glusterfs
-	}
-	if vol.ISCSI != nil {
-		return ISCSI
-	}
-	if vol.NFS != nil {
-		return NFS
-	}
-	if vol.Secret != nil {
-		return Secret
-	}
-	if vol.RBD != nil {
-		return RBD
-	}
-	if vol.DownwardAPI != nil {
-		return DownwardAPI
-	}
-	if vol.ConfigMap != nil {
-		return ConfigMap
-	}
-	if vol.Projected != nil {
-		return Projected
-	}
-	if vol.Ephemeral != nil {
-		return Ephemeral
-	}
-	if vol.FC != nil {
-		return FC
-	}
-	if vol.PhotonPersistentDisk != nil {
-		return PhotonPersistentDisk
-	}
-	if vol.PortworxVolume != nil {
-		return PortworxVolume
-	}
-	if vol.Quobyte != nil {
-		return Quobyte
-	}
-	if vol.ScaleIO != nil {
-		return ScaleIO
-	}
-	if vol.StorageOS != nil {
-		return StorageOS
-	}
-	if vol.VsphereVolume != nil {
-		return VsphereVolume
-	}
-	if vol.HostPath != nil {
-		return HostPath
-	}
-	if vol.EmptyDir != nil {
-		return EmptyDir
-	}
-	return ""
-}

internal/resourcepolicies/volume_types_conditions_test.go

@@ -1,576 +0,0 @@
-/*
-Copyright the Velero contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-package resourcepolicies
-
-import (
-	"testing"
-
-	corev1api "k8s.io/api/core/v1"
-)
-
-func TestGetVolumeTypeFromPV(t *testing.T) {
-	testCases := []struct {
-		name     string
-		inputPV  *corev1api.PersistentVolume
-		expected SupportedVolume
-	}{
-		{
-			name:     "nil PersistentVolume",
-			inputPV:  nil,
-			expected: "",
-		},
-		{
-			name: "Test GCEPersistentDisk",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						GCEPersistentDisk: &corev1api.GCEPersistentDiskVolumeSource{},
-					},
-				},
-			},
-			expected: GCEPersistentDisk,
-		},
-		{
-			name: "Test AWSElasticBlockStore",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						AWSElasticBlockStore: &corev1api.AWSElasticBlockStoreVolumeSource{},
-					},
-				},
-			},
-			expected: AWSElasticBlockStore,
-		},
-		{
-			name: "Test HostPath",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						HostPath: &corev1api.HostPathVolumeSource{},
-					},
-				},
-			},
-			expected: HostPath,
-		},
-		{
-			name: "Test Glusterfs",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						Glusterfs: &corev1api.GlusterfsPersistentVolumeSource{},
-					},
-				},
-			},
-			expected: Glusterfs,
-		},
-		{
-			name: "Test NFS",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						NFS: &corev1api.NFSVolumeSource{},
-					},
-				},
-			},
-			expected: NFS,
-		},
-		{
-			name: "Test RBD",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						RBD: &corev1api.RBDPersistentVolumeSource{},
-					},
-				},
-			},
-			expected: RBD,
-		},
-		{
-			name: "Test ISCSI",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						ISCSI: &corev1api.ISCSIPersistentVolumeSource{},
-					},
-				},
-			},
-			expected: ISCSI,
-		},
-		{
-			name: "Test Cinder",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						Cinder: &corev1api.CinderPersistentVolumeSource{},
-					},
-				},
-			},
-			expected: Cinder,
-		},
-		{
-			name: "Test CephFS",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						CephFS: &corev1api.CephFSPersistentVolumeSource{},
-					},
-				},
-			},
-			expected: CephFS,
-		},
-		{
-			name: "Test FC",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						FC: &corev1api.FCVolumeSource{},
-					},
-				},
-			},
-			expected: FC,
-		},
-		{
-			name: "Test Flocker",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						Flocker: &corev1api.FlockerVolumeSource{},
-					},
-				},
-			},
-			expected: Flocker,
-		},
-		{
-			name: "Test FlexVolume",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						FlexVolume: &corev1api.FlexPersistentVolumeSource{},
-					},
-				},
-			},
-			expected: FlexVolume,
-		},
-		{
-			name: "Test AzureFile",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						AzureFile: &corev1api.AzureFilePersistentVolumeSource{},
-					},
-				},
-			},
-			expected: AzureFile,
-		},
-		{
-			name: "Test VsphereVolume",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						VsphereVolume: &corev1api.VsphereVirtualDiskVolumeSource{},
-					},
-				},
-			},
-			expected: VsphereVolume,
-		},
-		{
-			name: "Test Quobyte",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						Quobyte: &corev1api.QuobyteVolumeSource{},
-					},
-				},
-			},
-			expected: Quobyte,
-		},
-		{
-			name: "Test AzureDisk",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						AzureDisk: &corev1api.AzureDiskVolumeSource{},
-					},
-				},
-			},
-			expected: AzureDisk,
-		},
-		{
-			name: "Test PhotonPersistentDisk",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						PhotonPersistentDisk: &corev1api.PhotonPersistentDiskVolumeSource{},
-					},
-				},
-			},
-			expected: PhotonPersistentDisk,
-		},
-		{
-			name: "Test PortworxVolume",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						PortworxVolume: &corev1api.PortworxVolumeSource{},
-					},
-				},
-			},
-			expected: PortworxVolume,
-		},
-		{
-			name: "Test ScaleIO",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						ScaleIO: &corev1api.ScaleIOPersistentVolumeSource{},
-					},
-				},
-			},
-			expected: ScaleIO,
-		},
-		{
-			name: "Test Local",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						Local: &corev1api.LocalVolumeSource{},
-					},
-				},
-			},
-			expected: Local,
-		},
-		{
-			name: "Test StorageOS",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						StorageOS: &corev1api.StorageOSPersistentVolumeSource{},
-					},
-				},
-			},
-			expected: StorageOS,
-		},
-		{
-			name: "Test CSI",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{
-					PersistentVolumeSource: corev1api.PersistentVolumeSource{
-						CSI: &corev1api.CSIPersistentVolumeSource{},
-					},
-				},
-			},
-			expected: CSI,
-		},
-		{
-			name: "Test Unknown Source",
-			inputPV: &corev1api.PersistentVolume{
-				Spec: corev1api.PersistentVolumeSpec{},
-			},
-			expected: "",
-		},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			result := getVolumeTypeFromPV(tc.inputPV)
-			if result != tc.expected {
-				t.Errorf("Expected %s, but got %s", tc.expected, result)
-			}
-		})
-	}
-}
-
-func TestGetVolumeTypeFromVolume(t *testing.T) {
-	testCases := []struct {
-		name     string
-		inputVol *corev1api.Volume
-		expected SupportedVolume
-	}{
-		{
-			name:     "nil Volume",
-			inputVol: nil,
-			expected: "",
-		},
-		{
-			name: "Test Unknown Source",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{},
-			},
-			expected: "",
-		},
-		{
-			name: "Test HostPath",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					HostPath: &corev1api.HostPathVolumeSource{},
-				},
-			},
-			expected: HostPath,
-		},
-		{
-			name: "Test EmptyDir",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					EmptyDir: &corev1api.EmptyDirVolumeSource{},
-				},
-			},
-			expected: EmptyDir,
-		},
-		{
-			name: "Test GCEPersistentDisk",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					GCEPersistentDisk: &corev1api.GCEPersistentDiskVolumeSource{},
-				},
-			},
-			expected: GCEPersistentDisk,
-		},
-		{
-			name: "Test AWSElasticBlockStore",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					AWSElasticBlockStore: &corev1api.AWSElasticBlockStoreVolumeSource{},
-				},
-			},
-			expected: AWSElasticBlockStore,
-		},
-		{
-			name: "Test GitRepo",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					GitRepo: &corev1api.GitRepoVolumeSource{},
-				},
-			},
-			expected: GitRepo,
-		},
-		{
-			name: "Test Secret",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					Secret: &corev1api.SecretVolumeSource{},
-				},
-			},
-			expected: Secret,
-		},
-		{
-			name: "Test NFS",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					NFS: &corev1api.NFSVolumeSource{},
-				},
-			},
-			expected: NFS,
-		},
-		{
-			name: "Test ISCSI",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					ISCSI: &corev1api.ISCSIVolumeSource{},
-				},
-			},
-			expected: ISCSI,
-		},
-		{
-			name: "Test Glusterfs",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					Glusterfs: &corev1api.GlusterfsVolumeSource{},
-				},
-			},
-			expected: Glusterfs,
-		},
-		{
-			name: "Test RBD",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					RBD: &corev1api.RBDVolumeSource{},
-				},
-			},
-			expected: RBD,
-		},
-		{
-			name: "Test FlexVolume",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					FlexVolume: &corev1api.FlexVolumeSource{},
-				},
-			},
-			expected: FlexVolume,
-		},
-		{
-			name: "Test Cinder",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					Cinder: &corev1api.CinderVolumeSource{},
-				},
-			},
-			expected: Cinder,
-		},
-		{
-			name: "Test CephFS",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					CephFS: &corev1api.CephFSVolumeSource{},
-				},
-			},
-			expected: CephFS,
-		},
-		{
-			name: "Test Flocker",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					Flocker: &corev1api.FlockerVolumeSource{},
-				},
-			},
-			expected: Flocker,
-		},
-		{
-			name: "Test DownwardAPI",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					DownwardAPI: &corev1api.DownwardAPIVolumeSource{},
-				},
-			},
-			expected: DownwardAPI,
-		},
-		{
-			name: "Test FC",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					FC: &corev1api.FCVolumeSource{},
-				},
-			},
-			expected: FC,
-		},
-		{
-			name: "Test AzureFile",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					AzureFile: &corev1api.AzureFileVolumeSource{},
-				},
-			},
-			expected: AzureFile,
-		},
-		{
-			name: "Test ConfigMap",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					ConfigMap: &corev1api.ConfigMapVolumeSource{},
-				},
-			},
-			expected: ConfigMap,
-		},
-		{
-			name: "Test VsphereVolume",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					VsphereVolume: &corev1api.VsphereVirtualDiskVolumeSource{},
-				},
-			},
-			expected: VsphereVolume,
-		},
-		{
-			name: "Test Quobyte",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					Quobyte: &corev1api.QuobyteVolumeSource{},
-				},
-			},
-			expected: Quobyte,
-		},
-		{
-			name: "Test AzureDisk",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					AzureDisk: &corev1api.AzureDiskVolumeSource{},
-				},
-			},
-			expected: AzureDisk,
-		},
-		{
-			name: "Test PhotonPersistentDisk",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					PhotonPersistentDisk: &corev1api.PhotonPersistentDiskVolumeSource{},
-				},
-			},
-			expected: PhotonPersistentDisk,
-		},
-		{
-			name: "Test Projected",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					Projected: &corev1api.ProjectedVolumeSource{},
-				},
-			},
-			expected: Projected,
-		},
-		{
-			name: "Test PortworxVolume",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					PortworxVolume: &corev1api.PortworxVolumeSource{},
-				},
-			},
-			expected: PortworxVolume,
-		},
-		{
-			name: "Test ScaleIO",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					ScaleIO: &corev1api.ScaleIOVolumeSource{},
-				},
-			},
-			expected: ScaleIO,
-		},
-		{
-			name: "Test StorageOS",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					StorageOS: &corev1api.StorageOSVolumeSource{},
-				},
-			},
-			expected: StorageOS,
-		},
-		{
-			name: "Test CSI",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					CSI: &corev1api.CSIVolumeSource{},
-				},
-			},
-			expected: CSI,
-		},
-		{
-			name: "Test Ephemeral",
-			inputVol: &corev1api.Volume{
-				VolumeSource: corev1api.VolumeSource{
-					Ephemeral: &corev1api.EphemeralVolumeSource{},
-				},
-			},
-			expected: Ephemeral,
-		},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			result := getVolumeTypeFromVolume(tc.inputVol)
-			if result != tc.expected {
-				t.Errorf("Expected %s, but got %s", tc.expected, result)
-			}
-		})
-	}
-}

internal/storage/storagelocation.go

@@ -18,7 +18,6 @@ package storage
 
 import (
 	"context"
-	"fmt"
 	"time"
 
 	"github.com/pkg/errors"
@@ -93,18 +92,3 @@ func ListBackupStorageLocations(ctx context.Context, kbClient client.Client, nam
 
 	return locations, nil
 }
-
-func GetDefaultBackupStorageLocations(ctx context.Context, kbClient client.Client, namespace string) (*velerov1api.BackupStorageLocationList, error) {
-	locations := new(velerov1api.BackupStorageLocationList)
-	defaultLocations := new(velerov1api.BackupStorageLocationList)
-	if err := kbClient.List(context.Background(), locations, &client.ListOptions{Namespace: namespace}); err != nil {
-		return defaultLocations, errors.Wrapf(err, fmt.Sprintf("failed to list backup storage locations in namespace %s", namespace))
-	}
-
-	for _, location := range locations.Items {
-		if location.Spec.Default {
-			defaultLocations.Items = append(defaultLocations.Items, location)
-		}
-	}
-	return defaultLocations, nil
-}

internal/storage/storagelocation_test.go

@@ -26,8 +26,8 @@ import (
 
 	velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
 	"github.com/vmware-tanzu/velero/pkg/builder"
+	"github.com/vmware-tanzu/velero/pkg/generated/clientset/versioned/scheme"
 	velerotest "github.com/vmware-tanzu/velero/pkg/test"
-	"github.com/vmware-tanzu/velero/pkg/util"
 )
 
 func TestIsReadyToValidate(t *testing.T) {
@@ -163,7 +163,7 @@ func TestListBackupStorageLocations(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			g := NewWithT(t)
 
-			client := fake.NewClientBuilder().WithScheme(util.VeleroScheme).WithRuntimeObjects(tt.backupLocations).Build()
+			client := fake.NewClientBuilder().WithScheme(scheme.Scheme).WithRuntimeObjects(tt.backupLocations).Build()
 			if tt.expectError {
 				_, err := ListBackupStorageLocations(context.Background(), client, "ns-1")
 				g.Expect(err).NotTo(BeNil())

internal/util/managercontroller/managercontroller.go

@@ -0,0 +1,37 @@
+/*
+Copyright 2020 the Velero contributors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+// TODO(2.0) After converting all controllers to runtime-controller,
+// the functions in this file will no longer be needed and should be removed.
+package managercontroller
+
+import (
+	"context"
+
+	"sigs.k8s.io/controller-runtime/pkg/manager"
+
+	"github.com/vmware-tanzu/velero/pkg/controller"
+)
+
+// Runnable will turn a "regular" runnable component (such as a controller)
+// into a controller-runtime Runnable
+func Runnable(p controller.Interface, numWorkers int) manager.Runnable {
+	// Pass the provided Context down to the run function.
+	f := func(ctx context.Context) error {
+		return p.Run(ctx, numWorkers)
+	}
+	return manager.RunnableFunc(f)
+}

internal/volume/volumes_information.go

@@ -1,571 +0,0 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package volume
-
-import (
-	"context"
-	"strconv"
-
-	snapshotv1api "github.com/kubernetes-csi/external-snapshotter/client/v4/apis/volumesnapshot/v1"
-	"github.com/sirupsen/logrus"
-	corev1api "k8s.io/api/core/v1"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	kbclient "sigs.k8s.io/controller-runtime/pkg/client"
-
-	velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
-	velerov2alpha1 "github.com/vmware-tanzu/velero/pkg/apis/velero/v2alpha1"
-	"github.com/vmware-tanzu/velero/pkg/itemoperation"
-	"github.com/vmware-tanzu/velero/pkg/kuberesource"
-	"github.com/vmware-tanzu/velero/pkg/plugin/velero"
-	"github.com/vmware-tanzu/velero/pkg/volume"
-)
-
-type VolumeBackupMethod string
-
-const (
-	NativeSnapshot  VolumeBackupMethod = "NativeSnapshot"
-	PodVolumeBackup VolumeBackupMethod = "PodVolumeBackup"
-	CSISnapshot     VolumeBackupMethod = "CSISnapshot"
-)
-
-const (
-	FieldValueIsUnknown string = "unknown"
-)
-
-type VolumeInfo struct {
-	// The PVC's name.
-	PVCName string `json:"pvcName,omitempty"`
-
-	// The PVC's namespace
-	PVCNamespace string `json:"pvcNamespace,omitempty"`
-
-	// The PV name.
-	PVName string `json:"pvName,omitempty"`
-
-	// The way the volume data is backed up. The valid value includes `VeleroNativeSnapshot`, `PodVolumeBackup` and `CSISnapshot`.
-	BackupMethod VolumeBackupMethod `json:"backupMethod,omitempty"`
-
-	// Whether the volume's snapshot data is moved to specified storage.
-	SnapshotDataMoved bool `json:"snapshotDataMoved"`
-
-	// Whether the local snapshot is preserved after snapshot is moved.
-	// The local snapshot may be a result of CSI snapshot backup(no data movement)
-	// or a CSI snapshot data movement plus preserve local snapshot.
-	PreserveLocalSnapshot bool `json:"preserveLocalSnapshot"`
-
-	// Whether the Volume is skipped in this backup.
-	Skipped bool `json:"skipped"`
-
-	// The reason for the volume is skipped in the backup.
-	SkippedReason string `json:"skippedReason,omitempty"`
-
-	// Snapshot starts timestamp.
-	StartTimestamp *metav1.Time `json:"startTimestamp,omitempty"`
-
-	CSISnapshotInfo          *CSISnapshotInfo          `json:"csiSnapshotInfo,omitempty"`
-	SnapshotDataMovementInfo *SnapshotDataMovementInfo `json:"snapshotDataMovementInfo,omitempty"`
-	NativeSnapshotInfo       *NativeSnapshotInfo       `json:"nativeSnapshotInfo,omitempty"`
-	PVBInfo                  *PodVolumeBackupInfo      `json:"pvbInfo,omitempty"`
-	PVInfo                   *PVInfo                   `json:"pvInfo,omitempty"`
-}
-
-// CSISnapshotInfo is used for displaying the CSI snapshot status
-type CSISnapshotInfo struct {
-	// It's the storage provider's snapshot ID for CSI.
-	SnapshotHandle string `json:"snapshotHandle"`
-
-	// The snapshot corresponding volume size.
-	Size int64 `json:"size"`
-
-	// The name of the CSI driver.
-	Driver string `json:"driver"`
-
-	// The name of the VolumeSnapshotContent.
-	VSCName string `json:"vscName"`
-
-	// The Async Operation's ID.
-	OperationID string `json:"operationID"`
-}
-
-// SnapshotDataMovementInfo is used for displaying the snapshot data mover status.
-type SnapshotDataMovementInfo struct {
-	// The data mover used by the backup. The valid values are `velero` and ``(equals to `velero`).
-	DataMover string `json:"dataMover"`
-
-	// The type of the uploader that uploads the snapshot data. The valid values are `kopia` and `restic`.
-	UploaderType string `json:"uploaderType"`
-
-	// The name or ID of the snapshot associated object(SAO).
-	// SAO is used to support local snapshots for the snapshot data mover,
-	// e.g. it could be a VolumeSnapshot for CSI snapshot data movement.
-	RetainedSnapshot string `json:"retainedSnapshot"`
-
-	// It's the filesystem repository's snapshot ID.
-	SnapshotHandle string `json:"snapshotHandle"`
-
-	// The Async Operation's ID.
-	OperationID string `json:"operationID"`
-}
-
-// NativeSnapshotInfo is used for displaying the Velero native snapshot status.
-// A Velero Native Snapshot is a cloud storage snapshot taken by the Velero native
-// plugins, e.g. velero-plugin-for-aws, velero-plugin-for-gcp, and
-// velero-plugin-for-microsoft-azure.
-type NativeSnapshotInfo struct {
-	// It's the storage provider's snapshot ID for the Velero-native snapshot.
-	SnapshotHandle string `json:"snapshotHandle"`
-
-	// The cloud provider snapshot volume type.
-	VolumeType string `json:"volumeType"`
-
-	// The cloud provider snapshot volume's availability zones.
-	VolumeAZ string `json:"volumeAZ"`
-
-	// The cloud provider snapshot volume's IOPS.
-	IOPS string `json:"iops"`
-}
-
-// PodVolumeBackupInfo is used for displaying the PodVolumeBackup snapshot status.
-type PodVolumeBackupInfo struct {
-	// It's the file-system uploader's snapshot ID for PodVolumeBackup.
-	SnapshotHandle string `json:"snapshotHandle"`
-
-	// The snapshot corresponding volume size.
-	Size int64 `json:"size"`
-
-	// The type of the uploader that uploads the data. The valid values are `kopia` and `restic`.
-	UploaderType string `json:"uploaderType"`
-
-	// The PVC's corresponding volume name used by Pod
-	// https://github.com/kubernetes/kubernetes/blob/e4b74dd12fa8cb63c174091d5536a10b8ec19d34/pkg/apis/core/types.go#L48
-	VolumeName string `json:"volumeName"`
-
-	// The Pod name mounting this PVC.
-	PodName string `json:"podName"`
-
-	// The Pod namespace
-	PodNamespace string `json:"podNamespace"`
-
-	// The PVB-taken k8s node's name.
-	NodeName string `json:"nodeName"`
-}
-
-// PVInfo is used to store some PV information modified after creation.
-// Those information are lost after PV recreation.
-type PVInfo struct {
-	// ReclaimPolicy of PV. It could be different from the referenced StorageClass.
-	ReclaimPolicy string `json:"reclaimPolicy"`
-
-	// The PV's labels should be kept after recreation.
-	Labels map[string]string `json:"labels"`
-}
-
-// VolumesInformation contains the information needs by generating
-// the backup VolumeInfo array.
-type VolumesInformation struct {
-	// A map contains the backup-included PV detail content. The key is PV name.
-	pvMap       map[string]pvcPvInfo
-	volumeInfos []*VolumeInfo
-
-	logger                 logrus.FieldLogger
-	crClient               kbclient.Client
-	volumeSnapshots        []snapshotv1api.VolumeSnapshot
-	volumeSnapshotContents []snapshotv1api.VolumeSnapshotContent
-	volumeSnapshotClasses  []snapshotv1api.VolumeSnapshotClass
-	SkippedPVs             map[string]string
-	NativeSnapshots        []*volume.Snapshot
-	PodVolumeBackups       []*velerov1api.PodVolumeBackup
-	BackupOperations       []*itemoperation.BackupOperation
-	BackupName             string
-}
-
-type pvcPvInfo struct {
-	PVCName      string
-	PVCNamespace string
-	PV           corev1api.PersistentVolume
-}
-
-func (v *VolumesInformation) Init() {
-	v.pvMap = make(map[string]pvcPvInfo)
-	v.volumeInfos = make([]*VolumeInfo, 0)
-}
-
-func (v *VolumesInformation) InsertPVMap(pv corev1api.PersistentVolume, pvcName, pvcNamespace string) {
-	if v.pvMap == nil {
-		v.Init()
-	}
-
-	v.pvMap[pv.Name] = pvcPvInfo{
-		PVCName:      pvcName,
-		PVCNamespace: pvcNamespace,
-		PV:           pv,
-	}
-}
-
-func (v *VolumesInformation) Result(
-	csiVolumeSnapshots []snapshotv1api.VolumeSnapshot,
-	csiVolumeSnapshotContents []snapshotv1api.VolumeSnapshotContent,
-	csiVolumesnapshotClasses []snapshotv1api.VolumeSnapshotClass,
-	crClient kbclient.Client,
-	logger logrus.FieldLogger,
-) []*VolumeInfo {
-	v.logger = logger
-	v.crClient = crClient
-	v.volumeSnapshots = csiVolumeSnapshots
-	v.volumeSnapshotContents = csiVolumeSnapshotContents
-	v.volumeSnapshotClasses = csiVolumesnapshotClasses
-
-	v.generateVolumeInfoForSkippedPV()
-	v.generateVolumeInfoForVeleroNativeSnapshot()
-	v.generateVolumeInfoForCSIVolumeSnapshot()
-	v.generateVolumeInfoFromPVB()
-	v.generateVolumeInfoFromDataUpload()
-
-	return v.volumeInfos
-}
-
-// generateVolumeInfoForSkippedPV generate VolumeInfos for SkippedPV.
-func (v *VolumesInformation) generateVolumeInfoForSkippedPV() {
-	tmpVolumeInfos := make([]*VolumeInfo, 0)
-
-	for pvName, skippedReason := range v.SkippedPVs {
-		if pvcPVInfo := v.retrievePvcPvInfo(pvName, "", ""); pvcPVInfo != nil {
-			volumeInfo := &VolumeInfo{
-				PVCName:           pvcPVInfo.PVCName,
-				PVCNamespace:      pvcPVInfo.PVCNamespace,
-				PVName:            pvName,
-				SnapshotDataMoved: false,
-				Skipped:           true,
-				SkippedReason:     skippedReason,
-				PVInfo: &PVInfo{
-					ReclaimPolicy: string(pvcPVInfo.PV.Spec.PersistentVolumeReclaimPolicy),
-					Labels:        pvcPVInfo.PV.Labels,
-				},
-			}
-			tmpVolumeInfos = append(tmpVolumeInfos, volumeInfo)
-		} else {
-			v.logger.Warnf("Cannot find info for PV %s", pvName)
-			continue
-		}
-	}
-
-	v.volumeInfos = append(v.volumeInfos, tmpVolumeInfos...)
-}
-
-// generateVolumeInfoForVeleroNativeSnapshot generate VolumeInfos for Velero native snapshot
-func (v *VolumesInformation) generateVolumeInfoForVeleroNativeSnapshot() {
-	tmpVolumeInfos := make([]*VolumeInfo, 0)
-
-	for _, nativeSnapshot := range v.NativeSnapshots {
-		var iops int64
-		if nativeSnapshot.Spec.VolumeIOPS != nil {
-			iops = *nativeSnapshot.Spec.VolumeIOPS
-		}
-
-		if pvcPVInfo := v.retrievePvcPvInfo(nativeSnapshot.Spec.PersistentVolumeName, "", ""); pvcPVInfo != nil {
-			volumeInfo := &VolumeInfo{
-				BackupMethod:      NativeSnapshot,
-				PVCName:           pvcPVInfo.PVCName,
-				PVCNamespace:      pvcPVInfo.PVCNamespace,
-				PVName:            pvcPVInfo.PV.Name,
-				SnapshotDataMoved: false,
-				Skipped:           false,
-				NativeSnapshotInfo: &NativeSnapshotInfo{
-					SnapshotHandle: nativeSnapshot.Status.ProviderSnapshotID,
-					VolumeType:     nativeSnapshot.Spec.VolumeType,
-					VolumeAZ:       nativeSnapshot.Spec.VolumeAZ,
-					IOPS:           strconv.FormatInt(iops, 10),
-				},
-				PVInfo: &PVInfo{
-					ReclaimPolicy: string(pvcPVInfo.PV.Spec.PersistentVolumeReclaimPolicy),
-					Labels:        pvcPVInfo.PV.Labels,
-				},
-			}
-
-			tmpVolumeInfos = append(tmpVolumeInfos, volumeInfo)
-		} else {
-			v.logger.Warnf("cannot find info for PV %s", nativeSnapshot.Spec.PersistentVolumeName)
-			continue
-		}
-	}
-
-	v.volumeInfos = append(v.volumeInfos, tmpVolumeInfos...)
-}
-
-// generateVolumeInfoForCSIVolumeSnapshot generate VolumeInfos for CSI VolumeSnapshot
-func (v *VolumesInformation) generateVolumeInfoForCSIVolumeSnapshot() {
-	tmpVolumeInfos := make([]*VolumeInfo, 0)
-
-	for _, volumeSnapshot := range v.volumeSnapshots {
-		var volumeSnapshotClass *snapshotv1api.VolumeSnapshotClass
-		var volumeSnapshotContent *snapshotv1api.VolumeSnapshotContent
-
-		// This is protective logic. The passed-in VS should be all related
-		// to this backup.
-		if volumeSnapshot.Labels[velerov1api.BackupNameLabel] != v.BackupName {
-			continue
-		}
-
-		if volumeSnapshot.Spec.VolumeSnapshotClassName == nil {
-			v.logger.Warnf("Cannot find VolumeSnapshotClass for VolumeSnapshot %s/%s", volumeSnapshot.Namespace, volumeSnapshot.Name)
-			continue
-		}
-
-		if volumeSnapshot.Status == nil || volumeSnapshot.Status.BoundVolumeSnapshotContentName == nil {
-			v.logger.Warnf("Cannot fine VolumeSnapshotContent for VolumeSnapshot %s/%s", volumeSnapshot.Namespace, volumeSnapshot.Name)
-			continue
-		}
-
-		if volumeSnapshot.Spec.Source.PersistentVolumeClaimName == nil {
-			v.logger.Warnf("VolumeSnapshot %s/%s doesn't have a source PVC", volumeSnapshot.Namespace, volumeSnapshot.Name)
-			continue
-		}
-
-		for index := range v.volumeSnapshotClasses {
-			if *volumeSnapshot.Spec.VolumeSnapshotClassName == v.volumeSnapshotClasses[index].Name {
-				volumeSnapshotClass = &v.volumeSnapshotClasses[index]
-			}
-		}
-
-		for index := range v.volumeSnapshotContents {
-			if *volumeSnapshot.Status.BoundVolumeSnapshotContentName == v.volumeSnapshotContents[index].Name {
-				volumeSnapshotContent = &v.volumeSnapshotContents[index]
-			}
-		}
-
-		if volumeSnapshotClass == nil || volumeSnapshotContent == nil {
-			v.logger.Warnf("fail to get VolumeSnapshotContent or VolumeSnapshotClass for VolumeSnapshot: %s/%s",
-				volumeSnapshot.Namespace, volumeSnapshot.Name)
-			continue
-		}
-
-		var operation itemoperation.BackupOperation
-		for _, op := range v.BackupOperations {
-			if op.Spec.ResourceIdentifier.GroupResource.String() == kuberesource.VolumeSnapshots.String() &&
-				op.Spec.ResourceIdentifier.Name == volumeSnapshot.Name &&
-				op.Spec.ResourceIdentifier.Namespace == volumeSnapshot.Namespace {
-				operation = *op
-			}
-		}
-
-		var size int64
-		if volumeSnapshot.Status.RestoreSize != nil {
-			size = volumeSnapshot.Status.RestoreSize.Value()
-		}
-		snapshotHandle := ""
-		if volumeSnapshotContent.Status.SnapshotHandle != nil {
-			snapshotHandle = *volumeSnapshotContent.Status.SnapshotHandle
-		}
-		if pvcPVInfo := v.retrievePvcPvInfo("", *volumeSnapshot.Spec.Source.PersistentVolumeClaimName, volumeSnapshot.Namespace); pvcPVInfo != nil {
-			volumeInfo := &VolumeInfo{
-				BackupMethod:          CSISnapshot,
-				PVCName:               pvcPVInfo.PVCName,
-				PVCNamespace:          pvcPVInfo.PVCNamespace,
-				PVName:                pvcPVInfo.PV.Name,
-				Skipped:               false,
-				SnapshotDataMoved:     false,
-				PreserveLocalSnapshot: true,
-				StartTimestamp:        &(volumeSnapshot.CreationTimestamp),
-				CSISnapshotInfo: &CSISnapshotInfo{
-					VSCName:        *volumeSnapshot.Status.BoundVolumeSnapshotContentName,
-					Size:           size,
-					Driver:         volumeSnapshotClass.Driver,
-					SnapshotHandle: snapshotHandle,
-					OperationID:    operation.Spec.OperationID,
-				},
-				PVInfo: &PVInfo{
-					ReclaimPolicy: string(pvcPVInfo.PV.Spec.PersistentVolumeReclaimPolicy),
-					Labels:        pvcPVInfo.PV.Labels,
-				},
-			}
-
-			tmpVolumeInfos = append(tmpVolumeInfos, volumeInfo)
-		} else {
-			v.logger.Warnf("cannot find info for PVC %s/%s", volumeSnapshot.Namespace, volumeSnapshot.Spec.Source.PersistentVolumeClaimName)
-			continue
-		}
-	}
-
-	v.volumeInfos = append(v.volumeInfos, tmpVolumeInfos...)
-}
-
-// generateVolumeInfoFromPVB generate VolumeInfo for PVB.
-func (v *VolumesInformation) generateVolumeInfoFromPVB() {
-	tmpVolumeInfos := make([]*VolumeInfo, 0)
-
-	for _, pvb := range v.PodVolumeBackups {
-		volumeInfo := &VolumeInfo{
-			BackupMethod:      PodVolumeBackup,
-			SnapshotDataMoved: false,
-			Skipped:           false,
-			StartTimestamp:    pvb.Status.StartTimestamp,
-			PVBInfo: &PodVolumeBackupInfo{
-				SnapshotHandle: pvb.Status.SnapshotID,
-				Size:           pvb.Status.Progress.TotalBytes,
-				UploaderType:   pvb.Spec.UploaderType,
-				VolumeName:     pvb.Spec.Volume,
-				PodName:        pvb.Spec.Pod.Name,
-				PodNamespace:   pvb.Spec.Pod.Namespace,
-				NodeName:       pvb.Spec.Node,
-			},
-		}
-
-		pod := new(corev1api.Pod)
-		pvcName := ""
-		err := v.crClient.Get(context.TODO(), kbclient.ObjectKey{Namespace: pvb.Spec.Pod.Namespace, Name: pvb.Spec.Pod.Name}, pod)
-		if err != nil {
-			v.logger.WithError(err).Warn("Fail to get pod for PodVolumeBackup: ", pvb.Name)
-			continue
-		}
-		for _, volume := range pod.Spec.Volumes {
-			if volume.Name == pvb.Spec.Volume && volume.PersistentVolumeClaim != nil {
-				pvcName = volume.PersistentVolumeClaim.ClaimName
-			}
-		}
-
-		if pvcName != "" {
-			if pvcPVInfo := v.retrievePvcPvInfo("", pvcName, pod.Namespace); pvcPVInfo != nil {
-				volumeInfo.PVCName = pvcPVInfo.PVCName
-				volumeInfo.PVCNamespace = pvcPVInfo.PVCNamespace
-				volumeInfo.PVName = pvcPVInfo.PV.Name
-				volumeInfo.PVInfo = &PVInfo{
-					ReclaimPolicy: string(pvcPVInfo.PV.Spec.PersistentVolumeReclaimPolicy),
-					Labels:        pvcPVInfo.PV.Labels,
-				}
-			} else {
-				v.logger.Warnf("Cannot find info for PVC %s/%s", pod.Namespace, pvcName)
-				continue
-			}
-		} else {
-			v.logger.Debug("The PVB %s doesn't have a corresponding PVC", pvb.Name)
-		}
-
-		tmpVolumeInfos = append(tmpVolumeInfos, volumeInfo)
-	}
-
-	v.volumeInfos = append(v.volumeInfos, tmpVolumeInfos...)
-}
-
-// generateVolumeInfoFromDataUpload generate VolumeInfo for DataUpload.
-func (v *VolumesInformation) generateVolumeInfoFromDataUpload() {
-	tmpVolumeInfos := make([]*VolumeInfo, 0)
-	vsClassList := new(snapshotv1api.VolumeSnapshotClassList)
-	if err := v.crClient.List(context.TODO(), vsClassList); err != nil {
-		v.logger.WithError(err).Errorf("cannot list VolumeSnapshotClass %s", err.Error())
-		return
-	}
-
-	for _, operation := range v.BackupOperations {
-		if operation.Spec.ResourceIdentifier.GroupResource.String() == kuberesource.PersistentVolumeClaims.String() {
-			var duIdentifier velero.ResourceIdentifier
-
-			for _, identifier := range operation.Spec.PostOperationItems {
-				if identifier.GroupResource.String() == "datauploads.velero.io" {
-					duIdentifier = identifier
-				}
-			}
-			if duIdentifier.Empty() {
-				v.logger.Warnf("cannot find DataUpload for PVC %s/%s backup async operation",
-					operation.Spec.ResourceIdentifier.Namespace, operation.Spec.ResourceIdentifier.Name)
-				continue
-			}
-
-			dataUpload := new(velerov2alpha1.DataUpload)
-			err := v.crClient.Get(
-				context.TODO(),
-				kbclient.ObjectKey{
-					Namespace: duIdentifier.Namespace,
-					Name:      duIdentifier.Name},
-				dataUpload,
-			)
-			if err != nil {
-				v.logger.Warnf("fail to get DataUpload for operation %s: %s", operation.Spec.OperationID, err.Error())
-				continue
-			}
-
-			driverUsedByVSClass := ""
-			for index := range vsClassList.Items {
-				if vsClassList.Items[index].Name == dataUpload.Spec.CSISnapshot.SnapshotClass {
-					driverUsedByVSClass = vsClassList.Items[index].Driver
-				}
-			}
-
-			if pvcPVInfo := v.retrievePvcPvInfo("", operation.Spec.ResourceIdentifier.Name, operation.Spec.ResourceIdentifier.Namespace); pvcPVInfo != nil {
-				dataMover := "velero"
-				if dataUpload.Spec.DataMover != "" {
-					dataMover = dataUpload.Spec.DataMover
-				}
-
-				volumeInfo := &VolumeInfo{
-					BackupMethod:      CSISnapshot,
-					PVCName:           pvcPVInfo.PVCName,
-					PVCNamespace:      pvcPVInfo.PVCNamespace,
-					PVName:            pvcPVInfo.PV.Name,
-					SnapshotDataMoved: true,
-					Skipped:           false,
-					StartTimestamp:    operation.Status.Created,
-					CSISnapshotInfo: &CSISnapshotInfo{
-						SnapshotHandle: FieldValueIsUnknown,
-						VSCName:        FieldValueIsUnknown,
-						OperationID:    FieldValueIsUnknown,
-						Driver:         driverUsedByVSClass,
-					},
-					SnapshotDataMovementInfo: &SnapshotDataMovementInfo{
-						DataMover:    dataMover,
-						UploaderType: "kopia",
-						OperationID:  operation.Spec.OperationID,
-					},
-					PVInfo: &PVInfo{
-						ReclaimPolicy: string(pvcPVInfo.PV.Spec.PersistentVolumeReclaimPolicy),
-						Labels:        pvcPVInfo.PV.Labels,
-					},
-				}
-
-				tmpVolumeInfos = append(tmpVolumeInfos, volumeInfo)
-			} else {
-				v.logger.Warnf("Cannot find info for PVC %s/%s", operation.Spec.ResourceIdentifier.Namespace, operation.Spec.ResourceIdentifier.Name)
-				continue
-			}
-		}
-	}
-
-	v.volumeInfos = append(v.volumeInfos, tmpVolumeInfos...)
-}
-
-// retrievePvcPvInfo gets the PvcPvInfo from the PVMap.
-// support retrieve info by PV's name, or by PVC's name
-// and namespace.
-func (v *VolumesInformation) retrievePvcPvInfo(pvName, pvcName, pvcNS string) *pvcPvInfo {
-	if pvName != "" {
-		if info, ok := v.pvMap[pvName]; ok {
-			return &info
-		}
-		return nil
-	}
-
-	if pvcNS == "" || pvcName == "" {
-		return nil
-	}
-
-	for _, info := range v.pvMap {
-		if pvcNS == info.PVCNamespace && pvcName == info.PVCName {
-			return &info
-		}
-	}
-
-	return nil
-}

internal/volume/volumes_information_test.go

@@ -1,866 +0,0 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package volume
-
-import (
-	"context"
-	"testing"
-
-	snapshotv1api "github.com/kubernetes-csi/external-snapshotter/client/v4/apis/volumesnapshot/v1"
-	"github.com/sirupsen/logrus"
-	"github.com/stretchr/testify/require"
-	corev1api "k8s.io/api/core/v1"
-	"k8s.io/apimachinery/pkg/api/resource"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/runtime/schema"
-
-	velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
-	velerov2alpha1 "github.com/vmware-tanzu/velero/pkg/apis/velero/v2alpha1"
-	"github.com/vmware-tanzu/velero/pkg/builder"
-	"github.com/vmware-tanzu/velero/pkg/itemoperation"
-	"github.com/vmware-tanzu/velero/pkg/plugin/velero"
-	velerotest "github.com/vmware-tanzu/velero/pkg/test"
-	"github.com/vmware-tanzu/velero/pkg/util/logging"
-	"github.com/vmware-tanzu/velero/pkg/volume"
-)
-
-func TestGenerateVolumeInfoForSkippedPV(t *testing.T) {
-	tests := []struct {
-		name                string
-		skippedPVName       string
-		pvMap               map[string]pvcPvInfo
-		expectedVolumeInfos []*VolumeInfo
-	}{
-		{
-			name:          "Cannot find info for PV",
-			skippedPVName: "testPV",
-			pvMap: map[string]pvcPvInfo{
-				"velero/testPVC": {
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PV: corev1api.PersistentVolume{
-						ObjectMeta: metav1.ObjectMeta{
-							Name:   "testPV",
-							Labels: map[string]string{"a": "b"},
-						},
-						Spec: corev1api.PersistentVolumeSpec{
-							PersistentVolumeReclaimPolicy: corev1api.PersistentVolumeReclaimDelete,
-						},
-					},
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name:          "Normal Skipped PV info",
-			skippedPVName: "testPV",
-			pvMap: map[string]pvcPvInfo{
-				"velero/testPVC": {
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PV: corev1api.PersistentVolume{
-						ObjectMeta: metav1.ObjectMeta{
-							Name:   "testPV",
-							Labels: map[string]string{"a": "b"},
-						},
-						Spec: corev1api.PersistentVolumeSpec{
-							PersistentVolumeReclaimPolicy: corev1api.PersistentVolumeReclaimDelete,
-						},
-					},
-				},
-				"testPV": {
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PV: corev1api.PersistentVolume{
-						ObjectMeta: metav1.ObjectMeta{
-							Name:   "testPV",
-							Labels: map[string]string{"a": "b"},
-						},
-						Spec: corev1api.PersistentVolumeSpec{
-							PersistentVolumeReclaimPolicy: corev1api.PersistentVolumeReclaimDelete,
-						},
-					},
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{
-				{
-					PVCName:       "testPVC",
-					PVCNamespace:  "velero",
-					PVName:        "testPV",
-					Skipped:       true,
-					SkippedReason: "CSI: skipped for PodVolumeBackup",
-					PVInfo: &PVInfo{
-						ReclaimPolicy: "Delete",
-						Labels: map[string]string{
-							"a": "b",
-						},
-					},
-				},
-			},
-		},
-	}
-
-	for _, tc := range tests {
-		t.Run(tc.name, func(t *testing.T) {
-			volumesInfo := VolumesInformation{}
-			volumesInfo.Init()
-
-			if tc.skippedPVName != "" {
-				volumesInfo.SkippedPVs = map[string]string{
-					tc.skippedPVName: "CSI: skipped for PodVolumeBackup",
-				}
-			}
-
-			if tc.pvMap != nil {
-				for k, v := range tc.pvMap {
-					volumesInfo.pvMap[k] = v
-				}
-			}
-			volumesInfo.logger = logging.DefaultLogger(logrus.DebugLevel, logging.FormatJSON)
-
-			volumesInfo.generateVolumeInfoForSkippedPV()
-			require.Equal(t, tc.expectedVolumeInfos, volumesInfo.volumeInfos)
-		})
-	}
-}
-
-func TestGenerateVolumeInfoForVeleroNativeSnapshot(t *testing.T) {
-	tests := []struct {
-		name                string
-		nativeSnapshot      volume.Snapshot
-		pvMap               map[string]pvcPvInfo
-		expectedVolumeInfos []*VolumeInfo
-	}{
-		{
-			name: "Native snapshot's IPOS pointer is nil",
-			nativeSnapshot: volume.Snapshot{
-				Spec: volume.SnapshotSpec{
-					PersistentVolumeName: "testPV",
-					VolumeIOPS:           nil,
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "Cannot find info for the PV",
-			nativeSnapshot: volume.Snapshot{
-				Spec: volume.SnapshotSpec{
-					PersistentVolumeName: "testPV",
-					VolumeIOPS:           int64Ptr(100),
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "Cannot find PV info in pvMap",
-			pvMap: map[string]pvcPvInfo{
-				"velero/testPVC": {
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PV: corev1api.PersistentVolume{
-						ObjectMeta: metav1.ObjectMeta{
-							Name:   "testPV",
-							Labels: map[string]string{"a": "b"},
-						},
-						Spec: corev1api.PersistentVolumeSpec{
-							PersistentVolumeReclaimPolicy: corev1api.PersistentVolumeReclaimDelete,
-						},
-					},
-				},
-			},
-			nativeSnapshot: volume.Snapshot{
-				Spec: volume.SnapshotSpec{
-					PersistentVolumeName: "testPV",
-					VolumeIOPS:           int64Ptr(100),
-					VolumeType:           "ssd",
-					VolumeAZ:             "us-central1-a",
-				},
-				Status: volume.SnapshotStatus{
-					ProviderSnapshotID: "pvc-b31e3386-4bbb-4937-95d-7934cd62-b0a1-494b-95d7-0687440e8d0c",
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "Normal native snapshot",
-			pvMap: map[string]pvcPvInfo{
-				"testPV": {
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PV: corev1api.PersistentVolume{
-						ObjectMeta: metav1.ObjectMeta{
-							Name:   "testPV",
-							Labels: map[string]string{"a": "b"},
-						},
-						Spec: corev1api.PersistentVolumeSpec{
-							PersistentVolumeReclaimPolicy: corev1api.PersistentVolumeReclaimDelete,
-						},
-					},
-				},
-			},
-			nativeSnapshot: volume.Snapshot{
-				Spec: volume.SnapshotSpec{
-					PersistentVolumeName: "testPV",
-					VolumeIOPS:           int64Ptr(100),
-					VolumeType:           "ssd",
-					VolumeAZ:             "us-central1-a",
-				},
-				Status: volume.SnapshotStatus{
-					ProviderSnapshotID: "pvc-b31e3386-4bbb-4937-95d-7934cd62-b0a1-494b-95d7-0687440e8d0c",
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{
-				{
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PVName:       "testPV",
-					BackupMethod: NativeSnapshot,
-					PVInfo: &PVInfo{
-						ReclaimPolicy: "Delete",
-						Labels: map[string]string{
-							"a": "b",
-						},
-					},
-					NativeSnapshotInfo: &NativeSnapshotInfo{
-						SnapshotHandle: "pvc-b31e3386-4bbb-4937-95d-7934cd62-b0a1-494b-95d7-0687440e8d0c",
-						VolumeType:     "ssd",
-						VolumeAZ:       "us-central1-a",
-						IOPS:           "100",
-					},
-				},
-			},
-		},
-	}
-
-	for _, tc := range tests {
-		t.Run(tc.name, func(t *testing.T) {
-			volumesInfo := VolumesInformation{}
-			volumesInfo.Init()
-			volumesInfo.NativeSnapshots = append(volumesInfo.NativeSnapshots, &tc.nativeSnapshot)
-			if tc.pvMap != nil {
-				for k, v := range tc.pvMap {
-					volumesInfo.pvMap[k] = v
-				}
-			}
-			volumesInfo.logger = logging.DefaultLogger(logrus.DebugLevel, logging.FormatJSON)
-
-			volumesInfo.generateVolumeInfoForVeleroNativeSnapshot()
-			require.Equal(t, tc.expectedVolumeInfos, volumesInfo.volumeInfos)
-		})
-	}
-}
-
-func TestGenerateVolumeInfoForCSIVolumeSnapshot(t *testing.T) {
-	resourceQuantity := resource.MustParse("100Gi")
-	now := metav1.Now()
-	tests := []struct {
-		name                  string
-		volumeSnapshot        snapshotv1api.VolumeSnapshot
-		volumeSnapshotContent snapshotv1api.VolumeSnapshotContent
-		volumeSnapshotClass   snapshotv1api.VolumeSnapshotClass
-		pvMap                 map[string]pvcPvInfo
-		operation             *itemoperation.BackupOperation
-		expectedVolumeInfos   []*VolumeInfo
-	}{
-		{
-			name: "VS doesn't have VolumeSnapshotClass name",
-			volumeSnapshot: snapshotv1api.VolumeSnapshot{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "testVS",
-					Namespace: "velero",
-				},
-				Spec: snapshotv1api.VolumeSnapshotSpec{},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "VS doesn't have status",
-			volumeSnapshot: snapshotv1api.VolumeSnapshot{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "testVS",
-					Namespace: "velero",
-				},
-				Spec: snapshotv1api.VolumeSnapshotSpec{
-					VolumeSnapshotClassName: stringPtr("testClass"),
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "VS doesn't have PVC",
-			volumeSnapshot: snapshotv1api.VolumeSnapshot{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "testVS",
-					Namespace: "velero",
-				},
-				Spec: snapshotv1api.VolumeSnapshotSpec{
-					VolumeSnapshotClassName: stringPtr("testClass"),
-				},
-				Status: &snapshotv1api.VolumeSnapshotStatus{
-					BoundVolumeSnapshotContentName: stringPtr("testContent"),
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "Cannot find VSC for VS",
-			volumeSnapshot: snapshotv1api.VolumeSnapshot{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "testVS",
-					Namespace: "velero",
-				},
-				Spec: snapshotv1api.VolumeSnapshotSpec{
-					VolumeSnapshotClassName: stringPtr("testClass"),
-					Source: snapshotv1api.VolumeSnapshotSource{
-						PersistentVolumeClaimName: stringPtr("testPVC"),
-					},
-				},
-				Status: &snapshotv1api.VolumeSnapshotStatus{
-					BoundVolumeSnapshotContentName: stringPtr("testContent"),
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "Cannot find VolumeInfo for PVC",
-			volumeSnapshot: snapshotv1api.VolumeSnapshot{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "testVS",
-					Namespace: "velero",
-				},
-				Spec: snapshotv1api.VolumeSnapshotSpec{
-					VolumeSnapshotClassName: stringPtr("testClass"),
-					Source: snapshotv1api.VolumeSnapshotSource{
-						PersistentVolumeClaimName: stringPtr("testPVC"),
-					},
-				},
-				Status: &snapshotv1api.VolumeSnapshotStatus{
-					BoundVolumeSnapshotContentName: stringPtr("testContent"),
-				},
-			},
-			volumeSnapshotClass:   *builder.ForVolumeSnapshotClass("testClass").Driver("pd.csi.storage.gke.io").Result(),
-			volumeSnapshotContent: *builder.ForVolumeSnapshotContent("testContent").Status(&snapshotv1api.VolumeSnapshotContentStatus{SnapshotHandle: stringPtr("testSnapshotHandle")}).Result(),
-			expectedVolumeInfos:   []*VolumeInfo{},
-		},
-		{
-			name: "Normal VolumeSnapshot case",
-			volumeSnapshot: snapshotv1api.VolumeSnapshot{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:              "testVS",
-					Namespace:         "velero",
-					CreationTimestamp: now,
-				},
-				Spec: snapshotv1api.VolumeSnapshotSpec{
-					VolumeSnapshotClassName: stringPtr("testClass"),
-					Source: snapshotv1api.VolumeSnapshotSource{
-						PersistentVolumeClaimName: stringPtr("testPVC"),
-					},
-				},
-				Status: &snapshotv1api.VolumeSnapshotStatus{
-					BoundVolumeSnapshotContentName: stringPtr("testContent"),
-					RestoreSize:                    &resourceQuantity,
-				},
-			},
-			volumeSnapshotClass:   *builder.ForVolumeSnapshotClass("testClass").Driver("pd.csi.storage.gke.io").Result(),
-			volumeSnapshotContent: *builder.ForVolumeSnapshotContent("testContent").Status(&snapshotv1api.VolumeSnapshotContentStatus{SnapshotHandle: stringPtr("testSnapshotHandle")}).Result(),
-			pvMap: map[string]pvcPvInfo{
-				"testPV": {
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PV: corev1api.PersistentVolume{
-						ObjectMeta: metav1.ObjectMeta{
-							Name:   "testPV",
-							Labels: map[string]string{"a": "b"},
-						},
-						Spec: corev1api.PersistentVolumeSpec{
-							PersistentVolumeReclaimPolicy: corev1api.PersistentVolumeReclaimDelete,
-						},
-					},
-				},
-			},
-			operation: &itemoperation.BackupOperation{
-				Spec: itemoperation.BackupOperationSpec{
-					OperationID: "testID",
-					ResourceIdentifier: velero.ResourceIdentifier{
-						GroupResource: schema.GroupResource{
-							Group:    "snapshot.storage.k8s.io",
-							Resource: "volumesnapshots",
-						},
-						Namespace: "velero",
-						Name:      "testVS",
-					},
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{
-				{
-					PVCName:               "testPVC",
-					PVCNamespace:          "velero",
-					PVName:                "testPV",
-					BackupMethod:          CSISnapshot,
-					StartTimestamp:        &now,
-					PreserveLocalSnapshot: true,
-					CSISnapshotInfo: &CSISnapshotInfo{
-						Driver:         "pd.csi.storage.gke.io",
-						SnapshotHandle: "testSnapshotHandle",
-						Size:           107374182400,
-						VSCName:        "testContent",
-						OperationID:    "testID",
-					},
-					PVInfo: &PVInfo{
-						ReclaimPolicy: "Delete",
-						Labels: map[string]string{
-							"a": "b",
-						},
-					},
-				},
-			},
-		},
-	}
-
-	for _, tc := range tests {
-		t.Run(tc.name, func(t *testing.T) {
-			volumesInfo := VolumesInformation{}
-			volumesInfo.Init()
-
-			if tc.pvMap != nil {
-				for k, v := range tc.pvMap {
-					volumesInfo.pvMap[k] = v
-				}
-			}
-
-			if tc.operation != nil {
-				volumesInfo.BackupOperations = append(volumesInfo.BackupOperations, tc.operation)
-			}
-
-			volumesInfo.volumeSnapshots = []snapshotv1api.VolumeSnapshot{tc.volumeSnapshot}
-			volumesInfo.volumeSnapshotContents = []snapshotv1api.VolumeSnapshotContent{tc.volumeSnapshotContent}
-			volumesInfo.volumeSnapshotClasses = []snapshotv1api.VolumeSnapshotClass{tc.volumeSnapshotClass}
-			volumesInfo.logger = logging.DefaultLogger(logrus.DebugLevel, logging.FormatJSON)
-
-			volumesInfo.generateVolumeInfoForCSIVolumeSnapshot()
-			require.Equal(t, tc.expectedVolumeInfos, volumesInfo.volumeInfos)
-		})
-	}
-}
-
-func TestGenerateVolumeInfoFromPVB(t *testing.T) {
-	tests := []struct {
-		name                string
-		pvb                 *velerov1api.PodVolumeBackup
-		pod                 *corev1api.Pod
-		pvMap               map[string]pvcPvInfo
-		expectedVolumeInfos []*VolumeInfo
-	}{
-		{
-			name:                "cannot find PVB's pod, should fail",
-			pvb:                 builder.ForPodVolumeBackup("velero", "testPVB").PodName("testPod").PodNamespace("velero").Result(),
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "PVB doesn't have a related PVC",
-			pvb:  builder.ForPodVolumeBackup("velero", "testPVB").PodName("testPod").PodNamespace("velero").Result(),
-			pod: builder.ForPod("velero", "testPod").Containers(&corev1api.Container{
-				Name: "test",
-				VolumeMounts: []corev1api.VolumeMount{
-					{
-						Name:      "testVolume",
-						MountPath: "/data",
-					},
-				},
-			}).Volumes(
-				&corev1api.Volume{
-					Name: "",
-					VolumeSource: corev1api.VolumeSource{
-						HostPath: &corev1api.HostPathVolumeSource{},
-					},
-				},
-			).Result(),
-			expectedVolumeInfos: []*VolumeInfo{
-				{
-					PVCName:      "",
-					PVCNamespace: "",
-					PVName:       "",
-					BackupMethod: PodVolumeBackup,
-					PVBInfo: &PodVolumeBackupInfo{
-						PodName:      "testPod",
-						PodNamespace: "velero",
-					},
-				},
-			},
-		},
-		{
-			name: "Backup doesn't have information for PVC",
-			pvb:  builder.ForPodVolumeBackup("velero", "testPVB").PodName("testPod").PodNamespace("velero").Result(),
-			pod: builder.ForPod("velero", "testPod").Containers(&corev1api.Container{
-				Name: "test",
-				VolumeMounts: []corev1api.VolumeMount{
-					{
-						Name:      "testVolume",
-						MountPath: "/data",
-					},
-				},
-			}).Volumes(
-				&corev1api.Volume{
-					Name: "",
-					VolumeSource: corev1api.VolumeSource{
-						PersistentVolumeClaim: &corev1api.PersistentVolumeClaimVolumeSource{
-							ClaimName: "testPVC",
-						},
-					},
-				},
-			).Result(),
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "PVB's volume has a PVC",
-			pvMap: map[string]pvcPvInfo{
-				"testPV": {
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PV: corev1api.PersistentVolume{
-						ObjectMeta: metav1.ObjectMeta{
-							Name:   "testPV",
-							Labels: map[string]string{"a": "b"},
-						},
-						Spec: corev1api.PersistentVolumeSpec{
-							PersistentVolumeReclaimPolicy: corev1api.PersistentVolumeReclaimDelete,
-						},
-					},
-				},
-			},
-			pvb: builder.ForPodVolumeBackup("velero", "testPVB").PodName("testPod").PodNamespace("velero").Result(),
-			pod: builder.ForPod("velero", "testPod").Containers(&corev1api.Container{
-				Name: "test",
-				VolumeMounts: []corev1api.VolumeMount{
-					{
-						Name:      "testVolume",
-						MountPath: "/data",
-					},
-				},
-			}).Volumes(
-				&corev1api.Volume{
-					Name: "",
-					VolumeSource: corev1api.VolumeSource{
-						PersistentVolumeClaim: &corev1api.PersistentVolumeClaimVolumeSource{
-							ClaimName: "testPVC",
-						},
-					},
-				},
-			).Result(),
-			expectedVolumeInfos: []*VolumeInfo{
-				{
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PVName:       "testPV",
-					BackupMethod: PodVolumeBackup,
-					PVBInfo: &PodVolumeBackupInfo{
-						PodName:      "testPod",
-						PodNamespace: "velero",
-					},
-					PVInfo: &PVInfo{
-						ReclaimPolicy: string(corev1api.PersistentVolumeReclaimDelete),
-						Labels:        map[string]string{"a": "b"},
-					},
-				},
-			},
-		},
-	}
-
-	for _, tc := range tests {
-		t.Run(tc.name, func(t *testing.T) {
-			volumesInfo := VolumesInformation{}
-			volumesInfo.Init()
-			volumesInfo.crClient = velerotest.NewFakeControllerRuntimeClient(t)
-
-			volumesInfo.PodVolumeBackups = append(volumesInfo.PodVolumeBackups, tc.pvb)
-
-			if tc.pvMap != nil {
-				for k, v := range tc.pvMap {
-					volumesInfo.pvMap[k] = v
-				}
-			}
-			if tc.pod != nil {
-				require.NoError(t, volumesInfo.crClient.Create(context.TODO(), tc.pod))
-			}
-			volumesInfo.logger = logging.DefaultLogger(logrus.DebugLevel, logging.FormatJSON)
-
-			volumesInfo.generateVolumeInfoFromPVB()
-			require.Equal(t, tc.expectedVolumeInfos, volumesInfo.volumeInfos)
-		})
-	}
-}
-
-func TestGenerateVolumeInfoFromDataUpload(t *testing.T) {
-	now := metav1.Now()
-	tests := []struct {
-		name                string
-		volumeSnapshotClass *snapshotv1api.VolumeSnapshotClass
-		dataUpload          *velerov2alpha1.DataUpload
-		operation           *itemoperation.BackupOperation
-		pvMap               map[string]pvcPvInfo
-		expectedVolumeInfos []*VolumeInfo
-	}{
-		{
-			name: "Operation is not for PVC",
-			operation: &itemoperation.BackupOperation{
-				Spec: itemoperation.BackupOperationSpec{
-					ResourceIdentifier: velero.ResourceIdentifier{
-						GroupResource: schema.GroupResource{
-							Group:    "",
-							Resource: "configmaps",
-						},
-					},
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "Operation doesn't have DataUpload PostItemOperation",
-			operation: &itemoperation.BackupOperation{
-				Spec: itemoperation.BackupOperationSpec{
-					ResourceIdentifier: velero.ResourceIdentifier{
-						GroupResource: schema.GroupResource{
-							Group:    "",
-							Resource: "persistentvolumeclaims",
-						},
-						Namespace: "velero",
-						Name:      "testPVC",
-					},
-					PostOperationItems: []velero.ResourceIdentifier{
-						{
-							GroupResource: schema.GroupResource{
-								Group:    "",
-								Resource: "configmaps",
-							},
-						},
-					},
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "DataUpload cannot be found for operation",
-			operation: &itemoperation.BackupOperation{
-				Spec: itemoperation.BackupOperationSpec{
-					OperationID: "testOperation",
-					ResourceIdentifier: velero.ResourceIdentifier{
-						GroupResource: schema.GroupResource{
-							Group:    "",
-							Resource: "persistentvolumeclaims",
-						},
-						Namespace: "velero",
-						Name:      "testPVC",
-					},
-					PostOperationItems: []velero.ResourceIdentifier{
-						{
-							GroupResource: schema.GroupResource{
-								Group:    "velero.io",
-								Resource: "datauploads",
-							},
-							Namespace: "velero",
-							Name:      "testDU",
-						},
-					},
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{},
-		},
-		{
-			name: "VolumeSnapshotClass cannot be found for operation",
-			dataUpload: builder.ForDataUpload("velero", "testDU").DataMover("velero").CSISnapshot(&velerov2alpha1.CSISnapshotSpec{
-				VolumeSnapshot: "testVS",
-			}).SnapshotID("testSnapshotHandle").Result(),
-			operation: &itemoperation.BackupOperation{
-				Spec: itemoperation.BackupOperationSpec{
-					OperationID: "testOperation",
-					ResourceIdentifier: velero.ResourceIdentifier{
-						GroupResource: schema.GroupResource{
-							Group:    "",
-							Resource: "persistentvolumeclaims",
-						},
-						Namespace: "velero",
-						Name:      "testPVC",
-					},
-					PostOperationItems: []velero.ResourceIdentifier{
-						{
-							GroupResource: schema.GroupResource{
-								Group:    "velero.io",
-								Resource: "datauploads",
-							},
-							Namespace: "velero",
-							Name:      "testDU",
-						},
-					},
-				},
-			},
-			pvMap: map[string]pvcPvInfo{
-				"testPV": {
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PV: corev1api.PersistentVolume{
-						ObjectMeta: metav1.ObjectMeta{
-							Name:   "testPV",
-							Labels: map[string]string{"a": "b"},
-						},
-						Spec: corev1api.PersistentVolumeSpec{
-							PersistentVolumeReclaimPolicy: corev1api.PersistentVolumeReclaimDelete,
-						},
-					},
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{
-				{
-					PVCName:           "testPVC",
-					PVCNamespace:      "velero",
-					PVName:            "testPV",
-					BackupMethod:      CSISnapshot,
-					SnapshotDataMoved: true,
-					CSISnapshotInfo: &CSISnapshotInfo{
-						SnapshotHandle: FieldValueIsUnknown,
-						VSCName:        FieldValueIsUnknown,
-						OperationID:    FieldValueIsUnknown,
-						Size:           0,
-					},
-					SnapshotDataMovementInfo: &SnapshotDataMovementInfo{
-						DataMover:    "velero",
-						UploaderType: "kopia",
-						OperationID:  "testOperation",
-					},
-					PVInfo: &PVInfo{
-						ReclaimPolicy: string(corev1api.PersistentVolumeReclaimDelete),
-						Labels:        map[string]string{"a": "b"},
-					},
-				},
-			},
-		},
-		{
-			name: "Normal DataUpload case",
-			dataUpload: builder.ForDataUpload("velero", "testDU").DataMover("velero").CSISnapshot(&velerov2alpha1.CSISnapshotSpec{
-				VolumeSnapshot: "testVS",
-				SnapshotClass:  "testClass",
-			}).SnapshotID("testSnapshotHandle").Result(),
-			volumeSnapshotClass: builder.ForVolumeSnapshotClass("testClass").Driver("pd.csi.storage.gke.io").Result(),
-			operation: &itemoperation.BackupOperation{
-				Spec: itemoperation.BackupOperationSpec{
-					OperationID: "testOperation",
-					ResourceIdentifier: velero.ResourceIdentifier{
-						GroupResource: schema.GroupResource{
-							Group:    "",
-							Resource: "persistentvolumeclaims",
-						},
-						Namespace: "velero",
-						Name:      "testPVC",
-					},
-					PostOperationItems: []velero.ResourceIdentifier{
-						{
-							GroupResource: schema.GroupResource{
-								Group:    "velero.io",
-								Resource: "datauploads",
-							},
-							Namespace: "velero",
-							Name:      "testDU",
-						},
-					},
-				},
-				Status: itemoperation.OperationStatus{
-					Created: &now,
-				},
-			},
-			pvMap: map[string]pvcPvInfo{
-				"testPV": {
-					PVCName:      "testPVC",
-					PVCNamespace: "velero",
-					PV: corev1api.PersistentVolume{
-						ObjectMeta: metav1.ObjectMeta{
-							Name:   "testPV",
-							Labels: map[string]string{"a": "b"},
-						},
-						Spec: corev1api.PersistentVolumeSpec{
-							PersistentVolumeReclaimPolicy: corev1api.PersistentVolumeReclaimDelete,
-						},
-					},
-				},
-			},
-			expectedVolumeInfos: []*VolumeInfo{
-				{
-					PVCName:           "testPVC",
-					PVCNamespace:      "velero",
-					PVName:            "testPV",
-					BackupMethod:      CSISnapshot,
-					SnapshotDataMoved: true,
-					StartTimestamp:    &now,
-					CSISnapshotInfo: &CSISnapshotInfo{
-						VSCName:        FieldValueIsUnknown,
-						SnapshotHandle: FieldValueIsUnknown,
-						OperationID:    FieldValueIsUnknown,
-						Size:           0,
-						Driver:         "pd.csi.storage.gke.io",
-					},
-					SnapshotDataMovementInfo: &SnapshotDataMovementInfo{
-						DataMover:    "velero",
-						UploaderType: "kopia",
-						OperationID:  "testOperation",
-					},
-					PVInfo: &PVInfo{
-						ReclaimPolicy: string(corev1api.PersistentVolumeReclaimDelete),
-						Labels:        map[string]string{"a": "b"},
-					},
-				},
-			},
-		},
-	}
-
-	for _, tc := range tests {
-		t.Run(tc.name, func(t *testing.T) {
-			volumesInfo := VolumesInformation{}
-			volumesInfo.Init()
-
-			if tc.operation != nil {
-				volumesInfo.BackupOperations = append(volumesInfo.BackupOperations, tc.operation)
-			}
-
-			if tc.pvMap != nil {
-				for k, v := range tc.pvMap {
-					volumesInfo.pvMap[k] = v
-				}
-			}
-
-			volumesInfo.crClient = velerotest.NewFakeControllerRuntimeClient(t)
-			if tc.dataUpload != nil {
-				volumesInfo.crClient.Create(context.TODO(), tc.dataUpload)
-			}
-
-			if tc.volumeSnapshotClass != nil {
-				volumesInfo.crClient.Create(context.TODO(), tc.volumeSnapshotClass)
-			}
-
-			volumesInfo.logger = logging.DefaultLogger(logrus.DebugLevel, logging.FormatJSON)
-
-			volumesInfo.generateVolumeInfoFromDataUpload()
-			require.Equal(t, tc.expectedVolumeInfos, volumesInfo.volumeInfos)
-		})
-	}
-}
-
-func stringPtr(str string) *string {
-	return &str
-}
-
-func int64Ptr(val int) *int64 {
-	i := int64(val)
-	return &i
-}

pkg/apis/velero/v1/backup_types.go

@@ -175,18 +175,6 @@ type BackupSpec struct {
 	// If DataMover is "" or "velero", the built-in data mover will be used.
 	// +optional
 	DataMover string `json:"datamover,omitempty"`
-
-	// UploaderConfig specifies the configuration for the uploader.
-	// +optional
-	// +nullable
-	UploaderConfig *UploaderConfigForBackup `json:"uploaderConfig,omitempty"`
-}
-
-// UploaderConfigForBackup defines the configuration for the uploader when doing backup.
-type UploaderConfigForBackup struct {
-	// ParallelFilesUpload is the number of files parallel uploads to perform when using the uploader.
-	// +optional
-	ParallelFilesUpload int `json:"parallelFilesUpload,omitempty"`
 }
 
 // BackupHooks contains custom behaviors that should be executed at different phases of the backup.
@@ -273,12 +261,12 @@ type ExecHook struct {
 type HookErrorMode string
 
 const (
-	// HookErrorModeContinue means that an error from a hook is acceptable and the backup/restore can
-	// proceed with the rest of hooks' execution. This backup/restore should be in `PartiallyFailed` status.
+	// HookErrorModeContinue means that an error from a hook is acceptable, and the backup can
+	// proceed.
 	HookErrorModeContinue HookErrorMode = "Continue"
 
-	// HookErrorModeFail means that an error from a hook is problematic and Velero should stop executing following hooks.
-	// This backup/restore should be in `PartiallyFailed` status.
+	// HookErrorModeFail means that an error from a hook is problematic, and the backup should be in
+	// error.
 	HookErrorModeFail HookErrorMode = "Fail"
 )
 
@@ -446,11 +434,6 @@ type BackupStatus struct {
 	// BackupItemAction operations for this backup which ended with an error.
 	// +optional
 	BackupItemOperationsFailed int `json:"backupItemOperationsFailed,omitempty"`
-
-	// HookStatus contains information about the status of the hooks.
-	// +optional
-	// +nullable
-	HookStatus *HookStatus `json:"hookStatus,omitempty"`
 }
 
 // BackupProgress stores information about the progress of a Backup's execution.
@@ -468,19 +451,6 @@ type BackupProgress struct {
 	ItemsBackedUp int `json:"itemsBackedUp,omitempty"`
 }
 
-// HookStatus stores information about the status of the hooks.
-type HookStatus struct {
-	// HooksAttempted is the total number of attempted hooks
-	// Specifically, HooksAttempted represents the number of hooks that failed to execute
-	// and the number of hooks that executed successfully.
-	// +optional
-	HooksAttempted int `json:"hooksAttempted,omitempty"`
-
-	// HooksFailed is the total number of hooks which ended with an error
-	// +optional
-	HooksFailed int `json:"hooksFailed,omitempty"`
-}
-
 // +genclient
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 // +kubebuilder:object:root=true

pkg/apis/velero/v1/download_request_types.go

@@ -25,7 +25,7 @@ type DownloadRequestSpec struct {
 }
 
 // DownloadTargetKind represents what type of file to download.
-// +kubebuilder:validation:Enum=BackupLog;BackupContents;BackupVolumeSnapshots;BackupItemOperations;BackupResourceList;BackupResults;RestoreLog;RestoreResults;RestoreResourceList;RestoreItemOperations;CSIBackupVolumeSnapshots;CSIBackupVolumeSnapshotContents;BackupVolumeInfos
+// +kubebuilder:validation:Enum=BackupLog;BackupContents;BackupVolumeSnapshots;BackupItemOperations;BackupResourceList;BackupResults;RestoreLog;RestoreResults;RestoreResourceList;RestoreItemOperations;CSIBackupVolumeSnapshots;CSIBackupVolumeSnapshotContents
 type DownloadTargetKind string
 
 const (
@@ -41,7 +41,6 @@ const (
 	DownloadTargetKindRestoreItemOperations           DownloadTargetKind = "RestoreItemOperations"
 	DownloadTargetKindCSIBackupVolumeSnapshots        DownloadTargetKind = "CSIBackupVolumeSnapshots"
 	DownloadTargetKindCSIBackupVolumeSnapshotContents DownloadTargetKind = "CSIBackupVolumeSnapshotContents"
-	DownloadTargetKindBackupVolumeInfos               DownloadTargetKind = "BackupVolumeInfos"
 )
 
 // DownloadTarget is the specification for what kind of file to download, and the name of the

pkg/apis/velero/v1/labels_annotations.go

@@ -83,20 +83,12 @@ const (
 	// AsyncOperationIDLabel is the label key used to identify the async operation ID
 	AsyncOperationIDLabel = "velero.io/async-operation-id"
 
-	// PVCNameLabel is the label key used to identify the PVC's namespace and name.
+	// PVCNameLabel is the label key used to identify the the PVC's namespace and name.
 	// The format is <namespace>/<name>.
 	PVCNamespaceNameLabel = "velero.io/pvc-namespace-name"
 
 	// ResourceUsageLabel is the label key to explain the Velero resource usage.
 	ResourceUsageLabel = "velero.io/resource-usage"
-
-	// VolumesToBackupAnnotation is the annotation on a pod whose mounted volumes
-	// need to be backed up using pod volume backup.
-	VolumesToBackupAnnotation = "backup.velero.io/backup-volumes"
-
-	// VolumesToExcludeAnnotation is the annotation on a pod whose mounted volumes
-	// should be excluded from pod volume backup.
-	VolumesToExcludeAnnotation = "backup.velero.io/backup-volumes-excludes"
 )
 
 type AsyncOperationIDPrefix string

pkg/apis/velero/v1/pod_volume_backup_types.go

@@ -51,12 +51,6 @@ type PodVolumeBackupSpec struct {
 	// volume backup as tags.
 	// +optional
 	Tags map[string]string `json:"tags,omitempty"`
-
-	// UploaderSettings are a map of key-value pairs that should be applied to the
-	// uploader configuration.
-	// +optional
-	// +nullable
-	UploaderSettings map[string]string `json:"uploaderSettings,omitempty"`
 }
 
 // PodVolumeBackupPhase represents the lifecycle phase of a PodVolumeBackup.
@@ -120,6 +114,7 @@ type PodVolumeBackupStatus struct {
 // +kubebuilder:printcolumn:name="Namespace",type="string",JSONPath=".spec.pod.namespace",description="Namespace of the pod containing the volume to be backed up"
 // +kubebuilder:printcolumn:name="Pod",type="string",JSONPath=".spec.pod.name",description="Name of the pod containing the volume to be backed up"
 // +kubebuilder:printcolumn:name="Volume",type="string",JSONPath=".spec.volume",description="Name of the volume to be backed up"
+// +kubebuilder:printcolumn:name="Repository ID",type="string",JSONPath=".spec.repoIdentifier",description="Backup repository identifier for this backup"
 // +kubebuilder:printcolumn:name="Uploader Type",type="string",JSONPath=".spec.uploaderType",description="The type of the uploader to handle data transfer"
 // +kubebuilder:printcolumn:name="Storage Location",type="string",JSONPath=".spec.backupStorageLocation",description="Name of the Backup Storage Location where this backup should be stored"
 // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"

pkg/apis/velero/v1/pod_volume_restore_type.go

@@ -48,12 +48,6 @@ type PodVolumeRestoreSpec struct {
 
 	// SourceNamespace is the original namespace for namaspace mapping.
 	SourceNamespace string `json:"sourceNamespace"`
-
-	// UploaderSettings are a map of key-value pairs that should be applied to the
-	// uploader configuration.
-	// +optional
-	// +nullable
-	UploaderSettings map[string]string `json:"uploaderSettings,omitempty"`
 }
 
 // PodVolumeRestorePhase represents the lifecycle phase of a PodVolumeRestore.

pkg/apis/velero/v1/restore_types.go

@@ -123,19 +123,6 @@ type RestoreSpec struct {
 	// +optional
 	// +nullable
 	ResourceModifier *v1.TypedLocalObjectReference `json:"resourceModifier,omitempty"`
-
-	// UploaderConfig specifies the configuration for the restore.
-	// +optional
-	// +nullable
-	UploaderConfig *UploaderConfigForRestore `json:"uploaderConfig,omitempty"`
-}
-
-// UploaderConfigForRestore defines the configuration for the restore.
-type UploaderConfigForRestore struct {
-	// WriteSparseFiles is a flag to indicate whether write files sparsely or not.
-	// +optional
-	// +nullable
-	WriteSparseFiles *bool `json:"writeSparseFiles,omitempty"`
 }
 
 // RestoreHooks contains custom behaviors that should be executed during or post restore.
@@ -227,11 +214,6 @@ type ExecRestoreHook struct {
 	// before attempting to run the command.
 	// +optional
 	WaitTimeout metav1.Duration `json:"waitTimeout,omitempty"`
-
-	// WaitForReady ensures command will be launched when container is Ready instead of Running.
-	// +optional
-	// +nullable
-	WaitForReady *bool `json:"waitForReady,omitempty"`
 }
 
 // InitRestoreHook is a hook that adds an init container to a PodSpec to run commands before the
@@ -358,11 +340,6 @@ type RestoreStatus struct {
 	// RestoreItemAction operations for this restore which ended with an error.
 	// +optional
 	RestoreItemOperationsFailed int `json:"restoreItemOperationsFailed,omitempty"`
-
-	// HookStatus contains information about the status of the hooks.
-	// +optional
-	// +nullable
-	HookStatus *HookStatus `json:"hookStatus,omitempty"`
 }
 
 // RestoreProgress stores information about the restore's execution progress

pkg/apis/velero/v1/schedule_types.go

@@ -42,13 +42,6 @@ type ScheduleSpec struct {
 	// Paused specifies whether the schedule is paused or not
 	// +optional
 	Paused bool `json:"paused,omitempty"`
-
-	// SkipImmediately specifies whether to skip backup if schedule is due immediately from `schedule.status.lastBackup` timestamp when schedule is unpaused or if schedule is new.
-	// If true, backup will be skipped immediately when schedule is unpaused if it is due based on .Status.LastBackupTimestamp or schedule is new, and will run at next schedule time.
-	// If false, backup will not be skipped immediately when schedule is unpaused, but will run at next schedule time.
-	// If empty, will follow server configuration (default: false).
-	// +optional
-	SkipImmediately *bool `json:"skipImmediately,omitempty"`
 }
 
 // SchedulePhase is a string representation of the lifecycle phase
@@ -82,11 +75,6 @@ type ScheduleStatus struct {
 	// +nullable
 	LastBackup *metav1.Time `json:"lastBackup,omitempty"`
 
-	// LastSkipped is the last time a Schedule was skipped
-	// +optional
-	// +nullable
-	LastSkipped *metav1.Time `json:"lastSkipped,omitempty"`
-
 	// ValidationErrors is a slice of all validation errors (if
 	// applicable)
 	// +optional

pkg/apis/velero/v1/zz_generated.deepcopy.go

@@ -381,11 +381,6 @@ func (in *BackupSpec) DeepCopyInto(out *BackupSpec) {
 		*out = new(bool)
 		**out = **in
 	}
-	if in.UploaderConfig != nil {
-		in, out := &in.UploaderConfig, &out.UploaderConfig
-		*out = new(UploaderConfigForBackup)
-		**out = **in
-	}
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new BackupSpec.
@@ -423,11 +418,6 @@ func (in *BackupStatus) DeepCopyInto(out *BackupStatus) {
 		*out = new(BackupProgress)
 		**out = **in
 	}
-	if in.HookStatus != nil {
-		in, out := &in.HookStatus, &out.HookStatus
-		*out = new(HookStatus)
-		**out = **in
-	}
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new BackupStatus.
@@ -794,11 +784,6 @@ func (in *ExecRestoreHook) DeepCopyInto(out *ExecRestoreHook) {
 	}
 	out.ExecTimeout = in.ExecTimeout
 	out.WaitTimeout = in.WaitTimeout
-	if in.WaitForReady != nil {
-		in, out := &in.WaitForReady, &out.WaitForReady
-		*out = new(bool)
-		**out = **in
-	}
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new ExecRestoreHook.
@@ -811,21 +796,6 @@ func (in *ExecRestoreHook) DeepCopy() *ExecRestoreHook {
 	return out
 }
 
-// DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
-func (in *HookStatus) DeepCopyInto(out *HookStatus) {
-	*out = *in
-}
-
-// DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new HookStatus.
-func (in *HookStatus) DeepCopy() *HookStatus {
-	if in == nil {
-		return nil
-	}
-	out := new(HookStatus)
-	in.DeepCopyInto(out)
-	return out
-}
-
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *InitRestoreHook) DeepCopyInto(out *InitRestoreHook) {
 	*out = *in
@@ -976,13 +946,6 @@ func (in *PodVolumeBackupSpec) DeepCopyInto(out *PodVolumeBackupSpec) {
 			(*out)[key] = val
 		}
 	}
-	if in.UploaderSettings != nil {
-		in, out := &in.UploaderSettings, &out.UploaderSettings
-		*out = make(map[string]string, len(*in))
-		for key, val := range *in {
-			(*out)[key] = val
-		}
-	}
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new PodVolumeBackupSpec.
@@ -1024,7 +987,7 @@ func (in *PodVolumeRestore) DeepCopyInto(out *PodVolumeRestore) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
 	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
-	in.Spec.DeepCopyInto(&out.Spec)
+	out.Spec = in.Spec
 	in.Status.DeepCopyInto(&out.Status)
 }
 
@@ -1082,13 +1045,6 @@ func (in *PodVolumeRestoreList) DeepCopyObject() runtime.Object {
 func (in *PodVolumeRestoreSpec) DeepCopyInto(out *PodVolumeRestoreSpec) {
 	*out = *in
 	out.Pod = in.Pod
-	if in.UploaderSettings != nil {
-		in, out := &in.UploaderSettings, &out.UploaderSettings
-		*out = make(map[string]string, len(*in))
-		for key, val := range *in {
-			(*out)[key] = val
-		}
-	}
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new PodVolumeRestoreSpec.
@@ -1366,11 +1322,6 @@ func (in *RestoreSpec) DeepCopyInto(out *RestoreSpec) {
 		*out = new(corev1.TypedLocalObjectReference)
 		(*in).DeepCopyInto(*out)
 	}
-	if in.UploaderConfig != nil {
-		in, out := &in.UploaderConfig, &out.UploaderConfig
-		*out = new(UploaderConfigForRestore)
-		(*in).DeepCopyInto(*out)
-	}
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new RestoreSpec.
@@ -1404,11 +1355,6 @@ func (in *RestoreStatus) DeepCopyInto(out *RestoreStatus) {
 		*out = new(RestoreProgress)
 		**out = **in
 	}
-	if in.HookStatus != nil {
-		in, out := &in.HookStatus, &out.HookStatus
-		*out = new(HookStatus)
-		**out = **in
-	}
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new RestoreStatus.
@@ -1514,11 +1460,6 @@ func (in *ScheduleSpec) DeepCopyInto(out *ScheduleSpec) {
 		*out = new(bool)
 		**out = **in
 	}
-	if in.SkipImmediately != nil {
-		in, out := &in.SkipImmediately, &out.SkipImmediately
-		*out = new(bool)
-		**out = **in
-	}
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new ScheduleSpec.
@@ -1538,10 +1479,6 @@ func (in *ScheduleStatus) DeepCopyInto(out *ScheduleStatus) {
 		in, out := &in.LastBackup, &out.LastBackup
 		*out = (*in).DeepCopy()
 	}
-	if in.LastSkipped != nil {
-		in, out := &in.LastSkipped, &out.LastSkipped
-		*out = (*in).DeepCopy()
-	}
 	if in.ValidationErrors != nil {
 		in, out := &in.ValidationErrors, &out.ValidationErrors
 		*out = make([]string, len(*in))
@@ -1677,41 +1614,6 @@ func (in *StorageType) DeepCopy() *StorageType {
 	return out
 }
 
-// DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
-func (in *UploaderConfigForBackup) DeepCopyInto(out *UploaderConfigForBackup) {
-	*out = *in
-}
-
-// DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new UploaderConfigForBackup.
-func (in *UploaderConfigForBackup) DeepCopy() *UploaderConfigForBackup {
-	if in == nil {
-		return nil
-	}
-	out := new(UploaderConfigForBackup)
-	in.DeepCopyInto(out)
-	return out
-}
-
-// DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
-func (in *UploaderConfigForRestore) DeepCopyInto(out *UploaderConfigForRestore) {
-	*out = *in
-	if in.WriteSparseFiles != nil {
-		in, out := &in.WriteSparseFiles, &out.WriteSparseFiles
-		*out = new(bool)
-		**out = **in
-	}
-}
-
-// DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new UploaderConfigForRestore.
-func (in *UploaderConfigForRestore) DeepCopy() *UploaderConfigForRestore {
-	if in == nil {
-		return nil
-	}
-	out := new(UploaderConfigForRestore)
-	in.DeepCopyInto(out)
-	return out
-}
-
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *VolumeSnapshotLocation) DeepCopyInto(out *VolumeSnapshotLocation) {
 	*out = *in

pkg/apis/velero/v2alpha1/data_download_types.go

@@ -56,7 +56,7 @@ type DataDownloadSpec struct {
 	OperationTimeout metav1.Duration `json:"operationTimeout"`
 }
 
-// TargetVolumeSpec is the specification for a target PVC.
+// TargetPVCSpec is the specification for a target PVC.
 type TargetVolumeSpec struct {
 	// PVC is the name of the target PVC that is created by Velero restore
 	PVC string `json:"pvc"`
@@ -131,7 +131,6 @@ type DataDownloadStatus struct {
 // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Time duration since this DataDownload was created"
 // +kubebuilder:printcolumn:name="Node",type="string",JSONPath=".status.node",description="Name of the node where the DataDownload is processed"
 
-// DataDownload acts as the protocol between data mover plugins and data mover controller for the datamover restore operation
 type DataDownload struct {
 	metav1.TypeMeta `json:",inline"`
 

pkg/apis/velero/v2alpha1/data_upload_types.go

@@ -51,7 +51,7 @@ type DataUploadSpec struct {
 	// DataMoverConfig is for data-mover-specific configuration fields.
 	// +optional
 	// +nullable
-	DataMoverConfig map[string]string `json:"dataMoverConfig,omitempty"`
+	DataMoverConfig *map[string]string `json:"dataMoverConfig,omitempty"`
 
 	// Cancel indicates request to cancel the ongoing DataUpload. It can be set
 	// when the DataUpload is in InProgress phase
@@ -161,7 +161,6 @@ type DataUploadStatus struct {
 // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Time duration since this DataUpload was created"
 // +kubebuilder:printcolumn:name="Node",type="string",JSONPath=".status.node",description="Name of the node where the DataUpload is processed"
 
-// DataUpload acts as the protocol between data mover plugins and data mover controller for the datamover backup operation
 type DataUpload struct {
 	metav1.TypeMeta `json:",inline"`
 

pkg/apis/velero/v2alpha1/zz_generated.deepcopy.go

@@ -1,17 +1,34 @@
 //go:build !ignore_autogenerated
 // +build !ignore_autogenerated
 
-// Code generated by controller-gen. DO NOT EDIT.
+/*
+Copyright the Velero contributors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+// Code generated by deepcopy-gen. DO NOT EDIT.
 
 package v2alpha1
 
 import (
-	"k8s.io/apimachinery/pkg/runtime"
+	runtime "k8s.io/apimachinery/pkg/runtime"
 )
 
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *CSISnapshotSpec) DeepCopyInto(out *CSISnapshotSpec) {
 	*out = *in
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new CSISnapshotSpec.
@@ -31,6 +48,7 @@ func (in *DataDownload) DeepCopyInto(out *DataDownload) {
 	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	in.Spec.DeepCopyInto(&out.Spec)
 	in.Status.DeepCopyInto(&out.Status)
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new DataDownload.
@@ -63,6 +81,7 @@ func (in *DataDownloadList) DeepCopyInto(out *DataDownloadList) {
 			(*in)[i].DeepCopyInto(&(*out)[i])
 		}
 	}
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new DataDownloadList.
@@ -95,6 +114,7 @@ func (in *DataDownloadSpec) DeepCopyInto(out *DataDownloadSpec) {
 		}
 	}
 	out.OperationTimeout = in.OperationTimeout
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new DataDownloadSpec.
@@ -119,6 +139,7 @@ func (in *DataDownloadStatus) DeepCopyInto(out *DataDownloadStatus) {
 		*out = (*in).DeepCopy()
 	}
 	out.Progress = in.Progress
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new DataDownloadStatus.
@@ -138,6 +159,7 @@ func (in *DataUpload) DeepCopyInto(out *DataUpload) {
 	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	in.Spec.DeepCopyInto(&out.Spec)
 	in.Status.DeepCopyInto(&out.Status)
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new DataUpload.
@@ -170,6 +192,7 @@ func (in *DataUploadList) DeepCopyInto(out *DataUploadList) {
 			(*in)[i].DeepCopyInto(&(*out)[i])
 		}
 	}
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new DataUploadList.
@@ -204,6 +227,7 @@ func (in *DataUploadResult) DeepCopyInto(out *DataUploadResult) {
 			}
 		}
 	}
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new DataUploadResult.
@@ -226,12 +250,17 @@ func (in *DataUploadSpec) DeepCopyInto(out *DataUploadSpec) {
 	}
 	if in.DataMoverConfig != nil {
 		in, out := &in.DataMoverConfig, &out.DataMoverConfig
-		*out = make(map[string]string, len(*in))
-		for key, val := range *in {
-			(*out)[key] = val
+		*out = new(map[string]string)
+		if **in != nil {
+			in, out := *in, *out
+			*out = make(map[string]string, len(*in))
+			for key, val := range *in {
+				(*out)[key] = val
+			}
 		}
 	}
 	out.OperationTimeout = in.OperationTimeout
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new DataUploadSpec.
@@ -267,6 +296,7 @@ func (in *DataUploadStatus) DeepCopyInto(out *DataUploadStatus) {
 		*out = (*in).DeepCopy()
 	}
 	out.Progress = in.Progress
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new DataUploadStatus.
@@ -282,6 +312,7 @@ func (in *DataUploadStatus) DeepCopy() *DataUploadStatus {
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *TargetVolumeSpec) DeepCopyInto(out *TargetVolumeSpec) {
 	*out = *in
+	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new TargetVolumeSpec.

pkg/archive/extractor.go

@@ -84,7 +84,7 @@ func (e *Extractor) readBackup(tarRdr *tar.Reader) (string, error) {
 			return "", err
 		}
 
-		target := filepath.Join(dir, header.Name) //nolint:gosec // Internal usage. No need to check.
+		target := filepath.Join(dir, header.Name) //nolint:gosec
 
 		switch header.Typeflag {
 		case tar.TypeDir:

pkg/backup/backup.go

@@ -302,7 +302,6 @@ func (kb *kubernetesBackupper) BackupWithResolvers(log logrus.FieldLogger,
 		itemHookHandler: &hook.DefaultItemHookHandler{
 			PodCommandExecutor: kb.podCommandExecutor,
 		},
-		hookTracker: hook.NewHookTracker(),
 	}
 
 	// helper struct to send current progress between the main
@@ -428,23 +427,11 @@ func (kb *kubernetesBackupper) BackupWithResolvers(log logrus.FieldLogger,
 	updated.Status.Progress.TotalItems = len(backupRequest.BackedUpItems)
 	updated.Status.Progress.ItemsBackedUp = len(backupRequest.BackedUpItems)
 
-	// update the hooks execution status
-	if updated.Status.HookStatus == nil {
-		updated.Status.HookStatus = &velerov1api.HookStatus{}
-	}
-	updated.Status.HookStatus.HooksAttempted, updated.Status.HookStatus.HooksFailed = itemBackupper.hookTracker.Stat()
-	log.Infof("hookTracker: %+v, hookAttempted: %d, hookFailed: %d", itemBackupper.hookTracker.GetTracker(), updated.Status.HookStatus.HooksAttempted, updated.Status.HookStatus.HooksFailed)
-
 	if err := kube.PatchResource(backupRequest.Backup, updated, kb.kbClient); err != nil {
-		log.WithError(errors.WithStack((err))).Warn("Got error trying to update backup's status.progress and hook status")
+		log.WithError(errors.WithStack((err))).Warn("Got error trying to update backup's status.progress")
 	}
-
-	if skippedPVSummary, err := json.Marshal(backupRequest.SkippedPVTracker.Summary()); err != nil {
-		log.WithError(errors.WithStack(err)).Warn("Fail to generate skipped PV summary.")
-	} else {
-		log.Infof("Summary for skipped PVs: %s", skippedPVSummary)
-	}
-
+	skippedPVSummary, _ := json.Marshal(backupRequest.SkippedPVTracker.Summary())
+	log.Infof("Summary for skipped PVs: %s", skippedPVSummary)
 	backupRequest.Status.Progress = &velerov1api.BackupProgress{TotalItems: len(backupRequest.BackedUpItems), ItemsBackedUp: len(backupRequest.BackedUpItems)}
 	log.WithField("progress", "").Infof("Backed up a total of %d items", len(backupRequest.BackedUpItems))
 
@@ -611,7 +598,6 @@ func (kb *kubernetesBackupper) FinalizeBackup(log logrus.FieldLogger,
 		discoveryHelper:          kb.discoveryHelper,
 		itemHookHandler:          &hook.NoOpItemHookHandler{},
 		podVolumeSnapshotTracker: newPVCSnapshotTracker(),
-		hookTracker:              hook.NewHookTracker(),
 	}
 	updateFiles := make(map[string]FileForArchive)
 	backedUpGroupResources := map[schema.GroupResource]bool{}

pkg/backup/backup_test.go

@@ -46,7 +46,6 @@ import (
 	"github.com/vmware-tanzu/velero/pkg/builder"
 	"github.com/vmware-tanzu/velero/pkg/client"
 	"github.com/vmware-tanzu/velero/pkg/discovery"
-	"github.com/vmware-tanzu/velero/pkg/features"
 	"github.com/vmware-tanzu/velero/pkg/itemoperation"
 	"github.com/vmware-tanzu/velero/pkg/kuberesource"
 	"github.com/vmware-tanzu/velero/pkg/plugin/velero"
@@ -72,7 +71,6 @@ func TestBackedUpItemsMatchesTarballContents(t *testing.T) {
 		Backup:           defaultBackup().Result(),
 		SkippedPVTracker: NewSkipPVTracker(),
 	}
-
 	backupFile := bytes.NewBuffer([]byte{})
 
 	apiResources := []*test.APIResource{
@@ -85,8 +83,8 @@ func TestBackedUpItemsMatchesTarballContents(t *testing.T) {
 			builder.ForDeployment("zoo", "raz").Result(),
 		),
 		test.PVs(
-			builder.ForPersistentVolume("bar").ClaimRef("foo", "pvc1").Result(),
-			builder.ForPersistentVolume("baz").ClaimRef("bar", "pvc2").Result(),
+			builder.ForPersistentVolume("bar").Result(),
+			builder.ForPersistentVolume("baz").Result(),
 		),
 	}
 	for _, resource := range apiResources {
@@ -1368,7 +1366,6 @@ func TestBackupItemActionsForSkippedPV(t *testing.T) {
 							"any": "whatever reason",
 						},
 					},
-					includedPVs: map[string]struct{}{},
 				},
 			},
 			apiResources: []*test.APIResource{
@@ -1382,12 +1379,6 @@ func TestBackupItemActionsForSkippedPV(t *testing.T) {
 			expectNotSkippedPVs: []string{"pv-1"},
 		},
 	}
-	// Enable CSI feature before running the test, because Velero will check whether
-	// CSI feature is enabled before executing CSI plugin actions.
-	features.NewFeatureFlagSet("EnableCSI")
-	defer func() {
-		features.NewFeatureFlagSet("")
-	}()
 	for _, tc := range tests {
 		t.Run(tc.name, func(tt *testing.T) {
 			var (

pkg/backup/item_backupper.go

@@ -52,8 +52,6 @@ import (
 	vsv1 "github.com/vmware-tanzu/velero/pkg/plugin/velero/volumesnapshotter/v1"
 	"github.com/vmware-tanzu/velero/pkg/podvolume"
 	"github.com/vmware-tanzu/velero/pkg/util/boolptr"
-	csiutil "github.com/vmware-tanzu/velero/pkg/util/csi"
-	pdvolumeutil "github.com/vmware-tanzu/velero/pkg/util/podvolume"
 	"github.com/vmware-tanzu/velero/pkg/volume"
 )
 
@@ -78,7 +76,6 @@ type itemBackupper struct {
 
 	itemHookHandler                    hook.ItemHookHandler
 	snapshotLocationVolumeSnapshotters map[string]vsv1.VolumeSnapshotter
-	hookTracker                        *hook.HookTracker
 }
 
 type FileForArchive struct {
@@ -185,7 +182,7 @@ func (ib *itemBackupper) backupItemInternal(logger logrus.FieldLogger, obj runti
 	)
 
 	log.Debug("Executing pre hooks")
-	if err := ib.itemHookHandler.HandleHooks(log, groupResource, obj, ib.backupRequest.ResourceHooks, hook.PhasePre, ib.hookTracker); err != nil {
+	if err := ib.itemHookHandler.HandleHooks(log, groupResource, obj, ib.backupRequest.ResourceHooks, hook.PhasePre); err != nil {
 		return false, itemFiles, err
 	}
 	if optedOut, podName := ib.podVolumeSnapshotTracker.OptedoutByPod(namespace, name); optedOut {
@@ -203,7 +200,7 @@ func (ib *itemBackupper) backupItemInternal(logger logrus.FieldLogger, obj runti
 			// Get the list of volumes to back up using pod volume backup from the pod's annotations. Remove from this list
 			// any volumes that use a PVC that we've already backed up (this would be in a read-write-many scenario,
 			// where it's been backed up from another pod), since we don't need >1 backup per PVC.
-			includedVolumes, optedOutVolumes := pdvolumeutil.GetVolumesByPod(pod, boolptr.IsSetToTrue(ib.backupRequest.Spec.DefaultVolumesToFsBackup))
+			includedVolumes, optedOutVolumes := podvolume.GetVolumesByPod(pod, boolptr.IsSetToTrue(ib.backupRequest.Spec.DefaultVolumesToFsBackup))
 			for _, volume := range includedVolumes {
 				// track the volumes that are PVCs using the PVC snapshot tracker, so that when we backup PVCs/PVs
 				// via an item action in the next step, we don't snapshot PVs that will have their data backed up
@@ -235,7 +232,7 @@ func (ib *itemBackupper) backupItemInternal(logger logrus.FieldLogger, obj runti
 
 		// if there was an error running actions, execute post hooks and return
 		log.Debug("Executing post hooks")
-		if err := ib.itemHookHandler.HandleHooks(log, groupResource, obj, ib.backupRequest.ResourceHooks, hook.PhasePost, ib.hookTracker); err != nil {
+		if err := ib.itemHookHandler.HandleHooks(log, groupResource, obj, ib.backupRequest.ResourceHooks, hook.PhasePost); err != nil {
 			backupErrs = append(backupErrs, err)
 		}
 		return false, itemFiles, kubeerrs.NewAggregate(backupErrs)
@@ -251,10 +248,6 @@ func (ib *itemBackupper) backupItemInternal(logger logrus.FieldLogger, obj runti
 	namespace = metadata.GetNamespace()
 
 	if groupResource == kuberesource.PersistentVolumes {
-		if err := ib.addVolumeInfo(obj, log); err != nil {
-			backupErrs = append(backupErrs, err)
-		}
-
 		if err := ib.takePVSnapshot(obj, log); err != nil {
 			backupErrs = append(backupErrs, err)
 		}
@@ -294,7 +287,7 @@ func (ib *itemBackupper) backupItemInternal(logger logrus.FieldLogger, obj runti
 	}
 
 	log.Debug("Executing post hooks")
-	if err := ib.itemHookHandler.HandleHooks(log, groupResource, obj, ib.backupRequest.ResourceHooks, hook.PhasePost, ib.hookTracker); err != nil {
+	if err := ib.itemHookHandler.HandleHooks(log, groupResource, obj, ib.backupRequest.ResourceHooks, hook.PhasePost); err != nil {
 		backupErrs = append(backupErrs, err)
 	}
 
@@ -367,14 +360,6 @@ func (ib *itemBackupper) executeActions(
 			ib.trackSkippedPV(obj, groupResource, "", "skipped due to resource policy ", log)
 			continue
 		}
-
-		// If the EnableCSI feature is not enabled, but the executing action is from CSI plugin, skip the action.
-		if csiutil.ShouldSkipAction(actionName) {
-			log.Infof("Skip action %s for resource %s:%s/%s, because the CSI feature is not enabled. Feature setting is %s.",
-				actionName, groupResource.String(), metadata.GetNamespace(), metadata.GetName(), features.Serialize())
-			continue
-		}
-
 		updatedItem, additionalItemIdentifiers, operationID, postOperationItems, err := action.Execute(obj, ib.backupRequest.Backup)
 		if err != nil {
 			return nil, itemFiles, errors.Wrapf(err, "error executing custom action (groupResource=%s, namespace=%s, name=%s)", groupResource.String(), namespace, name)
@@ -384,8 +369,8 @@ func (ib *itemBackupper) executeActions(
 			// snapshot was skipped by CSI plugin
 			ib.trackSkippedPV(obj, groupResource, csiSnapshotApproach, "skipped b/c it's not a CSI volume", log)
 			delete(u.GetAnnotations(), skippedNoCSIPVAnnotation)
-		} else if (actionName == csiBIAPluginName || actionName == vsphereBIAPluginName) && !boolptr.IsSetToFalse(ib.backupRequest.Backup.Spec.SnapshotVolumes) {
-			// the snapshot has been taken by the BIA plugin
+		} else if actionName == csiBIAPluginName || actionName == vsphereBIAPluginName {
+			// the snapshot has been taken
 			ib.unTrackSkippedPV(obj, groupResource, log)
 		}
 		mustInclude := u.GetAnnotations()[mustIncludeAdditionalItemAnnotation] == "true" || finalize
@@ -510,7 +495,6 @@ func (ib *itemBackupper) takePVSnapshot(obj runtime.Unstructured, log logrus.Fie
 
 	if boolptr.IsSetToFalse(ib.backupRequest.Spec.SnapshotVolumes) {
 		log.Info("Backup has volume snapshots disabled; skipping volume snapshot action.")
-		ib.trackSkippedPV(obj, kuberesource.PersistentVolumes, volumeSnapshotApproach, "backup has volume snapshots disabled", log)
 		return nil
 	}
 
@@ -667,7 +651,6 @@ func (ib *itemBackupper) getMatchAction(obj runtime.Unstructured, groupResource
 		}
 		return ib.backupRequest.ResPolicies.GetMatchAction(pv)
 	}
-
 	return nil, nil
 }
 
@@ -691,26 +674,6 @@ func (ib *itemBackupper) unTrackSkippedPV(obj runtime.Unstructured, groupResourc
 	}
 }
 
-func (ib *itemBackupper) addVolumeInfo(obj runtime.Unstructured, log logrus.FieldLogger) error {
-	pv := new(corev1api.PersistentVolume)
-	err := runtime.DefaultUnstructuredConverter.FromUnstructured(obj.UnstructuredContent(), pv)
-	if err != nil {
-		log.WithError(err).Warnf("Fail to convert PV")
-		return err
-	}
-
-	pvcName := ""
-	pvcNamespace := ""
-	if pv.Spec.ClaimRef != nil {
-		pvcName = pv.Spec.ClaimRef.Name
-		pvcNamespace = pv.Spec.ClaimRef.Namespace
-	}
-
-	ib.backupRequest.VolumesInformation.InsertPVMap(*pv, pvcName, pvcNamespace)
-
-	return nil
-}
-
 // convert the input object to PV/PVC and get the PV name
 func getPVName(obj runtime.Unstructured, groupResource schema.GroupResource) (string, error) {
 	if groupResource == kuberesource.PersistentVolumes {

pkg/backup/item_backupper_test.go

@@ -19,7 +19,6 @@ package backup
 import (
 	"testing"
 
-	"github.com/sirupsen/logrus"
 	"github.com/stretchr/testify/require"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 
@@ -238,34 +237,3 @@ func TestRandom(t *testing.T) {
 	err2 := runtime.DefaultUnstructuredConverter.FromUnstructured(o, pvc)
 	t.Logf("err1: %v, err2: %v", err1, err2)
 }
-
-func TestAddVolumeInfo(t *testing.T) {
-	tests := []struct {
-		name string
-		pv   *corev1api.PersistentVolume
-	}{
-		{
-			name: "PV has ClaimRef",
-			pv:   builder.ForPersistentVolume("testPV").ClaimRef("testNS", "testPVC").Result(),
-		},
-		{
-			name: "PV has no ClaimRef",
-			pv:   builder.ForPersistentVolume("testPV").Result(),
-		},
-	}
-
-	for _, tc := range tests {
-		t.Run(tc.name, func(t *testing.T) {
-			ib := itemBackupper{}
-			ib.backupRequest = new(Request)
-			ib.backupRequest.VolumesInformation.Init()
-
-			pvObj, err := runtime.DefaultUnstructuredConverter.ToUnstructured(tc.pv)
-			require.NoError(t, err)
-			logger := logrus.StandardLogger()
-
-			err = ib.addVolumeInfo(&unstructured.Unstructured{Object: pvObj}, logger)
-			require.NoError(t, err)
-		})
-	}
-}

pkg/backup/item_collector.go

@@ -290,7 +290,6 @@ func (r *itemCollector) getResourceItems(log logrus.FieldLogger, gv schema.Group
 
 		return items, nil
 	}
-
 	clusterScoped := !resource.Namespaced
 	namespacesToList := getNamespacesToList(r.backupRequest.NamespaceIncludesExcludes)
 

pkg/backup/pv_skip_tracker.go

@@ -10,14 +10,6 @@ type SkippedPV struct {
 	Reasons []PVSkipReason `json:"reasons"`
 }
 
-func (s *SkippedPV) SerializeSkipReasons() string {
-	ret := ""
-	for _, reason := range s.Reasons {
-		ret = ret + reason.Approach + ": " + reason.Reason + ";"
-	}
-	return ret
-}
-
 type PVSkipReason struct {
 	Approach string `json:"approach"`
 	Reason   string `json:"reason"`
@@ -29,8 +21,6 @@ type skipPVTracker struct {
 	// pvs is a map of name of the pv to the list of reasons why it is skipped.
 	// The reasons are stored in a map each key of the map is the backup approach, each approach can have one reason
 	pvs map[string]map[string]string
-	// includedPVs is a set of pv to be included in the backup, the element in this set should not be in the "pvs" map
-	includedPVs map[string]struct{}
 }
 
 const (
@@ -42,9 +32,8 @@ const (
 
 func NewSkipPVTracker() *skipPVTracker {
 	return &skipPVTracker{
-		RWMutex:     &sync.RWMutex{},
-		pvs:         make(map[string]map[string]string),
-		includedPVs: make(map[string]struct{}),
+		RWMutex: &sync.RWMutex{},
+		pvs:     make(map[string]map[string]string),
 	}
 }
 
@@ -55,12 +44,9 @@ func (pt *skipPVTracker) Track(name, approach, reason string) {
 	if name == "" || reason == "" {
 		return
 	}
-	if _, ok := pt.includedPVs[name]; ok {
-		return
-	}
 	skipReasons := pt.pvs[name]
 	if skipReasons == nil {
-		skipReasons = make(map[string]string)
+		skipReasons = make(map[string]string, 0)
 		pt.pvs[name] = skipReasons
 	}
 	if approach == "" {
@@ -70,12 +56,9 @@ func (pt *skipPVTracker) Track(name, approach, reason string) {
 }
 
 // Untrack removes the pvc with the specified namespace and name.
-// This func should be called when the PV is taken for snapshot, regardless native snapshot, CSI snapshot or fsb backup
-// therefore, in one backup processed if a PV is Untracked once, it will not be tracked again.
 func (pt *skipPVTracker) Untrack(name string) {
 	pt.Lock()
 	defer pt.Unlock()
-	pt.includedPVs[name] = struct{}{}
 	delete(pt.pvs, name)
 }
 

pkg/backup/pv_skip_tracker_test.go

@@ -4,7 +4,6 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func TestSummary(t *testing.T) {
@@ -42,23 +41,3 @@ func TestSummary(t *testing.T) {
 	}
 	assert.Equal(t, expected, tracker.Summary())
 }
-
-func TestSerializeSkipReasons(t *testing.T) {
-	tracker := NewSkipPVTracker()
-	//tracker.Track("pv5", "", "skipped due to policy")
-	tracker.Track("pv3", podVolumeApproach, "it's set to opt-out")
-	tracker.Track("pv3", csiSnapshotApproach, "not applicable for CSI ")
-
-	for _, skippedPV := range tracker.Summary() {
-		require.Equal(t, "csiSnapshot: not applicable for CSI ;podvolume: it's set to opt-out;", skippedPV.SerializeSkipReasons())
-	}
-}
-
-func TestTrackUntrack(t *testing.T) {
-	// If a pv is untracked explicitly it can't be Tracked again, b/c the pv is considered backed up already.
-	tracker := NewSkipPVTracker()
-	tracker.Track("pv3", podVolumeApproach, "it's set to opt-out")
-	tracker.Untrack("pv3")
-	tracker.Track("pv3", csiSnapshotApproach, "not applicable for CSI ")
-	assert.Equal(t, 0, len(tracker.Summary()))
-}

pkg/backup/request.go

@@ -20,9 +20,10 @@ import (
 	"fmt"
 	"sort"
 
+	snapshotv1api "github.com/kubernetes-csi/external-snapshotter/client/v4/apis/volumesnapshot/v1"
+
 	"github.com/vmware-tanzu/velero/internal/hook"
 	"github.com/vmware-tanzu/velero/internal/resourcepolicies"
-	internalVolume "github.com/vmware-tanzu/velero/internal/volume"
 	velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
 	"github.com/vmware-tanzu/velero/pkg/itemoperation"
 	"github.com/vmware-tanzu/velero/pkg/plugin/framework"
@@ -50,15 +51,12 @@ type Request struct {
 	VolumeSnapshots           []*volume.Snapshot
 	PodVolumeBackups          []*velerov1api.PodVolumeBackup
 	BackedUpItems             map[itemKey]struct{}
+	CSISnapshots              []snapshotv1api.VolumeSnapshot
 	itemOperationsList        *[]*itemoperation.BackupOperation
 	ResPolicies               *resourcepolicies.Policies
 	SkippedPVTracker          *skipPVTracker
-	VolumesInformation        internalVolume.VolumesInformation
 }
 
-// VolumesInformation contains the information needs by generating
-// the backup VolumeInfo array.
-
 // GetItemOperationsList returns ItemOperationsList, initializing it if necessary
 func (r *Request) GetItemOperationsList() *[]*itemoperation.BackupOperation {
 	if r.itemOperationsList == nil {
@@ -87,17 +85,3 @@ func (r *Request) BackupResourceList() map[string][]string {
 
 	return resources
 }
-
-func (r *Request) FillVolumesInformation() {
-	skippedPVMap := make(map[string]string)
-
-	for _, skippedPV := range r.SkippedPVTracker.Summary() {
-		skippedPVMap[skippedPV.Name] = skippedPV.SerializeSkipReasons()
-	}
-
-	r.VolumesInformation.SkippedPVs = skippedPVMap
-	r.VolumesInformation.NativeSnapshots = r.VolumeSnapshots
-	r.VolumesInformation.PodVolumeBackups = r.PodVolumeBackups
-	r.VolumesInformation.BackupOperations = *r.GetItemOperationsList()
-	r.VolumesInformation.BackupName = r.Backup.Name
-}

pkg/backup/request_test.go

@@ -1,5 +1,5 @@
 /*
-Copyright the Velero contributors.
+Copyright 2019 the Velero contributors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

pkg/backup/snapshots.go

@@ -1,84 +0,0 @@
-/*
-Copyright The Velero Contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package backup
-
-import (
-	"context"
-
-	snapshotv1api "github.com/kubernetes-csi/external-snapshotter/client/v4/apis/volumesnapshot/v1"
-	"github.com/sirupsen/logrus"
-	"k8s.io/apimachinery/pkg/util/sets"
-	kbclient "sigs.k8s.io/controller-runtime/pkg/client"
-
-	velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
-	"github.com/vmware-tanzu/velero/pkg/features"
-	"github.com/vmware-tanzu/velero/pkg/label"
-	"github.com/vmware-tanzu/velero/pkg/util/boolptr"
-)
-
-// GetBackupCSIResources is used to get CSI snapshot related resources.
-// Returns VolumeSnapshot, VolumeSnapshotContent, VolumeSnapshotClasses referenced
-func GetBackupCSIResources(
-	client kbclient.Client,
-	globalCRClient kbclient.Client,
-	backup *velerov1api.Backup,
-	backupLog logrus.FieldLogger,
-) (
-	volumeSnapshots []snapshotv1api.VolumeSnapshot,
-	volumeSnapshotContents []snapshotv1api.VolumeSnapshotContent,
-	volumeSnapshotClasses []snapshotv1api.VolumeSnapshotClass,
-) {
-	if boolptr.IsSetToTrue(backup.Spec.SnapshotMoveData) {
-		backupLog.Info("backup SnapshotMoveData is set to true, skip VolumeSnapshot resource persistence.")
-	} else if features.IsEnabled(velerov1api.CSIFeatureFlag) {
-		selector := label.NewSelectorForBackup(backup.Name)
-		vscList := &snapshotv1api.VolumeSnapshotContentList{}
-
-		vsList := new(snapshotv1api.VolumeSnapshotList)
-		err := globalCRClient.List(context.TODO(), vsList, &kbclient.ListOptions{
-			LabelSelector: label.NewSelectorForBackup(backup.Name),
-		})
-		if err != nil {
-			backupLog.Error(err)
-		}
-		volumeSnapshots = append(volumeSnapshots, vsList.Items...)
-
-		if err := client.List(context.Background(), vscList, &kbclient.ListOptions{LabelSelector: selector}); err != nil {
-			backupLog.Error(err)
-		}
-		if len(vscList.Items) >= 0 {
-			volumeSnapshotContents = vscList.Items
-		}
-
-		vsClassSet := sets.NewString()
-		for index := range volumeSnapshotContents {
-			// persist the volumesnapshotclasses referenced by vsc
-			if volumeSnapshotContents[index].Spec.VolumeSnapshotClassName != nil && !vsClassSet.Has(*volumeSnapshotContents[index].Spec.VolumeSnapshotClassName) {
-				vsClass := &snapshotv1api.VolumeSnapshotClass{}
-				if err := client.Get(context.TODO(), kbclient.ObjectKey{Name: *volumeSnapshotContents[index].Spec.VolumeSnapshotClassName}, vsClass); err != nil {
-					backupLog.Error(err)
-				} else {
-					vsClassSet.Insert(*volumeSnapshotContents[index].Spec.VolumeSnapshotClassName)
-					volumeSnapshotClasses = append(volumeSnapshotClasses, *vsClass)
-				}
-			}
-		}
-		backup.Status.CSIVolumeSnapshotsAttempted = len(volumeSnapshots)
-	}
-
-	return volumeSnapshots, volumeSnapshotContents, volumeSnapshotClasses
-}

pkg/builder/backup_builder.go

@@ -299,18 +299,3 @@ func (b *BackupBuilder) DataMover(name string) *BackupBuilder {
 	b.object.Spec.DataMover = name
 	return b
 }
-
-// ParallelFilesUpload sets the Backup's uploader parallel uploads
-func (b *BackupBuilder) ParallelFilesUpload(parallel int) *BackupBuilder {
-	if b.object.Spec.UploaderConfig == nil {
-		b.object.Spec.UploaderConfig = &velerov1api.UploaderConfigForBackup{}
-	}
-	b.object.Spec.UploaderConfig.ParallelFilesUpload = parallel
-	return b
-}
-
-// WithStatus sets the Backup's status.
-func (b *BackupBuilder) WithStatus(status velerov1api.BackupStatus) *BackupBuilder {
-	b.object.Status = status
-	return b
-}

pkg/builder/data_upload_builder.go

@@ -103,7 +103,7 @@ func (d *DataUploadBuilder) OperationTimeout(timeout metav1.Duration) *DataUploa
 }
 
 // DataMoverConfig sets the DataUpload's DataMoverConfig.
-func (d *DataUploadBuilder) DataMoverConfig(config map[string]string) *DataUploadBuilder {
+func (d *DataUploadBuilder) DataMoverConfig(config *map[string]string) *DataUploadBuilder {
 	d.object.Spec.DataMoverConfig = config
 	return d
 }

pkg/builder/delete_backup_request_builder.go

@@ -1,19 +1,3 @@
-/*
-Copyright 2023 the Velero contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
 package builder
 
 import (

pkg/builder/item_operation_builder.go

@@ -1,19 +1,3 @@
-/*
-Copyright 2023 the Velero contributors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
 package builder
 
 import (